summaryrefslogtreecommitdiff
path: root/sc/source/ui/unoobj
AgeCommit message (Collapse)AuthorFilesLines
5 daysdrop some coverity markupCaolán McNamara1-1/+1
Change-Id: Iffb2542be9e973d67ea3fea5fc1e924e491f14e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194820 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
6 daystdf#168850, tdf#167075, tdf#168850: Revert "ScViewData: pass ScDocShell by ref"Xisco Fauli3-40/+40
This reverts commit d8ab8992bd35aedfc1d2b0debebab0d623aa8d09 Unfortunately I had to revert the fix for tdf#167075 in ea940b7985921883f8f75009186cae24846b1bd4 "tdf#169554: Revert "tdf#167075: init doc shell before pasting as png/bmp (take 2)"" because of tdf#169554, which I can't reproduce, so reverting the original commit that introduced tdf#167075 It also fixes other similar issues reported in Bugzilla Change-Id: I88dfa08f2086b88cff168eff2df8b4faf4067439 Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194726 Tested-by: Jenkins
6 daysRevert "ScViewData: simplify constructors"Xisco Fauli1-1/+1
This reverts commit 52e3b2b040ac54c2a5661e3676b135170f028f50. Change-Id: I9ab9bc0e6ff909281370bb5d524375398b5a2c9c Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194725 Tested-by: Jenkins
8 days[API CHANGE] remove XPivotTableDataProviderNoel Grandin3-30/+31
in favor of a regular C++ interface class, since this is purely used internally to LO Change-Id: I84991efb1b0c8829e2175dc083b0f8627fcb1712 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194512 Code-Style: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
10 daysScDocument::GetAttr doesn't return nullptrMike Kaganski2-5/+5
Change-Id: Iaf2da73a9e5a9c2a5a579a8124beda9bb2689fde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194400 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-10-31move GraphicImportHelper/GraphicExportHelper into xmloffCaolán McNamara1-1/+1
Change-Id: If0e9d7b2d9fee0ff4307f35ae82074031b0b0015 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193210 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2025-10-20drop some more COVERITY stuffCaolán McNamara1-2/+2
Change-Id: Ieb15457e53a1cb68e71aea6be20a72e35f367588 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192701 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-10-20sc: fix issues with tile invalidationTomaž Vajngerl1-2/+6
Include sheet view in a view render state, so we get the correct tiles for our current view. Also use CurrentTabForData to get the anything connected to the size of columns and rows. We need to get that from the holder sheet if we hide, show, change the size, of columns and rows. Change-Id: I9431488d43920f5bb492c4bdcbc83dd24db0d89f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192602 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-10-10sc: send sheet view information as part properties via LOKitTomaž Vajngerl1-2/+17
This sends the information needed for online to handle show the sheets are using the sheet view functionality and to show if the sheet view is synched with the default view or not. Change getPart to return GetTabNumber instead of CurrentTabForData or the code will select the wrong sheet when we create or switch to a sheet view. Change-Id: I6990af757f60a9a33594e3991dec8b5b3b278b54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191977 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192147 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-10-05tdf#161948 support embedded-number-behavior='integer'Regina Henschel1-5/+7
The element <table:sort> has the values 'alpha-numeric', 'double' and 'integer' in its attribute embedded-number-behavior in ODF. The member bNaturalSort in ScSortParam covers only 'alpha-numeric' and 'double'. The patch replaces the member bNaturalSort of ScSortParam with a new eSortNumberBehavior. That takes the three values from enum ScSortNumberBehavior. Only the parameter 'SfxBoolItem NaturalSort SID_SORT_NATURALSORT' in SID_SORT is kept so that existing macros that use it still work. Change-Id: I2a346223767a5a4aae79bac5fa08e608b0cea503 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191159 Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2025-09-03sc: rename GetTabNo and GetTab to better namesTomaž Vajngerl3-18/+18
GetTabNo to CurrentTabForData to make it clear what it's usage should be and that it is not just a simple getter for a tab, but has logic behind it. GetTab was also renamed to GetTabNumber - it's a direct accessor for the current view's tab number. Document both methods. Change-Id: Ic855be43b2d38e421e0f9472d182baa20bb37feb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190201 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2025-09-02tdf161948 read & write ODF 'embedded-number-behavior'Regina Henschel1-1/+1
ODF has the attribute table:embedded-number-behavior to specify a natural sort (19.628 part3 ODF 1.4). Its values are 'alpha-numeric', 'double' and 'integer'. LO has the attribute bool bNaturalSort in struct ScSortParam. The ODF method 'integer' is not implemented in LO. The patch maps the internal bNaturalSort=true attribute to ODF value 'double'. Until value 'integer' is implemented, it is mapped to value bNaturalSort=true on import, as that makes at least a natural sort. This is next step after commit 47eb7f4e4dd0ed72679246b462686e153a1c07d0 Change-Id: Ie8c66e6b2eb2bdf035f0b02ada6ef91b1d921fe7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190437 Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Tested-by: Jenkins
2025-08-29tdf#167689: sc: support tableType attr. in <table> nodeBayram Çiçek1-0/+12
and import&export uniqueName attr. of <tableColumn>. - also added a unittest Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com> Change-Id: I98c6b7f6f7260195fc89aaae20a9a34208204186 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190314 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2025-08-26tdf#127978, tdf#132421 - Change URL encoding for filenameAndreas Heinisch1-1/+1
Change URL encoding for the filename of the import ASCII dialog's title and of the navigator's tooltip. Otherwise, filenames including a hash don't display correctly. Change-Id: Ib2f56e77649184f53dd226f4a77e80d270770135 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190240 Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Tested-by: Jenkins
2025-08-26tdf161948 bring natural sort to APIRegina Henschel1-0/+12
When sorting a database range the feature 'natural sort' can be used. If source has the strings K3 K10 K104 K23 K2, then the result will be K2 K3 K10 K23 K104. Alphanumerical sort results in K10 K104 K2 K23 K3. ODF has the attribute table:embedded-number-behavior for this (19.628 part3 ODF 1.4). Its values are 'alpha-numeric', 'double' and 'integer'. LO has the attribute bool bNaturalSort in struct ScSortParam. The ODF method 'integer' is not implemented in LO. Currently natural sort is not read/written with ODF and is not available in the API. I plan three steps: 1. Make natural sort available in the API (this patch) 2. Read and write table:embedded-number-behavior attribute 3. Implement 'integer' method. To be later able to have three values, not a boolean property is used for the API, but a group of constant values, although currently only two values are needed. Change-Id: I0418d5f23400fb0479034589fc90868a1e97ce44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190133 Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Tested-by: Jenkins
2025-08-26Related: tdf#168073 Extract ScEditFieldObj insertion into a functionMike Kaganski1-40/+46
This makes it easier to see that ScCellObj::insertTextContent attempts one of two alternative insertion methods. Additionally, this undoes a change of mine, made in commit 1e040b72222012f9a5f1e47d19aaf0c0369e08ad (tdf#168073: check if xRange is this, 2025-08-23), which disallowed to insert the same ScEditFieldObj secont time. I did that to follow what writer does; but the method doesn't specify that behavior, so it was an unwarranted change. Change-Id: Iea0d1ff5039f6e36126a93b0d56cd049ff070945 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190196 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-08-25tdf#168096: reset selection each time GetUnoText is calledMike Kaganski1-1/+7
ScCellObj represents the whole content of the cell; and its XText must always cover it all. However, implementation (ScCellTextObj) may get its "selection" (defining the actual range) out of sync, after created initially, if content is changed using other objects. It is a modification listener; but that doesn't help, because some methods may manually re-assign selection after the actual content change: see e.g. SvxUnoTextBase::insertString. This change resets the selection of the cell object each time its GetUnoText method is called. The EE_PARA_MAX value assigned to start.nPara causes the needed processing in CheckSelection. Change-Id: I94bc55ee3df7976dcaeaa9c4878059995e885e8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190142 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-08-24tdf#168073: generalize the fix to other XText methodsMike Kaganski1-11/+12
... that take XTextRange, and that should accept the cell itself Change-Id: Id9157b53521e22059825a6d86c814f334682a3c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190109 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-08-23This code is deadMike Kaganski1-11/+4
If getFromUnoTunnel<SvxUnoTextRangeBase> failed, there's no need to test getFromUnoTunnel<ScCellTextCursor>: it is derived from SvxUnoTextRangeBase, and will always fail. Change-Id: I9faac80c6d58ff8d5b84cdb6ab5682ffc06f6b3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190093 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-08-23Store Format value for later use in ScEditFieldObj::setPropertyValueURLMike Kaganski1-0/+5
An overlook from commit 48dae1af66b227e72d58935d5719610c957da30d (tdf#168066: implement Format property for Calc's URL field, 2025-08-22) Change-Id: I3132dfb27c5f15dadd3fc23701cca043a49f2dd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190089 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-08-23tdf#168073: check if xRange is thisMike Kaganski1-5/+8
And use its own XText implementation object as the range. Also relax the call to getFromUnoTunnel, to request SvxUnoTextRangeBase that is actually wanted, not arbitrarily chosen ScCellTextCursor. This makes this optimized code to also handle ranges returned from ScCellObj's own getStart() / getEnd(). Change-Id: I4f500b32790f2844fdd7f54818b79b8a29525475 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190085 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-08-22tdf#168066: implement Format property for Calc's URL fieldMike Kaganski1-0/+10
Inserting the field threw exception from SvxUnoTextBase::insertTextContent, because SvxFieldData::Create tried to access Format property of the field, which is documented in css::text::textfield::URL service. It is trivial to implement it, because the underlying SvxURLField already has it. Change-Id: I98ddb7ed554b4223922a9da7560a62a0202878b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190080 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-08-20sc: always write "std::" for common types (unique_ptr, vector)Tomaž Vajngerl2-124/+119
No need for "using ::std::unique_ptr" and similar.... Also change some css types. Change-Id: Ie9ad52a8b4e3714c4a5a926014c2c0f166cc6585 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189967 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-08-20sc::tools -> sctoolsMike Kaganski4-19/+19
At least some IDEs are confused by our multitude of `tools` namespaces, and show errors like `namespace "tools" is ambiguous`. This removes one such namespace. The idea is to drop all but the one in /tools (that has tools::Long and tools::Rectangle). Change-Id: Ib404ba7c66085a01861cd62507a479e91aa68e49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189953 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-08-12cid#1659785 Variable copied when it could be movedCaolán McNamara1-1/+1
and cid#1659793 Variable copied when it could be moved cid#1659830 Variable copied when it could be moved cid#1659841 Variable copied when it could be moved cid#1659856 Variable copied when it could be moved cid#1659863 Variable copied when it could be moved cid#1659864 Variable copied when it could be moved cid#1659865 Variable copied when it could be moved cid#1659903 Variable copied when it could be moved cid#1659909 Variable copied when it could be moved cid#1659917 Variable copied when it could be moved cid#1659924 Variable copied when it could be moved cid#1659929 Variable copied when it could be moved cid#1659930 Variable copied when it could be moved cid#1659932 Variable copied when it could be moved cid#1660056 Variable copied when it could be moved cid#1660112 Variable copied when it could be moved cid#1660169 Variable copied when it could be moved Change-Id: I623009beb8e4a61b2253a17f356576bd3ac3f06c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189402 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-08-12cool#4250 LOK calc export: use LOK Zoom via ScViewDataMohit Marathe1-0/+13
Justin Luth's comment on the original patch (to which I made some minor tweaks to adapt to the new simplified API): "The zoom values set in the view properties by LibreOfficeKit are technical zoom levels that depend on the current screen DPI. They do not reflect the logical zoom level that the user sees. This has been especially problematic for high DPI screens, where the technical-zoom-level is completely different from the human-zoom-level - and thus a weird value is exported. Instead, export the zoom value that LOK presents to the human. Since LOK doc_setClientZoom always calls setZoom for bAll sheets, it is sufficient to only have a single export zoom variable. COOL doesn't have a "View - Page break" view, so PageZoomValue is irrelevant. Of course, even in desktop mode it seems irrelevant to me... I'm rather worried about the "IsLOKExport" flag interferring with normal, synchronous operations during a background/download ODT save. Those WriteUserDataSequence are not at all limited to file-save operations. They just fill in property values for 'whatever' wants to capture the view settings. So if some other process runs in parallel with the save, then it will get the export zoom values, rather than the operational zoom values it was expecting. But I don't see any way around it since xmloff just dumps properties as the way that it saves an ODS. make CppunitTest_sc_tiledrendering \ CPPUNIT_TEST_NAME=testCellInvalidationDocWithExistingZoom" Signed-off-by: Mohit Marathe <mohit.marathe@collabora.com> Co-authored-by: Justin Luth <justin.luth@collabora.com> Change-Id: I54282e4d28dbe489ca0ea7c080036391faa4704c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188674 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
2025-08-10BitmapEx->Bitmap in various iconsNoel Grandin1-2/+2
now that Bitmap can handle transparency Change-Id: I00ea1e086af3266b1ebfd7e668c49a3abd97a131 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189272 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-08-08copy the PatternAttr cached valuesCaolán McNamara2-15/+15
which are derived from the SfxItemSet which is also copied so they are valid at the time of creation. And rework things to control more granularly when the ItemSet is changed to see when the cached values become invalid. Change-Id: Ibe3a07a37f2730495148d65911c465cbd7f2f027 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189023 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2025-08-05BitmapEx->Bitmap in VCLUnoHelper::CreateBitmapNoel Grandin1-1/+1
now that Bitmap can handle transparency Change-Id: I1de94ef39e00d16b052573ee323886953b574570 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188968 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-07-28use constexpr on variousNoel Grandin1-2/+2
otherwise gcc will put this into the read/write section of the object file. Change-Id: I142eb7b3cbe1c50aa8274c7983f9773d148a5b09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188329 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-07-19Drop separate EditTextObject itempoolNoel Grandin2-7/+7
and just have a single pool for the EditEngine machinery. I cannot find a reason for a separat pool anymore, probably it was a thing from the distant past. This also shaves 5% off the load time of tdf#162126 because we no longer have to spend losts of time re-creating SfxItemSets because they belong to different pools. Change-Id: I837045809dc292548b10e2cf5173d2a29b0879a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187969 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-07-16rename a couple of ScPoolHelper methodsNoel Grandin1-2/+2
to make it a little more obvious what these otherwise very similar SfxItemPools are destined for Change-Id: Iea0527b2b3f58edbccdee6387232c6b7501d1f0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187935 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-07-10use a different memory allocation strategy for cachesCaolán McNamara1-3/+10
redirect cache related allocations to the same place to attempt to put them in separate pages from other allocations to release that cache memory back to OS. Change-Id: I384658a3d652e668095b69e5a62eae5b972b5857 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187282 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-06-27Put "SearchFiltered" and "SearchFormatted" into ScCellSearchObj's ...Mike Kaganski1-0/+2
... XPropertySetInfo. These were forgotten in commits 2d301b6f4afc6e961e69b8821c0c10b43c7f5066 (Ported calc-find- replace-skip-filtered-sc.diff from ooo-build., 2010-09-28) and 9a85743766e8a063d20d5f93ee88758e243397f4 (tdf#48456 : when searching for a number, consider formatting, 2015-10-23). Allows to access these using uniform 'x.PropertyName' syntax in Basic and Python. Change-Id: Ie375392179d5a87476de2c2465fa81fcba02a032 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187122 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2025-06-24sc: convert enum to enum class ScViewOption and ScVObjTypeTomaž Vajngerl2-54/+54
Also rename the enum to sc::ViewOption and sc::ViewObjectType. Change-Id: Iba5f37a3786ebb9ea5727ad2a69e9d075ced5eaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186760 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-06-24tdf#167178: make sure to synchronize the tab in AdjustUpdatedRangesMike Kaganski1-9/+30
The change could adjust the tab in the aRanges; but aRange still has the original tab number. It needs to be updated. Regression after commit a0403b6eb25a99f6225e0f77f4b14d78f4045c9e (tdf#47479: Do not modify range of sheet / column / row in notifications, 2025-05-02). Change-Id: I248f5575ffc7fe388a65cb8bc0007ec72d9f2129 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186906 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-06-08cid#1648524 silence Data race conditionCaolán McNamara1-0/+2
Change-Id: I7a1df9310558c0edc6fe783d0cd2969b7bfcd477 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186264 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2025-05-30register caches with ImplSVDataCaolán McNamara1-13/+40
and put them under a single trim control Change-Id: I72b53102e781f6b16968588b9066588d7fdb3055 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185753 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-05-27ScViewData: simplify constructorsXisco Fauli1-1/+1
After commit d8ab8992bd35aedfc1d2b0debebab0d623aa8d09 Author: Xisco Fauli <xiscofauli@libreoffice.org> Date: Mon May 26 11:06:06 2025 +0200 ScViewData: pass ScDocShell by ref Change-Id: Ifc661f7e5c841fb017003af53e357218f0aff3f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185803 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-05-26ScPrintFunc, ScPrintFuncCache: pass ScDocShell by refXisco Fauli2-14/+14
Change-Id: If71f61c9b5e75e4035c6066fe07aeb747a3d08bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185811 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-05-26ScViewData: pass ScDocShell by refXisco Fauli3-40/+40
After this change, testTdf159174 started to fail. Move the fix introduced in commit 0b93cc83993b3cd78aa05556342839a21c96dc5a Author: Mike Kaganski <mike.kaganski@collabora.com> Date: Sun Jan 14 12:16:48 2024 +0600 tdf#159174: there may be no tabs in the clipboard document to the caller in ScTransferObj::PaintToDev Change-Id: I770305dd0e1ac31f897ddcf4209f7aba1387f8fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185786 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2025-05-23ScSimpleUndo: pass ScDocShell by refXisco Fauli3-10/+10
Change-Id: If3d1b364836922c210ffbbf8046ea98d912892b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185712 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-05-23tdf#166684 strip out some unnecessary UNO work (2)Noel Grandin1-2/+20
to make this easier to optimise, strip out some unnecessary UNO stuff between the import filter and the underlying spreadsheet model Change-Id: I0c1e12c09842390c90a7e804dffa5fdd034f60b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185648 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-05-23tdf#164970 add checkbox for toggling document color customizationSahil Gautam1-2/+6
after themes was released in 25.2, there were quite a few bug reports on bugszilla like [broken dark mode], and some on social platforms like one [bug reported on X]. this also [broke old presentations], and in that case it was more problematic than writer or calc as in case of impress it is assumed that "what you see is what you get". this happened because the documents didn't have the backgroung color attribute set and the document canvas color is dark in dark mode. the solution for this is to not override the document canvas colors by default and provide users with a choice to enable it if they want. [broken dark mode]: https://bugs.documentfoundation.org/show_bug.cgi?id=164838 [bug reported on X]: https://x.com/pritamckn25/status/1915068541801210201 [broke old presenatations]: https://bugs.documentfoundation.org/show_bug.cgi?id=165803 Change-Id: I613b5f0b6e4e1f8f2b8f9fddb50f98286dbdc481 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185388 Tested-by: Jenkins Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
2025-05-23tdf#166684 strip out some unnecessary UNO workNoel Grandin1-0/+58
to make this easier to optimise, strip out some unnecessary UNO stuff between the import filter and the underlying spreadsheet model Change-Id: I5d0ea6ffc487f089c87f17fd2eb18a30198dbacc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185647 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-05-22ScRefUndoData: pass ScDocument by refXisco Fauli1-2/+2
Change-Id: If389a4581933daccf6f4f5e9c6cda1a24e179d5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185656 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2025-05-21tdf#166662 Improve bad range name error msg.Olivier Hallot1-1/+1
Change-Id: I1cab4ba325422a7ebc9fa5a48fc9ac7419599742 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185559 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2025-05-16ScEditUtil::GetString: pass ScDocument by refXisco Fauli1-1/+1
allowing to drop ScGlobal::GetStaticFieldEditEngine(); It was added in commit 1ecdc7aaf661e97a33cf521f553481d79cd26de2 Author: Eike Rathke <erack@redhat.com> Date: Thu Jul 25 15:33:49 2013 +0200 resolved fdo#67249 use ScFieldEditEngine to resolve field content Also adapt the testRichTextContentODS unittest Change-Id: I06eb1b2b4fcc35867531c645098d854dd9907bc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185406 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-05-16ScConditionalFormat: pass ScDocument by refXisco Fauli5-18/+18
and in other related places Change-Id: Ic4fd970c0f91f246893013f0751376043dd809f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185361 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2025-05-02tdf#47479: Do not modify range of sheet / column / row in notificationsMike Kaganski1-12/+36
Change-Id: I2c5afa5397e3a98806908a2f73f8d654e83fb890 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184889 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2025-12-04 07:31:49 +0000