Age | Commit message (Collapse) | Author | Files | Lines |
|
since the console code is now inside sd/, we dont need this
anymore.
Change-Id: Ic663c148a641297b1e935aa7f5e245643ebc1157
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186569
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
* Update helpcontent2 from branch 'master'
to b19ed0b137935eef1927fdb040fa783a9fc79df3
- Fix Text Attributes Help for Drawing Objects
Change-Id: I05baf729d82fc4f842208e8e33029248a1c3e27d
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/186581
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Jenkins
|
|
Change-Id: Ie86ba52ab2e8df66cabe75acaf440b2ca076f4c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186580
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
now that the slide console is not a separate component
anymore.
Change-Id: I21641e4157b8af4d44be91b15bc0b5740311472c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186568
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: If5cb8de60e3ab64f21a57bb4be2f409cd6d26647
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186564
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
...for loplugin:unoany, loplugin:fakebool, and loplugin:refcounting
Change-Id: Ib3278b126c3ea792c93cbf57f2414fd316278b88
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186560
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
|
|
Looks like it could be the other way round, using GetPoint/GetMark.
Change-Id: Iae95470a5877bdb8eaf05a65db18819dacd26ad4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186553
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Based on the discussion in the bug ticket.
Change-Id: Id15ecf21c4cd2d37956b12b1fec3735501571da5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186416
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
|
|
The bugdoc has <ins>AABBCC</ins> in it, selecting BB, marking the
selection as e.g. bold + undo + redo resulted in a plain format redline
for BB instead of a hierarchical insert-then-format redline.
Checking SwUndoAttr, its item set correctly tracks the boldness, also it
tracks the own (format) redline in m_pRedlineData correctly, together
with the pre-existing redline data in m_pRedlineSaveData. Also, checking
how this works in the undo case, SwUndoAttr::UndoImpl() first deletes
all redlines in the interesting text range and then restores the
pre-existing redline using a call to SwUndo::SetSaveData(). In the bad
case, what instead happens is that SwUndoAttr::redoAttribute() calls
sw::DocumentContentOperationsManager::InsertItemSet() with redline
tracking enabled, that creates a format redline, then we try to create
our own format redline, and the last one wins, losing the underlying
insert redline.
Fix the problem by improving SwUndoAttr::redoAttribute() to also call
SwUndo::SetSaveData() to re-create just the pre-existing insert redline:
with this the following AppendRedline() will result in the correct
insert-then-format hierarchical redline.
Change-Id: I1e1a284c017f39c62dcc03b6b49463bac106f21b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186566
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Added in
commit f2e8141fdb80611dd2c27924ece8edd56e11a332
Author: Xisco Fauli <xiscofauli@libreoffice.org>
Date: Mon Jun 16 10:09:12 2025 +0200
tdf#167023, tdf#167018: sw: Add UItest
Kudos to M. Kaganski for flagging it
Change-Id: If4283d2fa91cb5d3d41a7871b624b83b01bed98e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186563
Tested-by: Jenkins
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Now that the UNO abstraction and corresponding services
have been dropped in
commit 0905c23676fe34a5346683ee46568e4d1c58806a
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Fri Jun 13 18:27:09 2025 +0200
Stop using UNO abstraction for color picker
and
Change-Id: I9264707df57e46192a393f6736257c413e5d9831
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon Jun 16 08:01:55 2025 +0200
[API CHANGE] Drop ColorPicker, AsynchronousColorPicker
, no longer pass a sal_Int16 param to the ColorPickerDialog
ctor, but use the vcl::ColorPickerMode enum directly
without casting.
This also means that there is no more need for the
underlying int values of the enum values to have a
specific value, so no longer set these explicitly.
Change-Id: Ife2a7b0672bacc73b3001ef0e2e57f4626837655
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186539
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
The unpublished com::sun::star::cui::ColorPicker and
com::sun::star::cui::AsynchronousColorPicker UNO services
were previously used to be able to use ColorPickerDialog
(implemented in cui) from svtools.
That's no longer the case since
commit 0905c23676fe34a5346683ee46568e4d1c58806a
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Fri Jun 13 18:27:09 2025 +0200
Stop using UNO abstraction for color picker
, so drop the now unused services and the ColorPicker
class that implemented them.
Change-Id: I9264707df57e46192a393f6736257c413e5d9831
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186538
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
...so that CppunitTest_services wouldn't fail with
> postprocess/qa/services.cxx:341:(anonymous namespace)::Test::test
> assertion failed
> - Expression: info.is()
> - instantiating "org.libreoffice.comp.embindtest.Test" via "org.libreoffice.embindtest.Test" does not provide XServiceInfo
Change-Id: I83721006bfd8b71b488b15c41e81df9c5d0d755e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186559
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
|
|
Change-Id: I6c529368e58a04949994a0fa3758fd835738d1f1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186529
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Icb8123dea4d9b0648069d991a80e178089514e60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186528
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
It turns out, that these are naturally processed twice.
When enumerating paragraph's content, CollectFrameAtNode would find both
the shape and the shape's text frame anchored to the paragraph node.
Then, XMLTextParagraphExport::exportTextContentEnumeration will process
the shape; and in XMLShapeExport::collectShapeAutoStyles, the shape will
be queried for XText, which will return the text frame, which will then
be processed.
And finally, XMLTextParagraphExport::exportTextContentEnumeration will
process the text frame, for the second time - at which point, the frame's
paragraphs will be processed again.
I don't know if it's possible to avoid the repeated processing; here I
only add a debug check for this, and skip adding duplicate node index.
Change-Id: I84275f233554a6b4923ddaabc336bec7a94ec2fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186546
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
It was left no-op in commit 7ab51def766ad6bfdcf5111e7b751bbc2bbf1d73
(sw: implement "Theme" property for the XDrawPage in Writer, 2023-02-01).
This resulted in the request for the property returning an empty Any;
then export code throwed with this stack:
xolo.dll!cppu::any2bool(const com::sun::star::uno::Any & rAny) Line 105
xolo.dll!XMLNamedBoolPropertyHdl::exportXML(rtl::OUString & rStrExpValue, const com::sun::star::uno::Any & rValue, const SvXMLUnitConverter & __formal) Line 55
xolo.dll!XMLPropertySetMapper::exportXML(rtl::OUString & rStrExpValue, const XMLPropertyState & rProperty, const SvXMLUnitConverter & rUnitConverter) Line 215
xolo.dll!SvXMLExportPropertyMapper::_exportXML(comphelper::AttributeList & rAttrList, const XMLPropertyState & rProperty, const SvXMLUnitConverter & rUnitConverter, const SvXMLNamespaceMap & rNamespaceMap, const std::vector<XMLPropertyState,std::allocator<XMLPropertyState>> * pProperties, unsigned long nIdx) Line 1079
xolo.dll!SvXMLExportPropertyMapper::_exportXML(unsigned short nPropType, unsigned short & rPropTypeFlags, comphelper::AttributeList & rAttrList, const std::vector<XMLPropertyState,std::allocator<XMLPropertyState>> & rProperties, const SvXMLUnitConverter & rUnitConverter, const SvXMLNamespaceMap & rNamespaceMap, std::vector<unsigned short,std::allocator<unsigned short>> * pIndexArray, long nPropMapStartIdx, long nPropMapEndIdx) Line 919
xolo.dll!SvXMLExportPropertyMapper::exportXML(SvXMLExport & rExport, const std::vector<XMLPropertyState,std::allocator<XMLPropertyState>> & rProperties, long nPropMapStartIdx, long nPropMapEndIdx, SvXmlExportFlags nFlags, bool bUseExtensionNamespaceForGraphicProperties) Line 823
xolo.dll!SvXMLAutoStylePoolP_Impl::exportXML(XmlStyleFamily nFamily, const SvXMLAutoStylePoolP * pAntiImpl) Line 683
xolo.dll!SvXMLAutoStylePoolP::exportXML(XmlStyleFamily nFamily) Line 369
xolo.dll!SdXMLExport::ExportAutoStyles_() Line 2207
xolo.dll!SvXMLExport::ImplExportAutoStyles() Line 1122
xolo.dll!SvXMLExport::exportDoc(xmloff::token::XMLTokenEnum eClass) Line 1390
xolo.dll!SvXMLExport::filter(const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & aDescriptor) Line 814
svxcorelo.dll!SvxDrawingLayerExport(SdrModel * pModel, const com::sun::star::uno::Reference<com::sun::star::io::XOutputStream> & xOut, const com::sun::star::uno::Reference<com::sun::star::lang::XComponent> & xComponent, const char * pExportService) Line 108
svxcorelo.dll!SvxDrawingLayerExport(SdrModel * pModel, const com::sun::star::uno::Reference<com::sun::star::io::XOutputStream> & xOut, const com::sun::star::uno::Reference<com::sun::star::lang::XComponent> & xComponent) Line 43
svxcorelo.dll!SvxDrawingLayerExport(SdrModel * pModel, const com::sun::star::uno::Reference<com::sun::star::io::XOutputStream> & xOut) Line 133
swlo.dll!SwTransferable::WriteObject(SvStream & rOStream, void * pObject, unsigned long nObjectType, const com::sun::star::datatransfer::DataFlavor & __formal) Line 738
vcllo.dll!TransferableHelper::SetObject(void * pUserObject, unsigned long nUserObjectId, const com::sun::star::datatransfer::DataFlavor & rFlavor) Line 912
swlo.dll!SwTransferable::GetData(const com::sun::star::datatransfer::DataFlavor & rFlavor, const rtl::OUString & rDestDoc) Line 612
vcllo.dll!TransferableHelper::getTransferData2(const com::sun::star::datatransfer::DataFlavor & rFlavor, const rtl::OUString & rDestDoc) Line 456
vcllo.dll!TransferableHelper::getTransferData(const com::sun::star::datatransfer::DataFlavor & rFlavor) Line 321
vclplug_winlo.dll!CXTDataObject::renderAnyDataAndSetupStgMedium(tagFORMATETC & fetc, tagSTGMEDIUM & stgmedium) Line 341
vclplug_winlo.dll!CXTDataObject::GetData(tagFORMATETC * pFormatetc, tagSTGMEDIUM * pmedium) Line 261
vclplug_winlo.dll!CXNotifyingDataObject::GetData(tagFORMATETC * pFormatetc, tagSTGMEDIUM * pmedium) Line 102
ole32.dll!HandleFromHandle(IDataObject * pDataObj, tagFORMATETC * pformatetc, tagSTGMEDIUM * pmedium) Line 2049
ole32.dll!RenderCurrentFormat(HWND__ * hClipWnd, unsigned int cf, tagSTGMEDIUM * pmedium, IDataObject * pDataObj) Line 4062
ole32.dll!RenderFormat(HWND__ * hClipWnd, unsigned int cf, IDataObject * pDataObj, void * pvMTADataObject) Line 4196
when trying to export this property as a boolean.
I don't know if there needs to be some change to handle the empty Any
case properly here; but now SwFmDrawPage provides the wanted value.
Change-Id: Id4fa7ff989697aa4329c6c36e0927d95eae8e6e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186533
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I81386e6b6f3052c07be3271cac31eb4194ef0bc0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186551
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
|
|
Change-Id: I14d12f6c577be7a47cead8c12c6db8d360e78867
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186527
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
The error may come not only from stream.
Change-Id: I71f050502381459bc0ee6fc8048790a51b0e1d0d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186532
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
See tdf#94879 for motivation.
Change-Id: Ic5df0feeaa57bd4ac34fa6b6bc3e13c5e6145e11
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186535
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Not all kind of shape objects were checked for "No alt text",
but only a few one. Let's extend it with the other possible
shape types in this patch.
Change-Id: Id3bcf4992fc8f281ee4a32c569cba3590ae6c002
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186413
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
|
|
Change-Id: I2a6576d2d853dd6b34c0ea69287690b462f194e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186504
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
|
|
Adjust naming following
Change-Id: Iebc3c1172dfd12dbbe72c3a56eeb6eb333d799c5
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Fri Jun 13 18:45:11 2025 +0200
Move SvColorDialog from svtools to vcl
* Rename SvColorChooserDialog -> ColorChooserDialog,
now that the class is no longer in svtools
* Move ColorPickerMode from svtools namespace to vcl
Change-Id: I27e84d6c6e7f7cde35dea31159b01dd1e0d312cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186482
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Now after
Change-Id: I3b9997b73a9a6bcce4c5b3ae3bd7d57816a4419b
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Fri Jun 13 18:27:09 2025 +0200
Stop using UNO abstraction for color picker
, SvColorDialog no longer depends on anything
above vcl, so move it there, which will
help in implementing support for platform/toolkit-native
alternatives for the color picker instead of using
the LO-internal one.
The "Sv" naming prefix will be dropped in a separate commit,
to keep the diff clearer.
Change-Id: Iebc3c1172dfd12dbbe72c3a56eeb6eb333d799c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186481
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
SvColorDialog is using an instance of
ColorPickerDialog under the hood.
So far, the ColorPickerDialog instance was
created and used via UNO abstraction, by
calling either
css::cui::ColorPicker::createWithParent (for the
synchronous case) or
css::cui::AsynchronousColorPicker::createWithParent
(for the async case), which would end up calling
the UNO service ctor,
com_sun_star_cui_ColorPicker_get_implementation
(and creating an instance of ColorPickerDialog
in both cases, just with a reference to a different
UNO interface as a return value for both cases).
Further interaction would then happen via the
XExecutableDialog or XAsynchronousExecutableDialog
UNO interfaces and by setting/reading properties.
Stop using that UNO abstraction and instead
introduce AbstractColorPickerDialog as a new
VclAbstractDialog subclass, which allows to
interact with the the ColorPickerDialog more
directly while still avoiding a direct dependency
on (the higher-level module) cui in svtools.
This also implies that SvColorDialog now no longer
depends on svt::DialogClosedListener for the async
case, which means that SvColorDialog can be moved
from svtools to vcl in the future. That in turn will
help in implementing support for platform/toolkit-native
alternatives for the color picker instead of using
the LO-internal one.
No change in user-observable behavior intended
or seen in a quick test in Writer (open dropdown for
"Font Color" toolbar item, then select "Custom Color"
to open the dialog).
Change-Id: I3b9997b73a9a6bcce4c5b3ae3bd7d57816a4419b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186468
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Move declaration of ColorPickerDialog and related
classes and enums from the .cxx to a new header file.
This is in preparation of creating an instance of
the class without having to go through the UNO
abstraction by creating a service using
com_sun_star_cui_ColorPicker_get_implementation
as SvColorDialog currently does by calling
css::cui::ColorPicker::createWithParent and
css::cui::AsynchronousColorPicker::createWithParent.
Change-Id: I797ab75f5393ceeff65235864b4aca48281a9744
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186467
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
Drop SvColorDialog::SetMode and instead pass the
mode in the ctor with a default mode of
svtools::ColorPickerMode::Select, i.e. leaving
behavior unchanged when none is explicitly passed.
This aligns SvColorDialog further with
ColorPickerDialog, which is used under the hood.
Change-Id: I67cc5f0874758e6d0f081666b32290a1d4726b46
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186466
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Extract logic to set a color from the ctor to a new
public method ColorPickerDialog::SetColor.
This aligns the ColorPickerDialog API further with
the one that SvColorDialog has, which uses the
ColorPickerDialog under the hood - currently still with
some UNO interface abstraction in between.
Change-Id: I82fb33a86ca8a9c9ec53c18e6fd87a631fae1860
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186465
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
Change-Id: I172b37fb05bb9907188653cce32424941a37feca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186464
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
... instead of as a param to SvColorDialog::Execute or
SvColorDialog::ExecuteAsync.
Passing a dialog or widget parent in the ctor is
typical for UI toolkits.
While SvColorDialog currently only creates the actual color
picker dialog in its Execute{,Async} methods, this will change
in an upcoming commit, for which this one prepares.
Change-Id: Ib1ea41cc986577a3e3f1dddfd93a04c2e69bc15f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186463
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
Change-Id: I94202657c9338596f0b16c63bab110d3af7d94df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186519
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
PasteSlidesFromSystemClipboard seems to have some serious side effects,
making following paste of different flavors fail. So check the object
descriptor, which allows to avoid the problematic code for non-Impress
objects. This also improves performance. But the underlying problem is
not fixed here.
Change-Id: I3c58c502900eb7c76b08b77945049bfa6a149182
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186526
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I1425886c86f277930ad03c97fcb01fd7546235ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186518
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
Let it return immediately where the job is done. To do that, move the
cleanup actions to a ScopeGuard. That avoids overlooks where an early
return skipped these actions by mistake.
Change-Id: I8330afed43c70e8f4a3b15ac7ced44f61cc51e9f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186522
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I9551b5739805c16bf3fd5b26812bd85bde7b17ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186517
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I961f3560c669eec4a1842f47bb3e8a7da5049589
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186521
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
|
|
This allows to avoid passing empty sequence as the "no theme" value.
Change-Id: I46b077149ec317fbcb19b39591aca6db3bf97393
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186520
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
we can use the underlying vcl API
Change-Id: I7c4987e5d12a0131e6556387c1e37c65c68cdae0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186509
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
It is not needed, because Unknown is -1, outside of the iterated
range of [0, LAST].
Change-Id: I3ee1c7112d4594d76f2ed526d4c18dc0d8c73e7b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186514
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Let it also handle a hypothetical non-UnoTheme implementation (it
is possible to create these e.g. from Basic / Python code). When
handling it, use theme name as color set name (there seems to be
no UNO API to get color set name?). And use the same code for the
creation of Theme from PropertyValue list.
The check that enumrange<ThemeColorType> does not iterate through
ThemeColorType::Unknown is redundant, since that value is outside
of [0, LAST] range.
Change-Id: Iae6770f196011deeb2a92d3b64af514fb6a53d06
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186513
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
|
|
commit 84f7b840 has moved deleteSeries from DataSeriesHelper to
ChartType. But the move has lost the actual erase.
No unit test, because I don't know how to use a dialog in a test.
Change-Id: I92dc1d2bdae0fe0d63b6c3b012b50b8c66032334
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186512
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I1b0c58a76da08c48fe967d27e34c2cc516d8cd16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186511
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
(1) remove the callback if the object destructs.
(2) assert if addCallback() is not going to do anything, so
we dont get subtle failure modes
Change-Id: Ibc4a8634c237858eb6add5e1db8ac1ca982590f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186510
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
It is created e.g. in XMLThemeContext dtor.
The type of return of FromAny is changed to shared_ptr, which allows
to return the result of UnoTheme::getTheme, and which matches the
types used by all the function callers.
Change-Id: Ie223e5663843be098e2da45cb04d825c72c372fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186508
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
|
|
The exception was thrown with this stack:
comphelper.dll!com::sun::star::lang::IllegalArgumentException::IllegalArgumentException(const rtl::OUString & Message_, const com::sun::star::uno::Reference<com::sun::star::uno::XInterface> & Context_, const short & ArgumentPosition_, std::source_location location) Line 39
comphelper.dll!comphelper::SequenceAsHashMap::operator<<(const com::sun::star::uno::Any & aSource) Line 151
comphelper.dll!comphelper::SequenceAsHashMap::SequenceAsHashMap(const com::sun::star::uno::Any & aSource) Line 109
docmodello.dll!model::Theme::FromAny(const com::sun::star::uno::Any & rVal) Line 86
sdlo.dll!SdXImpressDocument::setPropertyValue(const rtl::OUString & aPropertyName, const com::sun::star::uno::Any & aValue) Line 2879
xolo.dll!XMLThemeContext::~XMLThemeContext() Line 57
xolo.dll!XMLThemeContext::`scalar deleting destructor'(unsigned int)
xolo.dll!SvXMLImportContext::release() Line 106
xolo.dll!rtl::Reference<SvXMLImportContext>::~Reference<SvXMLImportContext>() Line 126
xolo.dll!SvXMLImport::endFastElement(long Element) Line 889
saxlo.dll!`anonymous namespace'::Entity::endElement() Line 515
saxlo.dll!sax_fastparser::FastSaxParserImpl::consume(`anonymous-namespace'::EventList & rEventList) Line 1021
saxlo.dll!sax_fastparser::FastSaxParserImpl::parseStream(const com::sun::star::xml::sax::InputSource & rStructSource) Line 860
saxlo.dll!sax_fastparser::FastSaxParser::parseStream(const com::sun::star::xml::sax::InputSource & aInputSource) Line 1479
xolo.dll!SvXMLImport::parseStream(const com::sun::star::xml::sax::InputSource & aInputSource) Line 528
sdlo.dll!`anonymous namespace'::ReadThroughComponent(const com::sun::star::uno::Reference<com::sun::star::io::XInputStream> & xInputStream, const com::sun::star::uno::Reference<com::sun::star::lang::XComponent> & xModelComponent, const rtl::OUString & rStreamName, const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> & rxContext, const char * pFilterName, const com::sun::star::uno::Sequence<com::sun::star::uno::Any> & rFilterArguments, const rtl::OUString & rName, bool bMustBeSuccessful, bool bEncrypted) Line 226
sdlo.dll!`anonymous namespace'::ReadThroughComponent(const com::sun::star::uno::Reference<com::sun::star::embed::XStorage> & xStorage, const com::sun::star::uno::Reference<com::sun::star::lang::XComponent> & xModelComponent, const char * pStreamName, const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> & rxContext, const char * pFilterName, const com::sun::star::uno::Sequence<com::sun::star::uno::Any> & rFilterArguments, const rtl::OUString & rName, bool bMustBeSuccessful) Line 369
sdlo.dll!SdXMLFilter::Import(ErrCode & nError) Line 615
sdlo.dll!sd::DrawDocShell::Load(SfxMedium & rMedium) Line 295
sfxlo.dll!SfxObjectShell::LoadOwnFormat(SfxMedium & rMedium) Line 3611
sfxlo.dll!SfxObjectShell::DoLoad(SfxMedium * pMed) Line 712
sdlo.dll!sd::slidesorter::controller::Clipboard::PasteSlidesFromSystemClipboard() Line 965
sdlo.dll!sd::View::InsertData(const TransferableDataHelper & rDataHelper, const Point & rPos, char & rDnDAction, bool bDrag, SotClipboardFormatId nFormat, unsigned short nPage, o3tl::strong_int<short,SdrLayerIDTag> nLayer) Line 711
sdlo.dll!sd::View::DoPaste(sd::Window * pWindow, bool __formal) Line 329
Change-Id: I5eca1088c75aafd0151d778c4fc16becb1e579dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186507
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
now that the slide console is not a separate component
anymore.
Change-Id: I85b219b43752596a67633f8a793d139b739316e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186497
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Unlike the two previous (SwXTextSections::GetObject and
SwXTextTables::GetObject), this one encapsulates a const_cast.
But it's used in a single place; no need for inconsistency.
Change-Id: I8af0d49a073214bb584fd89627f71cacc59415a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186506
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Unneeded inderection for another single static function call.
Change-Id: I81187f0f9f2d11816884a8228a28e45c90fc6fd2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186505
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
|
|
Unneeded inderection for another single static function call.
Change-Id: I0d6bc7a3adc2780f7a60514d596a30eca2bbe8e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186503
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|