summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
101 min.cid#1465234 Unchecked return valueHEADmasterCaolán McNamara1-2/+4
Change-Id: I56d59de5c65144283595b044142ff3f8988a02a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98409 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
101 min.cid#1465233 Unchecked return valueCaolán McNamara1-6/+30
Change-Id: I078f20bd607110cd526ce40a6391affd238a14d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98410 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
118 min.cid#1465235 Dereference null return valueCaolán McNamara1-1/+1
Change-Id: I73efddfeca873e43f1505790eebf260c27e248de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98408 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
119 min.cid#1465236 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I1303fe8ac9a5eecc06d9622893c8643d87120a58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98407 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
120 min.cid#1465237 silence Dereference after null checkCaolán McNamara1-0/+1
Change-Id: I7014da07d88861e4f08fb9e1006dccb6fc2ad245 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98406 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2 hoursRevert "tdf#128526: Make the read-only notification a bit more verbose"Samuel Mehrbrodt1-1/+1
This reverts commit 6c102b0a12ed911b207d8b1da421f2b916c2bcdf. Reason for revert: The Infobar has an "Edit Document" button which lets you edit the document without first saving it in another place. So at least in that place this verbose message is confusing. Change-Id: I3bcdd389a560ac4c8ee0f86ca13573bbc05f2ebb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98075 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins
3 hourscid#1465239 silence Explicit null deferencedCaolán McNamara1-0/+1
Change-Id: I35135f6522ea64d0a8d7063949cd006278ec6080 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98404 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
3 hourscid#1465238 Uninitialized scalar fieldCaolán McNamara1-0/+1
Change-Id: Ia0ffb4bad265aabe396ef94e3d9c2bbe79993b4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98405 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
3 hoursUpdate git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 5907932eac35843d0cd88adea09ba8890ed59884 - Fix Help after translator review. Many thanks to Mikel Tõnnov. Change-Id: I2858f436fe6fecaac6f50c6912883b5c9c46d050 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/98393 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
3 hoursscPrintTwipsMsgs: Use top-left of output-area as the refpointDennis Francis1-1/+1
We can't use the transformed version of editeng origin, since it need not be in client view area depending on text alignment, which is unusable as far as the clients are concerned. Top-left corner of output-area is always guaranteed to be in client view area independent of text-alignment settings. Change-Id: I5bd20d2b52e146371de4b605bf7934b7e7d6fc5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98131 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
3 hourslokit: Avoid sending wrong edit-cursor/selection messages when...Dennis Francis5-3/+58
the EditView's output-area needs to be tweaked temporarily to render it to a tile which is meant for another view. Change-Id: I2b8fc1986c247ce65c18ea64e3b43d25625c7e9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98129 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
4 hoursDocs: Add missing propertySamuel Mehrbrodt1-0/+4
Change-Id: I1f4a0602f23cba86adbf627b0881ae5034db0af8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98188 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
4 hoursunotools: create instances with uno constructorsNoel Grandin11-72/+89
See tdf#74608 for motivation Change-Id: I7a68484564aea9b416c12d5364d20ff8af77f40b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98380 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
4 hourstdf#134225 Chart view: fix moved date labelBalazs Varga3-13/+27
outside from pie chart. Do not need to check the sector size of a pie slice, before best fit algorithm, so we can use the CENTER position as a start position of BEST_FIT. Completion of c66cb6d6e4a843dc7c7d06e1c2c0723a6ff85fc5 (tdf#134029 Chart view: enable to move data label) Change-Id: Ie1a53784e7df2887282155113bf8bb607cdb09e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96945 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
4 hoursThere is no com_sun_star_comp_dbaccess_DatabaseDataProvider_get_implementationTor Lillqvist1-1/+0
Change-Id: I90f61ca1209a213757e60346ce77aff6912c8b58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98398 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
5 hoursThere is no com_sun_star_comp_dba_ODatabaseContext_get_implementationTor Lillqvist1-1/+0
Change-Id: Ic22eb0c075c195d4480c8757642d902003bd22d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98397 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
5 hoursdesktop: create instances with uno constructorsNoel Grandin22-438/+62
See tdf#74608 for motivation Change-Id: Id332d79c29c8e5f668663070d83aba596f017908 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98390 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
6 hourstdf#60684: graphic type content must correspond with graphic type extensionJulien Nabet2-2/+5
Change-Id: I8075b1b44aa400268b4022decb2a56770c81d83b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98239 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
6 hoursframework: create instances with uno constructorsNoel Grandin8-97/+60
See tdf#74608 for motivation Change-Id: Ia2d9447b687f0792d9d3a98d30cd2b8fe54049ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98388 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
6 hoursjsdialog: export cursor visibility for text areasSzymon Kłos2-0/+10
Change-Id: I404e496a6f68f5cc2e2e628b51c759be49c7fecd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97729 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98231 Tested-by: Jenkins
6 hoursclean up macro usageNoel Grandin49-639/+115
Change-Id: I06669718f692cc5e9e209b4e490365f4f016afdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98389 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
15 hourstdf#134606 DOCX table import: fix gridBefore + nestingLászló Németh3-15/+37
Nested tables in a table row with gridBefore could result of broken outer table, if the row doesn't contain text before the nested table, resulting invalid TextRange for insertion of gridBefore cells. Regression from commit 70274f86cdc1c023ffdd0130c262c1479262d76b (tdf#116194 DOCX import: fix missing tables with w:gridBefore) Change-Id: I6bb3948b6522d8785a1ea0ccf8d7c7f3c2bde189 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98320 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
15 hoursResolves: tdf#124454 exec the matrix operator on values converted from stringsEike Rathke1-1/+1
Effectively a fallout from the matrix operations rework started for tdf#89387 that did not convert strings at all and subsequent work converted the string according to settings but did not apply the current operator on the result. Change-Id: I90c8963021396fd9a46b063f6aee96283f89271a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98385 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
16 hoursFix typoAndrea Gelmini1-1/+1
Change-Id: I2a5a231d7e58c3a84651c70cdf561c81b56a651a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98250 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
17 hoursquery if the cursor can be moved up or downCaolán McNamara5-0/+59
Change-Id: I47c09ff5f76c873cf30e608a134f90b42040a0c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98387 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
17 hoursexpand to cover subwidgetsCaolán McNamara1-1/+1
Change-Id: Ib0765e6a38c6dc6cdb32eefc013b432f3cf36db2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98386 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
17 hourstdf#134264: sw: Add unittestXisco Fauli2-0/+8
Change-Id: I373b2549a067452056f649213c32d5983212580c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98378 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
17 hoursframework: create instances with uno constructorsNoel Grandin19-171/+230
See tdf#74608 for motivation Change-Id: I6237016000dc05eacb14e59815b53cd44fbfce0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98384 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
18 hourslok: set to export PDF bookmarks by default when save-as a PDFTomaž Vajngerl1-15/+19
Change-Id: Ieb182b9a0d1f18a29a83ce369881578c06e217ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98211 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
18 hourspdf: add PDFiumPathSegment to the wrapper & use in ImpSdrPdfImportTomaž Vajngerl4-28/+76
A PageObject of type FPDF_PAGEOBJ_PATH can have a path segment, that is common in vector graphic objects. The path segment is wrapped into PDFiumPathSegment which can be used to handle the path and path properties. Change-Id: I990d51ba90fa356a6eca137eb4b71947858289aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98210 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
18 hourssvmtest shouldn't compare rendering against itselfLuboš Luňák1-1/+2
Change-Id: I426187abfd4e5e2596f9680aff14fc1e370a18ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98383 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
18 hoursavmedia/win: create instances with uno constructorsNoel Grandin11-92/+21
See tdf#74608 for motivation Change-Id: I3a4afa5e583ad5b6339d4cf0036e1dc562274864 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98379 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
18 hoursunoxml: create instances with uno constructorsNoel Grandin19-432/+88
See tdf#74608 for motivation Change-Id: I636d92faa3b26ac06c044c0485e632967daa709c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98313 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
18 hoursdbaccess: create instances with uno constructorsNoel Grandin67-1410/+307
See tdf#74608 for motivation Change-Id: Ib03014444d8176417cbd00b56764ee45fdad557c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98322 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
18 hourssvgio: create instances with uno constructorsNoel Grandin6-125/+14
See tdf#74608 for motivation Change-Id: Iad7a6435482596dd3e955d3323aaf3d5e6984517 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98371 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
18 hoursimprove weld::Widget::draw rendering a widgetCaolán McNamara2-5/+9
Change-Id: I1f49e3e7829f41d7eb4ffc137a9b0ab5c47d2cce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98375 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
20 hoursSAL_WARN->SAL_INFO to prevent spamming the unit test logsNoel Grandin1-1/+1
Change-Id: I0c4f530f86e1e20f7fc42a1dff4499cc57c45bbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98366 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
20 hoursdrop WB_BORDER if the border style is invisibleCaolán McNamara2-1/+4
Change-Id: Ie88818cb2b61d411f868f748d6a7c2fdf8028e65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98377 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
20 hoursprepareWidgetOwnScrolling already set WB_BORDERCaolán McNamara1-6/+0
the pRealParent != pParent case already caused WB_BORDER to be set in prepareWidgetOwnScrolling Change-Id: Id33d9f8d10b8076a26b31e2dcdc70e3419bba5be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98376 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
21 hoursscPrintTwipsMsgs: Use print-twips paper-sizeDennis Francis4-5/+22
Paper size for the EditEngine is calculated based on per-cell pixel alignment. So lets use the exact print-twips version whenever we need it to compute/adjust output-area and visible-area of EditView. Change-Id: I7da6db9363d09965315ff5ca9d01f0fea141a533 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98130 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
21 hourssvx: create instances with uno constructorsNoel Grandin5-72/+10
See tdf#74608 for motivation Change-Id: If6bd80525d398b45c2938e921c183633f173dfae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98372 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
21 hourstdf#129452 writerfilter: preserve gridSpans longer than currentRowJustin Luth5-33/+42
It is a fairly common thing for table operations to compare items in the same column (like merged cells for example). In order to determine column information, each row's (gridBefore - change-id Ie305477f0e3468a4a923095d76f520d97fe99ffe - and) merged cells need to be known. So save that information in the cell data - and don't just throw it away after the current row has been analyzed. Good grief. Change-Id: Ibfdac336bbb1f7303c7e585a85c94be37ad6f916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97433 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: László Németh <nemeth@numbertext.org>
22 hoursuitest : Add demo for Calc-commentsAhmed ElShreif1-0/+49
This patch test the support that added to this patch: https://gerrit.libreoffice.org/c/core/+/96837 Change-Id: If7444813f65bd90d62d0eb3504dcfc588c3f4e32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97074 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
22 hoursuitest : Add support to Calc - commentsAhmed ElShreif2-0/+43
This patch has the implementation of the support for Calc comments . Now you can use these lines to use comments in calc: * Open Comment Window : >> gridwin.executeAction("COMMENT",mkPropertyValues({"OPEN":""})) * Then Type text as normal : >> gridwin.executeAction("TYPE",mkPropertyValues({"TEXT":"any"})) * Close Comment Window : >> gridwin.executeAction("COMMENT",mkPropertyValues({"CLOSE":""})) * Write Comment without opening comment window: >> gridwin.executeAction("COMMENT",mkPropertyValues({"SETTEXT":"any"})) You can also check the comment text by this line: >> get_state_as_dict(gridwind)["CurrentCellCommentText"] I will provide a test case in another patch. Change-Id: Ie3fc4efffb07827e742bdaa99dd5147c8b9711d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96837 Tested-by: Jenkins Reviewed-by: Ahmed ElShreif <aelshreif7@gmail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
22 hoursAvoid "ECHO is off." output when requested variable consists of spacesMike Kaganski1-1/+2
Change-Id: I41e298ee3ea8d6c1cd249e8ee5f0ced997255ec3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98369 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
23 hoursfix fuzzer buildCaolán McNamara9-17/+18
Change-Id: I1c96d177ddf6061e61f4027675e657c2d7fd446e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98367 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
24 hourstdf#134260: sw: Add unittestXisco Fauli2-0/+31
Change-Id: I719dac8528453b00219c5bdc621f7ce88cd40bde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98318 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
24 hoursFixing top border style by fixing three XSLT issues triggered by...Svante Schubert2-4/+12
... new properties in ODF 1.3 * check for fo:border='none' * missing @ in @fo:background-color * without default case (xsl:otherwise), end delimiter for "page" missing in CSS Change-Id: Ie5d0c3e8a32de0403534c5a4fa33a5f20393ce69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98365 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
24 hoursconfigure: try to fix qconfig.h checkMichael Stahl1-0/+5
Change-Id: Ie88d36d2f00c920a2d2a3e8fc6a84fdca4552b86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98314 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
24 hourstdf#134567 Show all properties in DPSShivam Kumar Singh2-11/+6
Change-Id: If2238a80fbc9fc803fc5e12904964bf4289ba2d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98310 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>