summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
94 min.Update git submodulesHEADmasterOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to f46ebea0276ae94bc299cb4c2bbf4a5b3d69173b - Mute l10n on some internal field names Change-Id: Ie794e15c31def6111eccd83f3e7a744984045cf6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117403 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
4 hoursAdd RemoveWhichRange unit testStephan Bergmann3-0/+194
...following up on the TODO in the commit message of 541f94df85756d3a383b1f9ba49841ca0011b52e "memcpy-param-overlap" Change-Id: Ib1f73b867eb3625e66a5040122e53a4a6e486802 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117385 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
4 hoursdon't ignore dump_syms errors during symbol extractionChristian Lohmaier2-8/+32
also fix the file filtering in case directories are passed for recursive traversal (pdb files are not created in instdir, so that never really matched our build-env) Pass a directory to the invocation to make use of that filtering, and also add a retry in case dump_syms segfaults during processing (see also 73299faa75a4974eb49c93ffdfb2d6329cb4e519) Change-Id: I8989c3fd72de0b18eecce490fac81db956f87515 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117386 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
5 hoursgtk4: reenable a cluster of working dialogsCaolán McNamara1-0/+8
Change-Id: Ida6e77c17681d9b1b5c0b7d6f6641974e097edbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117395 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
5 hoursdrop the bare set_busy_cursor, the scoped WaitObject is enoughCaolán McNamara1-2/+0
to set it back to its default on leaving the scope Change-Id: I303c201a1830ef24955fe35ad1058d6d88067f4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117394 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
5 hoursgtk4: get the cairo_font_options from widget pango_contextCaolán McNamara3-13/+29
in the absence of gdk_screen_get_font_options SalEvent::FontChanged is successfully firing for me on changing hinting in gnome-tweaks font section. Change-Id: I035a07d585b59822b08c801283321ab2582649aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117393 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
5 hoursgtk4: listen to display's setting-changedCaolán McNamara2-5/+21
in the absence of style-updated e.g. changing theme to a dark/light should change the brand image in the start center Change-Id: I7242019069b13093fee1430ade816a48fc0687f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117390 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
6 hoursNFC sw PropagateOutlineRule: early exit if no outlineRuleJustin Luth1-8/+6
There is only one outline rule, and we are just getting a pointer to it, so there should be no reason why this is retrieved for every style defined on the system. Just get it right at the beginning, and exit if there is none. Change-Id: I09d122481623dd4667e3f67c5de98164ff106a27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115615 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
6 hoursFix typoAndrea Gelmini1-1/+1
Change-Id: Ia84c47ea309734f27fd492ba791d88200408f105 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117361 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
6 hoursRemoved executable bits on pptx fileAndrea Gelmini1-0/+0
Change-Id: Icd927660130f72a077c12a38914b3fe8d0ab7d28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117360 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
6 hourstweak tools::Color::IsDark so it triggers on UbuntuNoel Grandin1-1/+2
in dark mode, otherwise some of the UI elements e.g. the start centre brand image, do not display the right version Change-Id: I3bfdc597324b564a9dbd47174332bb5f21b6a052 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117383 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
6 hours tdf#135316 docx open performance, cache next character style nameNoel Grandin5-19/+58
so we don't have to scan the list repeatedly, which is O(n^2) This takes my load time from 37s to 22s Change-Id: I0df2f2ace82f5cd6287c7ded796b02c5242269ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117396 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
6 hoursA separate function for getting a random search point is a little bit clearer.Todor Balabanov2-1/+5
Change-Id: I2d7471440cdee096b09ce704cbea3d5311f984c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117289 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
6 hourstdf#142839: do not forget to initialize *pHeightNTPMike Kaganski1-0/+4
Regression after commit d0a1616ccad0dd5f5a02c1b0204f537b57d0b4b5 Change-Id: Iaa8f67e0c7e3d99b057294717d24ffac4ad3534c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117389 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
8 hoursfix potential write-after-free in RecentDocsViewNoel Grandin2-3/+9
spotted while running a valgrind session Change-Id: I32c55ae2cc4b2d5abedca24c2f747aaa4183b3d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
8 hoursEMF+ WMF Update the variable names and add additional TODO warningsBartosz Kosiorek4-33/+34
Change-Id: I78b05fe3c293494195bdd37c3030147b1f21228e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117148 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
10 hoursstray always-show-image properties in random checkboxesCaolán McNamara1-2/+0
Change-Id: Ida0132cba449fb098415b26e59ee31643518af0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117378 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
10 hoursgtk4: reenable paragraph dialogCaolán McNamara1-0/+8
Change-Id: I25cb4ddd5f566892e11b600910b4691e4d46008a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117381 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
10 hoursgtk4: extend workaround for ampersand in paragraph dialog notebook labelsCaolán McNamara1-1/+1
Change-Id: Ib165f1ab1173f7bb6500d5dfff5f82e4216d9f42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117380 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
10 hoursgtk4: no need for ampersand workaround in an empty labelCaolán McNamara1-5/+8
Change-Id: I7e1327303589cc9c2bb24b72d5cac92ff0fc0bfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117379 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
10 hoursremove 'relief' from CheckButtonsCaolán McNamara9-11/+17
Change-Id: I8a17c36489946327113e63f80b952525ae4201a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117377 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
12 hourstools: handle special chars correctly in XmlHandler + testTomaž Vajngerl3-2/+75
Add the char encoding handler when calling xmlOutputBufferCreateIO so that special chars are handled correctly. Previously we just set nullptr. Change-Id: I7ef44130869625cc4662bf168550a3f987390287 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117355 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
12 hoursindexing: remove indexing changes from html exportTomaž Vajngerl6-78/+59
Turns out that reusing HTML export wasn't the best way to generate output XML that can be used for indexing, so reverting those changes. The IndexingExportTest and the test file has been moved out of html to its own folder, so it can be reused. Change-Id: Ie2b34285775133322c16c05eee9c0e9712c86c3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117354 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
12 hoursgtk4: reorder the cell renderers in the comboboxesCaolán McNamara1-1/+10
as used in format, character for the the tickboxes for spellchecking support Change-Id: I7b7b60455beb0f262b2e4c40286dcaec26eb42dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117375 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
12 hoursgtk4: implement setting grid row/col/widthCaolán McNamara1-26/+45
as used in e.g. font features dialog Change-Id: I558e52b2a1ccc471673613b63b42599db7c00ac5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117374 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
12 hoursthere is no such thing as a 'margin' propertyCaolán McNamara1-1/+0
added in: commit e97bccdba42b464e2df8d5996d4cdc9b03b6c243 Date: Wed Dec 9 00:44:10 2020 +0530 tdf#128176 Add a vertical scrollwindow to fontfeaturesdialog there is a deprecated 'border' property and various margin-start/margin-end/margin-top/margin-button properties Change-Id: I4528106a6cd51a9feede471cd8a47b81cf0df49a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117372 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
12 hourssplit SurfacePaintable outCaolán McNamara5-82/+128
Change-Id: I07d2109080f19fb7cf95bc439e5d99ba3247c2bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117371 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
12 hoursScriptForge - Comments in code: pointers to help pagesJean-Pierre Ledure21-1/+62
Insert in each service module a pointer to the help page on https://help.libreoffice.org containing the user documentation of the given service. Example: SF_Array.xba contains a pointer to next help page https://help.libreoffice.org/latest/en-US/text/sbasic/shared/03/sf_array.html?DbPAR=BASIC Only addition of comments lines. No code change. Change-Id: I83899d9fab247d23e2d5123378e2fb3fd0ade60e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117370 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
12 hoursuse string_view in the Translate APINoel Grandin67-120/+143
Change-Id: I0bb0ea9d39ed623928060ffd3f2e2bc36ba33209 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117272 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
13 hoursUpdate git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 21d0197b3705212a22b9e221ac1f624049516d9a - tdf#114930 Clarify associativity and precedence of operators to the help Change-Id: Ib55f0901235c082e88b49d1526b1123cd036f875 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117347 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
13 hoursAdapt o3tl::temporary to C++23 P2266R1Stephan Bergmann3-1/+30
With the recent implemenation of <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p2266r1.html> "P2266R1: Simpler implicit move" in Clang 13 trunk as <https://github.com/llvm/llvm-project/commit/bf20631782183cd19e0bb7219e908c2bbb01a75f> "[clang] Implement P2266 Simpler implicit move", a --with-latest-c++ build started to fail with > In file included from sal/rtl/random.cxx:25: > include/o3tl/temporary.hxx:21:62: error: non-const lvalue reference to type 'double' cannot bind to a temporary of type 'double' > template <typename T> constexpr T& temporary(T&& x) { return x; } > ^ > sal/rtl/random.cxx:97:37: note: in instantiation of function template specialization 'o3tl::temporary<double>' requested here > return std::modf(random, &o3tl::temporary(double())); > ^ etc. (And fixing that by adding the recommended static_cast then triggered a false loplugin:redundantcast warning.) Change-Id: I222429e9872afdedf77a07014c0a2e9e06c60b50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117335 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
13 hoursUpdate git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to ae00877c467d6ceee7b5c84ba3be99f0cb1468a4 - Mute l10n Change-Id: Id49c3b5c606c98bbc58d9c06245e2cebf8296676 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117300 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
13 hourssplit NotifyingLayout outCaolán McNamara6-96/+129
Change-Id: Ib706331f9e6b3749559a0b78f1a07d442a674829 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117369 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
13 hoursgtk4: undo overflow notebook insert in dtorCaolán McNamara1-2/+0
Change-Id: I2a051486346d4afabbf7f0f6f3b9683c8e0c9e62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117367 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
13 hoursgtk4: restore double-decker notebooksCaolán McNamara2-7/+131
add a 'NotifyingLayout' to find out when the size of a widget changes now that size-allocate has been removed Change-Id: Iae55b7fafd2fd26c62afaedd777ae40e84fbb964 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117348 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
14 hoursDrop the "console" functionality of ProfileZoneTor Lillqvist2-30/+6
It was not used anywhere and had not been cherry-picked to the relevant vendor production branches so apparently it was just some temporary experimentation? It is good to reduce complexity and increase code similarity between branches. Change-Id: Ib6717063f96d901d65ec36d65f3683af31065f2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117364 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
16 hourssvx: prefix member variables SdrViewEvent SdrView SdrObjGroupTomaž Vajngerl19-271/+275
Change-Id: Ic20c9dc7b8109cb095a883f2dfcec3e4f10b2428 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117352 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
16 hourstdf#90401 xmloff: remove personal info of comments and changesLászló Németh9-10/+205
If Options → LibreOffice → Security → Security Options and Warnings → Options... → Security Options → Remove personal information on saving" is enabled. Use the same time (1970-01-01T00:00:00) for mandatory time stamps, and replace authors and creator-initials with "1", "2", "3" etc., also to avoid of joining adjacent redline ranges. Note: to see the work of the unit test in Linux command line: (cd sw && make UITest_writer_tests7 UITEST_TEST_NAME="tdf90401.tdf90401.test_tdf90401_remove_personal_info" SAL_USE_VCLPLUGIN=gen) Change-Id: I3b4d710dbeeee12177aff378597cd2b683ca6c25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117319 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
16 hourssvx: pragma once for some SdrObject subclassesTomaž Vajngerl33-139/+35
Change-Id: Ibbadf5069fbf5327a8a5964a3003bf6e258fd00b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117351 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
17 hourstdf#115281 sc Windows: fix shortcut text Ctrl+` in View menuLászló Németh1-0/+3
In View->Show Formula, shortcut text was only "Ctrl" instead of the complete "Ctrl+`". Follow-up to commit 3f9fcf0e7f154e49bbffeaea925edb6055add494 "tdf#103388 Show the backtick used in shortcut in Calc View menu". Change-Id: Icef8904bac0b663d9702e62fcdc0ab1f0f4bd1ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117332 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
17 hoursScriptForge - Increment version numberJean-Pierre Ledure4-7/+7
Increment the versioning constants from 7.2 to 7.3 in next files modified: wizards/source/scriptforge/SF_Utils.xba modified: wizards/source/scriptforge/po/ScriptForge.pot modified: wizards/source/scriptforge/po/en.po modified: wizards/source/scriptforge/python/scriptforge.py Change-Id: Iba78215cea9c16f3e7dd9302b84c90815c7a9e68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117258 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
17 hoursbasegfx: change template param to use int instead bool - Tuple2DTomaž Vajngerl1-8/+4
Change-Id: I82bf089ea95fc3b2b527aa55cc8c9f09aa684502 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117353 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
21 hourstdf#142404 DOCX c15: fix centering when TabOverSpacingJustin Luth2-1/+5
I didn't notice the need for making the same exclusion that TabOverMargin made for centering when 7.2 got the new TabOverSpacing compat flag. But now I see it is still needed. Change-Id: Ia8069b5566eaf6dcdac6ff10ee0c60b849c5fa2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117339 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
25 hoursbasegfx: generalise tuples with template class Tuple2D and Tuple3DTomaž Vajngerl11-525/+714
B2DTuple2D, B2ITuple2D and B2I64Tuple share a lot in common so we can generalise it as a template class. The same goes for the 3D variants - B3DTuple and B3ITuple. This is the initial attempt, but doesn't yet generalise all that is possible. Add some tests for the tuple variants that test the behaviour of overloaded operators and other common methods. Change-Id: Iee5ed15d58ea88e65ee7854bd05a87ceab22023d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117104 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
25 hoursbasegfx: change template param to use int instead boolTomaž Vajngerl1-9/+9
Change-Id: I5e0f52ba9b9a82ad702204a2d35ea49a8d74aa55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117326 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
28 hoursAdapt implicit OString return value construction to C++23 P2266R1Stephan Bergmann7-9/+9
With the recent implementation of <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p2266r1.html> "P2266R1: Simpler implicit move" in Clang 13 trunk as <https://github.com/llvm/llvm-project/commit/bf20631782183cd19e0bb7219e908c2bbb01a75f> "[clang] Implement P2266 Simpler implicit move", a --with-latest-c++ build started to fail with > comphelper/source/xml/xmltools.cxx:103:20: error: no viable conversion from returned value of type 'char [39]' to function return type 'rtl::OString' > return str; > ^~~ [...] > include/rtl/string.hxx:277:5: note: candidate constructor [with T = char [39]] not viable: expects an lvalue for 1st argument > OString( T& value, typename libreoffice_internal::NonConstCharArrayDetector< T, libreoffice_internal::Dummy >::Type = libreoffice_internal::Dummy() ) > ^ [...] etc. Change-Id: If34f143a1855fdd7cd22ea3d7594f9381d50a7ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117336 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
29 hoursgtk4: redo theme unwanted active tab in overflow notebook into invisiblityCaolán McNamara2-24/+35
don't quite see why this doesn't work out of the box in gtk4, but putting it into the application-level style provider and using it via a style class works and probably makes more sense anyway. Change-Id: I4de196e462d7440174a0d67be25923bddab68197 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117337 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
29 hoursgtk4: partial restoration of double-decker notebooksCaolán McNamara1-22/+38
there isn't an obvious candidate as to when to do the split though Change-Id: Iee6d74015263b180470fc0c90924617bcde14421 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117334 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
29 hoursgtk4: Notebook label is now inside another widgetCaolán McNamara1-1/+6
Change-Id: If1f37959603dbe10e01d492321e9324ab55f10d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117333 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
29 hoursgtk4: add some working dialogsCaolán McNamara1-0/+6
Change-Id: Iac09640fe05110ef01cd7e4645b5a9e0ea8eb48e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117328 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>