Age | Commit message (Collapse) | Author | Files | Lines |
|
Writer does insert document variables only if they are in
document body as DOCVARIABLE fields. But ones given in
settings.xml (w:docVars/w:docVar) were ignored.
Moreover variables in settings should have priority and
overwrite ones in fields. Word by default does show only
field results, but refreshing field values will override
values with ones from settings.
Change-Id: I7103c90eef59ab18f8a25e616dcf8a8b1c6dcb08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149646
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
Change-Id: Ib6f1cd1ffac5479ae9cdf1e47fe0cb69abfc8c91
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148889
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149365
|
|
Change-Id: I2c40b1e6dbfcb8693afc27e65a75ef71e6a9b7e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148996
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149821
Tested-by: Jenkins
|
|
Change-Id: I694bf3ea9982032b0202e408f8121a6407427cca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148789
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149820
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
|
|
German UI"
This reverts commit 6896c12ddeb00210629396046678bc1d83d45644.
Reason for revert: it doesn't work according to https://bugs.documentfoundation.org/show_bug.cgi?id=129547#c48
Change-Id: Ia65cd31b652d41ff15352479923c49e9b30ba822
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149797
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I19722ac3e8b3f58ba916aa21513ba7ee34ef0bb8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148990
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149366
|
|
seen with
gcc --version
gcc (Debian 10.2.1-6) 10.2.1 20210110
similar to
commit ad59487053bcd267b53febde0cecbd64c7f94cc0
Author: Caolán McNamara <caolanm@redhat.com>
Date: Sun Mar 19 20:40:35 2023 +0000
crashtesting: frequent XDiagram OPropertySetHelper::getFastPropertyValue crash
Change-Id: If190e0c51a0b983165ff6f36bb2185456ea6bade
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149819
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
role mappings are somewhat unsatisfactory, but can serve as placeholders
for now
Change-Id: I050fdc0e85fc57de6d79823b2432b521dcffcad4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149215
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
... instead of SwDoc::GetUniqueTableName. The latter is expensive with
many tables, has O(n^2) complexity with rather large O, and in corner
cases of thousands tables with no or duplicate names, is unacceptably
slow.
Changes the test case import time from 39 s to 23 s on my system.
Change-Id: Ia461c860d56cbbfdcb25bacbb9cca4961ced885e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149817
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
* Update POPPLER_VERSION in poppler-config.patch.1
Change-Id: Iba770e6a3036a091925997025d4528f1d855da5d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148841
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
- add a SwRootFrame::DeleteEmptyFlys_(), which can delete empty flys and
invalidate the anchors, so the necessary text frame joins and page frame
deletions happen
- add a SwRootFrame::InsertEmptyFly(), which can build a to-delete list for
DeleteEmptyFlys_()
- add a SwFlyAtContentFrame::DelEmpty(), which can call InsertEmptyFly()
for one empty fly frame
- in SwTabFrame::Cut(), call DelEmpty() on the fly parent, similar to how we do
it for sections
- in SwLayAction::InternalAction(), call DeleteEmptyFlys() to actually delete
the unnecessary fly frames
Change-Id: I8d3b4ee2c07b60d6187059bb177c56a129810750
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149815
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Ideally SwFrame should not really know anything about footnote container
frames.
Change-Id: I2745cb74ff503288863439a15b37cec06766d208
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149814
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Which flushes out some dodgy behaviour.
Particularly in SwUndoFormatAttr, which was storing a sal_Int32 content offset in a sal_uInt16 page field.
In this case, rather just store the value on SwUndoFormatAttr itself, the same way it does for other things.
Change-Id: I5890353f5d51d82037bf7e0e77a16cf3b0dff565
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149764
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
I believe it's in a usable state now. But keep in
mind that the work isn't finished yet. For example,
there is only one base default style, and the work to
support styles for comments wasn't merged yet.
Change-Id: I1ad3a4803ad91773906743e19a35405d5cd3255d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149754
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
|
|
- Paste as Calc's own format (default in Calc, results with an
OLE object elsewhere), should preserve style assignment. This
can be in one of two ways: Either copy the shape itself, or a
cell range that includes a shape.
- Similarly, copying or moving a whole sheet to another document
should also preserve the style.
- Paste as drawing format (default in other apps, also default
in Calc when copying shapes from other apps), should preserve
the formatting as direct formatting. Pasting into Calc will
also assign the default style to that shape.
Change-Id: Icb951dad1a77ba9ced706c33c928980d1ec7f8ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149753
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
|
|
The style is empty, similar to the default cell style,
thus fall backs to the pool defaults for everything. This
ensures compatibility with existing documents, despite the
fact that the default style is applied to all shapes upon
import. In addition, people who will ignore styles and just
continue to use DF, will have their spreadsheets look the
same in older versions that don't support styles. For this
reason I also opted to not set a dedicated style for images
and OLE objects via
SdrModel::SetDefaultStyleSheetForSdrGrafObjAndSdrOle2Obj,
unlike Impress/Draw, and continue setting the "no fill and
no line" override as DF.
Change-Id: I11554044a1aaf386dc6c4acdbab798fc5a231adc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149359
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
|
|
since:
commit 628275acb1b9652e65b8c5c013549dce5ad6f5bf
Date: Thu Mar 23 11:24:30 2023 +0900
tdf#90407 Change the auto-fit alg. to match better with OOXML
Change-Id: Ib315d7543229b6ddae0e3282be8cfdfb3f1bad13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149776
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Id5e920c16f005512a14e41d453f435826a9e7053
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149775
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I7d4776d77385dc46f496b873c75e2be25840f86b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149774
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I93775299aa340e2e645a04be5d0bc36a9caea103
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149773
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
- get rid of legacy call with unused WhichId (TABLEFML_UPDATE)
- simplify and inlune ChangeSate, by now only handling TBL_CALC
- simplify params for UpdateTableFields (explictly just one SwTable*)
Change-Id: Ie356c2a17eab0b557efb54719d33e278b887eef5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149591
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
|
|
Change-Id: Ic165f012e6fc21e4be6833ccbfd6ad70e522cc11
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149772
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
when applying my upcoming patch to also consider O[U]StringBuffer
Change-Id: I8cf6a47ad357ddc73e2c430d966be72d5efd1485
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149767
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
* Update helpcontent2 from branch 'master'
to 6a882aaf39f3c8f80c40f460565c51e5265b2b58
- related tdf#152011 Typo in Insert description
Change-Id: I20fb5670621cb2a496fdf099d7f7c5599330fe5f
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149703
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
For German UI and locale
German layout keyboard (based from https://en.wikipedia.org/wiki/German_keyboard_layout)
https://www.traens.com/tipps/microsoft/datum-uhrzeit-excel.html
indicates:
"
Einfügen eines statischen Datums in Excel
Drücken Sie STRG + . (Strg und Punkt)
Einfügen der aktuellen Uhrzeit in eine Excel Tabelle
Drücken Sie STRG+UMSCHALT+. (Strg, Umschalt, Punkt)
"
so I added (specifically for "de"):
POINT_MOD1 for InsertCurrentDate
COLON_SHIFT_MOD1 for InsertCurrentTime
Change-Id: I2523dddf918f9680f87c82c174e20462620948ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148931
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I608efc6cf7ae05df5a0db3282e0a55315e286718
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149759
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I5cd697d0cfaf65a9ad581d4d7571a69e6214cbb1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149757
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
when applying my upcoming patch to also consider O[U]StringBuffer
Change-Id: Id38d983e59386554c61e9bdcd9333554bbf4665c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149756
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
when applying my upcoming patch to also consider O[U]StringBuffer
Change-Id: I44ce7183e4b292269fac1e3d2217286bf5abe823
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149752
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
when applying my upcoming patch to also consider O[U]StringBuffer
Change-Id: I2445a69dc46314c73f54c190a0c498c0309be06b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149750
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
As discussed in the ticket, the commands "Freeze First Column" and "Freeze First Row" are duplicated in the Tabbed UI (under the View tab), since there's already a "Freeze Rows and Columns" command that already offers these 2 options.
So this patch removes the "Freeze First Column" and "Freeze First Row" entries and keep the "Freeze Rows and Columns" comand.
The label of the ".uno:FreezePanes" is also changed to "Freeze Panes" so that it doesn't occupy so much space in the tab. I set the ContextLabel to "Freeze Rows and Columns", so in the menu and context menus, the text shown remains "Freeze Rows and Columns".
Change-Id: I57e6b22b103c2316ca0722878491b719e93b9bb4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149650
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
when applying my upcoming patch to also consider O[U]StringBuffer
Change-Id: I8619fa3280338afdfe75bdbfda6cb118d396e1c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149749
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
when applying my upcoming patch to also consider O[U]StringBuffer
Change-Id: Ic95e72e1c857c6814d6e25b9820494cdfa535465
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149746
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
when applying my upcoming patch to also consider O[U]StringBuffer
Change-Id: I49549347c1c041cc9ce103aed1fe1cc3bc1a780f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149751
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I6c9eef0a2167f738cdab8171d082becfca401d25
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149740
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir@collabora.com>
|
|
Change-Id: Iaefad282d40c83f58758b41db9b14f6e95552354
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149742
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
when applying my upcoming patch to also consider O[U]StringBuffer
Change-Id: I72c2afa0b6bddfe00fe09f34eb1b1bf2177461d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149747
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I2eeb07780e3581eea29a9ad98b493de4e78a5d65
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149745
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
when applying my upcoming patch to also consider O[U]StringBuffer
Change-Id: Id8f229c3a5223dee8d2710caf15d4612594fc763
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149748
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ia9ae20b8c73ddd762424c99eedbaf145fed81935
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148142
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Since commit 22b50f1937de67e4ad9e692d6964aa5b8d33af7a (use libtiff for
tiff import, 2022-05-21), transparent TIFs are imported correctly.
As the result, reqif export started to output the transparent TIF
images as GIFs, because XOutFlags::UseGifIfSensible handles case of
transparency, and XOutFlags::UseNativeIfPossible didn't handle TIF.
Additionally, the resulting mediatype was reported incorrectly:
<reqif-xhtml:object data="[...].gif" type="image/tiff" ... >
1. Handle TIFs in XOutBitmap::WriteGraphic when XOutFlags::UseNativeIfPossible
is specified.
2. Return the corrected mediatype from XOutBitmap::WriteGraphic,
to inform the caller about the possible change.
3. Remove the XOutFlags::UseGifIfSensible flag when doing the
reqif export, to avoid the format change at all.
Change-Id: I99f7cfb8d12ef66d372700ec810bd8b269868ffd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149744
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I7c398c3dec044722e4552527de8553506cda54f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149730
Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
|
|
Execution time changes:
- from 1m27,535s to 0m55,724s
- from 5m40,926s to 4m46,884s
- from 1m54,886s to 1m31,400s
- from 3m30,592s to 2m20,833s
for me. Also add a simple script that lists what's remaining to be
converted.
Change-Id: I274f5a11a0f606964bdad5d5e5254b65b09fe497
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149739
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
It's updates, not insert. One has to dispatch .uno:UpdateFields to see
this in action, which does something if the document already has exiting
reference marks.
Change-Id: If5a06d2a81aa2439977c9fc51c3af1ee241f9eb7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149738
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I6b4d0a30c2a1a51694770ecd02eea3cf3677b5eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149732
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: Id941b353e8d9f0df2de3816d47e03ec564351701
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149731
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 1a24e9d015c2747c37533c9edec8a081318d6e96
- tdf#83283 link help page for Label Field Selection in Form design
Change-Id: Id9abe070e03956c283b2f1c33fdb7737b7584f6a
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149734
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I1ba60b690a0402d1a98f792c86ddd033e0c39ed0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149726
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I4979cf5dab8b35ba35a46808cef76dc3f81c59b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149725
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I1471309e200c8eec21844658b873f817565f9604
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149693
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|