summaryrefslogtreecommitdiff
path: root/sc/source
AgeCommit message (Collapse)AuthorFilesLines
11 min.sc: fix exporting of row / column items of a pivot tableTomaž Vajngerl2-69/+389
The current row and column items export implementation was quite naive, where it added jsut one level of items and not understood why t="grand" needs to be added. This fixes the implementation so it now gathers the row / column items correctly. There are many scenarios we need to take into account, like grant totals, subtotals, filters and sorts. Those are covered by tests using different pivot tables. If the row / column items are not correctly set, the pivot table in MSOffice is not shown correctly in the sheet until you actually refresh the pivot table, so the data refreshes. In recent MSOffice version it also marks the pivot table as corrupt and removes the pivot table from the document. With this fix it now accepts the pivot table and show it correctly. Change-Id: I1fbe05b4b5a2051ec9d527f5243c84c2e8818b72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194940 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2 hourstdf#165233 replace std::bind with lambda in sqldataprovider.cxxSimon Chenery1-3/+3
Also apply clang-format to changes, requested by git commit hook. Change-Id: I7a978eb51935eb621e8ea0dc7f4661eb452c7efa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194175 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
13 hoursdataprovider: Run the import directly on the main threadNeil Roberts4-11/+23
When Import is called with mbDeterministic set to true, all of the data providers would previously launch the import thread and then immediately join the thread thus tying the main thread to the import thread. This is equivalent to just doing the work directly on the main thread because in either case the main thread is blocked until the work is complete. However, normally when the main thread tries to acquire the solar mutex it will additionally process any pending yield requests from other threads. In this case this yield processing doesn’t happen because the import thread returns false for IsMainThread even though in practice it’s working as if it’s the main thread because the real main thread is waiting on it. This patch instead makes it just run the import code directly in the current thread when mbDeterministic is true instead of launching the other thread. This is probably slightly more efficient, but the main reason to do this is to fix UI tests that invoke this code. In that case UIObjectUnoObj::executeAction will call Scheduler::ProcessEventsToIdle after sending the click event but without this patch that function’s attempt to cause the main thread to yield will never return when using the SVP backend. That happens because that backend doesn’t release the solar mutex when waiting for the main thread to yield and the import thread doesn’t yield when trying to acquire the mutex because it isn’t the main thread. Instead deadlock occurs. Change-Id: I0c0cf4542f899118e5b6da8bb68b4d645e3fe40e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194916 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
3 daysloplugin:unusedmethodsNoel Grandin3-14/+0
Change-Id: I85e2ca6222e33c2a99bfd0ea614d5ad238a7e8de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194890 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
3 daysloplugin:unusedfieldsNoel Grandin2-2/+1
Change-Id: I42dd442dc599d6a590b0b7874f5cd76dc8c07017 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194888 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
3 daysloplugin:stringloopNoel Grandin9-44/+45
resurrect the plugin and run it over the codebase Change-Id: I443a75961124aabd1e62b3c4bc166d52e4621b52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194870 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
3 daystdf#169077 dataproviderdlg setID expects mxEditIDRegina Henschel1-1/+1
maID needs to contain the string from mxEditID. In content it needs to be the XPath to the desired table element in the imported source. You can see the use of this element in the already working unit test ScDataProvidersTest::testHTMLImport Change-Id: If4de7fa345205e5afc2d93a198d88b6788be3700 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194789 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
3 daysdrop some coverity markupCaolán McNamara6-6/+6
Change-Id: I3e233e5e41d7f207837b1723fdb429e66acf1ade Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194836 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
4 dayscid#1660275 Uncaught exceptionCaolán McNamara1-3/+9
Change-Id: Iae44fdb0ec62b851f5683af4fdaa37fca3d652b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194835 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
4 dayscid#1659836 Uncaught exceptionCaolán McNamara1-9/+15
and cid#1659954 Uncaught exception cid#1659957 Uncaught exception Change-Id: Ie92b14b3f102b2fd80b3c8d798080d7d6885094d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194834 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
4 dayscid#1659626 Uncaught exceptionCaolán McNamara2-1/+8
and cid#1660288 Uncaught exception Change-Id: I1b4521a45ea166bca7f2c60878bfa8bfdd1eadf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194833 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
4 dayscid#1399336 Uncaught exceptionCaolán McNamara2-3/+3
Change-Id: I52e1617821c8a253df75b7faf6df9e990fb7c18d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194832 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
4 dayscid#1399299 Uncaught exceptionCaolán McNamara1-3/+7
and cid#1660449 Uncaught exception Change-Id: Iecec1cde88aaacc4640ab9daa6784aaf2d7e2a4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194831 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
5 dayscid#1399153 Uncaught exceptionCaolán McNamara2-3/+3
Change-Id: I4c8e1f1225a41d8c8d1671d609b807cd16ec0ee0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194819 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
5 daysdrop some coverity markupCaolán McNamara3-3/+3
Change-Id: Iffb2542be9e973d67ea3fea5fc1e924e491f14e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194820 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
5 dayscid#1399234 Uncaught exceptionCaolán McNamara1-1/+6
and cid#1399216 Uncaught exception Change-Id: Id0e2d04359608e0e92a94f4882b74fd779aa030a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194818 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
5 daystdf#146619 Run IWYU again on include/svl/Gabor Kelemen2-0/+2
Change-Id: I5dc8757a6d06ab6917a9af733550295008fde5b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193914 Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com> Tested-by: Jenkins
5 daystdf#168120 sc: Drop now unused CellLineStyleValueSetMichael Weghorn2-223/+0
This is now unused after the last use was ported to using weld::TreeView instead in previous commit Change-Id: I05c1e5f8f3689af02b4337c65b4aaba481c67e86 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Fri Nov 28 14:12:04 2025 +0100 tdf#168120 sc: Switch to weld::TreeView in CellLineStyleControl Change-Id: I00ce95cfa9ca7dd9c9d3ea9edec586d63cfca42e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194777 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
5 daystdf#168120 sc: Switch to weld::TreeView in CellLineStyleControlMichael Weghorn2-56/+96
Similar to how commit 85dc059a3990b41f93be6e163c2c8d2138f9e0e9 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Nov 27 22:29:52 2025 +0100 tdf#136905 tdf#169710 Use TreeView in PageSizeControl did elswhere, also switch from using a (different) custom control to using a weld::TreeView in the dropdown to select from a list of border styles in the Calc sidebar. The logic for creating the images for the single border styles in CellLineStylePopup::CreateImage is based on the existing logic in CellLineStyleValueSet::UserDraw (which was used so far). Indexes change because weld::TreeView indexes are 0-based while the ValueSet ones are 1-based (and use 0 as a special value). It will also no longer apply when switching from using CellLineStyleValueSet to using a weld::TreeView in an upcoming commit, because CellLineStyleValueSet uses a 1-based index while weld::TreeView uses a 0-based one. This reduces custom widget logic and custom drawing and makes this more consistent with other widgets used elsewhere. This also addresses the issue of a font inconsistent with what gets used elsewhere being used previously, as mentioned in tdf#168120. To trigger the dropdown: * start Calc * select a cell * open the "Properties" deck in the sidebar * in the "Cell Appearance" section, click on the "Specify the borders of the selected cell" control and select "Outer Border" * click on the "Select the line style of your borders" control (second control from the top on the right hand side in the "Cell Appearance" section). CellLineStyleValueSet is now unused and will be dropped in an upcoming commit. Change-Id: I05c1e5f8f3689af02b4337c65b4aaba481c67e86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194776 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
5 dayssc: Drop redundant comments in CellLineStylePopup::SetLineStyleSelectMichael Weghorn1-11/+16
The comment just duplicates the index passed to CellLineStyleValueSet::SetSelItem in the if block. It will also no longer apply when switching from using CellLineStyleValueSet to using a weld::TreeView in an upcoming commit, because CellLineStyleValueSet uses a 1-based index while weld::TreeView uses a 0-based one. Change-Id: I1faaf4b35b32a005412e2b1cca894e349eaef5c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194775 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
5 dayssc: Use std::vector in CellLineStyleValueSetMichael Weghorn3-28/+26
... and CellLineStyleControl. In particular for CellLineStyleValueSet::SetUnit, passing a vector of strings is more obvious than passing a pointer to a string (as the pointer to the first element in the array). Change-Id: I2d521ee3472ef274d15e89a3f84f38060916d3c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194765 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
5 dayssc: Merge two loops into oneMichael Weghorn1-5/+1
Change-Id: If8ce0d0790571f207afe7f6c25529c55acffb663 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194764 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
5 dayssc: Merge CellLineStylePopup::Initialize into ctorMichael Weghorn2-10/+4
Change-Id: I2f0e8a96c3569cfe120b5ffa5d9fd97e4557b27d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194763 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
5 dayssc: Use local var instead of CellLineStyleControl::maStrMichael Weghorn2-14/+14
It's only used in CellLineStylePopup::Initialize, so no need to have it as a class member. Change-Id: Id3b0790ff6f9177e9b38a1ed3f9e974af89b9cd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194762 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
6 daysResolves: tdf#169351 abandon inputbar mouse down on error dialogCaolán McNamara3-22/+37
Change-Id: I5f5a282c6dd6a5bfbe264e3555d0d8c052221408 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194745 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
6 daysupdate to officeotron-0.8.4.jarNoel Grandin1-5/+2
This reveals a problem with our export of the "dateCompatibility" attribute. We actually only want to write that out when targeting Word 2007, otherwise we want to use the more normal "date1904" attribute. On top of the original commit, this cherry-pick needs to add a bunch of calls to skipValidation() because we have validation turned on for more stuff on master, and this new officeotron seems to generate a lot more errors. Change-Id: I972bc7298ecf5026a76d109535a91c0c2544d08a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194522 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Code-Style: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit efebbf0107c57a2c3c73251085b90d7e6c06d3b0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194705 Tested-by: Jenkins
6 daysfix typo: BLN -> BGNXisco Fauli1-1/+1
After commit 37d1cc071ba0cc7f9922c4409d0a014a722ebbce Author: Rene Engelhard <rene@rene-engelhard.de> Date: Sat Aug 9 19:05:15 2025 +0200 add EUR for Bulgaria/Lew Change-Id: I6679404cba0be0219bf7ede06297f9b1c990e8b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194760 Reviewed-by: Eike Rathke <lo@erack.de> Tested-by: Jenkins Reviewed-by: René Engelhard <rene@debian.org>
6 daysRelated: tdf#169351 pass an explicit handler for input handler error messageCaolán McNamara2-11/+23
default it to the current behaviour Change-Id: Ic99f8120326002c1d1476137cb49b3cee1ef928f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194744 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
6 daystdf#168850, tdf#167075, tdf#168850: Revert "ScViewData: pass ScDocShell by ref"Xisco Fauli121-1147/+1168
This reverts commit d8ab8992bd35aedfc1d2b0debebab0d623aa8d09 Unfortunately I had to revert the fix for tdf#167075 in ea940b7985921883f8f75009186cae24846b1bd4 "tdf#169554: Revert "tdf#167075: init doc shell before pasting as png/bmp (take 2)"" because of tdf#169554, which I can't reproduce, so reverting the original commit that introduced tdf#167075 It also fixes other similar issues reported in Bugzilla Change-Id: I88dfa08f2086b88cff168eff2df8b4faf4067439 Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194726 Tested-by: Jenkins
6 daysRevert "ScViewData: simplify constructors"Xisco Fauli4-10/+38
This reverts commit 52e3b2b040ac54c2a5661e3676b135170f028f50. Change-Id: I9ab9bc0e6ff909281370bb5d524375398b5a2c9c Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194725 Tested-by: Jenkins
6 daystdf#169554: Revert "tdf#167075: init doc shell before pasting as png/bmp ↵Xisco Fauli2-6/+9
(take 2)" This reverts commit 671564bce4541244ad3d67b5b98899321176231e. I can't reproduce the issue on Windows nor on Linux but two people confirmed that 671564bce4541244ad3d67b5b98899321176231e introduced the regression in the report Change-Id: Iaf5df6a30bf01db738c3b4eb0f9fee51cf0a957c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194724 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
7 daysDrop explicit template parameter where deducibleMike Kaganski7-13/+13
Namely, from SfxRequest::GetArg variant taking TypedWhichId. Change-Id: I60e0fcf6defdc78d29bc98afe24ac22014d4aee2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194672 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
7 daystdf#169541 DataProvider avoid corrupt backreferenceRegina Henschel2-5/+6
If a document has defined more than one calcext:data-mapping element, the import builds a vector DataResources in the ExternalDataMapper. Error was, that not the current last item in the vector was refreshed but always the first one. If more than one DataResource exist, those before the last one have a corrupted backreference to the data provider. I have not found where this happens. Therefore, I now create in each refresh a new one. That is the same as done in the first refresh. If someone finds where it becomes corrupt it could be fixed differently. However, since the error causes a crash, we should use this solution in the meantime. Change-Id: If489c8e599bf44333c4936c608392c22d0f02d14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194433 Tested-by: Jenkins Code-Style: Regina Henschel <rb.henschel@t-online.de> Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
7 daystdf#166724 sc: vml x:anchor provides end anchor: so ResizeWithCellsJustin Luth1-1/+4
<x:Anchor> 1, 80, 1, 104, 3, 41, 6, 18</x:Anchor> which means: -starting in column B offset by 80 pixels - row 2 offset by 104 pixels -ending in column D offset by 41 pixels - row 7 offset by 18 pixels. Since an ending cell position has been specified, that means that the size should be adjusted if the row or column size changes. make CppunitTest_sc_subsequent_export_test2 \ CPPUNIT_TEST_NAME=testTdf166724_cellAnchor Change-Id: I1d2ab3162e954a6bebdcb3d40e722b2b8f322f72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194657 Reviewed-by: Justin Luth <jluth@mail.com> Code-Style: Justin Luth <jluth@mail.com> Tested-by: Jenkins
7 daystdf#166724 sc: update cell anchored objects if recalc optimal heightJustin Luth1-0/+3
The row height has changed. That means that any cell-anchored things needs to move relative to the page. SetOptimalHeightOnly is also used in conjunction with SetDrawPageSize commit 1e305422e1a7b23895ef964e56b36bd65812b370 Author: Kohei Yoshida on Tue Oct 5 14:06:55 2010 -0400 Ported calc-perf-ods-import-row-heights.diff from ooo-build. Avoid re-calculating cell note positions on every single row height change during import. That makes file load take forever. That suggests this patch might have a rather negative impact on load times if the document has lots of anchored objects, although it is obviously critically necessary for cell-anchors. make CppunitTest_sc_subsequent_export_test2 \ CPPUNIT_TEST_NAME=testTdf166724_cellAnchor Change-Id: I42d9132e76f77828637ff6563a0ad4ee7b00624d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194370 Reviewed-by: Justin Luth <jluth@mail.com> Code-Style: Justin Luth <jluth@mail.com> Tested-by: Jenkins
7 daystdf#166724 sc oox: limit x:anchor offsets to inside of the cellJustin Luth1-1/+13
In the customer's test document, the anchor was defined like <x:Anchor> 1, 80, 1, 104, 3, 41, 6, 18</x:Anchor> which means: -starting in column B offset by 80 pixels - row 2 offset by 104 pixels -ending in column D offset by 41 pixels - row 7 offset by 18 pixels. But row 2 was only 10 pixels tall, so the effective offset had to be limited to 10 pixels. make CppunitTest_sc_subsequent_export_test2 \ CPPUNIT_TEST_NAME=testTdf166724_cellAnchor Change-Id: Id90a0839b20e340676f70b62336b24a593a4f491 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194218 Reviewed-by: Justin Luth <jluth@mail.com> Code-Style: Justin Luth <jluth@mail.com> Tested-by: Jenkins
7 daystdf#145614 Convert #define RANGEFIND_MAX to constexprSimon Chenery1-3/+2
Change-Id: I7c1063a6f17852c70c9d6557f90a04b626b321fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194080 Tested-by: Jenkins Code-Style: Hossein <hossein@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org>
8 days[API CHANGE] remove XPivotTableDataProviderNoel Grandin3-30/+31
in favor of a regular C++ interface class, since this is purely used internally to LO Change-Id: I84991efb1b0c8829e2175dc083b0f8627fcb1712 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194512 Code-Style: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
9 daystdf#166724 - Checkbox anchor wrongly importedJohann LORBER1-0/+51
Form Controls are not being "fully" imported as the MoveWithCell and SizeWithCell properties are not set internally in Calc. Contrary to their own documentation, Microsoft Excel seems to declare (in the VML file) those properties with no value when they are false, and does not declare them when they are true. Test xlsx documents generated with Excel 2007, 2010, 2013 and 365 have led me to this conclusion. Change-Id: I7ba64983ae8036df8d672d6c94b2ca54d740a064 Signed-off-by: Johann LORBER <jlorber@linagora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190166 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Code-Style: Justin Luth <jluth@mail.com>
9 dayssc: fix changing of borders and invalidation after changeTomaž Vajngerl1-4/+6
When changing the theme and the ThemeColorChanger was run it would not change the borders if only top, left and bottom border lines would be set and not the right border line. This would not work because the wrong variable to check if we introduced any change for the borders would be used (bChanged and not bLineChanged). This fixes the problem and adds a test for borders and this specific scenario. It also fixes invalidation after changing the theme colors. Change-Id: Ia0529f70cdd37d1007ec1171d3debbb0f8a58bb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194451 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Code-Style: Tomaž Vajngerl <quikee@gmail.com>
10 daysFix typoAndrea Gelmini1-1/+1
Change-Id: Ia0ee309a0d1797093bee0bdf8e58a9c8f711f898 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194401 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
10 daysDrop useless static_castMike Kaganski1-2/+1
The specific call to GetAttr already returned the properly-typed result; so assigning it to a more generic reference just to cast to the needed type immediately could be avoided. Change-Id: I35eafada0d2bed1eb1faffdc570e5ad2c4565da5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194406 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
10 daysScDocument::GetAttr doesn't return nullptrMike Kaganski48-250/+220
Change-Id: Iaf2da73a9e5a9c2a5a579a8124beda9bb2689fde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194400 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
11 daysremove some coverity markupCaolán McNamara1-1/+1
Change-Id: I67077fa775225e22ac0fc87bb0b56da11d5ec60a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194395 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
11 dayscid#1660226 silence Uncaught exceptionCaolán McNamara1-2/+2
and cid#1659881 Uncaught exception cid#1482285 Uncaught exception cid#1448465 Uncaught exception cid#1421098 Uncaught exception cid#1421084 Uncaught exception cid#1400542 Uncaught exception cid#1399276 Uncaught exception cid#1399221 Uncaught exception cid#1399212 Uncaught exception Change-Id: I448e698047a6d2db7b0ac7575a54473fc5e88cc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194394 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
11 daysResolves: tdf#169521 forward IM events like KeyEvents for inputbarCaolán McNamara1-79/+89
which should also fix tdf#155453 formatting lost when formula bar edited via IM Change-Id: Ifabc029808f54b123ca88f58b5d64e0afaf40392 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194368 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
11 dayswe can return early if !m_xEditViewCaolán McNamara1-82/+80
I believe, and remove the problem that bInputMode would be stuck as true in the Kit path if that was the case Change-Id: I62865f00b6ccbd28edaacad432346f588d4f082e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194369 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
11 daysScModule::get was already fetchedCaolán McNamara1-4/+3
Change-Id: I0e8855b45781ae018a3f126e4d1628936393f7b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194367 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
12 daystdf#150150 Revert "draw Note mark before text for correct ZOrder"Justin Luth1-4/+4
This reverts 5.0 commit 2d1abfff0156c17cdaabf27c01e92b5e3f0bbbf4. The comment marker is not nearly as obstructive as it was back in 5.0 days. Change-Id: Id5596be2ede154e5c9302a23853b5fcaf724c1c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194343 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
14 daystdf#157211: don't limit range to data range when opening DB name dialogMarkus Mohrhard1-4/+0
This behavior is not what the user expects and we don't need to init the mark block mode again. This is already taken care off by the GetDBData code. Change-Id: I58556642ae696e32065e76e68b9eaca082863dad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194182 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2025-12-04 07:31:30 +0000