summaryrefslogtreecommitdiff
path: root/sc/source
AgeCommit message (Collapse)AuthorFilesLines
8 hourstdf#137594 prevent converting unallocated columns.Mark Hung1-1/+2
Check col against GetAllocatedColumnsCount() instead of MaxCol(). This prevents allocating a new column just for converting an empty cell. Change-Id: I5c8dcfffc2661ab9c4fd9c2c53ed389e57351517 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
8 hoursuse tools::Long in scNoel185-3078/+3081
Change-Id: I8f37a8d1174ed816df971b8cee036d4e88d4a7fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
30 hourstdf#90104 XLSX export: fix commas in data validation listTibor Nagy2-1/+35
Comma was exported as list separator instead of decimal separator, messing up the data validation list by breaking integer and fractional parts of a number to two integer numbers, for example the 2-item list 1,5, 2,5 to the bad 4-item list 1, 5, 2, 5. Note: for testing with numbers, it needs to set decimal separator to comma in locale settings. Co-authored-by: Attila Szűcs (NISZ) Change-Id: I6133c402b47aab8ed9f02b412762404fc520badc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104240 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
3 daysFix typoAndrea Gelmini1-1/+1
Change-Id: Ib2f34d65f77073f1cc9494a1d9ed263b089bff6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104458 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
4 dayssc: use the fastparser API when possibleNoel1-21/+19
part of the process of making SvXMLImport fastparser-only Change-Id: Idf785f38b233e26c00d699302b7eab7e41fe817a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104413 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
4 daysweld InputBarCaolán McNamara8-534/+508
this also restores that DnD of a selection from the inputbar is pasted as plain text not rich text formatted with the happenstance formatting of the inputbar's EditEngine Change-Id: If4934f83c14357afec2e0a7e1d51c8a1aea1d292 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104037 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
4 daysfix some *printf which are using "%l" ie. long specifiersNoel1-3/+3
which are not portable between Linux and Windows because long is not portable. In preparation for converting long -> tools::Long Change-Id: I8bf1aa1570946ca887a6c83dd5f99c024d437336 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104374 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
6 daysRemoved duplicated includeAndrea Gelmini1-1/+0
Change-Id: I1c16d73731e76e0569b796c1e5cff17f91fffd95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104317 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
6 daysResolves: tdf#137248 Fix wrong condition breaking non-group interpretEike Rathke1-4/+4
Regression from commit 4f36f2ccab6286ec09480caea602c0fa19195736 CommitDate: Thu Sep 10 11:15:47 2020 +0200 detect if a cell still needs interpreting after Interpret() The bool return from ScFormulaCell::Interpret() does not indicate if it was succesful but whether a group interpret was done. As both calls here happen in a non-group context bailing out on that if false (no group interpret) is wrong. Instead, ask the cell if it still needs to be interpreted after having been interpreted. Change-Id: I40eeeef65e1da3d729cb3fef550620b1ea0a5741 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104261 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
6 daystdf#76047 XLSX import: fix links to external dataAttila Szűcs1-1/+3
in array formulas to avoid loss of cell content. Without using SetExternalLinks in applyArrayFormulas the IDs of the linked files were not replaced with file names. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I57c304a46899f4171db9ad12e7e187bd6e4c1c15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104049 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
7 daysstatic_cast after dynamic_castNoel11-90/+72
Change-Id: I53e10fbebfd07c471ddd9b264562317251700500 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104225 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
7 daysstatic_cast after dynamic_castNoel6-76/+73
Change-Id: If1194bd3364fef8b2d0c26c22854745d0fb7b412 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104223 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
7 daysSet correct color for chart background in sidebarSzymon Kłos1-0/+47
Change-Id: Id41fba75133e3473dcb834c72ff2ecfb317ecb79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103603 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104201 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
7 daysstatic_cast after dynamic_castNoel9-45/+40
Change-Id: I487b5dc148f5a3d0d45f198c00179002841242ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104213 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
8 daysOnline: Hide right clicked sheet.gokaysatir3-3/+25
On core side, if user clicks on a tab with right mouse button, clicked tab is selected. So, for core side, if this feature will be desired, some more modification will be needed. Change-Id: Ic4755b27b8ba98d3a6aa086b2e0a3566d095ba16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103685 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104078 Tested-by: Jenkins
9 daystdf#133886 - Libreoffice Calc Subtotals check all columns at onceTomofumi Yagi2-14/+52
"Select all columns" checkbox is added to the subtotal group page. Change-Id: Iee5be3218ecb6d74c7c65b2bf49febf0703ebf35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104135 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
10 daystdf#126305 XLSX export: fix data validation Error AlertTibor Nagy1-1/+12
Excel supports three kinds of error messages: stop, warning and information, but LO only one of error message(stop) was exported. Co-authored-by: Attila Szűcs (NISZ) Change-Id: Iecf790c104bee39ee29629a13fe4af4d8b29d311 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104021 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
10 dayswe throw away the original of the cloneCaolán McNamara2-4/+2
so we can take ownership of the original instead Change-Id: I2399aa77b22e606008a5aed2bc73361e13b68455 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104174 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
10 dayscid#1467975 Logically dead codeCaolán McNamara1-1/+1
Change-Id: I6d226c696fd6100c61f7233d42d17f1858fe66d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104169 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
10 dayscid#1467974 Dereference before null checkCaolán McNamara1-1/+1
Change-Id: Ic612cb420934764c42cca08d09915bdc8332cb2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104171 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
10 daysResolves: tdf#137370 Re-enable UI translated standard cell style namesEike Rathke2-11/+41
Regression from style rework commit 7b0aed617f1e57335837cf56ef2d222a96f8270d CommitDate: Wed Sep 28 11:42:56 2016 +0000 Remove old cell styles from calc to commit 06f319937187f76ee402d53b3baa78c391c2af19 CommitDate: Sun Oct 2 13:51:26 2016 +0000 tdf#90937 Add a set of cell styles to calc Change-Id: I34dddb3ca3e54e3da5db112e1f9bcc8437fbda77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104141 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
11 daysAdded optional parameter Enabled for uno:SpellOnlineMert Tumer1-1/+3
Change-Id: I3578b0a002ea2cdcc7893972607f26732ce545ea Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103982 Tested-by: Jenkins
11 daysEditView->GetWindow()->GetClipboard() is the same as GetSystemClipboard()Caolán McNamara1-2/+1
so we don't really need the intermediate vcl::Window to get that Change-Id: I5fa449e46c2226f0fb84f2e230e328c4da5472ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104125 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
11 daysEditView may not have a WindowCaolán McNamara1-7/+8
Change-Id: I0b1a87bab8fbabd24962efd6d42e12a2c922de54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104124 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
11 daysClean-up: Initialized a variable to something.Attila Szűcs1-1/+1
To make sure it will have a legal value, even in cases when it won't be used. Without it, code analysing tools may idetify it as an issue. Change-Id: Ied6e6c8ca496aa9d61eeca0c45b2c6cec40c9156 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104091 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
11 daystdf#137205 sc: autofill date sequences in merged cellsAttila Szűcs1-31/+111
Improve FillAnalyse to discover and continue linear sequences of dates with the only differences of months or years in merged cells by skipping the empty overlapped cells of the merged area. Follow-up of commit Ib431e8968f5d71e321b0e57cfb173534a0f5da31 (tdf#88782 sc: autofill number sequences in merged cells) Co-authored-by: Tibor Nagy (NISZ) Change-Id: I1e37efd34858f53691bf867ebefc2fe26e39e676 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103967 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
12 daysuse sal_Int32 for style-sheet indexNoel Grandin2-3/+3
instead of a mix of unsigned and sal_uInt16. Change-Id: Ice56d58d22856daa6645577610368ba19a849176 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104076 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
12 daystdf#125462 sc: remove red (invalid data) circleTibor Nagy2-0/+65
around the cell after typing valid data in it. This mark wasn't removed when correct data is entered in the cell, giving the impression that the entered value is incorrect. Note: This fixes only the directly modified cell, not the other cells with red circles which refer the modified cell. Testing: Tools->Detective->Mark Invalid Data adds these red circles around the cells with invalid content, according to their validation added by Data->Validity... Co-authored-by: Attila Szűcs (NISZ) Change-Id: Ib7ca3c453a930669a7c58e89b91654de36b8bb3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103995 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
13 daysResolves: tdf#137315 explicitly use FloatWinPopupFlags::NoMouseUpCloseCaolán McNamara1-1/+1
so the popup won't disappear on releasing the mouse Change-Id: Ib496ad286c06305eca67f865946a8303e93118f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
14 daysOnline: Copy hyperlink location. / Core side.gokaysatir1-1/+8
Payload format is added to LOK_CALLBACK_CLIPBOARD_CHANGED. Clipboard changed event is not fired when "copy hyperlink location" command is issued. So i added a call to LOK_CALLBACK_CLIPBOARD_CHANGED inside TextDataObject::CopyStringTo function. Change-Id: I8157572288da88b5522662e13abe151ef8548b34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103164 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103872 Tested-by: Jenkins
14 daysloplugin:const* make some params and methods constNoel23-54/+54
Change-Id: If621bb2585fda4afef4be9a189c7f4c00008d358 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104029 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
14 daysmove set_user_managed_scrolling to an initial weld argumentCaolán McNamara5-10/+5
gtk is creating a11y objects on widgets changing parents so manage when that can happen to avoid premature creation of custom widget a11y objects Change-Id: I4879a93a897b2e4084cf6af0c9c0b0f0c1062254 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104025 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-06reparent to nothing to break gtk ownership cycleCaolán McNamara2-1/+9
which is our usual solution, instead of using less common flag Change-Id: I9dd54a161df53a5b6ffb0b7655e510a6cc4c4824 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104018 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-06pRuntimeWindow is always a ScInputBarGroupCaolán McNamara2-4/+4
so the dynamic cast isn't needed Change-Id: I38d55ba782425383969a3da06df81c51a146a338 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104005 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-05Related tdf#137167: reference Excel pb on limitation for data validity formulaJulien Nabet1-0/+2
Change-Id: I6910b761dc99c7a58c7fc1f84c4606ad8dbd729c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103913 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-05tdf#88782 sc: autofill number sequences in merged cellsAttila Szűcs3-13/+167
Improve FillAuto, FillAnalyse and FillSeries to continue linear sequences of numbers in merged cells by skipping the empty overlapped cells of the merged area, like other spreadsheets do. For example this fix autofill, when merged cells are used to highlight nth numbers. Instead of 1, 2 -> 1, 2, 2, 3, we get 1, 2 -> 1, 2, 3, 4 on the following fill: +-+-+-+ +-+-+-+-+-+-+ |1| 2 | -> |1| 2 |3| 4 | +-+-+-+ +-+-+-+-+-+-+ See the unit test document for more complex examples, and use merge/unmerge to check the work of the algorithm. For example, column C of the test document contains cells EMPTY, EMPTY, EMPTY, 2, EMPTY, 4, EMPTY calculated as 2, 4 during fill by skipping empty overlapped cells, but keeping also the merged structure, resulting the requested continuation of the linear sequence: EMPTY, EMPTY, EMPTY, 6, EMPTY, 8, EMPTY Note: special formats are not handled yet like date, string, boolean and userlist. Co-authored-by: Tibor Nagy (NISZ) Change-Id: Ib431e8968f5d71e321b0e57cfb173534a0f5da31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103765 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-04sc: ucsdet_detect may return nullptrTomofumi Yagi1-19/+22
ucsdet_detect function needs a NULL checking of the return value. "a UCharsetMatch representing the best matching charset, or NULL if no charset matches the byte data." Change-Id: I7e9a4b03ffd3c5e3f4953c2c7964dc67a53c39b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103890 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-30loplugin:unusedmethodsNoel2-6/+0
Change-Id: I4f5262af08bb35540e6330775a91df42e4c9977e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103684 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-30loplugin:reducevarscope in scNoel47-113/+83
Change-Id: If88c71351fb157b8eab242fceb65422f05eec3d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103645 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-30tdf#43958 sc: fix fill by selecting merged cellAttila Szűcs1-1/+20
wholly instead of only its top left corner, if there is no marked selection present. This fixes the selection rectangle during dragging by fill handle of selected merged cells, copying their attributes in other cells of the target area, too, fixing losing merged cell structure, e.g. incomplete grid and other problems. Follow-up of commit 1ed04c2029218619aab2f3422130c890f67f309c (tdf#40993 tdf#59585 sc fill: copy merged cell structure). Note: the selection is a bit different, if there is filtered (hidden) rows in the current cell area. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I387feef640b7a89ab601c24e3641075934d3fc54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103001 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-30tdf#40993 tdf#59585 sc fill: copy merged cell structureAttila Szűcs2-8/+55
like other spreadsheets do. This avoids losing and recreation of merged cell structure again and again after modifying cell content using fill. By dragging the fill handle, cell attributes ATTR_MERGE and ATTR_MERGE_FLAG are copied, too, resulting the same merged cell structure in the selection. See TODOs about the remaining tasks. Co-authored-by: Tibor Nagy (NISZ) Change-Id: Icd4287d4429d3ba27a2ffb062560856d7ad86099 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102394 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-09-30Clean-up of commit: I95d394c5432d22805a761b76219f656fad3feae1Attila Szűcs1-3/+3
Renamed a wrongly named variable, reported here: https://gerrit.libreoffice.org/c/core/+/102173/4/sc/source/core/data/documen3.cxx#1140 Change-Id: I42ef65df78c5ad04e2c2875cf47d241a280892e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103605 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-09-29Determine CharClass difference once, tdf#137091 follow-upEike Rathke1-1/+15
As a side note: Clang plugin simplifybool for !(rLT1.getLanguage() == "en" && rLT2.getLanguage() == "en") told "error: logical negation of logical op containing negation, can be simplified" which is nonsense (the message stayed the same while the checks evolved). It actually complained about !(a==b && c==d) to be rewritten as (a!=b || c!=d) whether that makes sense or not.. it may save one boolean operation, yes, but.. Change-Id: Ib478d46d7ff926c1c9f65fec059c7a3f31fa7ce3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103601 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-09-29Current sytem locale's CharClass for user defined names, tdf#137091 follow-upEike Rathke1-2/+8
Change-Id: I5f025a12ca183acb3f80d2a7527677aceb9ffbd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103593 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-09-29Resolves: tdf#137091 Use CharClass matching the formula languageEike Rathke1-21/+41
... not the current locale. Specifically important for uppercase/lowercase conversions that may yield different results for example in Turkish i with/without dot. Change-Id: I2aa57cdcf530d7a0697c4ffbd5dccb86bb526d8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103588 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-09-28export HYPERLINK target in html clipboard exportCaolán McNamara1-0/+23
Change-Id: Ia77e4bd8a5b54636d0e9e561360128202a81420b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103557 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-09-27never null ScViewData*Caolán McNamara26-206/+206
Change-Id: If5ad4c637a8c4db67ca4bfe99612e90ae6237ff6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103513 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-27never null ScViewData*Caolán McNamara13-112/+96
and so remove some never called code Change-Id: Ia5a6501f9a5214a4069623832508a6f884cfa6ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103494 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-27Resolves: tdf#67007 display sheet-local range name in Name Box for selectionEike Rathke1-0/+14
Change-Id: Ia9980b13ed5c93cc72231ead532e3916e6234f56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103509 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-09-26never null ScViewData*Caolán McNamara33-79/+79
Change-Id: Ie2c870ef1291b951a68ed4bb9344238d81c23762 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103472 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>