summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
11 hoursIWYU: drop some exceptions related to rtl::math and std::Gabor Kelemen1-8/+0
at least recent 0.24 no longer warns about these Change-Id: I1f7c4069df7d47bcd720298c93d71fd6c7bbed9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191002 Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins
33 hourstdf#165846 - Ensure degrees of freedom (nu value) is greater than 0Andreas Heinisch2-0/+35
Change-Id: I900d0b5436bc9417e4f91eac1434c8ae79bd70a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190988 Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Tested-by: Jenkins
39 hourssimplify EmbeddedObjectContainer::CreateEmbeddedObjectNoel Grandin1-1/+1
dont need the variant that passes extra params, we already take that param but convert that extra parameter from a pointer to a std::optional, because some of the call sites pass a temporary OUString, and taking the address of a temporary is a no-no. Change-Id: I4d55f01a14230f5c64a052a143666a08bfcbf704 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191021 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
45 hourscid#1665432 Variable copied when it could be movedCaolán McNamara1-2/+2
Change-Id: I1515f7254d6880eea0220bd79d06b708da0fc663 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190995 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
3 daystdf#167689: sc: export x15 namespace for xl/connections.xmlBayram Çiçek6-13/+110
- add support for x15 namespace. - add a unittest. - add support for <x15:connection> and <x15:rangePr> elements. - support model and sourceName attributes. <extLst> <ext xmlns:x15="..." > <x15:connection id="..." model="..."> <x15:rangePr sourceName="..."/> </x15:connection> </ext> </extLst> Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com> Change-Id: I3b3e380ddd07f251b23333fe9d3959961dd5c19c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190924 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
3 daystdf#167689: sc: don't export tableType if it does not existBayram Çiçek5-10/+44
- and if there is no tableType, there should not be any uniqueName attribute in <tableColumn> - add a unittest Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com> Change-Id: I425e9204a31646bd3d6f3986244d906ab4fea1a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190439 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
3 daysFix typoAndrea Gelmini1-1/+1
Change-Id: I0c33d34835c4678cbb8d2b4f37a06cab37322a73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190933 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
5 dayssc: change constructors for static methods in ScEditableTesterTomaž Vajngerl15-113/+112
All the different constructors make ScEditableTester hard to use as it is hard to determine what each constructor will trigger, so instead use properly named static methods to create the object, to make it easier to understand what was used. Change-Id: Ieaa20c4f0fd134bd65ffb4a4353c60ea9e0fc874 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190202 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
5 dayssc: make sheet view have different header colorsTomaž Vajngerl1-2/+5
So we can see when the sheet is using a sheet view. This also mimics the UI of MSO when a sheet view is used. The color was chosen arbitrarily. This has no effect in online os it's mostly for debugging purpuse only. Change-Id: Idb0a7c499ec4d87ea83ac5998d5ee7e17bd724d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189915 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
5 dayssc: move part of sheet view creation into ScDocumentTomaž Vajngerl4-25/+33
Instead of setting up in ScViewFunc, just create everything needed for adding a sheet view inside ScDocument::CreateNewSheetView. This will limit the functions we need to expose to the outside of ScDocument. Change-Id: Ie8c432b175e7bbb55fc5ae3c6fe3a2b822e6d619 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189914 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
5 dayssc: move SheetViewManager into own header file, describe methods.Tomaž Vajngerl8-27/+56
No other functional change was made, just simplification. Change-Id: I9d34f1525470f6517b315be48f519f6a6e1b62f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189857 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
5 dayssc: test ".uno:RemoveSheetView" to remove current sheet viewTomaž Vajngerl3-5/+86
Also fix issues found with the test. We need to broadcast that the table was inserted or it won't properly be accounted for ViewData, which will cause an assert to fail. Change-Id: I0c086e16090d40e8a663217b36d04d4de99966cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189386 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
5 dayssc: fix scrolling in sheet view, add check if a tab no. is validTomaž Vajngerl2-12/+21
Scrolling needs to use the tab number of the actual sheet we are currently using in the UI. The same goes for the grid. Added a function to check if a tab number is currently valid, to reduce duplication and to make the code a bit more readable. Change-Id: I4e76a61efaa3632b020cfd75ea77c0809f08f6da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190598 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
5 dayssc: make sure we are not using the sheet view tab directlyTomaž Vajngerl3-5/+18
Modified testSheetViewAutoFilter exposed an issue when we change the tab to the sheet view tab, which we shouldn't change directly. This fixes the issue by fixing the GetSimpleArea to return the correct tab when constructing a ScRange object. Change-Id: I677d25383cddd12037d12ab747fb4d3eff45e2b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189385 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
5 dayssc: add a way to switch to the next sheet (or default) viewTomaž Vajngerl10-1/+87
This addresses the need to switch to a different sheet view if there are multiple available and to switch the current view to the default view. Change-Id: I34c0c461793b6b824c4518716ba85906facb944d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188468 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
5 dayssc: add a way to remove the current sheet viewTomaž Vajngerl15-13/+89
If we are currently in a sheet view, this command will remove the sheet view (including the ScTable representing the sheet view), and return to the default view. Also add state code to not allow adding or removing a sheet view when read-only and disable remove command when in default view. Change-Id: I1b44db9faa717d53631b1e0571d4dba1e9856a5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188467 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
5 daysuitest: use different names for header and footer elementsXisco Fauli2-4/+4
Change-Id: Ie0aced391136a1417b50f05e4b609ce682ae7afc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190893 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
6 daysofz#444495246 avoid timeout when fuzzingCaolán McNamara1-7/+17
Change-Id: I2c1df68551300fa4b32cf20346b01d86bdcb85c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190866 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
6 daystdf#145538 Use range based for loopstoadkarter1-2/+2
Adds range based for loops to sc and sd modules where appropriate. Change-Id: I5261466ac2de0397dcb506818d92775d63734a40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190776 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
6 daysCall UpdateInputHandler after handling AcceptFormula uno command.Gökay Şatır1-0/+3
Issue: On Online side, setting focus on the calc input bar doesn't allow to continue typing. Steps: 1. open calc 2. start typing into cell 3. click "accept formula" button 4. click again at formulabar 5. try to type UpdateInputHandler finalizes the text editing and send notification back to the client. Also a test is added to ensure that formula bar gets "setText" event after sending "AcceptFormula" uno command. Signed-off-by: Gökay Şatır <gokaysatir@gmail.com> Change-Id: I8e3a64753deeb908f7727b0473596f6f3c07ff4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187959 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190803 Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> Tested-by: Jenkins
6 daysCalc LOK: Needs to send the pivot table filter position to Online side.Gökay Şatır3-0/+41
Issue: JSDialogs are not sending the position of the popup windows. To precisely position the popup window on the Online side, we need to have the column and row number of the filter button. This improvement sends the column and row indexes. Also a test added. Signed-off-by: Gökay Şatır <gokaysatir@gmail.com> Change-Id: Ib1a47dac3081baf1e241826ff522973f2c01ac0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189674 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190802 Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> Tested-by: Jenkins
6 daysofz#442383407 Integer-overflowCaolán McNamara1-2/+7
Change-Id: I96c62fd03a6c7b4c5e1ddaa62df4bb577fbdb8ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190812 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
7 dayscid#1660311 silence Division or modulo by float zeroCaolán McNamara1-0/+1
and cid#1660494 Division or modulo by float zero Change-Id: Ib3b27ab2ea527bea62e70910dffc0892be0b1532 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190792 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
7 daysOnline Calc: TextBox shape resizing test.Gökay Şatır2-0/+28
Add a unit test for the feature. This unit test doesn't pass without the previous revert. Signed-off-by: Gökay Şatır <gokaysatir@gmail.com> Change-Id: I30abe745f2a28a50bb59e2393c7c60119e3b3533 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186604 Reviewed-by: Balazs Varga <balazs.varga@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190801 Tested-by: Jenkins
7 daysCalc LOK: Needs to send the autofilter position to Online side.Gökay Şatır4-0/+39
Issue: JSDialogs are not sending the position of the popup windows. To precisely position the popup window on the Online side, we need to have the column and row number of the autofilter button. This improvement sends the column and row indexes. Also a test added. Signed-off-by: Gökay Şatır <gokaysatir@gmail.com> Change-Id: I8afaf81595be4e666375699b1efc4efd9b138a17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187634 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190800 Tested-by: Jenkins
7 daysOnline: This reverts fix for FormulaBar focus.Gökay Şatır1-2/+0
Reverted commit: 6c1e3cd597cba07ff637173ab298794dba463054 The reverted commit fixes issue: 1. open calc 2. start typing into cell 3. click "accept formula" button 4. click again at formulabar 5. try to type result: no text is shown. After reverting the commit, the issue that the reverted commit targets is still not reproducible. The reason for the revert: * Select a word in formula bar. * Switch to / from bold text. * Click on another word on formulabar, without leaving the formulabar. * The switch from bold text gets cancelled. This commit also adds a test for the formula bar property reset issue. Signed-off-by: Gökay Şatır <gokaysatir@gmail.com> Change-Id: Ia219255ea4725276847490326a3ce55b4c8b714a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187898 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190799 Tested-by: Jenkins
7 daysloplugin:unusedmethodsNoel Grandin4-13/+0
Change-Id: Iffab96d7383925d706bfb92495c6340698d8aa62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190793 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
7 daystdf#168175 Use sort parameter language in natural sortRegina Henschel2-13/+88
Now the natural sort uses the language given in the sort parameter. Only if it does not contain a language, then the global locale is used. The language determines, which character is used as decimal separator. This corresponds to ODF where both the locale info and whether to use natural sort belong to the database range attributes. Change-Id: I52629bdff7f6a93974770d2922e80ac95df21a5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190622 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
8 dayssc: sync a change to the sheet view and the main sheetTomaž Vajngerl8-72/+246
Change-Id: I58486928c4655da9385e58210cd707250946b16d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188192 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
8 daystdf#137833 Always respect EXIF Orientation tag when importing a JPEGAndras Timar1-12/+0
Previously EXIF Orientation tag was read only via the Insert -> Image route. Now it is respected even via File -> Open or drag&drop. Change-Id: I16a79940823f4a62e8df5fa5d7c2e28a755e3460 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190717 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190733 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Jenkins
8 daystdf#166121 supress row height calc during "Remove Duplicate"Noel Grandin1-1/+4
shaves 50% off time required Change-Id: I479015afd5dc5dcf8d14bf4cb17ed931ddbc56fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190725 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
9 daysHide hyperlink dialog fields based on selectionMaya Stephens4-0/+5
Hides the name field in all cases except writer text or draw text, as these seem to be the only types of text that can store link names. Hides text field for non-text links, such as shapes or images. If a shell does not set the properties m_showText or m_showName, deafult values to true, to avoid regressions for unimplemented shells. Change-Id: I228dc7f9d65c5cb17717afb79feb515376cd4d31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189885 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Stahl <michael.stahl@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190678 Tested-by: Jenkins
12 dayscid#1665261 Argument cannot be negativeCaolán McNamara1-1/+3
and approx 24 other similar cases Change-Id: I6bd05c61f6d1b7fcd983947ec4fa677f1c9ad2f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190634 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
12 daystdf#100287 svx dialog: sync "first header" with "first footer"Justin Luth1-3/+3
When either the header OR the footer wants different first content, then (by design) the application applies it to both of them. (True for Writer only - not true for Calc!!!) It is also important (for the user experience) that either one is able to stop using first content altogether (for Writer only). This was already working to some extent, but the user experience was not consistent or predictable. Specifically, the improvements with this patch: -provide an appropriate "default" value when turning on a H/F. -always visually match the most recent "first content" choice. -in Calc, simply visiting the H/F no longer turns on first page. The prior situation was very "fickle", and "first content" could be affected without the user even touching that box (for both Writer and Calc). The underlying reason this patch can work is because of SvxHFPage::SvxHFPage SetExchangeSupport(). That causes SfxTabDialogController::DeactivatePage to update the m_xExampleSet which is then passed to SvxHFPage::ActivatePage. Thus the active tab knows about all the dialog's current settings. Since Reset() calls ActivatePage, it was safe to move the initialization out of Reset. make -srj1 UITest_calc_tests8 \ UITEST_TEST_NAME=tdf144940.tdf144940.test_tdf144940 \ SAL_USE_VCLPLUGIN=gen Change-Id: Icd6084ca50d244317c807266f04c85dadbba2bb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190606 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
12 daysremove BitmapExNoel Grandin4-4/+1
all use-sites have been converted to Bitmap Change-Id: I1a8842217a266eef100bd387ab013b004e532256 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190618 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
13 daysskip this test on non-default-dpi machinesNoel Grandin1-0/+4
Change-Id: I7d4a6243b4ee8e62d99c21595055a7802f835c5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190613 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
13 daysBitmapEx->Bitmap in various commentsNoel Grandin1-1/+1
leftovers from earlier conversions Change-Id: Ia6df2a70eb1eed25dbdcc45654a6466177f0ddfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190610 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
14 daysloplugin:unusedmethodsNoel Grandin1-1/+0
Change-Id: I89922f71f6bc7120410a8710e51240dd548f0fd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190578 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
14 daysfix build - rename AutoFilter.odsTomaž Vajngerl2-1/+1
Change-Id: I765b3f7af3c464edbd33201cbced33f74fed9645 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190575 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
14 daystdf#108911 Toggle input modes in Cell Edit handler, not input handlerNeil Roberts3-9/+24
The F2 key by default maps to “Cell Edit” which sets the input mode to SC_INPUT_TABLE to start editing the cell. If you press F2 again, the key event handling code in the input handler had a hardcoded handler for F2 which switched to SC_INPUT_TYPE mode when the mode is already TABLE. This meant that you could press F2 to toggle between the two modes. This is useful if you are editing an equation because sometimes you want the cursor keys to move the text input cursor and sometimes you want it to move the cell cursor to help type a cell reference. This feature relies on the fact that the input handler code gets to see the key event before the accelerator handler code. With the GTK backend this works fine but on MacOS the accelerator code ends up eating the key event before the input handler gets to see it. This meant that pressing F2 always set TABLE mode instead of toggling. There’s also the slight weirdness on all platforms that if you reassign “Cell Edit” to a different shortcut key then it no longer works like a toggle and instead you always have to press F2 to get to TYPE mode once you’re in TABLE mode. It also means that if you tried to reassign F2 to a different command then it wouldn’t work if you are editing a cell. This patch changes the behaviour so that the toggling is done directly in the handler for the “Cell Edit” command. The hardcoded handler for F2 in the input handler is removed. That means that the toggling will work regardless of what key the command is assigned to and the input handler doesn’t need to see the key before the accelerator key handler. Change-Id: I79aa6fa515f7a720335f3535146c95eae874ea0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190557 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
14 daystdf#158803 Remove unused imports from /sc/qaBogdan Buzea5-5/+3
Change-Id: Ie883a000a44a76cc4931db5f1f898f8fe027cbac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190302 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-09-03Fix typoAndrea Gelmini1-1/+1
Change-Id: I5e54ae307e1fc23681dd7d15cb23a091469ed63d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190559 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>
2025-09-03tdf#167941 - Chart style file is not supported in OOXMLKurt Nordback2-4/+6
Parse the style*.xml file in the OOXML package, and store the imported styles in XChartDocument via a new XChartStyle. Some areas are yet to be fleshed out, but the intent here is to get a review of the general approach and architecture. This includes no work on the export side (or the UI and application of styles to a chart, which is a separate but related project). Change-Id: I9d5b9f5aa44fb7944b2d971edc26e04dc2256c7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189531 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-09-03sc: rename GetTabNo and GetTab to better namesTomaž Vajngerl104-668/+684
GetTabNo to CurrentTabForData to make it clear what it's usage should be and that it is not just a simple getter for a tab, but has logic behind it. GetTab was also renamed to GetTabNumber - it's a direct accessor for the current view's tab number. Document both methods. Change-Id: Ic855be43b2d38e421e0f9472d182baa20bb37feb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190201 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2025-09-03sc: add tests for sheet view - check auto filter sortingTomaž Vajngerl7-0/+179
Check sorting the auto-filter in a sheet view doesn't influence the sorting in the other views. Change-Id: Id7b4be75b2071709b67c7cb27ed7b4303029efcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188148 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-09-03sc: initial commit of "sheet view" functionalityTomaž Vajngerl20-12/+300
The idea of a sheet view is that we can change the auto filter's fitlering and sorting in the current view without influencing the filter in other views. This is realised with a copy of a current sheet, which is shown in the current view instead of the default sheet (which still can be seen by other views). Very important aspect is to keep the tables in sync. There can be multiple sheet views and in the current view we can switch between the default view and other sheet views freely. This change adds a command to create a new sheet view. When the command is triggered, it then creates a copy of the current sheet and registers a new sheet view for that sheet/table. The current view automatically uses the copy of the sheet for all changes, but if the sheet is changed, nothing is synched yet. Change-Id: Ia77c5ab759113eaae237c638015401418ab56033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187741 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2025-09-03Fix typoAndrea Gelmini1-1/+1
Change-Id: If520ec4a88d129c5fb9ba9d73e82e9665d77f30d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190137 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>
2025-09-02tdf161948 read & write ODF 'embedded-number-behavior'Regina Henschel6-7/+99
ODF has the attribute table:embedded-number-behavior to specify a natural sort (19.628 part3 ODF 1.4). Its values are 'alpha-numeric', 'double' and 'integer'. LO has the attribute bool bNaturalSort in struct ScSortParam. The ODF method 'integer' is not implemented in LO. The patch maps the internal bNaturalSort=true attribute to ODF value 'double'. Until value 'integer' is implemented, it is mapped to value bNaturalSort=true on import, as that makes at least a natural sort. This is next step after commit 47eb7f4e4dd0ed72679246b462686e153a1c07d0 Change-Id: Ie8c66e6b2eb2bdf035f0b02ada6ef91b1d921fe7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190437 Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Tested-by: Jenkins
2025-09-02tdf#168159 CRASH: deleting columns and undoingNoel Grandin2-7/+4
revert commit 68db5b64b8db405f9e6c0368836a8ee671b46830 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Sat Jun 28 16:13:53 2025 +0200 crashtesting ooo120243-1.ods and commit c8742f36fa2bdc9d23042378f5b587ccda8b54dd Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu May 22 10:18:48 2025 +0200 tdf#166684 reduce cost of CellAttributeHelper::registerAndCheck Change-Id: I4d4442c6927121e7f18e3e08eb1736fa94a896bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190521 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-09-02sc: Resave deletecontents.ui with glade 3.40Michael Weghorn1-79/+76
This dialog can be triggered in Calc using "Sheet" -> "Clear Cells". Change-Id: Ie0ae34a87e1b4933dfb26eecbdf4c1e627873d77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190492 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>