summaryrefslogtreecommitdiff
path: root/sc/source/ui
AgeCommit message (Collapse)AuthorFilesLines
21 hoursreduce symbol visibility in scNoel Grandin3-12/+12
Change-Id: I7a1c7dbe61e302584b977fdf202d041d987d0833 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166777 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
4 days[API CHANGE] a11y: Use XAccessible for relation targetsMichael Weghorn3-6/+6
Use a Sequence of XAccessible rather than its base interface XInterface for AccessibleRelation's TargetSet. As the targets are accessible objects as well, anything other than XAccessible doesn't make much sense. Using XAccessible right away makes that clearer and avoids the need to query the XAccessible interface. (The winaccessibility bridge was already using `static_cast`, relying on the fact that the objects are XAccessibles.) The a11y UNO API is not published, so an API change should be unproblematic. Change-Id: I7f08e98d1ec303d5343d9a7954187cdd71495ebc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166586 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
4 dayscool#8789 sc lok: classify multi-selection with 2 cells as simpleMiklos Vajna1-1/+1
The trouble was that even if commit b13c7b31f9ce3c3a25cffd0c35e7ee6b8c2a1895 (cool#8789 sc lok: fix copy for multi-selections, 2024-04-19) made multi-selection copy work, just 2 cells in a multi-selection was classified as a complex selection at a LOK level, while 2 cells next to each other is a simple selection, which is inconsistent. (A LOK client can provide a simpler UI for simple selections.) What happens is that the multi-selection clipboard document had no selection ranges defined, so ScDocument::GetClipArea() returned early, so the numbers in the ScTransferObj ctor were left initialized, which at the end lead to a >1000 cells in ScTransferObj::isComplex(), because we were calculating uninitialized data. Fix the problem by passing a range (that covers all ranges of the multi-selection) to ScViewFunc::CopyToTransferable(), which avoids the wrong col/row start/length, so the selection is classified as simple. Also adapt testRowColumnSelections, which was just meant to check we don't crash, but now the cell under the cell cursor is returned, so the assert about the empty selection would fail. Change-Id: If98212c623fa75adb2ddf628a6e90f3eef450e59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166581 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
4 daystdf#160765 - Save content for undo when pasting notesAndreas Heinisch1-1/+2
even if no content was changed after pasting special. Otherwise, the undo functionality crashes due to undoing a cell with no content where the annotation indicator will remain (unod/redo of note captions are handled via drawing undo). Change-Id: I7007fce510d6e9896cbda11a1e14a61b5ccb34a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166469 Tested-by: Jenkins Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
5 daystdf#160768 Changing value in a text box control with a link cell set up, CrashNoel Grandin1-0/+23
regression from commit 7510cca63690ea97eb02a43f698fc183c3d0434a Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Mar 26 15:56:02 2024 +0200 convert OCellValueBinding to comphelper::WeakComponentImplHelper Change-Id: I36ec4cca7a48992b29d6c2ff5c87fb0fed1c8c3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166540 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
5 daysloplugin:singlevalfieldsNoel Grandin1-2/+2
Change-Id: I4d7b38c90d73a00f4dbc8ad7318fe4573328ed46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166503 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
6 daystdf#61313 Replace the static ">=" with a dropdown of different operatorsAhmedHamed1-17/+13
The problem is with conditional formatting using icon set, as the icons order is fixed. It is solved by using comboBoxes for condition mode in ScIconSetFrmtDataEntry for every icon, and adjusting the UI file. A function that compares according to the currnt mode is added. Related CppunitTest files are updated. For every cell, last valid condition is applied. Change-Id: I489206d349a46092b307203c180705f42883183d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165701 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
6 daystdf#63374 Change cell background color when in edit modeSahil Gautam3-0/+28
Set the edit cell background (EditView) color to CALCCELLFOCUS and allow enabling/disabling via a checkbox tools > options > Calc > View > Edit cell background highlighting Change-Id: I1216dfa0880e1080d23059512e3801d6af3b3c11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165075 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
7 daystdf#80390 Use local copy in anonymous function.Sahil Gautam1-5/+5
The nCount object might go out of scope, as it's used by an async function. https://gerrit.libreoffice.org/c/core/+/164316/comments/507b830b_001a71eb Change-Id: I4218f6e35b61704115047481cb97a193c593a072 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154750 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
8 daystdf#80390 Extend InsertCells Dialog to allow adding a set of Rows/ColumnsSahil Gautam9-12/+72
Change-Id: I103574d720fef685b806943672a2aeb1fbf87097 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164316 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
9 dayscool#8789 sc lok: fix copy for multi-selectionsMiklos Vajna1-0/+8
Select A1+A3 in Calc, copy, try to paste in B1, nothing happens. This is because lok::Document::getSelectionTypeAndText() for a Calc document ends up in ScViewFunc::CopyToTransferable(), which only handles the SC_MARK_SIMPLE* cases. Fix the problem by implementing support for SC_MARK_MULTI, similar to what ScCellShell::ExecuteEdit() does in the SID_COPY case, which also calls CopyToClip(). Keep the test highlevel as the Calc shell doesn't seem to have an easy function to do the same as the Ctrl-click on a cell without duplicating lots of code in the testcase. Change-Id: I641d9db95ca391a4f39d96aeeb33422129262288 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166279 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
11 daystdf#129701 Follow-up of previous changeLaurent Balland1-3/+3
According to comments in https://gerrit.libreoffice.org/c/core/+/163536 Follow-up of previous change Change-Id: Icd7b6798d6ef35ca9574125cd3d4c4d89044569c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166133 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
11 daysFix typoAndrea Gelmini1-1/+1
Change-Id: I64398416dcad6b573cb2eeb2089a43bf42f5bed3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166163 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
11 daysFix typoAndrea Gelmini1-1/+1
Change-Id: Idee34a2b522f69a0fcea9595c62b68f74628c299 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166164 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
12 daystdf#160589: compare the correct OutDev with PageWindowsArmin Le Grand (allotropia)3-1/+9
Change-Id: I29d9c60cac04536bb2d5ad2ed1c086c8e67a9f20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166151 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
13 daysconvert OCellValueBinding to comphelper::WeakComponentImplHelper (II)Noel Grandin2-58/+66
second attempt at landing this Change-Id: I1dd3597b0047131c99b3ec81a3cb5eabf9bf8a12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165865 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
13 daysGeneralize basegfx::fround for templated return typeMike Kaganski2-6/+6
And use it when assigning to tools::Long Change-Id: I0814d7bac9cdd48191ba69c64e3b12a4973b3417 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166071 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-12lok: calc: not possible to select the cell adjacent to the edited oneMarco Cecchetti1-1/+3
In the LOK case using the paper size for the printer case (wysiwyg) can make the cell background and visible area larger than needed which makes selecting the adjacent right cell impossible in some cases. Change-Id: I20edd62645692f30e432b1064bb9c85b3396dc32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164702 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit a6bc0272607590d1692db385be7f6fbfeb1a8fb4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164999 Tested-by: Jenkins
2024-04-10tdf#114441 Convert sal_uLong to better integer typesRafał Dobrakowski2-2/+2
This patch changes the usage of type sal_uLong in sc module to sal_Int32. Looking into ScRefreshTimer constructor in sc/inc/refreshtimer.hxx, it becomes clear that sal_Int32 is a good choice. The usage is for communicating the refresh delay, measured in seconds. The reason to use signed variables is to follow the convention in ScRefreshTimer class. Change-Id: Ib565fd50ec4e6a46e95e9db06b7798a0b4a38d4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164957 Tested-by: Hossein <hossein@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org>
2024-04-10kit: Update formulas when switching tabsCaolán McNamara1-1/+3
we moved to not forcing a redraw on switching tabs at: commit 9f3ee2b27ceeab175fb865a55cfeabd66fbb128d Date: Sun Jan 14 16:29:56 2024 +0000 don't invalidate when switching tabs but in a scenario (to which two_sheets.ods is updated to capture) where there is no view/user active on a sheet B that depends on cells in sheet A, then when A is updated, B does not update automatically to reflect the changes in A. So, on switching to a tab, do the check for out of date formulas on the switched to tab. Change-Id: Ibbba83119adbd323b42314dbd9bcba6f797e5934 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165911 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-10cid#1596245 Explicit null dereferencedCaolán McNamara1-1/+2
Change-Id: I3912517648f76cd7a0fd651cf592bce427dc69f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165900 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-10tdf#146619 Drop unused 'using namespace' in: sc/Gabor Kelemen7-12/+0
Change-Id: I03478dd4c8e3c2ac88c0fe5e51efd53b09888475 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165695 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-08cid#1596254 Null pointer dereferences in GetSotStorageStreamNoel Grandin5-24/+19
Re-arrange the calling convention to make it obvious that a valid stream is the same as a good (true) result. Change-Id: I974b023a8e7231e70ab649628fdbe43c33001e5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165874 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-06use "ok" id like the other 446 dialogs instead of "okay"Caolán McNamara1-1/+1
and similar standardizations of stock labels and allow mnemonics Change-Id: I75c06f5a8ab961cf3b5427c33c801ae0f5ea5a78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165854 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-06Disable dragging in readonly view mode.Gökay Şatır1-0/+3
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com> Change-Id: I962d68b85897c156bba6d1898cf78b5fcd85540a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164866 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 0cdafeb746196f9f1e9ad271a77f5911694ff07d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165726 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-06tdf#152336 Detect charset and separators for csv filesGabriel Masei5-10/+46
Change-Id: Ie8451b3d30e390d363d8f9e5ec8bdf47350ca3a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164936 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-04-05Revert "convert OCellValueBinding to comphelper::WeakComponentImplHelper"Noel Grandin2-68/+58
This reverts commit 7510cca63690ea97eb02a43f698fc183c3d0434a. Reason for revert: deadlocking Change-Id: Id50926e401871be259fa955b68b1767fd7f6b9de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165723 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-04remove leftoversNoel Grandin2-3/+0
from commit e1e48bba55ff68397d514ab3771850678312f348 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Mon Apr 1 18:40:26 2024 +0200 tdf#160399 speed up print preview Change-Id: I399752d473a4f6f782cdfcc53b4625dcdf7cb460 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165778 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-03tdf#160252 ITEM remove unnecessary cleanups of shared_ptrArmin Le Grand (allotropia)2-3/+2
Change-Id: I5654d65097bf88b70cb85937de3ce111fa7e4345 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165552 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-04-02tdf#146619 Remove unused #includes from C/C++ filesRafał Dobrakowski53-88/+3
'sc' module was cleaned. Change-Id: Ia491d741a4c1c5314f35ebb4baa82dd516948ae7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165699 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-02fix assert in loading forum-de3-11775.odsNoel Grandin1-3/+1
regression from commit a95bff116e1da140b9abe9742ceeb9a3caed43d5 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Mar 26 15:42:52 2024 +0200 convert OCellListSource to comphelper::WeakComponentImplHelper Change-Id: Ib8af6627c641c73d9e4e6aaa43d694084a2854ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165671 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-02Conditional Formatting: Adding More Specified Dialoguescodewithvk2-16/+60
We have added additional single conditional dialogues to enhance the conditional formatting options for conditions such as duplicates, N elements, etc. Signed-off-by: codewithvk <vivek.javiya@collabora.com> Change-Id: I46d069f259d47739ad1bc859b19513f19d414eb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165290 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit abcb07e2baf2d59904b50e9c20f8a108ab9f17de) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165626 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-04-02simplify SotTempStream and lifetimeNoel Grandin8-30/+32
It is really just an SvStream instance, and the lifetime does not need reference counting Change-Id: Idb5ffd96f852aae0dc1a94cddc0a83fbcdf974ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165655 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-02tdf#160399 speed up print previewNoel Grandin4-79/+23
takes time from 2.5s to 1s for me Store all of the PrintPageRanges in the ScPrintState save/restore data structure, means we don't recompute the data in that structure, so of which is quite expensive. Change-Id: If65c8ca1cce25ff228c483f173b19b456056dc57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165646 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-01tdf#151413: add UTF-8 data to the Link clipboard formatMike Kaganski2-49/+10
And introduce methods in TransferableDataHelper to handle that. Change-Id: I1d91f0f6b7e8523125f9cc1507dbd6737968f7d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165607 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-04-01Fix abbr.Andrea Gelmini1-1/+1
Change-Id: Ia1f8f1527e76f2a721d42f6de11122f8c167bc96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165589 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-03-28tdf#123159 Make Hyperlinks keyboard accessibleSahil Gautam4-10/+110
Extend .uno:OpenHyperlinkOnCursor to open all hyperlinks in a cell, when not in edit mode. The UNO command can be assigned to a keyboard shortcut from `Tools > Customize > Keyboard`. If the active cell is not in edit mode, then pressing the shortcut opens all the hyperlinks in the cell. If in edit mode, pressing the shortcut opens the hyperlink under the caret "|". Change-Id: I7ffdab54fa31b9f7f614e04cc3158d8be217825e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157666 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-03-28Refactor ScGridWindow::GetEditUrl()sahil1-28/+34
To avoid code copy/pasting, common code is refactored to `lcl_SetEngineTextKeepingDefaults` to be used later in tdf#123159 Change-Id: I1889c8eee931ef8950e95af8aec73a1884b07302 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158516 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-03-28convert OCellValueBinding to comphelper::WeakComponentImplHelperNoel Grandin2-58/+68
Change-Id: I007d0c44bed1ab9e00cadcdbd126bc6bf3d99ea8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165364 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-27convert ScChartObj to comphelper::WeakComponentImplHelperNoel Grandin1-5/+3
Change-Id: I94974713ce5acff13aa0c12a782f9f3fdf004f55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165363 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-27convert OCellListSource to comphelper::WeakComponentImplHelperNoel Grandin2-68/+62
Change-Id: Iec9a3d20868c96dfe23141930b660e08773b5833 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165362 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-26lok: The GridWindow can get reset to a smaller than wanted sizeCaolán McNamara2-9/+16
This is the same problem as described in: commit 22a185a977f90d706c3e9d182adeaac310b6f348 Date: Thu Jan 11 15:08:21 2024 +0900 sc lok: set the GridWindow size to the client area size + test except that the size of the GridWindow gets reset by UpdateFormulas via UpdateHeaderWidth to the width of the "frame" which is remains at the nominal 800x600 initial size throughout. That only happens if there are enough rows in the document to trigger a check against this, so add some extra content into the test document to trigger the problem, and then guard against this reset for the kit case. Change-Id: Ibf80849929a4c987fd0fe977518336e5115ebdce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165240 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-26tdf#160338 Calc freeze on Text Attribute dialogNoel Grandin11-248/+133
This reverts commit 76e9023c8abc823447b1128056e55238f90da8d6 Author: Noel Grandin <noelgrandin@gmail.com> Date: Mon Jan 22 08:36:28 2024 +0200 convert more calc dialogs to async I fixed some lifetime issues, but even once that was happy, the Text Attributes dialog was not receiving mouse events properly, something else is unhappy when we mix async and modal dialogs. Change-Id: I4a35d886895c65af2085b606ff5c7a7c02fb5671 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165305 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-25cid#1594675 Logically dead codeCaolán McNamara1-2/+4
Change-Id: Icaf621e7a2e163f969ac7b6a1d6d04bf9251ea56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165277 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-24fix CppunitTest_sc_subsequent_filters_test4 intermittent failureCaolán McNamara1-1/+1
Change-Id: Ieb532183fd07915f8e0f2ec0cc3983a390024522 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165257 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-23tdf#143148 Replace include guards with pragma once in sc moduleRMZeroFour1-3/+1
As part of the efforts in #143148 to replace include guards in the codebase with #pragma once, this performs the changes for the remaining files in the sc module. Change-Id: Ia5633919e4159da94b6e663fa484ef0524cf7bd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165196 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-03-23Related: tdf#160056 do calc NumberFormatting via ScInterpreterContextCaolán McNamara11-52/+58
and for the duration of Threaded calculation where there will be no new formats required we can drive number formatting with the unlocked RO policy. Change-Id: Ic0e449acdcf834bc569d13b4a984f13c55316801 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165160 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-22Related: tdf#160056 refactor SvNumberFormatterCaolán McNamara2-3/+3
to split it into two constituent parts SvNFFormatData which is the data store for number formats it generally operates on. SvNFLanguageData for data around the current language in use. and then a SvNFEngine which implements the interaction between those parts SvNFEngine has two policies, the typical RW mode and a new RO mode where the SvNFFormatData doesn't change, all formats needed in this mode must already exist. Change-Id: I56b070ccd2e556a0cb1fe609a2fae28e18277c8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165146 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-03-22Resolves tdf#160282 - Ranges references text colors for dark backgroundsHeiko Tietze1-1/+9
Change-Id: I3d3bb22302ad5016c962d606e80c2e9942301fbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165095 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-03-22improve loplugin:staticmethodsNoel Grandin3-12/+12
Some of the exclusions were too aggressive. Restrict them to only the important classes, which exposes some more places this plugin applies. Change-Id: I1b2d1fb24391adc71ed0984f94168f61a149479f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165154 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 14:50:42 +0000