summaryrefslogtreecommitdiff
path: root/sc/source/ui/attrdlg/scdlgfact.cxx
AgeCommit message (Collapse)AuthorFilesLines
10 daystdf#80390 Extend InsertCells Dialog to allow adding a set of Rows/ColumnsSahil Gautam1-0/+5
Change-Id: I103574d720fef685b806943672a2aeb1fbf87097 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164316 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-04-06tdf#152336 Detect charset and separators for csv filesGabriel Masei1-2/+3
Change-Id: Ie8451b3d30e390d363d8f9e5ec8bdf47350ca3a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164936 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-03-26tdf#160338 Calc freeze on Text Attribute dialogNoel Grandin1-35/+0
This reverts commit 76e9023c8abc823447b1128056e55238f90da8d6 Author: Noel Grandin <noelgrandin@gmail.com> Date: Mon Jan 22 08:36:28 2024 +0200 convert more calc dialogs to async I fixed some lifetime issues, but even once that was happy, the Text Attributes dialog was not receiving mouse events properly, something else is unhappy when we mix async and modal dialogs. Change-Id: I4a35d886895c65af2085b606ff5c7a7c02fb5671 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165305 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-01-29make chart-source dialog asyncNoel Grandin1-0/+5
Change-Id: If33d2bc57d5c79d3204079b9858a488e7d92e968 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162689 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-01-29make append/rename table dialog asyncNoel Grandin1-0/+5
Change-Id: I3713271d121c525daa9800dcc1ac39bbd25e9c7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162512 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-01-29make set-tab-bg-col dialog asyncNoel Grandin1-0/+5
and adjust the logic in Dialog::EndDialog to cope with dialogs that can loop. Change-Id: I71c88d8fb0512e92e7890566143c762ec9650e28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162511 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-01-24make insert table dialog asyncNoel Grandin1-0/+5
Change-Id: I4fd880ed2b1f07439229750e77246cf9cb2df5f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162498 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-01-24convert more calc dialogs to asyncNoel Grandin1-0/+35
Change-Id: I6349942f0a4d6156ef59f43a6e96049128f47524 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162360 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-01-23sc: make inactive sheets movable and copyableBayram Çiçek1-1/+6
- move and copy use the same ScViewFunc::MoveTable function - added 3 new parameters to "SfxVoidItem Move FID_TAB_MOVE" - SfxBoolItem FromContextMenu FN_PARAM_4, - SfxUInt16Item ContextMenuIndex FN_PARAM_5, - SfxBoolItem MoveOrCopySheetDialog FN_PARAM_6 - moveLeft and moveRight of inactive tabs are implemented - move and copy of inactive tabs from the Move/Copy Sheet dialog are implemented - made Move/Copy Sheet dialog async Change-Id: I97461780a6c46f601bce9490315cd5cbea9505d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158078 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> (cherry picked from commit 4d5f8b43b04734805f48b921b98a74fd9ab67d0f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162385 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-25follow tdf#154131 Treat also HMTL importLaurent Balland1-0/+5
Add Detect numbers in scientific notation option to HTML paste Still need some qa tests Change-Id: I553404a01ab2a61566b861b3c01d14bdc0c46668 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152591 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-02Avoid conversions between OUString and OString in VCLMike Kaganski1-24/+24
Standardize on OUString, which is the main internal string class. Convert from/to OUString only when communicating with respective external APIs. Removes about 200 conversions from the code. Change-Id: I96ecee7c6fd271bb76639220e96d69d2964bed26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149930 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-22sc drawstyles: Add a dialog for style editingMaxim Monastirsky1-0/+7
Change-Id: I7e62251024df8f24bd6fe318f5c0262bbd6a1a11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149279 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2022-11-15sc: convert optimal width/height and normal width/height dialog to asyncrash4191-1/+6
Signed-off-by: rash419 <rashesh.padia@collabora.com> Change-Id: I96f6d90692d7767bdc276f753897bdc392c90411 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132919 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133127 Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142633 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2022-11-02sc: make InsertCell and DeleteCell async.Michael Meeks1-0/+10
Also enable them for use with jsdialogs. Change-Id: I378f228e86959edb98ad691089af919330dcdcec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142144 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2022-06-07tdf#129674 Add GoTo Sheet commandLaurent BP1-0/+32
Insert command in menu Sheet > Navigate (alongs with To Previous/Next Sheet) Use .uno:JumpToTable command from Navigator Use its own Go To Sheet dialog Add a Search entry to type partial name of sheet Menu translation missing? Change-Id: I16b8b56a688c8396159617f04a2a7e034721ce31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134714 Tested-by: Jenkins Reviewed-by: Laurent Balland-Poirier <laurent.balland@mailo.fr>
2022-02-03sal_uLong->sal_Int32 for refresh delayNoel Grandin1-4/+4
and improve the naming of the related methods and variables Change-Id: I1dc522090b0353fd4c63e74864a0deeb8d70fd28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129404 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-20tdf#142763 sc UI: add first page header/footer optionsDaniel Arato (NISZ)1-0/+12
Add checkbox "Same content on first page" checkbox (similar to the existing "Same content on left and right pages) to the Page Style dialog window, on the Header and Footer panes. Follow-up to commit 19fa853ce12136b5c14e0c5a0aa906c296b75388 (tdf#121715 XLSX: support custom first page header/footer) and commit 52beb3907dd3c7e6ae112e263def1005272cecd8 (tdf#142764 sc: import "Same content on first/left page"). Note: to set different header or footer on the first page of the spreadsheet, disable "Same content on first page" on Format->Page Style...->Header (or Footer), and choose the "Edit..." button. Change-Id: I3348fde216424b8d2c662956eab27cbe5880fc1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117316 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-07-15WhichRangesContainer, reduce malloc in SfxItemSetNoel Grandin1-1/+1
SfxItemSet shows up in perf profiles frequently, and the hottest part is the malloc of the two arrays we need. But most of the time, one of those arrays is a compile-time constant. So this change introduces (*) WhichRangesContainer, which manages whether the SfxItemSet owns the array it points at or not. (*) a static const member in svl::Items (idea from mkaganski) to store the data. Change-Id: Icb8cdbc4d54fd76739565c575e16a744515e5355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118703 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-17pivot table: properly close all subdialogsSzymon Kłos1-0/+10
Change-Id: Ieda601ce25d822394d6ddd12da861128b9270aa2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107843 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114207 Tested-by: Jenkins
2021-03-09let ScLinkedAreaDlg have a Widget parent instead of a WindowCaolán McNamara1-1/+1
Change-Id: Ida871186e5d15290ed2520b18651bad211799c1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112167 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-08pivot table: make subdialogs of pivot table dialog asyncSzymon Kłos1-2/+12
Change-Id: I2c1b26ebe661a2f66bc7bf94e4f3ede2fc5e18b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107775 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112095 Tested-by: Jenkins
2021-02-19tdf#65872 [WIP] Allow prefered interpretation of pasted numbers to be savedGeorge Bateman1-0/+5
Change-Id: I065f1f8cff1b3c7d7198ce431df39a7b8cb7b593 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107402 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-11CreateScSubTotalDlg always called with a non-null pArgSetCaolán McNamara1-2/+2
Change-Id: I8a13a66ab7ce55a48896a921dc3b91594abefbc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-11CreateScAutoFormatDlg always passed a non-null ScViewData*Caolán McNamara1-2/+2
Change-Id: I0b9568df6fdc571b5fa6cbf75a7473ac588442da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109066 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-07Make Pivot table db & external source dialogs asyncSzymon Kłos1-2/+12
Change-Id: Iff1a49a9fa04b55ece1aa30259ab57d105883eda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106996 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108798 Tested-by: Jenkins
2020-11-30Make Pivot table data source dialog asyncSzymon Kłos1-1/+6
Change-Id: I573038935e31c5393293197c1a9706110a970837 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106848 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-27tdf#42949 Fix new IWYU warnings in directory sc/Gabor Kelemen1-0/+2
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I217817e2e4a42b096f5a7fb6344568c10d69aab2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106078 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-10-20use tools::Long in scNoel1-4/+4
Change-Id: I8f37a8d1174ed816df971b8cee036d4e88d4a7fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-23ScRefAddress::GetRefString never passed a null ScDocument*Caolán McNamara1-2/+2
so the nullptr check can be removed and some more along that vein Change-Id: Ic0c1f98564b6bd457edd0d3ba2a4382b7945e806 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103217 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-18Make Group dialog asyncSzymon Kłos1-1/+6
Change-Id: I37fd6c44d43b0f0b424bd023e13ffa07f601a08b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100119 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102876 Tested-by: Jenkins
2020-07-28Make Sort dialog asyncSzymon Kłos1-2/+17
Change-Id: I914e09e59561e261dc2807ad00615d3b58afa541 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99127 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99351 Tested-by: Jenkins
2020-07-08distinguish between dialog screenshoting and rendering a widgetCaolán McNamara1-28/+14
Change-Id: I43ee0c68d72c97a15d26e2ffea577c2a44ba91e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98326 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-30loplugin:makeshared in scNoel Grandin1-20/+20
Change-Id: I512d05ea24c519c25f03a35842e362bf23f05693 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93198 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-25tdf#127113: Allow to fill any two numeric fields in Fill Series dialogSarper Akdemir1-1/+3
Added m_nSelectHeight and m_nSelectWidth to ScFillSeriesDlg class for deriving missing box if other two boxes are full. CheckValues() mimics behaviour of previous check functions with added functionality of calculating missing start or increment values (end value was already handled in previous check functions) in linear fill mode if it is possible to calculate them from other two values. Change-Id: If30d96f1b5f7e1bb88f473d7c0c5c2802ba6f225 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87841 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-02-07tdf#99693 Add Highlighting tab for CalcMaxim Monastirsky1-2/+2
Works with shapes and comments. Change-Id: I2a91a6038ab618bf7e6fd4eb2d129a9485a47fef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88163 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2019-11-08Resolves: tdf#128667 crash in csv import from pasteCaolán McNamara1-0/+5
Change-Id: Id50d0a7e4f176ccf83292495cb229da492fbf381 Reviewed-on: https://gerrit.libreoffice.org/82287 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-17weld ScImportAsciiDlgCaolán McNamara1-7/+21
notably the csv control is always LTR even in RTL mode, but the surrounding ScrollingWindow follows the environment direction, except the horizontal scrolling widget itself must LTR scroll. Change-Id: I72ee2b9dade73a11bcc4391e755fdb02886a884d Reviewed-on: https://gerrit.libreoffice.org/80765 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-09Related: tdf#123765 fix up some screenshottingCaolán McNamara1-0/+176
and add in two special cases for the mentioned cui dialogs Change-Id: Ibd2bf8e9e5bff131f2c009c784652f4500842326 Reviewed-on: https://gerrit.libreoffice.org/80488 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-12weld ScDataFormDlgCaolán McNamara1-4/+6
Change-Id: I656a11f5f9c55913cede710cf48543384132129d Reviewed-on: https://gerrit.libreoffice.org/72199 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-11weld ScCondFormatManagerDlgCaolán McNamara1-8/+15
Change-Id: Iccf2657f2c8fe98b4e975936fb75d56fc9523b5a Reviewed-on: https://gerrit.libreoffice.org/72162 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-01weld ScPivotLayoutDialogCaolán McNamara1-2/+2
Change-Id: I821ee682bf5b65774a609227811365b94ae2063e Reviewed-on: https://gerrit.libreoffice.org/71547 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-09drop newly unused ScAbstractTabDialog_ImplCaolán McNamara1-28/+0
Change-Id: I7f200543a77d9bbf2f892498bca8cbecdf9628a1 Reviewed-on: https://gerrit.libreoffice.org/70429 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-08weld ScHFEditDlgCaolán McNamara1-13/+13
Change-Id: I2f17dfb1f8193730b26e7c338100a786ddbb87c7 Reviewed-on: https://gerrit.libreoffice.org/70418 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-28loplugin:useuniqueptr in sc dialog constructorsNoel Grandin1-4/+4
Change-Id: I9fef0d3d567d9a0143c7a796725a44348b96bb23 Reviewed-on: https://gerrit.libreoffice.org/69880 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-26weld ScPivotFilterDlgCaolán McNamara1-6/+8
Change-Id: I0a2ffa6fd02dcf82d55f961ba229112b456eda8e Reviewed-on: https://gerrit.libreoffice.org/69733 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-16weld ScAutoFormatDlgCaolán McNamara1-7/+10
Change-Id: I700034eefe9fb25ee331645283bd3611c88faf5b Reviewed-on: https://gerrit.libreoffice.org/69052 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-11weld ScSubTotalDlgCaolán McNamara1-3/+2
Change-Id: I34db4ff89aa8e91d882bcde94e9ecfb88f25d9a6 Reviewed-on: https://gerrit.libreoffice.org/68984 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-21tdf#42949 Fix IWYU warnings in sc/source/ui/[a-c]*Gabor Kelemen1-7/+0
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I5e810ed15cc33900d106b64353584d21f081517f Reviewed-on: https://gerrit.libreoffice.org/67992 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-15weld ScDPFunctionDlgCaolán McNamara1-9/+12
Change-Id: I49428a9e6cd07a962c55939477f8408822170590 Reviewed-on: https://gerrit.libreoffice.org/67881 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-15weld ScDPSubtotalDlgCaolán McNamara1-10/+13
Change-Id: I33403031421a9f372c240cddea320591ac72bfc2 Reviewed-on: https://gerrit.libreoffice.org/67878 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 22:33:34 +0000