summaryrefslogtreecommitdiff
path: root/sw/source/ui/fmtui
AgeCommit message (Collapse)AuthorFilesLines
2023-11-02Drop SvxHtmlOptions::IsPrintLayoutExtensionGabor Kelemen1-2/+2
as it is just now a simple wrapper over officecfg Change-Id: If41c7c9db191af7ebede9072fd995d015056bf1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158779 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-02Avoid conversions between OUString and OString in VCLMike Kaganski1-3/+3
Standardize on OUString, which is the main internal string class. Convert from/to OUString only when communicating with respective external APIs. Removes about 200 conversions from the code. Change-Id: I96ecee7c6fd271bb76639220e96d69d2964bed26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149930 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-22sw: check GetActiveView()Xisco Fauli1-13/+14
See https://crashreport.libreoffice.org/stats/signature/SwView::GetDocShell() Change-Id: I90ebbff5082f1f9cae7fa3b940cbb9796d6c6dd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149223 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-02-17check GetActiveWrtShell() and CheckAndGetWrtShell()Xisco Fauli1-14/+20
See https://crashreport.libreoffice.org/stats/signature/SwModule::ApplyItemSet(unsigned%20short,SfxItemSet%20const%20&) Change-Id: I7c719c5fe4cda9f6571592c30f39bd440053dbe9 Change-Id: Iaa4448dccd1a0ec1aefa539e476b5046ed50f7b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147155 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-16SfxViewShell::GetViewFrame never returns null, change to a referenceCaolán McNamara1-1/+1
various null checks can be seen to be redundant and removed Change-Id: Icf49c1de4b0302795d2769a370af3abceaad0221 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147147 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-10-17sw: prefix members of SwSvxNumBulletTabDialog, SwTableTabDlg, ...Miklos Vajna1-33/+33
SwTemplateDlgController and SwXSelChgLstnr_Impl See tdf#94879 for motivation. Change-Id: I84d1ba98798a375f8bd138276b5bff45b005d6fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141438 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-06-23tdf#149615: "No list" twice in Outline & Style tab (non English UI only)Julien Nabet1-1/+1
Change-Id: I8a983b62175ed00ca8817556bd3e55fc87ddc9d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136110 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-10sw: remove all uses of MM50 with (added) o3tl::toTwipTomaž Vajngerl1-1/+2
MM50 constant is the number of twips for 5mm. This is (ab)used as a "shortcut" to set or compare various variables through the code and also to set a multiplied value (like 1cm, 2cm, 4cm) or divided value (2.5mm, 1.25mm). The problem with this is that converting the 5mm to twip doesn't round up exactly and multiplied and divided values increase the error even more. Instead of basing it from MM50 constant, it is just better to use our o3tl::convert (or the added variant o3tl::toTwip), which can actually calculate the conversion at compile time, so there is no added complexity at runtime and we get a more readable code with more exact result. i.e. o3tl::toTwip(4, o3tl::Length::cm) instead of the more cryptic MM50 * 8 In addition also sanitize and comment the values of the constants in sw/inc/swtypes.hxx. Change-Id: I85c306c36207d47ac3dc207094b68d0fb1ca5b70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119397 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-07-28use officecfg for SvtCJKOptionsNoel Grandin1-7/+4
and remove some unused options Change-Id: I487a233de4f7414012e5405f2c2e1f9c8b8fb4f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119554 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-26use officecfg for SvxHtmlOptionsNoel Grandin1-2/+1
Change-Id: Ie7db7d20509e45fd87d8460c7fae6c0131e0a1f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119494 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-09Recheck include/ with IWYUGabor Kelemen1-0/+1
See tdf#42949 for motivation Change-Id: Ifc253bf800bb1468b5774663a93f4fb30bec81d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113657 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-03-29tdf#101965 : Add No List default in Styles deck in sidebarAnshu1-0/+1
Change-Id: I167b379f31809bc252d3c091d0f545f8c2a3f13e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112143 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-14fix typo in style dialog functionSeth Chaiklin1-3/+3
Change-Id: I88b38a33a1ca50a0165b11679ca28bb092a6eab5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112307 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-06Related tdf#128469 - Customization of tab dialog buttonsHeiko Tietze1-2/+11
Change-Id: Ib7d4bbc6d78ac93510835e061640bfcd99248195 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111987 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-03-02Related tdf#128469 - Change label of Standard buttonHeiko Tietze1-0/+5
Change-Id: I1bfc7cbfa71cf76d1cd76db83d8a7f951535e47e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111821 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2021-01-06loplugin:unusedfieldsNoel1-1/+1
Change-Id: I0599f33ef4c0070e6ce61b0041db074cce217349 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108659 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-17svx: SVX_ENABLE_FLASH is now unusedMiklos Vajna1-1/+1
It was read by the Writer character blinking UI, which is gone. Change-Id: I97114f0fcfca02e1b2ff53f613d2d78619262f9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96478 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-26tdf#130456 sw: enable semi-transparent text for char style dialogMiklos Vajna1-1/+1
The code is shared, so this fixed the para style dialog as well. Change-Id: I742231bf76c562b3255700fc4eeb4c870c3deb6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94805 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-05-05remove unused nSearchFamily and nMask membersCaolán McNamara1-2/+0
and so SetSearchMask which doesn't have any effect anymore Change-Id: I0b7f402ce0317971d5196fc448fe2945a6a292f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93393 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05make the family and mask explicit in SfxStyleSheetBasePool::FirstCaolán McNamara1-2/+2
Change-Id: I36655b65ca00e5f7b8779a28d4a1778c8e35dc4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93461 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-23tdf#42949 Fix IWYU warnings in sw/source/ui/[c-u]*/*cxxGabor Kelemen1-10/+1
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Icf4e6f8ea7c751c8d068dbde50ea1b4726d565d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87004 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-12-16Related tdf#105225: Remove old background tab page codeJim Raykowski1-1/+1
All uses of SvxBackgroundTabPage have been replaced by a new background tab page derived from the SvxAreaTabPage. This patch removes the SvxBackgroundTabPage code and code used only by it. Change-Id: I83a2a04c0bf908cdc630fa091cd5ccdfb5d9381d Reviewed-on: https://gerrit.libreoffice.org/85194 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-15Use SvxBkgTabPage::GetRanges for new background tab pagesJim Raykowski1-2/+2
Commit 03facb4bb75e4283c91de6f081ee96137ca4346c introduced GetRanges function for SvxBkgTabPage. This patch replaces all uses of SvxBackgroundTabPage::GetRanges for new background tab pages with SvxBkgTabPage::GetRanges. Change-Id: I5dd16617d25b09bcf2e02656abd84db25f7b614e Reviewed-on: https://gerrit.libreoffice.org/85137 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-12-11num->number and bul->bullet in sw/Noel Grandin1-1/+1
make some symbols easier to read Change-Id: Icb5ea48dce1bcf4ae17e57e8f4c7bec3acd33f82 Reviewed-on: https://gerrit.libreoffice.org/84924 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-04use SfxUInt16Item for SID_METRIC_ITEMNoel Grandin1-2/+2
because we aren't using the array of values in SfxAllEnumItem Change-Id: I67ccb7737c52f9949495c53881e052d5005882aa Reviewed-on: https://gerrit.libreoffice.org/80165 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-05tdf#42949 Fix IWYU warnings in sw/source/uibase/inc/[l-z]*Gabor Kelemen1-0/+1
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie1c889bb9bd74b0d2bd859dad4c85a209db750a3 Reviewed-on: https://gerrit.libreoffice.org/76503 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-29tdf#111703 Select the Organizer tab page when new styleJim Raykowski1-1/+3
Change-Id: Ib031bd1139ea9a8bf084a1ead17bc17f30565401 Reviewed-on: https://gerrit.libreoffice.org/76508 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-02-10loplugin:indentation in swNoel Grandin1-2/+1
Change-Id: I4936284bff568b6bb47e5df3821f4ddd78260e92 Reviewed-on: https://gerrit.libreoffice.org/67568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-09cppcheck: multicondition "columns" in sw/tmpdlgJulien Nabet1-6/+0
weld writer page style dialog and SvxBorderBackgroundDlg writer, format page is complete a2304f62e963b413b7575bedfb8d34e5f2d3ea58 + SwTemplateDlg is now unused 2fc2f235b94de9f70a28aee90564745cda313489 Change-Id: I67c3ed5b2724ac7d8dacc42ad6eabf4ec68739a8 Reviewed-on: https://gerrit.libreoffice.org/64836 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-26tdf#105225 Use derived background tab page in Paragraph Style dialogJim Raykowski1-1/+1
Missed this one in Change-Id: I47f9ae10a0fd967729ff6e83c1a312aa49e1d13c Change-Id: Ibb825a922e7d7fcc31456386935b3a847642ebf0 Reviewed-on: https://gerrit.libreoffice.org/63966 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-11-25SwTemplateDlg is now unusedCaolán McNamara1-157/+46
Change-Id: If7de6baf5d2770d18926ee744a5c0fc6283c0195 Reviewed-on: https://gerrit.libreoffice.org/63973 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21weld writer char style dialogCaolán McNamara1-279/+18
Change-Id: Iaa61260e3d59dad782b32304aabe4e2d25069559 Reviewed-on: https://gerrit.libreoffice.org/63716 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21weld writer parastyle dialogCaolán McNamara1-9/+163
Change-Id: Id377af704ad9b0df90d6a494cc738fa2f62e4525 Reviewed-on: https://gerrit.libreoffice.org/61218 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-17weld writer numbering styles dialogCaolán McNamara1-93/+59
Change-Id: I697fa74a21acec550fcacd2a8d8468dfb21afcac Reviewed-on: https://gerrit.libreoffice.org/63495 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-05tdf#105225 new background tab pageJim Raykowski1-4/+4
This patch allows the new background/highlighting tab page and derived from area tab page to work correctly in the same tab dialog. It also provides a cleaner way to use the new background tab page by setting brush item as fill attributes to target set in the background tab page created method. Previously if the new background tab page and the area tab page were used in the same tab page dialog one would affect the other due to the same use of pool fill items. This patch makes a local copy of the attribute item set passed and then passes that set along to the parent class area tab page on each activation/deactivation. Tab page dialogs that use both the background and area tab pages are: Writer Paragraph Styles, Impress Presentations Styles and Drawing/ Graphics Styles, and Draw Drawing/Graphics Styles. All new background tab page merged patches have been reworked in this patch and remaining old background tab pages, with the exception of Report Design, have been replaced by the new tab page. Change-Id: I47f9ae10a0fd967729ff6e83c1a312aa49e1d13c Reviewed-on: https://gerrit.libreoffice.org/57102 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-30Simplify containers iterations in sw/source/ui*Arkadiy Illarionov1-2/+2
Use range-based loop or replace with STL functions. Change-Id: I0d690e873f720a68f04991674ce84ec590231fd0 Reviewed-on: https://gerrit.libreoffice.org/62432 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-17rename to weld::ComboBox are they are not text only nowCaolán McNamara1-1/+1
Change-Id: Ice26d1fd2ad97a6959c6916fef428777efea9c2d Reviewed-on: https://gerrit.libreoffice.org/60500 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-07weld writer page style dialog and SvxBorderBackgroundDlgCaolán McNamara1-6/+197
writer, format page is complete Change-Id: I09f6e4354461c4374cdb0d0e0754dfee35415b45 Reviewed-on: https://gerrit.libreoffice.org/60058 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-05clang-tidy performance-inefficient-vector-operationNoel Grandin1-2/+3
Change-Id: Iebcaea7b08c5284946d83b6b6b9ed26b218025d4 Reviewed-on: https://gerrit.libreoffice.org/59992 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-03Add missing sal/log.hxx headersGabor Kelemen1-0/+1
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directory sw Change-Id: I1ede3f86e390bfec1a2d3ee8e8bb6ec67083b194 Reviewed-on: https://gerrit.libreoffice.org/58372 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-15weld SwParagraphNumTabPageCaolán McNamara1-2/+2
Change-Id: I6d95b5235d43dabc17515f3ac31063093c68d959 Reviewed-on: https://gerrit.libreoffice.org/55860 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-09remove cargo cult OSL_ENSURE(pFact, "ScAbstractFactory create fail!"(Noel Grandin1-1/+0
Possibly this was useful once upon a time, but now it's just noise. If it failed, we're going to crash on the next line when we call a method on that pointer anyway. Change-Id: Ic601f0c3344f6895f8a6ffb3bc6f8bcb45d00a92 Reviewed-on: https://gerrit.libreoffice.org/55082 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-20drop unnecessary includesCaolán McNamara1-1/+0
Change-Id: I1a817d5575bbd57ecaa874a27158b9218e4210cc Reviewed-on: https://gerrit.libreoffice.org/51603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-01tdf#42949 Remove unneeded helpids.h headers (3/3)Gabor Kelemen1-1/+0
A side effect of the .ui migration is that we use a lot less HIDs in the code. A lot of files still contain helpids.h includes even if no actual HID is referenced. This cleans up directory sw. Found with: git grep helpids.h | cut -d : -f 1 | xargs grep -c HID_ | grep :0$ Change-Id: I100fd818b0e68eaaecbfaf7c7b58e95dea489aeb Reviewed-on: https://gerrit.libreoffice.org/46870 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-15More loplugin:cstylecast: swStephan Bergmann1-2/+2
Change-Id: I75f75b53e58221a3bd0a6eb837483e7ebae3a02b
2017-07-21de-hrc various thingsCaolán McNamara1-1/+1
e.g. helpid[s].hrc -> helpids.h and insert include guards where missing move "ordinary" defines into .hxx files remove .hrc entries that are used as arguments to dialog factory when a dedicated method can be added instead Change-Id: I792fb8eb0adfaa63cf354e6e57401fc943e9196e
2017-07-05tdf#108829 Cannot set a numbering style to a paragraph styleNoel Grandin1-1/+1
regression from commit f05d0d05829dd51cb9d8071ac97cc219779ee40a loplugin:unusedfields in sw part1 Change-Id: Ic7049c5288b2ec875936be0784611f5c7e6a4788 Reviewed-on: https://gerrit.libreoffice.org/39557 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-21loplugin:unusedfields in sw part1Noel Grandin1-23/+9
Change-Id: Iabbf7f09c0d92b488d7e03f4436f077c5e6e87aa Reviewed-on: https://gerrit.libreoffice.org/39039 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14remove noise UUUU tags in commentsNoel Grandin1-9/+9
Change-Id: Id8a2940ae7348bf75ca967f31adf8489dc678d00 Reviewed-on: https://gerrit.libreoffice.org/35161 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-21tdf#104737: Bullets and Numbering: inconsistent naming of last tab pageTamás Zolnai1-1/+1
Change-Id: Id1d1d92933c110942fd232067620e8224686a915 Reviewed-on: https://gerrit.libreoffice.org/32256 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 18:24:31 +0000