summaryrefslogtreecommitdiff
path: root/sw/source
AgeCommit message (Collapse)AuthorFilesLines
37 hoursofz#22822 use TOOLS_WARN_EXCEPTIONCaolán McNamara2-2/+2
Change-Id: Iaf879d5ec52cd422634287d1fe69a4aafe13c4d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95188 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
41 hoursofz#22775 Integer-overflowCaolán McNamara1-2/+5
Change-Id: I616350ce96e83f92beac711a59077815ff00fe50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95172 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2 daysRemoved duplicated includeAndrea Gelmini1-1/+0
Change-Id: I052762267bee88789e88b1b2f7ecabc192620a45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94877 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2 daysFix typoAndrea Gelmini1-2/+2
Change-Id: Ia7b3b9d770fdaf5ba6697b4ebb23befdb51fc949 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94878 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2 daysuse for-range loop on SequenceNoel Grandin1-2/+1
Change-Id: Ib2d7b21e0fa52087027c0b3b1d362693c7019ba3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93856 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
3 daysloplugin:simplifybool in swNoel Grandin20-44/+40
Change-Id: Ib842d5a768806fc41a66802908acc8679cf7a985 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95107 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
3 daystdf#133453 doc import: HasSprm can return last oneJustin Luth3-18/+25
The last sprm is the one that takes effect in the rare cases of duplicate SPRMs defined, so at least have an option to return that one as the matching value. Unfortunately, that seems to have been ignored in the last 20+ years of .doc support. So I added it carefully and only enabled finding the last SPRM in the specific case I was dealing with. However, I expect it should ~always be true, so perhaps I will followup with a patch looking for examples of duplicate/different SPRMs defined. Change-Id: I5539aa3d6117380cd6d852ca165d40c7c7f3c330 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95013 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
3 dayspack a few more classesNoel Grandin9-24/+23
Change-Id: Ia7870d1d0d91de213727116ccda5b41913223866 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95097 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
3 daystdf#102256 sw: ODF export: oops, don't write table attributes ...Michael Stahl1-17/+17
... when not writing table itself. (regression from commit d705a860936a58e40a2894a12d02be585a06e1c1) Change-Id: I73cbb126a5c6d12399806a20cd7f4307111a6c8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95057 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
3 dayschange TreeView toggle signal to provide an iter instead of a row indexCaolán McNamara3-8/+5
Change-Id: Ib611780816d170daa40f394b9798640ff6284d68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95056 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
3 daysFix 983db96a17630be906b868d2be811663f0d846f6Julien Nabet6-10/+10
warn:unotools.config:172285:172285:unotools/source/config/configitem.cxx:409: ignoring XHierarchicalNameAccess to /org.openoffice.Office.Writer/FormLetter/PrintOutput/AskForMergeFormLetter/FileOutput/FilePassword/FromDatabaseField com.sun.star.container.NoSuchElementException message: FormLetter/PrintOutput/AskForMergeFormLetter/FileOutput/FilePassword/FromDatabaseField /home/julien/lo/libreoffice/configmgr/source/access.cxx:436 missing comma + confusion in switch cases in SwMiscConfig::Load + typo Encyrpted->Encrypted Author: Gülşah Köse <gulsah.kose@collabora.com> Date: Fri May 22 11:51:33 2020 +0300 Add an option to create encyrpted PDF files with mailmerge. With that option user can create encyrpted pdf files with a password column in database via mailmerge. Change-Id: I1ae9bbeb3f69ed9c0ba51709852f8edd5f2dc683 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95033 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
4 dayssw: convert some assert in sectfrm.cxxMichael Stahl1-6/+4
Change-Id: Idf0d21ea9f0ae655584b8353140ebca4889e7fb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94945 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
4 daysResolves: tdf#133411 drop CONTENT_FLOWS_TO from dialog to search resultsCaolán McNamara3-113/+1
in the document, looks like only the calc one actually works, and when it works on large quantities of results calc grinds to a complete halt This was introduced with: commit b41332475783c31136673fb44cf4c411bb0148f8 Date: Mon Dec 2 15:54:29 2013 +0000 Integrate branch of IAccessible2 and has been a problem on and off with calc's potentially ~infinite grid There is the on-by-default search results dialog in calc (which has a limit on how many it shows) which provides an alternative route to iterate through the results Change-Id: I2685e480d2d15220be0bddbc83baad3992e7d5d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95006 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
4 daysRelated: tdf#133411 SetDocWin is using the previous search success stateCaolán McNamara1-8/+4
not the new state The order of calls probably didn't matter in the past where the use of the flag was deferred until the Accessibility data was queried which would happen in another event loop. This makes it more clear that it appears that only calc actually does anything productive here. I think this flow-to has created more trouble that its worth and I'll remove it but if we need to restore it, then this, I think, it the working state to restore to. Change-Id: Id6fbb483c081f6d5142100d70c1b29705dcb6452 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95005 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
4 daysMake loplugin:simplifypointertobool handle parenthesized expressionsStephan Bergmann2-3/+3
...as discussed as an open TODO in the commit message of fe6cce01c88d045a1fcf09acf049c34c22299b02 "Fix loplugin:simplifypointertobool for libstdc++ std::shared_ptr". The necessary changes across the code base have been done fully automatically with the rewriting plugin on Linux. (All those changes apparently involve uses of macro arguments wrapped in parentheses in the macro body, but always in conditionally-converted-to-bool contexts. In other contexts, such automatic rewriting would add the "bool" to the macro body, which would be wrong in general, but we apparently get away with that sloppy coding for now.) The parenExprs_ stack that fe6cce01c88d045a1fcf09acf049c34c22299b02 had introduced to treat such (then-undetected, it had turned out) parenthesized cases now turns out to not be needed after all. Change-Id: I2021f61c2e2805be7e18b38edf8744d186cac3cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95010 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
4 dayssw: handle PropLineSpacingShrinksFirstLine when replacing compat optionsMiklos Vajna1-5/+4
This was added in commit 9605763e3dc8c85137787c77c31e8639553a35ed (fdo#79602: sw: add new compatibiltiy flag PropLineSpacingShrinksFirstLine, 2014-10-30), it's on by default and off for old ODF documents. See tdf#124790 for motivation. Change-Id: If12447825ee9ed3094c5487e354eb7a0af5a46a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95004 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
5 daystdf#132236 sw_redlinehide: fix SwUndoDelete with sections even moreMichael Stahl3-3/+22
SwUndoDelete::UndoImpl may want to move something like this into the nodes-array: [ 9] 0x6356fe0 TextNode "", [ 10] 0x31cba00 ~DeletedNode , [ 11] 0x64d8840 TextNode "Introduction - xzn Overview Of KmneqxziTY\t3", [ 12] 0x64e9750 TextNode "shell\t20", [ 13] 0x7a0f0a0 ~DeletedNode , The ~DeletedNode become end nodes of section nodes; in this case m_nSectDiff != 0. Don't skip these end nodes because in the above "Untitled 1.odt" example, they are not necessarily consecutive. Between the 1st and 2nd one a new SwSectionFrame must be created via the outer section, so adapt InsertCnt_() to check for extra end nodes in the range and do this. (regression from 723728cd358693b8f4bc9d913541aa4479f2bd48) Change-Id: I7bfba9efca1789392495ebec37eb3e5b6138bd07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94883 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
5 dayssw: dump sectionNodeIndex in layout.xmlMichael Stahl1-0/+6
useful to see if the sections are nested Change-Id: I49c92b8f3084f72a2753462724b596b07fffbe62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94882 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
5 daystdf#131684 tdf#132236 sw_redlinehide: fix upper of frame moved...Michael Stahl1-0/+30
... in SwUndoDelete::UndoImpl; this wasn't fixed properly in commit 6c7245e789f973cf6dad03f7008ab3f9d12d350c - the SwTextFrame was moved into the SwSectionFrame but its upper was whatever it was previously. This is rather ugly because with the constraint from the very special case of tdf#131684 the MakeFrames() requires one node with pre-existing frames, and it's not possible to move the pre-existing frame after MakeFrames() because then the tdf#132236 case will have an empty SwSectionFrame and InsertCnt_() will just delete it. So try to detect the situation with some hack in InsertCnt_() to move it into the SwSectionFrame. (regression from 723728cd358693b8f4bc9d913541aa4479f2bd48) Change-Id: Ic0199c85d7523a49676ad3df1d2c4d8fe135c2ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94881 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
5 daystdf#133370 docx export: don't export unseen columnbreakJustin Luth4-10/+2
A compatibility option indicates whether a column break is treated as a page break when there are no columns. (Currently true only for DOCX). Don't export this column break when compat is off, because it WILL show up as a page-break in Word and LO when loaded. In theory, the RTF and DOC code that converts these into page-breaks on import could now be removed, but I can't think of any reason why that would be of benefit. testColumnBreak_ColumnCountIsZero in ooxmlexport4 covers the situation where docx MUST round-trip these. Change-Id: I5c17e43d90469bdb86087c61dadf48a9440f7b96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94799 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
5 daysFix loplugin:simplifypointertobool for libstdc++ std::shared_ptrStephan Bergmann28-59/+59
...where the get member function is defined on a std::__shared_ptr base class, so loplugin:simplifypointertobool used to miss those until now. (While e.g. using libc++ on macOS found those cases.) 366d08f2f6d4de922f6099c62bb81b49d89e0a68 "new loplugin:simplifypointertobool" was mistaken in breaking isSmartPointerType(const clang::Type* t) out of isSmartPointerType(const Expr* e); c874294ad9fb178df47c66875bfbdec466e39763 "Fix detection of std::unique_ptr/shared_ptr in loplugin:redundantpointerops" had introduced that indivisible two-step algorithm on purpose. The amount of additional hits (on Linux) apparently asked for turning loplugin:simplifypointertobool into a rewriting plugin. Which in turn showed that the naive adivce to just "drop the get()" is not sufficient in places that are not contextually converted to bool, as those places need to be wrapped in a bool(...) functional cast now. If the expression was already wrapped in parentheses, those could be reused as part of the functional cast, but implementing that showed that such cases are not yet found at all by the existing loplugin:simplifypointertobool. Lets leave that TODO for another commit. Besides the changes to compilerplugins/ itself, this change has been generated fully automatically with the rewriting plugin on Linux. Change-Id: I83107d6f634fc9ac232986f49044d7017df83e2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94888 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
6 daysweld SwFieldListBoxCaolán McNamara1-33/+63
Change-Id: I205ce5b300d869d6424c3552a2799c3b02282ff7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94810 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
6 daystdf#130456 sw: enable semi-transparent text for char style dialogMiklos Vajna1-1/+1
The code is shared, so this fixed the para style dialog as well. Change-Id: I742231bf76c562b3255700fc4eeb4c870c3deb6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94805 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
6 daysAdd an option to create encyrpted PDF files with mailmerge.Gülşah Köse6-8/+143
With that option user can create encyrpted pdf files with a password column in database via mailmerge. Change-Id: I081ef050bc269b1fec24fd01ecc812acd7b857ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94709 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
6 daystdf#133030: DOCX export: fix formula alignment - part 3Attila Bakos2-12/+56
Follow-up of commit 1237acf9851f8b12d1ccd929e2aa8b184c06d552 (tdf#132811 DOCX: fix formula alignment – part 2) Co-authored-by: Tibor Nagy (NISZ) Change-Id: I5466649a2aa6b7ffdb0def723f79dfbecdf1495f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93665 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
7 daysRevert "tdf#104017 DOC export: be less aggressive with merging page styles"Justin Luth1-1/+1
This reverts LO 6.3.4 commit 5d1709a7c4184eb31cfc4c2d3acadff3a4a68189, which tdf#133334 shows is wrong. How this made it past QA is a mystery to me. There should be lots of examples. Change-Id: I17be6e4bab44057f4535d4728825e12d068b65d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94782 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
7 daysFix typosAndrea Gelmini1-1/+1
Change-Id: I7c94080396dae767079a968cdda74449a144a947 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94655 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
7 dayssw: add XPackageEncryption save support for binary docVasily Melenchuk2-0/+106
This adds save support for API-based MS-CRYPTO algos. If we have custom encryption data in media descriptor and corresponding service is available it will be used during saving. Change-Id: I814e4a7f73979ff7a65831b99f77f1a9e85916de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84438 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
7 dayssw: add XPackageEncryption support for binary docVasily Melenchuk2-1/+101
This adds read support for API-based MS-CRYPTO algos. DRM encryption is implemented as a service and desrption will be called if we found corresponding streams inside binary OLE package. Change-Id: Ie1a5b0417e1e7851b24d410c8f41dc85dd9210f7 Reviewed-on: https://gerrit.libreoffice.org/81600 Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Tested-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84437 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
7 dayssw: prefix members of SwUndoDelNum, SwUndoInsNum, SwUndoNumruleRename ...Miklos Vajna4-67/+67
... and SwUndoRenameFormat See tdf#94879 for motivation. Change-Id: I9ff812ce6c3c956954262e0546fe5f538bd91d83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94768 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
7 daystdf#133348 remove from list before calling SetActiveSidebarWinJulien Nabet1-2/+4
so GetNextPostIt won't deal with mvPostItFields containing empty unique_ptr See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=161242 Change-Id: I7c9a3e91d5186492cb185f799b60d1dcc5edf7af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94766 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
7 daysuse SETNOSB for nameCaolán McNamara1-1/+1
Change-Id: Ia05d6a267e19d2a0a3b45862f4a7d04568e950e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94742 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
8 daysinline some use-once typedefsNoel Grandin8-24/+12
Change-Id: Idddba2f3fd05265b08dbc88edb6152d34a166052 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94730 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
8 daysremove some unused typedefsNoel Grandin2-2/+0
Change-Id: I305086e26538110481918f8250a482e4738ac41f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94729 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
8 daysnospin hack no longer in useCaolán McNamara1-2/+2
Change-Id: Ib855c429ac936f9b7bb219ad4729f99b0625ec37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94734 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
9 daystdf#133270 MAILMERGE progress is not updated during export of many filesSerge Krot2-2/+5
See also https://gerrit.libreoffice.org/c/core/+/90686 for a similar change. Change-Id: I063394f7ef0a68c79366f09c9d2cf5775a57e640 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94663 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
9 daysRelated: tdf#133189 values not updated when units changedCaolán McNamara1-4/+0
do it for all of them, not just the writer one. A braver move. Change-Id: Ib1f635ccc6a70c1ef00f82449bd351c82da7a13d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94707 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
10 daysuitest: Add wait methods for slow elementsXisco Fauli2-0/+6
some elements take some time to be updated, specially with slow machines or ASan+UBSan builds Use the same time based approach used for launching the dialogs also reintroduce 634ce6f2d87a30b8abd2e8c67668e3bb5d87406b Change-Id: Ia1cca74474ef65578bbc60a53a8a511402a082b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94648 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
10 daysResolves: tdf#133189 values not updated when units changedCaolán McNamara1-0/+4
Change-Id: I7028974e9a916a630f5530c65952103ada702212 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94696 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
10 daysmove InterimItemWindow to vclCaolán McNamara3-3/+3
Change-Id: If0a4a14708810c44d087b51961f2ecb3fda4df23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94649 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
10 daysremove Size arg from Window::Draw and depend on GetSizePixelCaolán McNamara4-17/+16
90% of cases pass GetSizePixel as the Size arg already and this aligns Window::Draw with how Window::PaintToDevice works Change-Id: If5b024179a4b7a3b099177c2f6d4b1fb006b95ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94644 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
10 days[API CHANGE] officecfg,xmloff: remove SaveBackwardCompatibleODFMichael Stahl1-8/+2
org.openoffice.Office.Common.Save.Document.SaveBackwardCompatibleODF was added in 2007 and apparently enables storing invalid ODF (or OOoXML) to workaround bugs in OOo <= 2.3; nobody should need it in this day and age, and the OOoXML export has been removed anyway. bce5e157785745a6729db62b15fb98bc396cddee 2007 c7a3859693971bf7103bfb0d05d64712e724fa37 2007 7477a65e09b20917adf025550c550f8822b508ee 2007 77baabe992c77018a0467ffec8f9482f8d76b66b 2007 575222083e058a740f5ad69e14e18622c3d4f7af 2007 66b908b45cde78af020b35e817e67bc40b8493f0 2007 Change-Id: Ib3f730c7c9ac6fbbbbae9fb4a42c1bd65f6c93df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94571 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
10 daysDon't show styles frame in insert table in onlineSzymon Kłos2-0/+6
Change-Id: I2ee2daef028b49a409920c0fe83190575e7a82c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94639 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94657 Tested-by: Jenkins
11 daysuitest: sw: grab focus before using toggle button in navigatorXisco Fauli1-0/+3
otherwise the focus in on the document since ada385f1cba427416c1e8517cb6a45b61ceff7b0 Change-Id: Ia8300fdceb4f50f89c6d90f238483a4c785163d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94647 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
11 dayssw XHTML export: properly write <li>...</li> around multiple paragraphsMiklos Vajna2-16/+15
Writer just has a list of text nodes, but ODF and HTML can have multiple paragraphs inside <li>, in case the non-first text nodes have their RES_PARATR_LIST_ISCOUNTED set to false. Improve b6f7a4908d1c3fc610440a1cbbbc1673a53da8b6 (sw XHTML export: properly write <li>...</li> around paragraphs, 2018-04-11) to make the decision around when to write </li> based on not only the current but also the next text node. This way we omit </li> for non-first paragraphs inside <li>, but keep writing it in other cases. Change-Id: I994855961aeea92050268dba5f19f125c7ad2b7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94622 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
11 daystdf#133035 DOCX export: fix position of unnamed OLEAttila Bakos1-1/+1
Position export depended on OLE object names, instead of the type of anchoring. Follow-up of commit 2150fdc7d0f63288ac56c33cb898589512057642 (tdf#131539 DOCX export: fix position of OLE objects). Co-authored-by: Tibor Nagy (NISZ) Change-Id: Ib98a19cb012047f37a5830c81541ef00c55589dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94190 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
11 daysMake Insert Table dialog asyncSzymon Kłos3-83/+113
Change-Id: Id2458c16f259a58e2376f42104a9a6c9056cab11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94536 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94589 Tested-by: Jenkins
11 daysuse for-range on Sequence in sfx2..swNoel Grandin1-5/+5
Change-Id: I09806869f2fdbae61f4c5d5c9db6859202bb63b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94609 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
11 dayssw: handle CollapseEmptyCellPara when replacing compat optionsMiklos Vajna1-1/+1
This was added in commit 56b2cf0c10d9caa01ebae1d80465e342d046a85c (sw-collapse-empty-table-par-like-html.diff:, 2010-09-14), it's on by default and off for old ODF documents. Change-Id: I372c3447b0f8d63a4608543bb466817d694cbff4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94599 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
12 daysNFC sw layout: optimize assignment of bAllowSplitOfRowJustin Luth1-6/+3
1.) Remove unnecessary test for !bDontSplit, since by definition, bTableRowKeep requires !bDontSplit const bool bDontSplit const bool bTableRowKeep = !bDontSplit && ... const bool bAllowSplitOfRow = bTableRowKeep && ... 2.) Put the trivial !bPrevInd test first and so potentially avoid the non-trivial lookup of AreAllRowsKeepWithNext(pFirstNonHeadlineRow) 3.) bAllowSplitOfRow by definition contains the two requirements of !bDontSplit and !pIndPrev, so pull out and test earlier - potentially avoiding further tests. This also emphasizes its similarity to bEmulateTableKeep. Change-Id: I41cb72aa03371eacfdb68d63dc3df21f85e755bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93635 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>