summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)AuthorFilesLines
19 hoursloplugin:singlevalfieldsNoel Grandin6-25/+9
Change-Id: I4d7b38c90d73a00f4dbc8ad7318fe4573328ed46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166503 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
20 hourstdf#159379 sw: fix crash on dropping multiple as-char imagesMiklos Vajna3-2/+82
Have an empty Writer document, set preferences so images created via drag&drop are anchored as-char, drop 2 images from a file manager, crash. The root of the problem is that the first image gets dropped fine, but the second one would be anchored to the currently selected graphic node, since commit 651527b4efe9700c8c8dff58ce5aa86ad5681f16 (sw: fix double-click opening frame dialog, not graphic dialog on images, 2022-04-26). The new SwTextCursor::GetModelPositionForViewPoint() returning a graphic node for a point inside the image looks correct, so fix the problem by extending SwFEShell::Insert() to take the anchor position as the anchor for the new image, in case a graphic node is selected. The original use-case would use SwEditWin::ExecuteDrop(), but keep the test simple and invoke the underlying SwFEShell::Insert() instead, that also triggers the problem. Change-Id: Ibba57aa28d0616ded16b4abb314f04974f1b8f9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166499 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
33 hoursResolves tdf#160731 Navigate by recency does not work under gtk3 +Jim Raykowski1-3/+1
wayland I think the lines of code removed by this patch were meant to allow recency to remember the cursor position before being moved to a start/ end/previous/next word or sentence position by an UNO dispatch command. These are already taken care of in the slot execute function void SwTextShell::ExecMoveLingu. Change-Id: I8bf231ea4cbb03125f54332a41c5544f9094b768 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166350 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2 days-Werror,-Wunused-variableStephan Bergmann1-2/+0
...ever since the code was introduced in 0c7ae3bd96130eaa400d55a3ba9bf1e2fe6600de "tdf#156146 tdf#159903 sw: add unit tests" Change-Id: Ib53b98f6f1ce460bda6b06a7b082a28a49f05a28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166388 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
3 daysResolves tdf#58434 - Show formatting marks independently from fieldsHeiko Tietze2-49/+47
Field Shading / .uno:Marks toggles now only fields, footnotes, tox etc. and Tab, SoftHyphen, Blank, as well as ControlChar depends now on Formatting Marks / .uno:ControlCodes. Field Shading also does not toggle HardBlank and SoftHyphen, and what control character is shown respect the options under Formatting Aids Change-Id: I63c826e7fdc09ec95f17aee9735d4f5de9a1b897 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166033 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
3 daystdf#81956 vml import: put groupshape in foreground if positive z-indexJustin Luth2-0/+24
no interesting unit tests found, but this one at least lets you add text to the body and visibly see the effect of foreground/background. make CppunitTest_sw_ooxmlimport CPPUNIT_TEST_NAME=testN751077 Change-Id: Ib03e6b429ad4ec6a38d1119f3720bc56a70b98eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166345 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
4 daystdf#146190 Fix move to next drawing object using the tab keyJim Raykowski4-21/+48
after double click on a drawing obect in the Navigator doesn't move to the next/previous drawing object when there is a number rule at the current current cursor position and the current cursor position is at the start of a paragraph. This patch reworks the SwWrtShell::GotoDrawingObject function so the document cursor position gets moved to the position of the drawing object when the object is selected. Another way to get expected results is to leave the GotoDrawingObject function as is and move: else if (rSh.GetSelectionType() & (SelectionType::Graphic | SelectionType::Frame | SelectionType::Ole | SelectionType::DrawObject | SelectionType::DbForm)) above the: else if( rSh.GetNumRuleAtCurrCursorPos() && rSh.IsSttOfPara() && !rSh.HasReadonlySel() ) in the SwEditWin::KeyInput function case KEY_TAB: block. SwWrtShell::GotoDrawingObject is made SW_DLLPUBIC by this patch to able to be used by the included unit test. Change-Id: I047b416ae94a9284d304798924e0c5f2be526f85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166089 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
4 daystdf#159910 sw a11y: Set a11y name for Navigator comboboxMichael Weghorn1-0/+5
Set a11y name for this combobox in the Navigator to "Navigate By". This is in line with the tooltip shown when hovering over the combobox, which is set for the combobox's parent, the panel. This makes Orca with the qt6 VCL plugin now announce the a11y name of the combobox with the corresponding role, rather than the panel ("Navigator, panel, Navigate By, combobox" instead of "Navigator, panel, Navigate by, panel, combobox"). For gtk3, Orca still doesn't announce the combobox or it's a11y name set in the .ui file, but still just says "Toggle button, not pressed", which will have to be addressed separately. This is because while there is a combobox with accessible name "Navigate By" in the AT-SPI tree now, the object that gets focus is a toggle button that doesn't have a name set for the gtk3 VCL plugin, which will be addressed in a separate commit. Change-Id: Id6b615f033c78d318611b520d49332714fa40eb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166246 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
4 daysloplugin:constantparam in swNoel Grandin4-9/+9
Change-Id: Ibb4d4d1cca59ece6bcd28e887f84d657dedee756 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166314 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
4 daysloplugin:constantparam in swNoel Grandin2-8/+6
Change-Id: Ia1379762ba957097a1a2134c5d206f254e22683b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166313 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
4 daysloplugin:constantparam in swNoel Grandin2-12/+5
Change-Id: Idf7d3abd464b7be87d109d14adf94357a5d49dd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166312 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
4 daysloplugin:constantparam in swNoel Grandin10-24/+17
Change-Id: Ia3e1b50954354973ffef701821f661cf782687db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166311 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
4 daystdf#140616 ApplyParagraphMarkFormatToNumbering: including highlightJustin Luth2-1/+2
I was concerned that I might override highlights set in numbering.xml but in that case pFormat && pFormat->hasItem(RES_CHRATR_HIGHLIGHT) so pCleanSet no longer hasItem. (see num3n.docx and TestDoc_highlight2.docx) Note: must use Word 2010+ to see numbering.xml highlights!! This is strictly a visual thing. Unit testing has traditionally used magic tile rendering x,y positions to check the color, which seems completely untrustworthy. Change-Id: I026252f127107e4782d08f72bfd5e2a412142111 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166303 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
5 daystdf#156146 tdf#159903 sw: add unit testsMichael Stahl6-7/+350
Unfortunately the actual computed margins are not stored in text formatting data structures so are only available directly from SwTextMargin. Change-Id: Ia7ce5e148194a55b5d9874ed112aaa977ed16c7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166258 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
5 daystdf#140616 writerfilter: recognize style rPr under pPrJustin Luth2-1/+13
Although it is completely NOT normal to put any rPr's in the style's pPr (since they normally just go into a stand-alone rPr), MSO is able to read and apply those - while LO just ignored them (as misplaced properties). It seems harmless to me to import it this way as well. make CppunitTest_sw_ooxmlexport14 \ CPPUNIT_TEST_NAME=testHighlightEdit_numbering Change-Id: Ie4a6c4c91a8214f40e34dc58c47b0bb9381bac1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166189 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
5 daysFix typoAndrea Gelmini1-1/+1
Change-Id: I00f6c7696b9b2cdb6f1ac0ae71774795f48daf91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166285 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
5 daysRemove exec bits on docx fileAndrea Gelmini1-0/+0
Change-Id: I69a9fb310e640b68ca4a9987b8b4a8b7cbd744c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166286 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
5 daysFix typoAndrea Gelmini1-1/+1
Change-Id: I8b7aa192fbdc5269b0da527dc2aeb2d535f1f0d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166284 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
5 daystdf#158451 - sw unit test - FILEOPEN DOCX crashKira Tubo2-0/+12
Unit text checks if DOCX file crashes when opened. Document contains grouped shapes that is anchored "As character". Change-Id: I7df17de0e1f1bf252593548883ba7959f2002023 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165776 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
5 daysAdd a unit test for commit 3f0220f18a66630e06e3c128980f21a5722f49caMike Kaganski2-0/+24
(Handle empty range properly, 2024-04-18) Change-Id: Ifea60ace8ff864ef092e6a62177d5926ceb60de3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166278 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
5 daystdf#160622: Let SalLayout::GetBoundRect return basegfx::B2DRectangleMike Kaganski1-2/+2
This avoids premature rounding in TextLayouterDevice::getTextBoundRect. The box in D2DWriteTextOutRenderer::performRender needs to be expanded to allow room for the line width (which now will be guaranteed on all sides; previously, the rounding could happen to give no room on some side, even prior to commit 8962141a12c966b2d891829925e6203bf8d51852). Fixes some lines partially cut off in smaller text (or zoomed out). Change-Id: I07335136021f894cf045363b4d736bfab06c64d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166236 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
5 daystdf#160700: Avoid both bookmark-start and bookmark-end at the same indexMike Kaganski3-0/+33
There is a special handling of CrossRefBookmark, which has no end position in the document model, but must span the whole paragraph, and end position is generated explicitly. Since commit 1d7ce421480d9170316533de03feb8d04eb5c767 (tdf#159438: when there's no frame, close previous bookmark first, 2024-01-30), end marks of an index are sorted before start marks of the same index, with the expectation that start / end marks represent non-empty span. Dun in case of empty paragraphs with a CrossRefBookmark, both start and end mark were emitted into the same index, and the new sorting resulted in the wrong order of the elements. Fix this by checking if the start index is less than node end, and don't handle CrossRefBookmark specially, if the check is negative. This writes a single text:bookmark, instead of a text:bookmark-start, followed by a text:bookmark-end. Change-Id: I533c4f7814edddc3cf24b1213490f251d60b2273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166266 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
5 daysCppunitTest_sw_uibase_docvw: turn on set_non_application_font_useMiklos Vajna1-0/+4
Similar to commit dc4d7500c9d283e26d1553ce11366a217cf1f69d (Fix CppunitTest_sd_import_tests-smartart non_application_font_use, 2023-10-23), though this didn't find anything. Change-Id: I775e984410c1e25fb1ae09a9ddfa09793a4f9bb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166231 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
6 daystdf#158056 Connect to MS Access .mdb files by mean of ACE.OLEDB.12.0 providerjucasaca3-19/+4
* Modify the code so that all connections to MS Access files, both .mdb and .accdb are made with the provider "Microsoft.ACE.OLEDB.12.0". * Remove all references to the "Microsoft.Jet.OLEDB.4.0" provider to clean up the code. * Leave only one entry "Microsoft Access" in the Connection Wizard, which would work for .mdb and .accdb files. * Remove the entry "Microsoft Access 2007" from the Connection Wizard, since it is no longer needed. Change-Id: If523712d071199d61e0c994b35291d3a69246ad1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165756 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
6 daystdf#156546: sw unit test: freeze redo insert tableKira Tubo1-0/+37
Unit test checks if writer freezes when the user performs redo on table inserted into a new document. Change-Id: I9d48f32a1ef27deb01c8042a68c21b0be20f2d05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165919 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
6 daysmove writerfilter inside swNoel Grandin334-0/+97543
writerfilter wants to convert incoming RTF and OOXML files into writer's document model. But it currently has to do so by manipulating the limited subset that we expose through the UNO API. This is both slower and less accurate than having access to the full document model. So move it inside, and then we can strip out various hacks, and optimise imports. Change-Id: Ie1114d28130ef5f9a786531bc552cb8ee7768015 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165953 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
6 daystdf#160621 Redesign name and value fields in variabe fields dialog pageOliver Specht1-354/+291
The space available in the bottom of the dialog page is now used to make the input fields longer Change-Id: If936decbcc44ff356095fc291ff8306084c248ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165952 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
7 daysCppunitTest_sw_rtfexport3: avoid DECLARE_RTFEXPORT_TESTMiklos Vajna1-246/+448
No need to go via Writer-specific macros here. Change-Id: I5cc93ca6ee7bfc2f14d90edfe837a14c182bc73c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166169 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
7 daysDrop FRound, and use generalized basegfx::froundMike Kaganski2-3/+2
Change-Id: I7447e649dc3ef4e51242f69c7486a3e84e103d2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166159 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
7 daystdf#160632 TABLE: Crash when using column width dialogNoel Grandin8-38/+35
regression from commit a08110be32a6958f27ce9ddb1e2cb2227265dfe1 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Jan 30 12:24:47 2024 +0200 convert table width dialog to async we were referencing an object that had already been destroyed by the time the dialog completed Change-Id: I2a06dd99129b53c558d6f5f3f96fc16dcc04f754 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166147 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
8 dayscid#1596278 Dereference after null checkCaolán McNamara1-1/+1
Change-Id: I4fb7b4b113e60dc3cc4aabd49e4dd23dbeeb74f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166112 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
8 daysImprove case rotation in sentence caseOliver Specht5-20/+36
Rotating case (Shift+F3) applies sentence case only if multiple words are already selected or selects sentence if SENTENCE_CASE is going to be applied. Change-Id: I9e8536d7744a344d7ad54150783e91e843e0e81e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165986 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
9 dayscid#1596323 Dereference null return valueCaolán McNamara1-4/+7
Change-Id: I63eeb8662ee28f1a0e990160b1ff9992d9d9337f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166111 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
9 daysGeneralize basegfx::fround for templated return typeMike Kaganski3-36/+39
And use it when assigning to tools::Long Change-Id: I0814d7bac9cdd48191ba69c64e3b12a4973b3417 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166071 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
10 daysUse more o3tl::convertMike Kaganski1-3/+3
Change-Id: I922502c80d79b8432a46e97178bc87f43847f996 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166061 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
10 daysSwContentTree: remove repeated pointer assignmentJim Raykowski1-21/+12
The selected entry does not change within the CommandHdl function therefore assignment of the pointer to the selected entry SwContentType does not need to be repeated elsewhere in the function. Change-Id: I025ecb9259e2ee46a64d55c75d0c3f3c8cc625ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166018 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
10 daystdf#158067 Replace OUStringLiteral with _ustrAaron Bourdeaux3-13/+4
Change-Id: I3a58469c52055121e8726cee2d3e42ecd23cdf96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165826 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
10 daysSimplify and use more o3tl::convertMike Kaganski1-59/+35
Change-Id: Ic7babea4eec3633d40d306488fea252d6f2636be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166050 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
12 daysAdd the strings "dialog" after "Macro Selector" in extended tipsTaichi Haradaguchi1-1/+1
because the Macro Selector is the dialog name. Change-Id: I3e766016279f85c47eca8a6abf8b5dde4cc6a538 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165487 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
12 dayscrashtesting: assert on exporting fdo48097-1.doc to docxCaolán McNamara1-1/+3
noticeable since: commit ad4b72a0eacf6bb6887236ea3a3807b1264de822 Date: Thu Mar 21 12:10:40 2024 +0100 tdf#160301 import DOCVARIABLE fields as user fields but not really caused by it Change-Id: I44910756df3938829589f230716363beaf0f4f91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166023 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
12 daystdf#116091: Replaced 'AutoFormat' Button in Convert Text to Table dialogSujatro Bhadra8-532/+957
Change-Id: If8eee099e79e65d5a6ca1b06d1cfb2a71bbe52f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165099 Tested-by: Jenkins Reviewed-by: Sujatro Bhadra <sujatrobhadra@gmail.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
12 dayssw: workaround crash in IsAllHiddenRow()Michael Stahl1-1/+2
Not sure why but somehow still crashes in the code added in commit ab7893544dc6be6dc192dffefd57cd5ddd421c35 https://crashreport.libreoffice.org/stats/crash_details/912e7417-5e04-4279-bbaf-380234f4cd33 Change-Id: I23b7ecdd83009cfe6584866ed72102d8f2179f86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166010 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
13 daystdf#132599 cui offapi sw xmloff: add hyphenation-keep-typeLászló Németh14-26/+1213
Support XSL attribute "column" and CSS 4 attribute "spread", stored in loext:hyphenation-keep-type, to give better control over hyphenation-keep. E.g. spread: both parts of a hyphenated word shall lie within a single spread, i.e. when the next page is not visible at the same time (e.g. the next page is not a right page of a book). – css::style::ParaHyphenationKeep is a boolean property now, importing hyphenation-keep = "page" as true. – type of ParaHyphenationKeep, including the new non-ODF types is stored in the new ParagraphProperties::ParaHyphenationKeepType. – default value of ParaHyphenationKeepType is COLUMN for interoperability. – Add checkboxes to Text Flow -> Hyphenation Across in paragraph dialog: * Column (previously: Hyphenate across column and page) * Page * Spread – enabling/disabling them follows XSL/CSS 4/loext, i.e. possible combinations: * No Hyphenation across (hyphenation-keep = "page" and loext:hyphenation-keep-type = "column") * Hyphenation across [x] Column (hyphenation-keep = "page" and loext:hyphenation-keep-type = "page") * Hyphenation across [x] Column [x] Page (hyphenation-keep = "page" and loext:hyphenation-keep-type = "spread") * Hyphenation across [x] Column [x] Page [x] Spread (hyphenation-keep = "auto") – Add ODF import/export – Update DOCX import – Add ODF unit tests Note: recent implementation depends on widow settings: disabling widow handling allows hyphenation across columns and pages not only in table cells. Note: RTF import-only, but not used bPageEnd has been renamed to bKeep. Depending on the RTF test results, likely it will need to disable the layout change, e.g. GetKeepType()=ParagraphHyphenationKeepType::AUTO, if PageEnd uses obsolete hyphenation rule, i.e. shifting only the hyphenated word to the next page, not the full line. More information: – COLUMN (standard XSL value, defined in https://www.w3.org/TR/2001/REC-xsl-20011015/slice7.html#hyphenation-keep) – SPREAD and ALWAYS (CSS 4 values of hyphenate-limit-last, equivalent of hyphenation-keep, defined in https://www.w3.org/TR/css-text-4/#hyphenate-line-limits). Follow-up to commit 9574a62add8e4901405e12117e75c86c2d2c2f21 "tdf#132599 cui offapi sw xmloff: implement hyphenate-keep" and commit c8ee0e8f581b8a6e41b1a6b8aa4d40b442c1d463 "tdf160518 DOCX: import hyphenation-keep to fix layout". Change-Id: I3ac6d9e86d0ed1646f105de8607c0e8ebc534eaa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165954 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
13 daysCppunitTest_sw_uibase_shells: turn on set_non_application_font_useMiklos Vajna2-0/+4
Similar to commit dc4d7500c9d283e26d1553ce11366a217cf1f69d (Fix CppunitTest_sd_import_tests-smartart non_application_font_use, 2023-10-23), got rid of 'ＭＳ 明朝' as suggested by the failing assert. Change-Id: I24dcf0bffa8c213f776c0483d53fdee64ff7a413 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165982 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
14 daysCppunitTest_sw_rtfexport2: avoid DECLARE_RTFEXPORT_TESTMiklos Vajna1-565/+1008
No need to go via Writer-specific macros here. Change-Id: I50de20f3199878db2b9fe7e66f09b2620e43cc3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165918 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
14 daystdf#146619 Drop unused 'using namespace' in: sw/Gabor Kelemen65-99/+0
Change-Id: I56463130ab617b0e11e237718cb8456913373818 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165696 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-09tdf#88214 sw: text formatting: adapt empty line at end of para to WordMichael Stahl10-3/+97
For an empty line at the end of an empty paragraph, Writer already uses any existing text attribute in the paragraph, see for example testEmptyTrailingSpans. For an empty line at the end of a non-empty paragraph, Writer text formatting uses only paragraph attributes, ignoring any text attributes, whereas the UI will display the attributes from the text attributes (such as font height) if you move the cursor there. Word uses text attributes also in this case, so adapt the inconsistent Writer behaviour: text formatting now uses text attributes too. Apparently this can be achieved by calling SeekAndChgBefore() instead of SeekAndChg(). Add another compat flag "ApplyTextAttrToEmptyLineAtEndOfParagraph" to preserve the formatting of existing ODF documents. Adapt test document fdo74110.docx, it has a line break with "Angsana New" font. Change-Id: I0863d3077e419404194b47110e4ad2bdda3d11c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165887 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-04-09sw: document SwTextFormatCollsMiklos Vajna1-0/+2
Text is never clear, it means paragraph in this case, since we have SwCharFormats for character styles. Change-Id: Iba21df71053f0b4fbcc0616c024e5cd2972ad44a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165902 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-04-08cid#1596254 Null pointer dereferences in GetSotStorageStreamNoel Grandin1-6/+3
Re-arrange the calling convention to make it obvious that a valid stream is the same as a good (true) result. Change-Id: I974b023a8e7231e70ab649628fdbe43c33001e5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165874 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-04-08Resolves: tdf#154715 don't use last-used field setting when editing fieldCaolán McNamara1-1/+1
If we are inserting a field it makes sense to use the last-used settings, but if we are editing an existing field we naturally want to populate with the current field. Here we have IsRefresh used twice as a condition, one inside the other. But if was true in the outer use, it will also be true in the inner (this duplication exists all the way back to the initial commit) because GetUserData() has no side effect. IsRefresh is only true during EditNewField (which is the case of using the "next/back" button to go to edit another field). So even before this change if you click next and then back (assuming there is another field to move to) then you then get the right results Skip restoring the last-used settings in the EditField case, replace the outer !IsRefresh() with !IsFieldEdit() Change-Id: I4224302171d2e8d02a0f1e0efc9fdada5ada9d7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165876 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-24 04:14:35 +0000