Age | Commit message (Collapse) | Author | Files | Lines |
|
- handle the picture case in SwWrtShell::InsertContentControl(): insert
a placeholder bitmap & create content control around the as-char image
- expose this as a new .uno:InsertPictureContentControl command
- add the new uno command to the default & MS-compatible menus
- rename the SwWrtShell::Insert() overload taking a Graphic to make this
a bit more readable
Change-Id: I289d6b6a9cd622c585b6cf0ec0c91d6b51ad81ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134681
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Crashreport signature:
Fatal signal received: SIGSEGV code: 1 for address: 0x0
program/../program/libswlo.so
SwPageFrame::GetPageDesc() const
sw/source/core/inc/pagefrm.hxx:144
program/../program/libswlo.so
SwHeaderFooterWin::IsEmptyHeaderFooter() const
sw/source/uibase/docvw/HeaderFooterWin.cxx:403
program/../program/libswlo.so
SwHeaderFooterWin::ShowAll(bool)
sw/source/uibase/docvw/HeaderFooterWin.cxx:273
program/../program/libswlo.so
SwFrameControl::ShowAll(bool)
sw/source/uibase/inc/FrameControl.hxx:49
Change-Id: I3c1a6f46c7a15c2ca1a3db69a14d49abbea8c879
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134656
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Map Picture UNO property on content controls to:
<w:sdt>
<w:sdtPr>
<w:picture/>
...
And do the opposite on import.
Change-Id: I5b164f796f194f5fc4bb30d7a30e053e577ed92d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134657
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
off by default, since each warning needs careful inspection
Change-Id: I805c1d1cdde531a1afdc76e87b22f879fc3c9753
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134641
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
As a step toward internal UI labeling consistency, this patch
focused on dialogs, menus, toolbars that involve OLE Objects,
which can be defined as embedded objects that use
the Properties dialog in sw/uiconfig/swriter/ui/objectdialog.ui.
One reason for the change is to distinguish these objects from the
generic term "object", which is also used for Shapes and Textboxes.
The label "Object" is changed to "OLE Object", where appropriate,
which will align the menu and dialog labels with the one that
appears in Navigator and Toolbar. Also changed "Objects" to
"OLE objects" for the Statistics field.
Changed "OLE-object" to "OLE Object" - again for consistency.
Changed "Type" tab label to "Position and Size" in Object Dialog,
to keep consistency with tdf#138844
Change-Id: Iba54c30fd83489631a9be546d6efc9365bdbefd3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134186
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
|
|
Change the Tab label in Image Properties dialog.
"Type -> "Position and Size"
To keep consistency in appearance across related dialogs,
made same change for the Frame dialog in this patch, and
for Object dialog in
https://gerrit.libreoffice.org/c/core/+/134186
Change the Tab label in Image Properties dialog.
"Image -> "Rotation"
Not found in the related dialogs.
Change-Id: I57a3fbd45f84513e55e71896a141201bef000507
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134189
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
|
|
For redlines, typically DocumentContentOperationsManager::InsertString()
will insert text, and it explicitly removes any redlines on the text
that has been inserted, hence it is always visible - so effectively the
sw::MergedPara is updated correctly.
However for fieldmarks the situation is different, if the insertion
happens inside of the part that is hidden in the layout, then it must
not be inserted into the sw::MergedPara.
Try to figure out which part(s) of a fieldmark the insertion position is
in and ignore the inserted text as appropriate in
SwTextFrame::SwClientNotify().
Change-Id: Ic5066b20e9609f50438ca64ac7d2cbd09baeef23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134611
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
Apparently it happens when loading a 0-byte file that the
SfxObjectShell is still in IsLoading() stage when close() is called.
This then causes the SfxEventHintId::LoadFinished event to be emitted
during close(), which is not a situation the assert was intended for.
Change-Id: I60a260ca1c1e6cbf9502832ba6622de2628763e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134610
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
Change-Id: I22b582ed88d43ef5299443914dd28b8db61d1b70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134639
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Rename, delete, move up & move down does nothing initially, disable the
buttons when their event handler would just do an early return to make
this less confusing.
Change-Id: I4cfb9750d07b4686440c05901ef72e8ce4de961e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134538
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Previous content control types (rich text, checkbox, dropdown) had the
cursor somewhere in the content control and click selected the content
control in the placeholder case.
The picture case is somewhat different: the content control has a single
as-char image, and by the time SwWrtShell::GotoContentControl() is
invoked, the picture frame is already selected.
All we have to do here is to trigger the file picker to select a
replacement and then insert that image to replace the already selected
frame's bitmap.
Change-Id: Id3ad94ed8f7e13b0ebc2f57327bb8c0b1e374a86
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134511
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Seems original problem is no longer reprodicible with recent builds
but ovewriting of numbering style params with inline values leads
to another problems.
Removing this mechanics do some impact on RTF filter: it tries to
modify numbering styles, so this was also corrected. It is not ideal
yet but looks better in support numbering char properties different
from paragraph ones.
This reverts commit 2123ede032ca64f696ef54af4ad3238974ca2b5d.
Change-Id: If8c79d6191de13b2f09c128b59d17efcfdb1a4ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133877
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Left-aligned group shape was synced to the textbox, resulting
jumbled positions after DOCX export/import. To fix it,
set horizontal orientation of the textbox back to NONE.
Regression from commit 2951cbdf3a6e2b62461665546b47e1d253fcb834
"tdf#143574 OOXML export/import of textboxes in group shapes".
Change-Id: I02ee79862344f3495846091e3eef27c24d8ef162
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134149
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Change-Id: Ie90f36439bb6ca23c45d1b75494ec1955b35513f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134531
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I8d836c4a919056e8b600549f82b0d5dee9ab1a47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134536
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
On save LO was just emitting w:lvlOverride to actual level
where override does happen. But MS Word won't accept override
for next level if there are no overrides for previous ones.
For example, if we are overriding level 3 we should also emit
empty lvlOverride for levels 0-2.
Provided fix did cause some problems on DOCX import: overrides
were applied to current level, but in this context current !=
actual level where override did happen.
Change-Id: Ia00dd9a5990f7f122027e8126f411642c32da189
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134411
Tested-by: Jenkins
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
- Fix logic problem for the last element.
- Some glyphs may be made of many sal_Unicode ( ex. Unicode IVS ),
take care ( fix ) of the following case
a) 1 as the second glyph
b) n-1 as the previous glyph.
c) nCnt-1 as the last glyph.
- Move the code to justify.cxx and its own namespace.
Change-Id: Ice2236a54e8290a489fb2d887a326ccc4768213e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134243
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
|
|
Change-Id: I7c0be7b435d6b5f97bdd40484023584146638d70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134506
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ia5dfb07e2c3e980f6fd8664f648ef96aa2c0d345
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134501
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
It was added in 7d20dc2ca69711c61fb1593ad85ccdef282c978d
"sw: fix assert in SwObjectFormatterTextFrame"
and it contains more than 300kbs of images which are
not needed
Change-Id: Ib2599baf7b83f83cba45492eccf1f5704aea39e5
Change-Id: I7ecdd5ba7e1251ed334924a3f75f275415d298e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134491
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Commit b17180a84cb4561b8a7bbf9e2281c91fffd56f87 (write out image size in
html export for 'keep ratio' images, 2021-06-29) changed the sw HTML
export to write the layout size of images in case one dimension is "keep
ratio" and the other is some more concrete value.
This is useful in case that other dimension is a fixed value, because
"keep ratio" on the UI only means to keep the ratio as the size changes,
it does not mean that the ratio will be the original ratio of the
bitmap. However, it's problematic to write this layout size of the "keep
ratio" dimension when the other dimension is relative, as this will mean
the image's aspect ratio will change if the user resizes the browser
window.
Fix the problem by extending the way we write the "height" and "width"
of fly frames:
1) Write a percentage in case of relative sizes
2) Write an explicit "auto" (or just omit the attribute in XHTML mode)
in case the size is "keep ratio" and the other dimension is a
relative size
3) Write the layout size in other cases (fixed size or "keep ratio", but
the other dimension is a fixed size)
Note that HTML itself has no concept of relative sizes where 100% is not
the parent's size (e.g. page, not paragraph) and also has no concept of
keeping an aspect ratio which is not the aspect ratio of the bitmap, so
those cases remain unchanged.
Change-Id: Ic5c7dc4d697160eff81e960a2f7d335fb78ab7c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134482
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: Ie5d62eaec01a3b06ff1bd6070510384641ea7ad3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134483
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
sw/source/core/layout/objectformattertxtfrm.cxx:237: virtual bool SwObjectFormatterTextFrame::DoFormatObj(SwAnchoredObject&, bool): Assertion `GetPageFrame().GetPhyPageNum() == GetPgNumOfCollected(nIdx)' failed.
The problem is that there are multiple (9) flys on text frame 324.
In the loop in CalcContent(), frame 324 starts out on page 13, then
with the first/second fly moves to page 12, then with the 3rd fly moves
forward to page 13 - but the pPageFrame that is passed to
SwObjectFormatter::FormatObj() was fetched outside of the loop.
(regression from commit c799de145f7e289f31e3669646e5bd12814e6c5e
and commit 533a998e540b0f04068c876dde0e74adc3f79c93)
Change-Id: Iae573900b4b6558634bfed161e5c95bd5ba27151
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121924
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
The assert(pMerged->pFirstNode->GetIndex() <= i) is intended for when
frames are really deleted, but CheckParaRedlineMerge() calls it while
the now-outdated MergedPara is still on the frame, but the nodes already
have new flags; assign a dummy node in this situation.
Change-Id: I23fbfdb6901e6e15abf92913aa252e59877bc280
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134475
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
How could i forget that MovePara(GoCurrPara, fnParaStart) will move to
a previous paragraph when it's already at the start of the current one,
it's so intuitive.
(regression from commit d814941b31b4f9cc8b6e9bd4ddc5188015529707)
Change-Id: Ief9bcd42b7ea78feef50ac42bc93580c29c080b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134468
Tested-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
As described in bugs tdf#65067, tdf#103816, tdf#149052 and a few other duplicates, Formula objects in Writer receive 2 unnecessary spacings:
1) From the "Formula" frame style, which has a Left/Right internal spacing of 0.2cm
2) From the Math formula editor itself, that adds an additional 1pt of internal spacing (left/right)
In MS Word the default behavior is setting all of these spaces to zero, which makes the formula flow better alongside text in paragraphs.
Therefore, this patch set both of these spaces to Zero so that Formula objects in Writer behave similarly as Formulas in MS Word.
Change-Id: Iedcef7124afed6b799f85bcefe37016c8fd972e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134185
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
This is meant to be a content control (providing rich text), which is
also a picture placeholder field.
Add a new Picture property to track this type, this way the click
handler will be able to present a file picker when showing the
placeholder.
Change-Id: Ibbd3720fc94d0f17654ec813821d218166c76424
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134457
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
How it interacts with SwCursorShell::MoveTable() is far from trivial.
Change-Id: I04c9123c0b39192df43fe32984d66852102ebd1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134410
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I943a7696fd896c8709fdcd25bce650dd80244daf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134367
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Ieb6d04e344b1d875f2661833e17f64930681e528
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134366
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Modify is really similar to insert, just we pre-fill the list item
properties dialog with old data.
Also allow moving items up / down, and eliminate a not needed frame in
the inner dialog, which would assert when using the gen backend.
With this, the content control dialog is quite complete for dropdowns.
Change-Id: I26e77dd881f0a0eea44d2a6137f76fd29ab32fc5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134405
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Make the keyboard accelerators in the Statistics tab of the
File - Properties dialog select the text of the fields that they label.
Change-Id: I61a93e227ed1e457355dc971dc4864ab4419a770
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134358
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Id586e015e42c23aa455d6f1a5dc42fbda492d2a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134381
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
Change-Id: I8303cd8d2cabd8888797758870480483661d8801
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134391
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Jenkins
|
|
- add a weld::TreeView to show existing display name - value pairs
- add a button to add a new list item, together with a new
SwContentControlListItemDlg to specify the list item properties +
write the changed list back to the doc model
Change-Id: I9243be84eb0af65437eccfb48c6780787609bc68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134379
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
... SwWW8FltRefStack and SwWW8ReferencedFltEndStack
See tdf#94879 for motivation.
Change-Id: I93ac7230bc383433d7232c5d14ed98339620316f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134380
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Libc++ debug has a feature that randomizes equal elements during
sort, which normally wouldn't make a difference, but some tests
rely on specific order of tested data. The ones failing without
this include:
CppunitTest_sw_ooxmlexport testMsoPosition
CppunitTest_sw_xhtmlexport testTdf66305
CppunitTest_sw_ww8export testCommentExport
Change-Id: Id49846939a264150cc82091718ffe6b904d7130e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134337
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: Id7a7b845e0255086eb877d21699ddb0b80cc47c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134335
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
complete warning log:
<SwTextFormatColl::GetAssignedOutlineStyleLevel()> - misuse of method
part of bt when opening attachment of tdf#149072
0 SwTextFormatColl::GetAssignedOutlineStyleLevel() const (this=0x77064d0) at sw/source/core/doc/fmtcol.cxx:608
1 0x00007f8a52aa7941 in sw::(anonymous namespace)::HeaderCheck::check(SwNode*) (this=0xa457630, pCurrent=0x7705e98) at sw/source/core/access/AccessibilityCheck.cxx:622
2 0x00007f8a52a9a6a3 in sw::AccessibilityCheck::check() (this=0x7ffe4a14ab10) at sw/source/core/access/AccessibilityCheck.cxx:947
3 0x00007f8a53ed2ad7 in SwDocShell::runAccessibilityCheck() (this=0x74ef0e0) at sw/source/uibase/app/docst.cxx:1559
4 0x00007f8a16e7fdec in ImpPDFTabDialog::OkHdl(weld::Button&) (this=0xa0e9990) at filter/source/pdf/impdialog.cxx:324
5 0x00007f8a16e7fb2d in ImpPDFTabDialog::LinkStubOkHdl(void*, weld::Button&) (instance=0xa0e9990, data=...) at filter/source/pdf/impdialog.cxx:317
Change-Id: I2ed50f14eff01babd47ada3831c0a051fc767dbe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134312
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
shaves 2% off load time
Change-Id: I5bd4eabf61205df21a27d2822acd2676a7732a3d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134315
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I2f9f38ae79f0f05b42e6f209d504c5f8a5896ed3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134182
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: Ibd33fe5c5168850eca1bdc7242afc38ed08b5fa2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134289
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
- read the doc model: show if a content control is a placeholder or not
- work with a shared pointer in the dialog, which avoids lifetime issues
in case the content control we edit in one view gets deleted in an
other view
- write the doc model: set the placeholder mode of the content control
based on the checkbox state and mark the doc as modified if any widget
is touched when pressing OK
- handle command state: allow this dialog only inside content controls
Change-Id: Ie0b9075ccd3450dd403cc7f8bbf93fc04de3b234
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134278
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
and use it where possible
Change-Id: I3efc7a642f73661ce606c917c0323ba9948521c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134265
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
- expose the available list items in a new "items" key of the
LOK_CALLBACK_CONTENT_CONTROL callback
- add a new lok::Document::sendContentControlEvent() function to be able
to select a list item from the current drop-down
- add a new listbox to the gtktiledviewer toolbar to select a content
control list item when the cursor is inside a dropdown
- add tests for the array API of tools::JsonWriter
Change-Id: I47f1333a7815d67952f7c20a9cba1b248886f6dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134256
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
(CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
2022-04-07) for motivation.
Change-Id: Ie52b96e1d7a5e5e2d55d9f68f7756e21b86ea9b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134249
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
1. SwTextSizeInfo::GetHangingBaseline() calls SwFont::GetHangingBaseline() to obtain the hanging baseline value. Only CTL script handled, it always return 0 for other two scripts. Eventually Outdev::GetFontMetric() and TextMetric::GetHangingBaseline() are called to obtain the hanging baseline value from vcl.
2. SwTextFormatter::CalcAscent() sets the baseline value for the portion via SwTextSizeInfo::GetHangingBaseline().
3. SwTextFormatter::InsertPortion() sets the maximum baseline value for the whole line.
4. SwTextCursor::AdjustBaseLine() calculates the new baseline in case hanging baseline is available.
Change-Id: I1aae7a34dfc953227b7873fc8e3af5cc7e2fbbff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133668
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
|
|
- make sure the DOC/RTF export doesn't write the dummy char as-is
- let "enter" only insert a linebreak while inside a content control, to
ensure that the starting and ending dummy char stays inside the same
text node
- let deletion of the dummy character at the end behave the same as the
start dummy character: if trying to delete that single character, then
just move the cursor, don't delete it
- reject document insertion in the middle of a content control, similar
to input fields
Change-Id: I9b54ef50261e6b17f38eadadacfe1e1111199e96
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134239
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Crashreport signature:
SwDrawShell::Execute(SfxRequest&) [clone .cold]
include/svx/svdhdl.hxx:194
SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool)
sfx2/source/control/dispatch.cxx:255
which is a bit tricky to read (probably due to LTO), but what happens
here is that the handle index is user input and we look at index up in a
list without error handling.
This is a problem since commit 7eed711a6115bf892c998cbd73a2c5b706c6f99d
(Extended MoveShapeHandle command for Anchors as well, 2021-05-24),
which assumed that handle indexes and the handle list can't get out of
sync.
Fix the problem similar to what commit
48beccf52413981d3d1c525a81a2c57048abe261 (sw: fix crash in
SwView::Execute(), 2021-09-03) did at SID_MOVE_SHAPE_HANDLE handler for
Writer images (this one is for Draw shapes).
This fix just makes sure we don't crash, there may be some deeper reason
why the handle index is out of sync with the handle list in the first
place.
Change-Id: I8f3a25d74082984cedce09362a690f24d7236ba6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134216
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
- introduce a SwContentControlListItem::ToString() that tries to use the
display text of the list item, otherwise falls back to its value and use it
while building the dropdown widget and when inserting selected list item
- handle the dropdown case in SwWrtShell::InsertContentControl()
- expose this as a new .uno:InsertDropdownContentControl command
- mention the new and all previous content control commands in the
MS-compatible forms menu as well
Change-Id: I075f77933c1466b5258357d5a661e173c34de34f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134215
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|