path: root/sw
AgeCommit message (Collapse)AuthorFilesLines
7 hourstdf#138209 ODF export: work around forms problem in LO < 7.0Michael Stahl2-2/+4
LO without commit 519d96fd8b83ef4c61576d87b58f97b7e6e6e3c6 makes a mess when storing form documents it has loaded from ODF 1.3 documents: the XML parts are stored as ODF 1.2, but the storage (and therefore manifest entry) keeps version 1.3. To avoid this, store form documents as ODF 1.2 extended by default. Unfortunately a bunch of ODF export code accesses the global SvtSaveOptions variable; with this version override, only SvXMLExport::getSaneDefaultVersion() must be used. Change-Id: I5fa8e286f5103c578ed0d93da07a8a6cbe2f0ddd Reviewed-on: Tested-by: Jenkins Reviewed-by: Michael Stahl <>
13 hourstdf#141613 sw: avoid possible crash when undoing header creationDaniel Arato (NISZ)2-3/+6
Move the ClearRedo() call to the very end of the undo process in order to avoid heap use after free. We still need to call ClearRedo() because there's no mechanism in place to Redo a header/footer change. Regression from commit 65e52cb61d74b0c71b45b63b2da131bc6b621104 "tdf#141613 sw: fix crash at header/footer undo". Change-Id: Ibd4604379c9791e85aef3d4dc6c29c9e3ecd5a28 Reviewed-on: Tested-by: László Németh <> Reviewed-by: László Németh <>
14 hourstdf#142130 sw track changes: fix crossing out of neighboring imagesLászló Németh5-7/+82
Normal images got crossing out from the next deleted images. Fix it by using only the start position of the image in CheckLine() instead of the 1-character length range of the anchor point. Note: add unit test also for tdf#78864. Follow-up to commit d845b91bcc6eb885c55494d4d4fab4ec09577e1d (tdf#78864 sw track changes: cross out deleted images). Change-Id: I8894e625d479adea4b1003f55f24f292064ed7ba Reviewed-on: Tested-by: Jenkins Reviewed-by: László Németh <>
17 hourssw: prefix members of SwAutoStylesEnumImpl, SwXRedline, ...Miklos Vajna5-56/+56
... SwXRedlineEnumeration and SwXRedlineText See tdf#94879 for motivation. Change-Id: I58a7077522264856e84ae53fe9134509b6640690 Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins
18 hourssw: test fix of tdf#140731 (freezing with track changes)Balazs Santha1-0/+57
Follow-up to commit e463d239555d3a4dc61797eeb8c638b6442112a3 "tdf#140731: sw transliteration: avoid too many redlines" Change-Id: I49d80d6fa5744797b7bb56d470ebc6f3b5f898d2 Reviewed-on: Tested-by: László Németh <> Reviewed-by: László Németh <>
18 hourstdf#120761: sw_ww8import: fix typo in unittestXisco Fauli2-1/+1
Change-Id: Ia8fef7dea598cd2ea1513908f69e0176c057900b Reviewed-on: Tested-by: Jenkins Reviewed-by: Xisco Fauli <>
41 hoursclang-tidy Undefined or garbage value returned to callerNoel Grandin1-2/+2
[clang-analyzer-core.uninitialized.UndefReturn,-warnings-as-errors] Change-Id: Idc8f2f4a3189a3a65c95740a12387d5df7c0bea6 Reviewed-on: Tested-by: Jenkins Reviewed-by: Noel Grandin <>
2 daysref-count SfxItemPoolNoel Grandin5-16/+8
so we can remove SfxItemPoolUser, which is a right performance hog when we have large calc spreadsheets Change-Id: I344002f536f6eead5cf98c6647dd1667fd9c8874 Reviewed-on: Tested-by: Noel Grandin <> Reviewed-by: Noel Grandin <>
3 dayssimplify SwAttrPool codeNoel Grandin2-41/+2
Change-Id: I1bf94fb65f75e80641df7485b228bd1c80870482 Reviewed-on: Tested-by: Jenkins Reviewed-by: Noel Grandin <>
3 daystdf#138518 sw: layout: unbreak fdo80206-1.docMichael Stahl1-1/+1
The 7 flys on the para on page 3 create ~15 extra pages with one paragraph each. Argh! One of the bPageHasFlysAnchoredBelowThis checks was inverted. How dumb of me. (regression from c799de145f7e289f31e3669646e5bd12814e6c5e) Still doesn't look good but now it looks same as in 7.0. Change-Id: Ib10c46f48746362d8d679c147ddc8b85157be508 Reviewed-on: Reviewed-by: Michael Stahl <> Tested-by: Jenkins
4 dayscid#1401328 Uncaught exceptionCaolán McNamara1-3/+3
and cid#1401334 Uncaught exception Change-Id: I609ec44bf28db28e69533d7b795f705fa8a330f1 Reviewed-on: Tested-by: Jenkins Reviewed-by: Caolán McNamara <>
4 daystdf#138518 sw: layout: fix assert on ooo43913-1.docMichael Stahl3-13/+19
Assertion `rAnchoredObjPage.GetPhyPageNum() == _nFromPageNum' failed. Because not only the fly's anchor frame moves forward in FormatAnchorFrameForCheckMoveFwd(), but also the fly itself, apparently because it's in a table: 0 SwAnchoredObject::SetPageFrame(SwPageFrame*) (this=0x5a1d3d8, _pNewPageFrame=0x8cfbeb0) at sw/source/core/layout/anchoredobject.cxx:162 1 SwPageFrame::MoveFly(SwFlyFrame*, SwPageFrame*) (this=0x8cbd8c0, pToMove=0x5a1d280, pDest=0x8cfbeb0) at sw/source/core/layout/flylay.cxx:985 2 lcl_ArrangeLowers(SwLayoutFrame*, tools::Long, bool) (pLay=0x8cf80c0, lYStart=179488, bInva=false) at sw/source/core/layout/tabfrm.cxx:5000 3 SwCellFrame::Format(OutputDevice*, SwBorderAttrs const*) (this=0x8cf80c0, pAttrs=0x8ce78c0) at sw/source/core/layout/tabfrm.cxx:5359 4 SwLayoutFrame::MakeAll(OutputDevice*) (this=0x8cf80c0) at sw/source/core/layout/calcmove.cxx:1036 5 SwFrame::PrepareMake(OutputDevice*) (this=0x8cf80c0, pRenderContext=0x5b7fcf0) at sw/source/core/layout/calcmove.cxx:375 6 SwFrame::Calc(OutputDevice*) const (this=0x8cf80c0, pRenderContext=0x5b7fcf0) at sw/source/core/layout/trvlfrm.cxx:1792 7 SwFrame::MakePos() (this=0x8cebdb0) at sw/source/core/layout/calcmove.cxx:627 8 SwTextFrame::MakePos() (this=0x8cebdb0) at sw/source/core/text/frmform.cxx:340 9 SwContentFrame::MakeAll(OutputDevice*) (this=0x8cebdb0) at sw/source/core/layout/calcmove.cxx:1412 10 SwFrame::PrepareMake(OutputDevice*) (this=0x8cebdb0, pRenderContext=0x5b7fcf0) at sw/source/core/layout/calcmove.cxx:286 11 SwFrame::Calc(OutputDevice*) const (this=0x8cebdb0, pRenderContext=0x5b7fcf0) at sw/source/core/layout/trvlfrm.cxx:1792 12 SwTextFrame::CalcFollow(o3tl::strong_int<int, Tag_TextFrameIndex>) (this=0x5ae2c60, nTextOfst=...) at sw/source/core/text/frmform.cxx:279 13 SwTextFrame::AdjustFollow_(SwTextFormatter&, o3tl::strong_int<int, Tag_TextFrameIndex>, o3tl::strong_int<int, Tag_TextFrameIndex>, unsigned char) (this=0x5ae2c60, rLine=..., nOffset=..., nEnd=..., nMode=1 '\001') at sw/source/core/text/frmform.cxx:611 14 SwTextFrame::FormatAdjust(SwTextFormatter&, WidowsAndOrphans&, o3tl::strong_int<int, Tag_TextFrameIndex>, bool) (this=0x5ae2c60, rLine=..., rFrameBreak=..., nStrLen=..., bDummy=false) at sw/source/core/text/frmform.cxx:1166 15 SwTextFrame::Format_(SwTextFormatter&, SwTextFormatInfo&, bool) (this=0x5ae2c60, rLine=..., rInf=..., bAdjust=false) at sw/source/core/text/frmform.cxx:1613 16 SwTextFrame::Format_(OutputDevice*, SwParaPortion*) (this=0x5ae2c60, pRenderContext=0x5b7fcf0, pPara=0x8d07490) at sw/source/core/text/frmform.cxx:1720 17 SwTextFrame::Format(OutputDevice*, SwBorderAttrs const*) (this=0x5ae2c60, pRenderContext=0x5b7fcf0) at sw/source/core/text/frmform.cxx:1910 18 SwContentFrame::MakeAll(OutputDevice*) (this=0x5ae2c60) at sw/source/core/layout/calcmove.cxx:1525 19 SwFrame::PrepareMake(OutputDevice*) (this=0x5ae2f80, pRenderContext=0x5b7fcf0) at sw/source/core/layout/calcmove.cxx:321 20 SwFrame::Calc(OutputDevice*) const (this=0x5ae2f80, pRenderContext=0x5b7fcf0) at sw/source/core/layout/trvlfrm.cxx:1792 21 SwObjectFormatterTextFrame::FormatAnchorFrameAndItsPrevs(SwTextFrame&) (_rAnchorTextFrame=...) at sw/source/core/layout/objectformattertxtfrm.cxx:905 22 SwObjectFormatterTextFrame::FormatAnchorFrameForCheckMoveFwd() (this=0x8ce5720) at sw/source/core/layout/objectformattertxtfrm.cxx:919 23 SwObjectFormatterTextFrame::DoFormatObjs() (this=0x8ce5720) at sw/source/core/layout/objectformattertxtfrm.cxx:368 24 SwObjectFormatter::FormatObjsAtFrame(SwFrame&, SwPageFrame const&, SwLayAction*) (_rAnchorFrame=..., _rPageFrame=..., _pLayAction=0x0) at sw/source/core/layout/objectformatter.cxx:160 25 SwContentFrame::CalcLowers(SwLayoutFrame&, SwLayoutFrame const&, long, bool) (rLay=..., rDontLeave=..., nBottom=192048, bSkipRowSpanCells=true) at sw/source/core/layout/tabfrm.cxx:1534 26 lcl_RecalcRow(SwRowFrame&, tools::Long) (rRow=..., nBottom=192048) at sw/source/core/layout/tabfrm.cxx:1653 27 SwTabFrame::MakeAll(OutputDevice*) (this=0x8cf5f80, pRenderContext=0x5b7fcf0) at sw/source/core/layout/tabfrm.cxx:2425 It looks like the _nFromPageNum is always from the SwObjectFormatter::mrPageFrame anyway because that's a precondition of the mpPgNumAndTypeOfAnchors->Collect() being called, so just rely on that to get the correct page. (regression from c799de145f7e289f31e3669646e5bd12814e6c5e) Change-Id: Ibdffb2121cffbc04320d17a29ab2e160dec4250b Reviewed-on: Tested-by: Jenkins Reviewed-by: Michael Stahl <>
4 daysadd missing truncate-multiline propertiesCaolán McNamara1-0/+1
Change-Id: Idbb227185806f97e00e99faa88a3fc6818e75513 Reviewed-on: Tested-by: Jenkins Reviewed-by: Caolán McNamara <>
4 daysloplugin:unusedmethodsNoel Grandin3-44/+0
plugin code needed some updating because it was interacting badly with PCH code in pluginhandler::ignoreLocation Change-Id: I228f94a4e285747bd1d5b8536010f8617118cafa Reviewed-on: Tested-by: Jenkins Reviewed-by: Noel Grandin <>
4 daysadd SfxItemPoolDeleter utilityNoel Grandin4-8/+7
add use so we can hold the pool with std::unique_ptr Change-Id: I685fbc37c0ae145a5b48a66a88eab9fb29a0fc0b Reviewed-on: Tested-by: Jenkins Reviewed-by: Noel Grandin <>
4 daystdf#126226: sw: Add UItestXisco Fauli2-0/+29
Change-Id: Id236fa585ae02cb0282a7d6179b9cb2d779dfdf8 Reviewed-on: Tested-by: Jenkins Reviewed-by: Xisco Fauli <>
5 daystdf#128913 DOCX: import track changes of inline imagesLászló Németh2-0/+8
Deleted images were imported as not deleted part of the document. Both deleted and inserted images lost their change tracking. Change-Id: Ia273d307d01c5ea535889bc9951084e96cd7fc50 Reviewed-on: Tested-by: László Németh <> Reviewed-by: László Németh <>
5 daystdf#121659 DOCX import: fix lost column break at shapesAttila Szűcs2-0/+14
The column break was moved into the neighboring shape during the first import, and eliminated during the second import, losing the 2-column text layout. As a workaround, split the paragraph moving the column break into a new paragraph. Based on the patch written by Justin Luth. Co-authored-by: Justin Luth and Tibor Nagy (NISZ) Change-Id: Id4042a92b09aa55952bc0ea02319d5e588f77d3b Reviewed-on: Tested-by: László Németh <> Reviewed-by: László Németh <>
5 daysuse Label::set_label_type to designate a label as a warning/errorCaolán McNamara2-3/+1
To be consistent with other cases. weld::LabelType::Error is another option. What colors, if any, it results in isn't cast in stone, but be consistent in that all warnings (or errors) use the same ones. Change-Id: I6943aa6370cf6cead60cd404987e8211532143eb Reviewed-on: Tested-by: Jenkins Reviewed-by: Caolán McNamara <>
5 daysFix typosAndrea Gelmini2-2/+2
Change-Id: Ibc86f8a76080b55dd7c5a458e2b8fa7ce534a4b3 Reviewed-on: Tested-by: Jenkins Reviewed-by: Michael Stahl <>
5 daysReplace magic numbers in SwPageFrame::UpdateAttr_()Miklos Vajna1-9/+9
By using the same SwPageFrameInvFlags constants that SwPageFrame::SwClientNotify() already does. Change-Id: Ic07ce518901890367ce95080bf2a588697b8990b Reviewed-on: Tested-by: Jenkins Reviewed-by: Miklos Vajna <>
5 daysloplugin:constmethodNoel Grandin2-2/+2
Change-Id: I7913fd8144d521b8293ac43036d0fad82e457cd1 Reviewed-on: Tested-by: Jenkins Reviewed-by: Noel Grandin <>
5 daystdf#142080 sw: layout: fix infinite loop in CalcContent()Michael Stahl3-5/+25
On page 9, SwSectionFrame::Format() calls CalcContent() and that formats all its content frames, then on SwTextFrame 91 SwObjectFormatter::FormatObj() fails becuase it moved forward. With commit c799de145f7e289f31e3669646e5bd12814e6c5e this now sets the o_rbPageHasFlysAnchoredBelowThis to true, which prevents a call to SwLayouter::InsertMovedFwdFrame(), and the flys anchored in next frames aren't moved off the page at this time. Then the loop starts over at the beginning of the SwSectionFrame, and frame 91 will be formatted again because the loop tries to format the first frame on the next page to see if it will move back; now the MoveBwd() isn't prevented any more so the result is the same failure in SwObjectFormatter::FormatObj(). Fix this by ignoring the bRestartLayoutProcess in case the current frame was originally on the next page and didn't move back (or, as is the case here, moved back and then forward again); it should just be formatted again on the next page. Once that happens, it will eventually be entered into SwLayouter::InsertMovedFwdFrame() too. This happens to fix another problem with this bugdoc too: the first column of the section on page 9 is empty. This also happens in LO 6.4 but not LO 6.1. An alternative would be to move the flys anchored below off the page as is done in SwLayAction::FormatContent() now but sections can be in flys or footnotes or headers so perhaps it should be done only at the top-level. (regression from c799de145f7e289f31e3669646e5bd12814e6c5e) Change-Id: I0965aebb4e3cec687f4e70f8d5e3aa8a55da3393 Reviewed-on: Tested-by: Jenkins Reviewed-by: Michael Stahl <>
6 daystdf#141935 svx cui: apply line cap setting of line stylesLászló Németh1-0/+102
Only line dash pattern of the selected line style was applied on the selected line or shape using the 1) Line Style popup menu of Drawing toolbar and sidebar pane Properties and 2) Style popup menu of Line pane of Line setting dialog window. Now both line dash and line cap settings are applied, supporting the usage of the new "rounded" preset styles and the old not "rounded" versions. Follow-up to commit b9b2c6a98fec798fc0ec76ec3cd407724f19dcac "tdf#141933 add preset dash styles with round cap". Change-Id: Ib3f64afcdcb50545166d40476a03a4b45f7d0b8a Reviewed-on: Tested-by: László Németh <> Reviewed-by: László Németh <>
6 daystdf#141933 add preset dash styles with round capLászló Németh2-3/+31
New OOXML-compatible preset styles weren't recognized on the UI, including the Drawing Object Properties toolbar and Line Style settings, if the preset styles use round cap, e.g. line styles with dot-like dots (i.e. not tiny squares as dots). As a workaround for interoperability and access to the line styles with dot-like dots, add "Rounded" version for every OOXML-compatible preset styles with round cap. This allows to apply dot-like dotted lines to new shapes, too. Background: round cap modifies the DotLen and DashLen values of the LineDash struct during the OOXML import, using ~zero values to get dot-like dots. For the details, see commit 3f3b50015e4fd9efc3459612a70409fca49cf390 "tdf#134053 tweak dash and space length for ooxml" and commit 24d770799660d3ec94ee7add435645794426042b "tdf#134128 Use Gdiplus::DashCapRound for round dash or dot". Follow of commit 183c06fc02a50fb117bb6162e4d6e56cdd34fad1 "tdf#139301 fix OOXML-compatible preset dash styles". Change-Id: I4f3173579964b2c00618ada475b012c85320f758 Reviewed-on: Tested-by: László Németh <> Reviewed-by: László Németh <>
6 daysIntroduce SwPageFrameInvFlags to replace magic numbers in ...Miklos Vajna2-22/+38
... SwPageFrame::SwClientNotify() SwPageFrame::UpdateAttr_() is not yet updated to produce these. Change-Id: Id45162b11ca9bf60f0f0ae43fc22cc2086e0fd67 Reviewed-on: Tested-by: Jenkins Reviewed-by: Miklos Vajna <>
6 daystdf#140969 Select in Navigator all document selected drawing objectsJim Raykowski2-14/+39
when in Drawing objects content navigation view Change-Id: If5d78453f36f035a93936490ab8c2cd4223f1feb Reviewed-on: Tested-by: Jenkins Reviewed-by: Jim Raykowski <>
6 daystdf#138782 DOCX import: fix frame positions of old docsAttila Bakos (NISZ)2-0/+16
by limiting AddFrameOffsets compatibility option for docs created by MSO 2010 or older. Likely regression from commit 355d25eac764713f4d52eac801ade6e2ff1deab0 (n#779627: added quite some compat options from the ww8 filter on writerfilter). This patch fixes several bugs, which were collected as duplicates by Gábor Kelemen. Change-Id: I106e90c4bf00bb0b6a8986615cb3ad9c4828d5b3 Reviewed-on: Tested-by: László Németh <> Reviewed-by: László Németh <>
6 daystdf#69635 DOCX: export hidden (shared) headers/footersDaniel Arato (NISZ)14-48/+145
Exporting to .docx used to lose all header and footer content that was not visible in the document at the moment of saving. This commit forces the DocxExport class to output all headers and footers even when the "Same content on left and right pages" option is turned on. Change-Id: I6a52f216f1e1b386d887ec614198766670b5bce3 Reviewed-on: Tested-by: László Németh <> Reviewed-by: László Németh <>
6 daystdf#141945 sw: layout: check master frame when moving fly forwardMichael Stahl2-2/+6
The problem is that in the finished layout the fly frames are positioned on the first page but are in SwPageFrame::m_pSortedObjs of the second page. Don't use FindPageFrameOfAnchor() because that looks up the follow-frame that contains the anchor position. This was unintentional; the idea was to get flys anchored in subsequent paragraphs out of the way. This situation where it's on a follow-frame of the same paragraph is more complicated and less obvious, so don't try to solve it now. (regression from eb85de8e6b61fb3fcb6c03ae0145f7fe5478bccf) Change-Id: Ic6809a43c467955368807ccc82a7873c29fbfc2e Reviewed-on: Tested-by: Jenkins Reviewed-by: Michael Stahl <>
6 daystdf#141613: sw_uiwriter3: fix unittestXisco Fauli2-13/+31
The original test added in sw/qa/uitest/writer_tests7/ doesn't fail without the fix in place. While at it, move the UItest to CppUnittest Change-Id: I254c4ed042b14adee8c702d4c047572e69040887 Reviewed-on: Tested-by: Jenkins Reviewed-by: Xisco Fauli <>
7 daystdf#141613 sw: fix crash at header/footer undoDaniel Arato (NISZ)2-0/+97
Undoing the creation of a header/footer used to leave their corresponding document nodes intact, causing the node index of a previous undo entry to point to the wrong node. We now force the destruction of the header/footer nodes manually. We also cut the redo chain which loses the redo history, but solves another crash for now (when redoing the creation of the header). The proper solution would be to create a new SwUndo* derived class from scratch to represent the creation of a new header/footer section in the document. Regression from commit 8d8486f43c1a8a51157bfc3e0b87090b05a9229e (tdf#46561 sw: fix lost undo stack setting header/footer) Change-Id: I97188aa8ded802bc6b6fa88ddd83a95c40de8bc3 Reviewed-on: Tested-by: László Németh <> Reviewed-by: László Németh <>
7 daystdf#140296: Added Edit Fields(context menu) inside of tablesAyhan Yalçınsoy5-0/+5
Change-Id: I22b6a179c1575171315d9eb40cd4895c35d77b6f Reviewed-on: Tested-by: Jenkins Reviewed-by: Heiko Tietze <>
7 daystdf#139713:Renamed Footnote/endnote settings dialog captionAyhan Yalçınsoy1-1/+1
Change-Id: Iacaf7637e53fbbfe9dd683c8991b543ba3763d33 Reviewed-on: Tested-by: Jenkins Reviewed-by: Heiko Tietze <>
7 dayscid#1478174 Uninitialized scalar fieldCaolán McNamara1-0/+1
Change-Id: Ib17e55b600012ef5f6a26d01e9d54aa7be9c590d Reviewed-on: Tested-by: Jenkins Tested-by: Caolán McNamara <> Reviewed-by: Caolán McNamara <>
8 daysloplugin:stringadd improvement for appending numbersNoel Grandin9-71/+59
I was wrong, the Concat framework already optimised appending numbers by stack-allocating small buffers, so include them in the plugin Change-Id: I922edbdde273c89abfe21d51c5d25dc01c97db25 Reviewed-on: Tested-by: Jenkins Reviewed-by: Noel Grandin <>
8 daysloplugin:unnecessaryparen small improvementNoel Grandin2-6/+6
when calling a function, and passing only one arg, but the function has defaulted args, we were ignoring this case. Change-Id: I86517f18e30531127664088ddc09ef96dbd8bdf5 Reviewed-on: Tested-by: Jenkins Reviewed-by: Noel Grandin <>
8 dayssw: prefix members of BaseFrameProperties_Impl, SwDocStyleSheetPool, ...Miklos Vajna4-80/+80
... SwShapeDescriptor_Impl and SwStyleSheetIterator See tdf#94879 for motivation. Change-Id: I5602b7e94da0e5b004a45bed56d8c231b11004f5 Reviewed-on: Reviewed-by: Miklos Vajna <> Tested-by: Jenkins
8 daystdf#141995 Remove uno:Flash command from Customize dialogGabor Kelemen1-6/+0
Change-Id: Ie94e24a3f8ba518dde509c3cfa6d98e542074e3f Reviewed-on: Tested-by: Jenkins Reviewed-by: Miklos Vajna <>
8 dayssal_uLong->sal_uInt32 in SvParserNoel Grandin2-4/+4
Change-Id: Ibe5599e1cc136330a8e9c089c7cc66d0ef4bc966 Reviewed-on: Tested-by: Jenkins Reviewed-by: Noel Grandin <>
8 daysthrow() -> noexcept, part 2/3: Automatic loplugin:noexcept rewriteStephan Bergmann49-116/+116
Change-Id: I076f16d0536b534abf0ced4d76051eadb4c0e033 Reviewed-on: Tested-by: Jenkins Reviewed-by: Stephan Bergmann <>
9 daysRemove duplicated includeAndrea Gelmini1-1/+0
Change-Id: Ib26ae0e3e1b1b1721f426b3f9967d97baf4f982c Reviewed-on: Tested-by: Jenkins Reviewed-by: Julien Nabet <>
9 daystdf#79049 speed up OOXML workbook load (4)Noel Grandin3-14/+10
Optimise LocaleDataWrapper for reads by initialising the data we in the constructor, so we don't need any kind of locking Reduces load time from 34s to 28s. Change-Id: I4bd3bddb30b70ba015fe5b1372534f9507762b74 Reviewed-on: Tested-by: Jenkins Reviewed-by: Noel Grandin <>
10 dayssw: add some SAL_INFO on DoIdleJob interruptMichael Stahl1-0/+6
Change-Id: I44df06ab4bad1a5e0aaf5409590f5d7869f33482 Reviewed-on: Tested-by: Jenkins Reviewed-by: Michael Stahl <>
10 dayssw: speed up DoIdleJobs(WORD_COUNT)Michael Stahl1-0/+8
SwTextNode::CountWords() has early returns that don't clear the WordCountDirty flag, for nodes that don't contain any plain text. This speeds things up considerably for tdf135116-1.odt, which didn't finish the idle jobs after 5 minutes in an optimized 7.1 build, because the time slice tends to expire iterating nodes in word-count before it can make progress. With this it does ~25 WORD_COUNT pages and then ~90 AUTOCOMPLETE_WORDS pages per idle, sending OnLayoutFinished after 13-14 seconds. jmux just pointed me to commit 0fedac18214a6025401c4c426466a5166553e8ec which is not in 7.1 today and may have improved the performance here. Change-Id: I5e9651da3a173649c49fc36edefb23298dfd6bc4 Reviewed-on: Tested-by: Jenkins Reviewed-by: Michael Stahl <>
10 daysreinterpret_cast to SwPostItContent when field type is postitJim Raykowski1-12/+34
Change-Id: I4ed914479c07c786fdc3401c56f7d793777df751 Reviewed-on: Tested-by: Jenkins Reviewed-by: Jim Raykowski <>
11 daystdf#78864 sw track changes: cross out deleted imagesLászló Németh3-1/+59
Show Changes mode shows deleted images with crossing out to allow differentiate deleted and inserted images during change tracking. See also commit d6322bcedc197a654abc7d64bfea8cf570f123bf (tdf#59463 track changes: record deletion of images). Change-Id: If9bc2252c6cdd06cbe267fe130023c416aa53ce7 Reviewed-on: Tested-by: László Németh <> Reviewed-by: László Németh <>
11 daysallow dnd into weldeditviewCaolán McNamara1-2/+0
Change-Id: I42fafed01a3884279781642154656f0ee32ad431 Reviewed-on: Tested-by: Jenkins Reviewed-by: Caolán McNamara <>
11 daystdf#137741 SW: Add fields content type to NavigatorJim Raykowski5-8/+195
also makes Comments category be tracked Change-Id: I038ba87d6ae0b96bae2d7a213ec5df92ac7d566d Reviewed-on: Tested-by: Jenkins Reviewed-by: Jim Raykowski <>
11 daystdf#133548 don't change outline level attrib and list style attribJim Raykowski1-11/+0
when a new paragraph style is created based on a "to outline style assigned" paragraph style Change-Id: Ia757ca375e0e8749a24c27ad8e3f40daff7ef55d Reviewed-on: Tested-by: Jenkins Reviewed-by: Jim Raykowski <>