summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBoris Brezillon <boris.brezillon@collabora.com>2022-04-22 14:54:55 +0200
committerMarge Bot <emma+marge@anholt.net>2022-06-14 22:44:42 +0000
commit82d3433d2a5e2e7acf79f60e7c98c54835247b6b (patch)
tree0482cf25f0eb63613c6fa9245ee4b54a8deda2d3
parent303175cfecb166cc69736c1405ac2d3bbee9d82c (diff)
microsoft/compiler: Set typed_uav_load_additional_formats when appropriate
This flag should be set to true when the RWTexture is attached a vector, and we always declare a vec4 right now, so it should always be true. Might be worth reworking the dxil_module_get_res_type() to use a scalar when the image only has one component. Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16926>
-rw-r--r--src/microsoft/compiler/nir_to_dxil.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/src/microsoft/compiler/nir_to_dxil.c b/src/microsoft/compiler/nir_to_dxil.c
index 3eb4a595361..bdca79bf9ec 100644
--- a/src/microsoft/compiler/nir_to_dxil.c
+++ b/src/microsoft/compiler/nir_to_dxil.c
@@ -3670,8 +3670,12 @@ emit_image_load(struct ntd_context *ctx, nir_intrinsic_instr *intr)
store_dest(ctx, &intr->dest, i, component, out_type);
}
- if (num_components > 1)
- ctx->mod.feats.typed_uav_load_additional_formats = true;
+ /* FIXME: This flag should be set to true when the RWTexture is attached
+ * a vector, and we always declare a vec4 right now, so it should always be
+ * true. Might be worth reworking the dxil_module_get_res_type() to use a
+ * scalar when the image only has one component.
+ */
+ ctx->mod.feats.typed_uav_load_additional_formats = true;
return true;
}