diff options
| author | Daniel Stone <daniels@collabora.com> | 2019-06-25 20:50:26 +0100 |
|---|---|---|
| committer | Daniel Stone <daniels@collabora.com> | 2019-06-26 12:28:03 +0100 |
| commit | f1cecef2f88006e1e76202d030830d58519afb3d (patch) | |
| tree | 4f1fbcda797f59a33c009354532bae2b8b6c46b1 | |
| parent | 30f586375648c4a47bd3ce4bedf542b0acdc9821 (diff) | |
gl-renderer: Demystify output repaint slightly
Add some comments in the function to make it clear what's going on,
especially as we twist and turn between a lot of things called 'damage'
meaning different things in different co-ordinate spaces.
Signed-off-by: Daniel Stone <daniels@collabora.com>
| -rw-r--r-- | libweston/renderer-gl/gl-renderer.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/libweston/renderer-gl/gl-renderer.c b/libweston/renderer-gl/gl-renderer.c index 491f7684..ab86eb06 100644 --- a/libweston/renderer-gl/gl-renderer.c +++ b/libweston/renderer-gl/gl-renderer.c @@ -1491,12 +1491,19 @@ gl_renderer_repaint_output(struct weston_output *output, pixman_region32_fini(&undamaged); } - pixman_region32_init(&total_damage); + /* previous_damage covers regions damaged in previous paints since we + * last used this buffer */ pixman_region32_init(&previous_damage); + pixman_region32_init(&total_damage); /* total area to redraw */ + /* Update previous_damage using buffer_age (if available), and store + * current damaged region for future use. */ output_get_damage(output, &previous_damage, &border_status); output_rotate_damage(output, output_damage, go->border_status); + /* Redraw both areas which have changed since we last used this buffer, + * as well as the areas we now want to repaint, to make sure the + * buffer is up to date. */ pixman_region32_union(&total_damage, &previous_damage, output_damage); border_status |= go->border_status; |