Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: If73c0259cf11ce5c8b5f2af19ac5abb084d78b0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186730
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Port this Java a11y test to C++.
This mostly ports the existing logic from
Java to C++ and switches to the existing
helpers for testing the XAccessible* interfaces.
Change-Id: Ib39b2d301b98896a5ce29cd90c56c0d97e8cb892
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186679
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
So far, the XAccessibleEventBroadcasterTester logic was
to modify a vcl::Window to generate a11y events for it
that the XAccessibleEventBroadcaster would receive.
Change this to allow passing a function to the ctor that
is responsible for generating accessible events, to
allow using this class for other scenarios in the future as
well.
Move the vcl::Window-specific logic to a new subclass
WindowXAccessibleEventBroadcaster.
Change-Id: I36cd49d40e68127d2d98a6b5c151b1e32c29dd92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186678
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
Similar to how e.g. XAccessibleContextTester tests
the methods of the XAccessibleContext interface, this
one tests the methods of the XAccessibleText interface.
The logic in this C++ version is in general based on the Java
implementation in
qadevOOo/tests/java/ifc/accessibility/_XAccessibleText.java.
This will be used to port the AccessibleFixedTest
Java test to C++ one in an upcoming commit.
Tests that don't test common expectations for all XAccessibleText
implementations but depend on further conditions (like particular
text content, see the tests in the Java version that check whether
or not this is the "SmGraphicAccessible" or "AccessibleStatusBarItem"
test) are not included in the C++ version.
If considered relevant, I think it makes more sense to include those
specific tests in the test suite for the particular classes for which
the corresponding behavior is expected.
In XAccessibleTextTester::testGetCharacterBounds, don't
fail if the character bounds are outside of the
component, but just produce output, as the Java
version (in _XAccessibleText._getSelectedText) does.
Change-Id: Iec0c6a7413181b2f6ea28fdbbf6c0f2d9792fac8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186677
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
This is a subtask of tdf#165742: Chartex charts are lost on input from
OOXML and re-export.
Fix chartex parsing so as to properly handle series. This code considers
the <cx:plotAreaRegion> tag to be equivalent to the chart 'type group'
tags (<c:barChart>, <c:areaChart>, etc.). Therefore it allows use of the
type group mechanisms in chartex, even though there is not strictly a
tag for type group. This also includes a basic CI test for the
ability to round-trip (OOXML -> LO -> OOXML) simple chartex content.
Change-Id: Ibe96a239aa5329897b8e0652ce7388a7c398dda2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186298
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
... instead of the toolkit counterpart, XWindow.
This allows to use this also for vcl::Window
based tests, without having to involve
the UNO abstraction.
Adjust AccessibleStatusBarTest accordingly to pass the
vcl::Window associated with the XWindow.
To run the test:
make CppunitTest_toolkit_a11y
Change-Id: Iee77f293338f269a2ad7c631384d5e3797b06152
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186200
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
See
commit ed03c63f00dee22112a8632df45e5e044541960d
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Thu May 22 09:45:02 2025 +0100
wina11y: Don't rely on win accessible being VCLXWindow
for more background.
Change-Id: I19a01f9715536918dd9463f18a72c22878d0cd7c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185836
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
See commit messsage of
Change-Id: Id81ab5f90955ecc600e179164b5f9c7a771182d1
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed May 21 11:03:56 2025 +0200
sw a11y test: Don't rely on XWindow being XAccessible
for more background.
Extract a new helper from the existing
test::AccessibleTestBase::getWindowAccessibleContext
that returns only the XAccessible and use that one
to avoid duplication.
Change-Id: I0f3db88a4754f3ce8de5b02e0a0e41ac9cac9ac2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185602
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
See commit messsage of
Change-Id: Id81ab5f90955ecc600e179164b5f9c7a771182d1
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed May 21 11:03:56 2025 +0200
sw a11y test: Don't rely on XWindow being XAccessible
for more background.
Change-Id: Ieda73dc058444ad4b272f1a63a123289ee58bc23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185599
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
Change-Id: Iaa1baccfb0b95972cd8703da8f80433fdcd62163
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185598
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Change-Id: I874a95777aed3471675bf03acfcf05ecfcb4f830
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183531
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Similar to how e.g. XAccessibleContextTester tests
the methods of the XAccessibleContext interface, this
one tests the methods of the XAccessibleAction interface.
This C++ version is similar to what the Java implementation in
qadevOOo/tests/java/ifc/accessibility/_XAccessibleAction.java
does.
XAccessibleActionTester::testGetAccessibleActionDescription is
more strict in that it also requires that the action description
is non-empty.
This will be used to replace the existing AccessibleDropDownListBox
Java test with a C++ one in an upcoming commit.
Change-Id: I41e9fe2fb5011cd8f33dbfc2494b04f4833c43cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182983
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Move the XAccessibleEventBroadcasterTester and
XAccessibleExtendedComponentTester classes from toolkit to test,
so they can be reused for a11y tests in other modules.
Change-Id: I33e9ee43b9652e6cefcea2ee3264114109f8d9f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182982
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
An accessible can have multiple children at the same point. As the
XAccessibleComponent::getAccessibleAtPoint doc says:
@return
If there is one child which is rendered so that its bounding box
contains the test point then a reference to that object is
returned. If there is more than one child which satisfies that
condition then a reference to that one is returned that is
painted on top of the others. If there is no child which is
rendered at the test point an empty reference is returned.
So far, XAccessibleComponentTester::testAccessibleAtPoint was making
the assumption that if multiple children are at the same point, the
one on top has the higher child index. Otherwise, the test would fail.
The reason for that assumption is unclear. Replace that by checking
whether the accessible returned by XAccessibleComponent::getAccessibleAtPoint
is a direct child (by checking its parent) and actually contains the
point instead.
Without this, the test was seen failing in a WIP branch that converts
the AccessibleDropDownListBox JUnit test to a cppunit test.
Related failure output:
Found 2 children
* Found child: (0x562c20b3b7b8) role=TEXT name="" description=""
states: ENABLED | SENSITIVE
component: 0x562c20b3b770
bounds: X: 0, Y: 0, Width: 100, Height: 21
bounds: 100x21+0+0
finding the point which lies on the component
Child found at point +0+0
* Found child: (0x562c20b30028) role=LIST name="" description=""
states: ENABLED | FOCUSABLE | MANAGES_DESCENDANTS | SENSITIVE
component: 0x562c20b30010
bounds: X: 0, Y: 20, Width: 100, Height: 88
bounds: 100x88+0+20
finding the point which lies on the component
Child found at point +0+20
The child found ((0x562c20b3b7b8) role=TEXT name="" description="") is not the expected one ((0x562c20b30028) role=LIST name="" description="")
/home/michi/development/git/libreoffice/test/source/a11y/XAccessibleComponentTester.cxx:204:AccessibleDropDownListBox::TestBody
equality assertion failed
- Expected: (0x562c20b30028) role=LIST name="" description=""
- Actual : (0x562c20b3b7b8) role=TEXT name="" description=""
- The child found is NOT the expected one
Change-Id: I8bc01c333ff0b3b9e90948bfd21b5abb86989687
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182968
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
Move the XAccessibleComponentTester and XAccessibleContextTester
classes from toolkit to test, so they can be reused for a11y tests
in other modules.
Change-Id: I9a4bb3f96d92b05d58a5e8afe7f86b5eb2fd0c38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182967
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
found by a little plugin I created.
Plugin parked into store/ folder because it needs hand-holding
when run.
Change-Id: I2b4da7378f0becbc5f020ac9e78cd765aa0119b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181768
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
This patch effectively replaces (and thus contains a revert of)
25.8 commit d97085cc6cd2bdc3b6723d1960d0ec5fa0a48165.
This fixes a longstanding bug that became more prominent in 7.6
when mstahl renamed docx filters to promote Word 2010,
and then again in 25.2 when my bug 164201 patches
told command-line convert-to to export using Word 2010 filter,
and finally in 25.8 for interactive round-tripping of existing files.
So what does this patch fix?
Basically, all of the meta-data was not being read by MS Word,
which primarily means no create/modify dates, subject, title etc.
Every time we saved to DOCX format (except DOCX 2007), we caused Word
to be incapable of understanding anything in docProps/core.xml.
Telltale sign: when MS Word round-trips with added docProps/core0.xml.
The spec says that DOCX 2010 should be using
officedocuments/2006/relationships/metadata/core-properties
and thus our untouched 2010-era coding
specified all of that for import and export.
But reality seems to be much different than the spec,
(and some errata-sounding documentation agrees),
so throw the spec out the window and always write
package/2006/relationships/metadata/core-properties
(but only for DOCX - Excel and Powerpoint follow the spec...)
That meant that I also had to rewrite our import logic,
but that was already suggested by mstahl in
https://gerrit.libreoffice.org/c/core/+/178048
Bug 165207 doesn't affect LO in any way.
If there was already a unit test writing out to _rels/.rels
I would have added a test for this, but since there isn't
I won't bother since I don't see any value in doing so.
Plus, we already have validity checks to cover this kind of stuff.
The retained the unit test ensures import logic is still correct:
make CppunitTest_sw_ooxmlexport20 CPPUNIT_TEST_NAME=testTdf158855
A uiwriter4 test depends on the previous patch in this bug report.
(See earlier versions of my patchset for details)
officeotron sounds like they WANT to report invalidation errors
based only on spec, so no point in trying to "submit a patch".
Change-Id: Ib76803bf0c9f3791f9078846f00c118099ef67cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181463
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
|
|
and drop coverity workarounds
Change-Id: If9ffc607999285b2f5b63e85c51b0289fb05750f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180531
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
to the right
Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com>
Change-Id: Id8da1a1b199927bb2f1b71b814737b8287ea2a34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178362
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
|
|
Now that the accessibility module no longer
depends on toolkit and svtools and there's
therefore no more cyclic dependency, merge it
into the vcl library, where the vcl widgets are located,
for which the classes in the accessibility
module (primarily) provide the a11y classes.
Initially, take over the existing UNO service
"com.sun.star.accessibility.comp.GetStandardAccessibleFactoryService"
to vcl as is. It used to be necessary to break the cyclic
dependency between the vcl, svtools, toolkit and
accessibility module. (vcl is the lowest and
accessibility used to be furthest up in the dependency
chain; yet vcl needed it to create the objects
providing the XAccessible/XAccessibleContext
for its widgets.)
Further simplification can happen in upcoming commits.
Change-Id: Ib46c87446dc9121d3b8e735e0e5a40594da73cc5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178647
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
After
commit 168512dce7f1f1453c045584d47bd78a0a6c73f7
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Thu Dec 12 18:06:13 2024 +0100
a11y: Stop using VCLXWindow in vcl a11y classes
and further related commits, VCLXAccessibleComponent
no longer depends on anything in the toolkit module,
so move it from there to vcl.
This way, subclassing VCLXAccessibleComponent (as the
a11y classes for vcl widgets do, currently located in
accessibility/ ) no longer introduces a toolkit
dependency.
Change-Id: I4fd33fb1dc2265d75e8ca9ad87bcc70db61639d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178434
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
follow up for f5ebf512ccd3d5ae3af5fe706b411a85fa19182d
now same actions are performed on all the dialogs
Change-Id: I6531a766327dda106770a2c513ebd492dea7c655
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176933
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
(cherry picked from commit 2fba6df7242586870988b62909156538b42c2bc0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177892
Tested-by: Jenkins
|
|
Change-Id: I49477c20849dd99118d5935c0f1576429648bfca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177734
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
and
cid#1556101 COPY_INSTEAD_OF_MOVE
cid#1555475 COPY_INSTEAD_OF_MOVE
cid#1555310 COPY_INSTEAD_OF_MOVE
Change-Id: Ibabd8fd59a5435b8ab6c33d78c1303e5e1bdfd9a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177609
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
and
cid#1606986 COPY_INSTEAD_OF_MOVE
cid#1557969 COPY_INSTEAD_OF_MOVE
cid#1557837 COPY_INSTEAD_OF_MOVE
cid#1557772 COPY_INSTEAD_OF_MOVE
cid#1557735 COPY_INSTEAD_OF_MOVE
cid#1557672 COPY_INSTEAD_OF_MOVE
cid#1557664 COPY_INSTEAD_OF_MOVE
cid#1557650 COPY_INSTEAD_OF_MOVE
cid#1557642 COPY_INSTEAD_OF_MOVE
cid#1557639 COPY_INSTEAD_OF_MOVE
cid#1557628 COPY_INSTEAD_OF_MOVE
cid#1557623 COPY_INSTEAD_OF_MOVE
cid#1557581 COPY_INSTEAD_OF_MOVE
cid#1557489 COPY_INSTEAD_OF_MOVE
cid#1557473 COPY_INSTEAD_OF_MOVE
cid#1557317 COPY_INSTEAD_OF_MOVE
cid#1557261 COPY_INSTEAD_OF_MOVE
cid#1557146 COPY_INSTEAD_OF_MOVE
cid#1557135 COPY_INSTEAD_OF_MOVE
cid#1557134 COPY_INSTEAD_OF_MOVE
cid#1557079 COPY_INSTEAD_OF_MOVE
cid#1557063 COPY_INSTEAD_OF_MOVE
cid#1557052 COPY_INSTEAD_OF_MOVE
cid#1556982 COPY_INSTEAD_OF_MOVE
cid#1556977 COPY_INSTEAD_OF_MOVE
cid#1556950 COPY_INSTEAD_OF_MOVE
cid#1556943 COPY_INSTEAD_OF_MOVE
cid#1556804 COPY_INSTEAD_OF_MOVE
cid#1556736 COPY_INSTEAD_OF_MOVE
cid#1556658 COPY_INSTEAD_OF_MOVE
cid#1556621 COPY_INSTEAD_OF_MOVE
cid#1556590 COPY_INSTEAD_OF_MOVE
cid#1556579 COPY_INSTEAD_OF_MOVE
cid#1556534 COPY_INSTEAD_OF_MOVE
cid#1556524 COPY_INSTEAD_OF_MOVE
cid#1556478 COPY_INSTEAD_OF_MOVE
cid#1556467 COPY_INSTEAD_OF_MOVE
cid#1556422 COPY_INSTEAD_OF_MOVE
cid#1556314 COPY_INSTEAD_OF_MOVE
cid#1556309 COPY_INSTEAD_OF_MOVE
cid#1556258 COPY_INSTEAD_OF_MOVE
cid#1556143 COPY_INSTEAD_OF_MOVE
cid#1556119 COPY_INSTEAD_OF_MOVE
cid#1556101 COPY_INSTEAD_OF_MOVE
cid#1556097 COPY_INSTEAD_OF_MOVE
cid#1556039 COPY_INSTEAD_OF_MOVE
cid#1555966 COPY_INSTEAD_OF_MOVE
cid#1555948 COPY_INSTEAD_OF_MOVE
cid#1555915 COPY_INSTEAD_OF_MOVE
cid#1555836 COPY_INSTEAD_OF_MOVE
cid#1555748 COPY_INSTEAD_OF_MOVE
cid#1555644 COPY_INSTEAD_OF_MOVE
cid#1555582 COPY_INSTEAD_OF_MOVE
cid#1555478 COPY_INSTEAD_OF_MOVE
cid#1555475 COPY_INSTEAD_OF_MOVE
cid#1555409 COPY_INSTEAD_OF_MOVE
cid#1555372 COPY_INSTEAD_OF_MOVE
cid#1555334 COPY_INSTEAD_OF_MOVE
cid#1555330 COPY_INSTEAD_OF_MOVE
cid#1555310 COPY_INSTEAD_OF_MOVE
cid#1555257 COPY_INSTEAD_OF_MOVE
cid#1555247 COPY_INSTEAD_OF_MOVE
cid#1555147 COPY_INSTEAD_OF_MOVE
cid#1555120 COPY_INSTEAD_OF_MOVE
cid#1555059 COPY_INSTEAD_OF_MOVE
cid#1555016 COPY_INSTEAD_OF_MOVE
cid#1554880 COPY_INSTEAD_OF_MOVE
cid#1554824 COPY_INSTEAD_OF_MOVE
cid#1554808 COPY_INSTEAD_OF_MOVE
cid#1546189 COPY_INSTEAD_OF_MOVE
Change-Id: I2d2f33c603f1596228c9ecb169472ba6751e7826
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177593
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I6953958b4429dd0fa1a44d02b0b49618f97baf90
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176500
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I890ec73e30d3cc6b210903ecee29431f3cb5f635
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175979
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Add a new AccessibilityTools::getAccessibleObjectForId
helper that can be used in a11y tests to identify an object
by its accessible ID.
Add a test that checks that the accessible ID of the
spelling dialog matches what Orca's logic expects
in order to identify it, and that more UI elements
with expected accessible IDs exist.
This is to prevent breaking Orca logic without noticing.
Any changes affecting this test should be discussed with
the Orca maintainer first.
See the comment above the newly added test for more details
and a link to the corresponding Orca commits.
The new test initially only checks that objects with corresponding
IDs exist, could be extended to verify more of their
properties as needed.
Logic for checking availability of a dictionary, needed for
spell check was taken over from the existing tdf155705 test in
sw/qa/extras/accessibility/tdf155705.cxx, whose sample doc
is also used.
Change-Id: I0c5629272a89a4a570e080e62e99b6c105369cf9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176281
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
we can just take a "const &".
(found by running clang-tidy with the
performance-unnecessary-copy-initialization warning)
Change-Id: I20fd208c65303da78170b1ac06c638fdf3aa094b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176267
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
Switch css::accessibility::AccessibleRelationType
from integer constants to an enum.
This provides more type safety and improves the debugging
experience, e.g. GDB now prints
com::sun::star::accessibility::AccessibleRelationType::AccessibleRelationType_CONTENT_FLOWS_TO
instead of just "2" when printing the value of a
corresponding variable, so it's no longer necessary
to manually look up what constant has that integer
value to know what relation this refers to.
offapi/com/sun/star/accessibility/AccessibleRelationType.idl
had this comment:
> <p>We are using constants instead of a more typesafe enum. The reason
> for this is that IDL enums may not be extended. Therefore, in order to
> include future extensions to the set of roles we have to use constants
> here.</p>
However, the a11y UNO API is internal (not published),
so that shouldn't be a concern.
Change-Id: I44a7d56cb085dc24effb24fcd34bb222b78ef4cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176153
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
Change-Id: Ie69536fca492f0e8fcd8da5c167429d0f3de42ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175830
Tested-by: Jenkins
Reviewed-by: David Gilbert <freedesktop@treblig.org>
|
|
Change-Id: Ia834d19a5af999440f7d5847aeeae863daacd952
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175784
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
|
|
Change-Id: Ic62bd287406326f4c3d3e0702850fe0337f17686
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175762
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Ie67eebec74f783fa0c29acfb23bb83bc582812b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175724
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
|
|
As defined by commit 69586e8381037417d106d8474d9f73638c5b9c55 (UI
tests: use a dedicated desktop on Windows, 2024-07-17).
Change-Id: Icd4ad6dfa95301fc1f6e699349278d3a0198fd08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175296
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
so there's a recheck on each major if they are still needed
Change-Id: I351f731fe4eaec0ebf735147a9a168cccba3bca5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174883
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
These are only sent to an external API expecting char*-like strings,
or for comparison. Having every assertXPath having three of _[ou]str
is too much syntactic noise, making the unit tests almost unreadable.
Change-Id: Ic004a36ea75e7bfe0b96f405c40f926a957b51cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174416
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I83ac72accf2bbddd3ca74790654327bb9e86dba4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172765
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
|
|
In commit cf15306ccf49da290b391517e2c5dd22a4f1be45 (ERROR: Invalid
content was found starting with element 'p:pic'., 2014-12-22), the
pic element inside the oleObj element was only alloswed for the old
revision of ECMA-736 export, because that was considered invalid by
officeotron. However, as of ECMA-376-1:2016, this element is
mandatory; CT_OleObject definition in Annex A has:
<xsd:element name="pic" type="CT_Picture" minOccurs="1" maxOccurs="1"/>
and Annex L (Primer) has L.7.2.5 "Embeddings in a PresentationML
Document" saying:
The oleObj element shall have a pic child element that (optionally)
contains the image data to be used in place of loading the actual
object data.
The omission of this in the export is the reason of tdf#163064. So
here I filter out the error from the validation results, which is
not ideal (I have no way to know if the found pic is really in the
oleObj, or somewhere else), but a lesser evil, compared to required
exclusion of all tests that export OLE objects.
Change-Id: Ia73a49da7347e8ff22c626e211b55ba1e0625070
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173761
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I2fe2621458608a2bf6c382397ec5acdaeffe3748
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171774
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
So parseLayoutDump is only called once per test
Change-Id: Ia199e0a7eeac26fbde94f6450d2aa49828940806
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171219
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
|
|
and
cid#1554847 COPY_INSTEAD_OF_MOVE
cid#1554850 COPY_INSTEAD_OF_MOVE
cid#1554857 COPY_INSTEAD_OF_MOVE
cid#1554860 COPY_INSTEAD_OF_MOVE
cid#1554870 COPY_INSTEAD_OF_MOVE
cid#1554874 COPY_INSTEAD_OF_MOVE
cid#1557899 COPY_INSTEAD_OF_MOVE
cid#1608424 COPY_INSTEAD_OF_MOVE
cid#1608402 COPY_INSTEAD_OF_MOVE
Change-Id: Iaa6e39cf24cd56cdc4a9be5cbf2b8073a1f635c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170722
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
|
|
Increase the timeout for a11y UI tests from 1 to 2 min,
to see whether this helps with one slow Windows Jenkins
builder running into the timeout every once in a while,
as was mentioned in ESC calls.
Example from [1]:
timeout waiting for dialog 'Bookmark' to show up
warn:vcl.schedule:6600:11456:vcl/source/app/scheduler.cxx:524: Uncaught exception during Task::Invoke()!
abort() has been calledwarn:sal.cppunittester:6600:11456:sal/cppunittester/cppunittester.cxx:601: CAUGHT SIGABRT:
[...]
[1] https://ci.libreoffice.org/job/gerrit_windows/181051/console
Change-Id: I5b16ea8c538f6e2b5a30ebac714e177e696aac92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170569
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|
|
- import&export connections stream
- insert xl/connections.xml reference to [Content_Types].xml
- add Relationship::CONNECTIONS
- add support for xr16 namespace
- add ../customXml/item1.xml relationship to xl/_rels/workbook.xml.rels
- add import&export support for following xml elements in xl/connections.xml:
<connections>
<connection>
<dbPr />
<olapPr />
<webPr> (Web Query Properties)
<tables>
<m />
<s />
<x />
</tables>
</webPr>
<textPr>
<textFields>
<textField />
</textFields>
</textPr>
<parameters>
<parameter />
</parameters>
<extLst>
<ext>
(Any element in any namespace) <- TODO/LATER
</ext>
</extLst>
</connection>
</connections>
Change-Id: I1d1c10675b3fe5ffd6a35f1b91d4b83401be2cae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164290
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Change-Id: I0318485c3c0159277e47096e0c7e0df8ed109ea4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169865
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Take care to match the case of the names. Some tools rely on specific
case; so standardize on what Word outputs.
getXPath is modified to tell which XPath has failed (needed for the
unit test).
Change-Id: I3e71f5905b26d7e784d68ba11ff205eefedaaa2c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168755
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: Ie261167fc3e1ed9073210e0f8b179455da340c83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167620
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
|
|
Add option to check data validity with case sensitive and case
insensitive. The default set would remain the original case insensitive
mode for data validity.
Change-Id: Ic4fe56e2b31b7fc348b742f3b95fb44cd35bc49d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167280
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
|
|
Change-Id: I7a4df11c23a92d0c5538cea4290dcc5e2c9ac3c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167547
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
|
|
Use a Sequence of XAccessible rather than its base
interface XInterface for AccessibleRelation's TargetSet.
As the targets are accessible objects as well,
anything other than XAccessible doesn't make much sense.
Using XAccessible right away makes that clearer and avoids
the need to query the XAccessible interface.
(The winaccessibility bridge was already using
`static_cast`, relying on the fact that the objects
are XAccessibles.)
The a11y UNO API is not published, so an API change
should be unproblematic.
Change-Id: I7f08e98d1ec303d5343d9a7954187cdd71495ebc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166586
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
|