summaryrefslogtreecommitdiff
path: root/configure.ac
AgeCommit message (Collapse)AuthorFilesLines
2020-02-28Update commentStephan Bergmann1-1/+1
Since Visual Studio 2017, these menu items appear to no longer have the "VS20xx" prefix. Change-Id: I76a72de148fed288a0005db52cc9fed3abfb5f35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89665 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-28Remove redundant MSVSVERStephan Bergmann1-2/+1
Same as vcyear since ba6c014d9c3e2267cfa08e753ea7ba651a03f2fe "Simplify Visual Studio and Windows SDK related configurability" Change-Id: I77f27b43d2bbac73ff739ac1f9580076e8b46ff2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89664 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins
2020-02-26Resolves tdf#130500 - Sukapura icon themeHeiko Tietze1-4/+4
Added to core and made default on macOS Change-Id: I1c1e8caab514198717cf6cd7e8c00a1c1d5c15da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89183 Tested-by: Jenkins Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-02-26Detect -std=c++20Stephan Bergmann1-1/+1
at least Clang trunk accepts it now since <https://github.com/llvm/llvm-project/ commit/24ad121582454e625bdad125c90d9ac0dae948c8> "Add -std=c++20 flag, replace C++2a with C++20 throughout the Clang" Change-Id: I389bb2e79acbbdf2622dc7c839a3164836c40415 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89464 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-25configure: fix outdated doc on --with-tls defaultMiklos Vajna1-2/+2
This was changed in commit 133d59adf744b2279a7d59071ca834ac766b9719 (configure: build oox with NSS backend by default, 2013-11-01), but the documentation was not updated. Change-Id: I468cb9a0274779318a7e1a86600fdef32756fa24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89460 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-02-22tdf#128849 -- Add Sifr (Dark + SVG) to the icon theme listrizmut1-3/+3
Change-Id: I314f925c54a5ed30cd74e4fbbfba065a1b70c947 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89243 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-02-20macOS Xcode ld is known to always support -platform_version nowStephan Bergmann1-12/+0
...after 358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4". This effectively reverts b7fd89100d8653dc73955780358fe31d38b68ebf "tdf#122218: Baseline Xcode 9.3 ld presumably doesn't support -platform_version". Change-Id: Ib79563babe3cc948556d5369b0f6b6a8d208cab2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89160 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-20Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4Stephan Bergmann1-2/+2
...as discussed at <https://lists.freedesktop.org/archives/libreoffice/2020-February/084471.html> "Bump macOS Xcode baseline to 11?" and <https://lists.freedesktop.org/archives/libreoffice/2020-February/084519.html> "ESC meeting minutes: 2020-02-20". (Code that might no longer be relevant will be cleaned up in follow-up commits.) Change-Id: I179e6099937d244502bd0e7fbff43f1734984213 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89154 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-19add --enable-optimized=debugLuboš Luňák1-4/+26
This will use -Og with GCC/Clang instead of -O0, which should make unittests run faster without (hopefully) breaking anything related to debugging. This is primarily meant to Jenkins builds, where debug info is rarely needed (backtraces for unittest crashes AFAICT). This can be also used to make LO itself run faster when developing, but I personally do not find it worth it (with Clang and full PCH this makes starmath build take about 70% longer, although presumably for non-PCH builds the relative increase will be smaller). Change-Id: I198d0759ebca94c90be662e02e0f1281a24d1d70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88917 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins
2020-02-18Remove unused HAVE_FEATURE_LDAPStephan Bergmann1-1/+0
It was introduced with 6776c53b7ce2e431d8636f4e5a755f50f787ec8f "Make LDAP support optional", but it appears that it has been unused right from the start. Change-Id: Ia4afe23433c42e279a36a030bd661b26da72735e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88945 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-16MAC_OS_X_VERSION_MIN_REQUIRED_DOTS is the same as MACOSX_DEPLOYMENT_TARGETStephan Bergmann1-4/+2
Change-Id: I3a725e4681c11f503dae57436b05b5a80ff2979c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88764 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-15Do not silently ignore an explicit --enable-sdremote-bluetoothStephan Bergmann1-0/+3
Change-Id: I362d9402f3123f852a4342ce5f8b604913e11ece Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88762 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-15IOBluetoothAddServiceDict is removed completely from MacOSX10.15.sdkStephan Bergmann1-1/+1
... (see Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/ MacOSX10.15.sdk/System/Library/Frameworks/IOBluetooth.framework/Headers/ IOBluetoothUserLib.h), so e.g. --with-macosx-sdk=10.15 --with-macosx-version-max-allowed=10.13 would have failed with > In file included from sd/source/ui/remotecontrol/BluetoothServer.mm:1: > sd/source/ui/remotecontrol/BluetoothServer.cxx:1477:19: error: use of undeclared identifier 'IOBluetoothAddServiceDict' > IOReturn rc = IOBluetoothAddServiceDict(reinterpret_cast<CFDictionaryRef>(dict), &serviceRecordRef); > ^ Change-Id: I520976c70ac0146953eb4d074e6e3d37a7cbffa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88759 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-14Prevent -Werror,-Wunknown-warning-option when building compilerpluginsStephan Bergmann1-0/+14
...with --enable-werror (seen it fail with a local build against a locally built Clang 5.0.2). (bin/gen-boost-headers faces a similar dilemma with Clang needing to silence -Wunknown-warning-option and GCC failing upon the silencing incantation. There, we were able to hack around that with a preceding #pragma GCC diagnostic ignored "-Wpragmas" Here, the easiest approach appears to be a new COMPILER_PLUGINS_COM_IS_CLANG analoguous to the existing COM_IS_CLANG.) Change-Id: I9036261fdd238c8a020a1d88b4e75fd444f9e030 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88725 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-14tdf#122218: Baseline Xcode 9.3 ld presumably doesn't support -platform_versionStephan Bergmann1-0/+12
...according to <https://github.com/llvm/llvm-project/commit/ 25ce33a6e4f3b13732c0f851e68390dc2acb9123> "[driver][darwin] Pass -platform_version flag to the linker instead of the -<platform>_version_min flag": "In Xcode 11, ld added a new flag called -platform_version [...] This patch adopts the new -platform_version flag in Clang, and starts using it by default, unless a linker version < 520 is passed to the driver." So detect new HAVE_MACOS_LD_PLATFORMVERSION and adapt 645fe53be0dc36535dba0ed684e21ca4cda80d70 "tdf#122218: Hack to avoid blurry text with macOS SDK 10.15" accordingly. (This also changes the passed -platform_verion sdk value from 0.0 to 0.0.0, for cosmetic consistency with the default Clang behavior cited above. Also, after f67e5ef9a5c71f3b35b1c67eb72794e44cc15410 "Drop broken filter-out of -bind_at_load for Executable_soffice_bin on macOS" got included in the meantime, the surrounding ifeq in desktop/Executable_soffice_bin.mk can be combined now.) Change-Id: Ie1ddf2d618e2f1232c6b4e17ce17665851f3bd38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88717 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-12If asked to do so, enable icecream even in the 'build' part of configure.Jan Holesovsky1-0/+1
Otherwise it is used only in the 'host' part of the cross-compile build. Change-Id: Ifb8d88e18c131e3019a4f3168afc1b743f3cc8e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88486 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-12Drop macOS SDK 10.12 baselineMike Kaganski1-5/+2
...which appears to no longer work due to incompatible changes incorporated in LO code already. sberg says: "The first issue I encountered when building against the 10.12 SDK is 'fpicker/source/aqua/ControlHelper.hxx:119:78: error: use of undeclared identifier 'NSControlStateValueOn''." Change-Id: Ib762dd8eaa355925b9a81fb41b550c49bfcf53da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86216 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins
2020-02-12tdf#84553 Correctly handle failures while getting a WMI Object.Michel Thomas1-18/+22
The output before this patch : checking for active Antivirus software... C:\cygwin\home\tdf\lode\jenkins\workspace\gerrit_windows\antivirusDetection.vbs(1, 1) (null): 0x8004100E found The link for which is : https://ci.libreoffice.org/job/gerrit_windows/57035/consoleFull Change-Id: I714442739a8daf132e95b9f6a750aa7abab3561e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88465 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-10android hunspell: Don't explicitly disable extensions on Android.Jan Holesovsky1-1/+1
We need the bundled extensions for hunspell. Change-Id: I423d71376652b7d54dfdcc81462a19db9dc785bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88218 Tested-by: Jan Holesovsky <kendy@collabora.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88365
2020-02-10tdf#84553 Detection of antivirus exclusion, EICAR test.Michel Thomas1-1/+14
Change-Id: I3577a361edcc67f85f86ddb75778cd39784b39a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88269 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2020-02-08tdf#84553 Detect and warn of Windows Antivirus.Michel Thomas1-0/+15
Change-Id: I7731cb316306c153ad14bb3d27f39600a44ed9ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87811 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-01-29Fix typoAndrea Gelmini1-1/+1
Change-Id: I27f2c02ff3d4ab277219428be99b1219f1d6e94e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87667 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-28HAVE_GCC_ATTRIBUTE_WARN_UNUSED should always be true now for Clang/GCCStephan Bergmann1-4/+4
...but for safety, leave the configure.ac check in for some longer. Change-Id: I90cba5812492ba85d7723ff71aba75b7721b9622 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87621 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-28Remove obsolete Clang <= 3.8 __float128 checkStephan Bergmann1-31/+1
According to README.md, for Linux the baseline is Clang 5.0.2, and for macOS and iOS (should this libstdc++ __float128 stuff be relevant for either of them at all) the baseline is Xcode 9.3 which maps to ca. LLVM 5.0.2 according to <https://en.wikipedia.org/wiki/Xcode# Xcode_7.0_-_11.x_(since_Free_On-Device_Development)>. Change-Id: Ibd916cff795998bc63398695be63481cfd02abcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87618 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-24Fix --with-visual-studio help output: 2019 is supportedMike Kaganski1-2/+2
Change-Id: Id9c3987a5fdaca8722d7ad8cabe1d1ef523b598e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87302 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-23next major version will be 7.0Christian Lohmaier1-1/+1
Change-Id: If618bf789370ee462b562cc5977b41802fbe47b5
2020-01-20tdf#128849: Added svg version of the breeze dark icon set.Luca Carlon1-5/+5
Change-Id: I045d8acd5b42473b220f7c9bb96e2a87d6141727 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86590 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-01-18use -Wl,-dead_strip on Mac, its linker doesn't know -Wl,--gc-sectionsLuboš Luňák1-0/+23
Change-Id: Ic69d0030a46fe4753cc75da58bb2c15cf009b135 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87023 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-18support Clang's -fmodules-codegen/debuginfo options for PCH buildingLuboš Luňák1-0/+31
These (starting with my patches for Clang-to-be-10) allowing emitting debuginfo and functions into a dedicated object file, so that all the normal compilations using the PCH can skip those, thus saving the time. The debuginfo option seems to always be worth it. The codegen option is more tricky, it doesn't seem to be worth it for optimized builds (optimizing all the functions in that one object file costs too much). This requires also using --Wl,--gc-sections . The reason is that the object file contains all template instances instantiated from the PCH, so that they can be shared, but the template instance may come from another library or use a private symbol from that library. For example the std::unique_ptr<ScInterpreterContext> in ScInterpreterContextPool in the header refers to ScInterpreterContext dtor. But even though both these classes are private, the header gets used also by scfilt, because there it is included by document.hxx because of a private ScDocument data member. So even though nothing in scfilt uses ScInterpreterContext, the PCH object file will refer to it. Fortunately that template instance itself is not used by scfilt, so --gc-sections will remove it. Change-Id: I2a06ebcc4dd4175424b3a72ab3ebcaf2ac3ee295 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87011 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-18add support for Clang's -building-pch-with-objLuboš Luňák1-0/+15
This marks the PCH as having an accompanying object file, and this object file needs to be also built, but this allows the compiler to skip generating stuff that'd be shared by all the objects using the PCH. Currently it doesn't make much of a difference, few symbols if any, but template instantiations could be shared this way, as soon as Clang gets the necessary support (my WIP patch). Change-Id: Ib1b86338d85a47b48979558435253dc2672a0da8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87009 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-13Merge both x64 and x86 CRT merge modules into x64 MSIMike Kaganski1-6/+3
... because it contains x86 binaries in addition to x64: e.g., twain32shim, spsupp_x86. The opposite (inclusion of x64 MSM into x86 MSI) is not possible ( see https://stackoverflow.com/questions/58181986 ), so do it just for x64 MSI. And fix inclusion of CRT MSMs in VS2019, which were detected in configure.ac, but not used in scp2/source/ooo/vc_redist.scp. Change-Id: I3935fce751b1b6d04291fede6b82be25fe541582 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86667 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-09python3: bundle libffi for GNU/Linux buildsMichael Stahl1-0/+3
CPython commit f40d4ddff3c800b3c956a5e8820aabe3aa87cddd "Closes #27979: Remove bundled copy of libffi" causes a bit of a problem because it turns out that libffi isn't all that stable; there's libffi.so.5 on CentOS 6, libffi.so.6 on CentOS 7 and libffi.so.7 on lo_daily_update_gandalf tinderbox. So we have to bundle it in LO; it's only used on GNU/Linux currently. CPython commit 32119e10b792ad7ee4e5f951a2d89ddbaf111cc5 "bpo-35947: Update Windows to the current version of libffi (GH-11797)" also removes the libffi for MSVC, so in a future python upgrade we will have to build libffi for MSVC too. The libffi fork for MacOSX is still in CPython git master. (regression from b10be5d48433076f0b7238d818020f708553e114) Change-Id: Ibc20cf8cd3614cf9941b6970662bd930496776b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86493 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-08python3: upgrade to release 3.7.6Michael Stahl1-2/+2
* external/python3/python-3.3.3-aix.patch.1: most of it doesn't apply and AIX port isn't maintained anyway so remove it for now * external/python3/ubsan.patch.0: apparently one of the files was removed * 0001-3.6-bpo-17239-Disable-external-entities-in-SAX-parse.patch.1: fixed upstream * python3-osx-avoid-new-10.13.patch.1: replace with simply passing ac_cv_func_utimensat=no to configure * external/python3/python-3.5.4-ssl.patch.1: project files to build OpenSSL removed upstream * There have been changes to how python locates OpenSSL; new variables OPENSSL_INCLUDES etc; it turns out that you have to pass one directory to --with-openssl, as the variables cannot be passed * libuuid.so.1 is a new dependency of the _uuid module * libffi.so.6 is a new dependency of the _ctypes module (the bundled copy of libffi for non-Darwin platforms was removed) * python-3.3.0-pythreadstate.patch.1: the PyThreadState functions have been changed such that CppunitTest_services asserts when there is a PyThreadAttach on top of PyThreadDetach on top of PyThreadAttach, i.e., 2 PyThreadState per thread (PyGILState_Check() fails). Instead of patching in additional workarounds, change PyThreadAttach so that it re-uses an existing PyThreadState if one exists for the thread. Change-Id: I24c19d79b43a30709261fd9db66312b2e3872fd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84765 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-03Use only the 'MacOSXSpell' component on iOS, not the 'spell' oneTor Lillqvist1-2/+6
Using only the system spell checker (through MacOSXSpell) is what we have been doing anyway. Do not build the hunspell or mythes externals for iOS. Do not build the lnth or spell components for iOS. Change-Id: I2e2abc268d7719e540072e5daff3f7960e04ed27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86172 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86174 Tested-by: Jenkins
2019-12-29Fix order of CLANGTOOLLIBS archivesStephan Bergmann1-1/+1
Building compilerplugins against recent Clang 10 trunk started to fail with > [GEN] compilerplugins/clang/sharedvisitor/analyzer [...] > /usr/bin/ld: /home/sbergman/llvm/inst/lib/libclangFrontend.a(CompilerInvocation.cpp.o): in function `getOptimizationLevel(llvm::opt::ArgList&, clang::InputKind, clang::DiagnosticsEngine&) [clone .isra.0]': > /home/sbergman/github.com/llvm/llvm-project/clang/include/clang/Driver/OptionUtils.h:40: undefined reference to `clang::getLastArgIntValue(llvm::opt::ArgList const&, llvm::opt::OptSpecifier, int, clang::DiagnosticsEngine*, unsigned int)' [...] Change-Id: I3b74d71bd2488ebd5cc7e3a88d4eb0451268141c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85934 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-18Fix typos concerning the __cxa_exception checkStephan Bergmann1-3/+3
...introduced with 069506bcb0ee4005b01c22095ed427b96b553c98 "Use config_cxxabi.h to check for __cxa_eh_globals, __cxa_exception", but which appear to have been harmless as (a) the checked-for __cxxabiv1::__cxa_exceptions never existed in cxxabi.h, and (b) lack of __cxxabiv1::__cxa_exception in cxxabi.h happened to conincide with !HAVE_CXXABI_H_CXA_EH_GLOBALS Change-Id: I13f8a2b3cf0f03f2bc96cf053d2b571860055978 Reviewed-on: https://gerrit.libreoffice.org/85373 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-17Tweak configure to allow Windows builds using VC++ Build ToolsStepas Toliautas1-1/+6
Since Visual Studio 2017 Microsoft offers Build Tools installer package which comes with MSVC++ compiler and can include most toolchains and libraries, but does not require Visual Studio IDE installation. This patch asks vswhere.exe to use path to Build Tools as compiler path (in case Visual Studio path is not found) and lowers 'devenv' detection error to warning with an explanation. Identical build is produced in both cases, and even IDE integration (creation of sln/vsproj) works as usual. Change-Id: I6176d10cc6ea2091c353eb40d13913d8adb8f85d Reviewed-on: https://gerrit.libreoffice.org/85245 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-12-17Remove dated check for jre sub-dir in JDKStephan Bergmann1-12/+7
Since Java 9, a JDK installation no longer necessarily has a jre sub-dir, see <https://docs.oracle.com/javase/9/install/ installed-directory-structure-jdk-and-jre.htm> vs. <https://docs.oracle.com/javase/8/docs/technotes/tools/windows/jdkfiles.html>. The check for a jre sub-dir had been there ever since 157d22babb277a9e7bc750a74737cd60e84dfee8 "INTEGRATION: CWS rodarvus01", but the code that determines a working JAVA_HOME has been improved a lot since then. Given that the current check can be misleading (see <https://lists.freedesktop.org/archives/libreoffice/2019-December/084005.html> "Re: what jdk for build?"), better remove it completely and hope that the code determining a working JAVA_HOME is good enough by now. Change-Id: Ib1da3c00b8a3f1e54d5204e6ecd43b4c4441c827 Reviewed-on: https://gerrit.libreoffice.org/85257 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-14Rename HAVE_GCC_BUG_87150 to HAVE_P1155R3Stephan Bergmann1-2/+2
...to match the new reality (see comment in config_host/config_global.h.in) Change-Id: I5450e520d8b82584e3fd71d7e42a6840993b5ddb Reviewed-on: https://gerrit.libreoffice.org/85142 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-12Enable -Wdeprecated-copy-dtor where availableStephan Bergmann1-0/+17
We already get -Wdeprecated-copy (warning about implicitly defined copy functions that will in the future be deleted because other user-provided copy functions exist) automatically through -Wextra, where available. -Wdeprecated-copy-dtor (warning about implicitly defined copy functions that will in the future be deleted because of a user-provided dtor) is split off into its own warning excluded from -Wextra for somewhat unclear reasons, see the discussion at <https://gcc.gnu.org/bugzilla/buglist.cgi?quicksearch=88136> "-Wdeprecated-copy is draconian and shouldn't be in -Wall". But -Wdeprecated-copy-dtor has been useful in finding issues (esp. the Clang 10 trunk version, which, unlike the GCC 9 version, also finds copy functions that are implicitly defined because they are used from template instantiations), see 3e59716375a240576fd6d8759b32b4319506ed70 "Prevent BroadcastRecalcOnRefMoveHandler copies" and 4f98cd0f9ce9c2a331a5d34b3ef9d18f9bb6b235 "ScShapeChild has broken copy functions". We need to disable -Wdeprecated-copy-dtor in files included from external/boost, and in two compilerplugin/clang/test/ files. Change-Id: I74b159c3a046e23661473ddbfe53c92c4136a9db Reviewed-on: https://gerrit.libreoffice.org/85073 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-07Adapt o3tl::span to P1872R0Stephan Bergmann1-0/+16
..."span should have size_type, not index_type" (<http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1872r0.pdf>), as implemented by libc++ since <https://github.com/llvm/llvm-project/commit/ 1466335cf4b2854a0be1defcf279fe50772bad6f> "[libc++][P1872] span should have size_type, not index_type." All uses of index_type had been added to mitigate the previous std::span change from signed (ptrdiff_t) to unsigned (size_t) index_type, see 6ef8420fdbf8dff16de13147c5ab833bc5e01121 "Adapt o3tl::span to updated C++2a std::span". There is no easy solution to transparently support all three std::span variants currently out there (signed index_type, unsigned index_type, unsigned size_type), without causing compilation failures due to CPPUNIT_ASSERT_EQUAL with arguments of different types, or compiler warnings about mixed signed/unsigned comparisons. So rule out the oldest std::span variant (signed index_type) in configure.ac (so that o3tl::span will use its own hand-rolled code in that case) and simplify the uses of index_type to std::size_t (as had already been mentioned in 6ef8420fdbf8dff16de13147c5ab833bc5e01121). Change-Id: I6ddf424ffb7941da3f69ad66fd29ecd35f09afae Reviewed-on: https://gerrit.libreoffice.org/84652 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-06Honor BISON passed into configureStephan Bergmann1-3/+17
...and require new-enough Bison for --enable-compiler-plugins to not generate bogus loplugin:external warnings in Bison boilerplate code. (As happend for me on macOS where /usr/bin/bison is version 2.3. Not sure which versions exactly are too old, but at least 3.4.1 is known good. If other versions newer than 2.3 turn out to be problematic too, the configure.ac check will need to be adapted.) No idea why there need to be three places across solenv/gbuild/ that set gb_YACC (to the same bison in each case), but leave that to be cleaned up later. Change-Id: I01d8219726f8df7895631b817866207327367759 Reviewed-on: https://gerrit.libreoffice.org/84650 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-06Qt5 fix missing XCB_ICCCM_WM_HINT_WINDOW_GROUPJan-Marek Glogowski1-2/+9
This is the application level equivalent of the Qt5 fix for bug QTBUG-46626 / commit 0de4b32 ("xcb: fix issue with dialogs hidden by other windows"), which was broken since Qt 5.4 and is just fixed since Qt 5.12. It is needed for some window managers, which don't know about the WM_CLIENT_LEADER property. Both settings are the same, but just the latter is set by older Qt5 releases. This probably isn't a real problem, as GNOME or XFCE would use the gtk VCL plugin, but since I already wrote the code when debugging tdf#129071, there is also no reason to drop it (except: more code, more bugs...). This fix is optional and needs development headers for xcb-icccm, which can actually be compiled into Qt5. If missing configure will just print a warning, since it's a runtime requirement and we explicitly drop the linked Qt version symbol, so the potential build Qt version won't matter. Change-Id: Ifc5a8f8a40ee13779a911efb53e8b8b868614d0b Reviewed-on: https://gerrit.libreoffice.org/84299 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-12-03split instrinsics CXXFLAGS per each instruction setLuboš Luňák1-90/+206
The common usage pattern should be having one source file per each instruction set and then one source file compiled with neutral flags that dispatches to the relevant code based on runtime checks. Which means that there can't be any one "correct" flag, otherwise all files would get compiled e.g. with SSE4.2 but then CPUs capable only of SSE2 would crash running that code. Change-Id: I362bf66f672dae4588a48effe3bcd30c34ea75b3 Reviewed-on: https://gerrit.libreoffice.org/84227 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-12-02android: Fix location of the built freetype library.Jan Holesovsky1-1/+5
Otherwise it is not found when the the fontconfig's ./configure is running, which leads to linking failure during the fontconfig's ./configure time, which leads to an undefined HAVE_FT_GET_NEXT_CHAR which leads to not using the actual FT_Get_Next_Char, but instead some dummy code that leads to an infinite loop on the app startup; huh. Change-Id: I40b7a403fbe75582bb98f15f1afe7a4050fd13aa Reviewed-on: https://gerrit.libreoffice.org/83922 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 94eb59078731b2e4093d983bc618d051f4e31740) Reviewed-on: https://gerrit.libreoffice.org/84190 Tested-by: Jenkins
2019-11-27android: Introduce --enable-android-lok configure switch to fix RGB vs. BGR.Jan Holesovsky1-0/+19
This indicates that the build targets the Online-based Android app, for which we need to avoid various tweaks that are needed for the 'old' Android app present in the android/ subdir of core.git. In particular, the switch used in this patch fixes a RGBA vs. BGRA confusion that caused yellow <-> cyan switch in the Online-based Android app. Change-Id: I5f394868f51ce87013677834cfafb967b9bb333e Reviewed-on: https://gerrit.libreoffice.org/83342 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 49002a143a4534df5f6139e07fefd06174621c59) Reviewed-on: https://gerrit.libreoffice.org/83718 Tested-by: Jenkins
2019-11-27build Skia only on selected platformsLuboš Luňák1-1/+7
Feel free to adjust your platform as necessary. Change-Id: I3003a643c39b6afeb3102f97280f20534b9c7f77
2019-11-27build skia by defaultLuboš Luňák1-3/+3
Change-Id: Ia7d9c95b2e1e78481755f40d817c6f16a5d2b4ed
2019-11-27use the same config file for skia build and using itLuboš Luňák1-0/+1
So that the setup is consistent. Change-Id: Ia113c7bf79036e3ec7585263ed70da68e461fbac
2019-11-27initial build of the Skia libraryLuboš Luňák1-0/+18
Not quite complete yet, missing e.g. Vulkan sources, and the setup is not completely correct either. Change-Id: I2283bf12f0d226ff8a34554deae5a7bd69045971