summaryrefslogtreecommitdiff
path: root/chart2/source/controller/dialogs/DialogModel.cxx
AgeCommit message (Collapse)AuthorFilesLines
2025-05-31tdf#163738 Use insert() to add multiple values in container instead of for loopStefan Dorneanu1-2/+3
Signed-off-by: Stefan Dorneanu <cdmail2012.cd@gmail.com> Change-Id: I6f34abdf199db2cfb14313a600652452ac328079 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185432 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2025-04-14chart2: fold isSupported* functions into ChartTypeTomaž Vajngerl1-1/+1
This moves isSupported* function from ChartTypeHelper to ChartType where it better belongs to. We can access the concrete classes now instead of accessing through UNO si this is possible to do. Change-Id: Icc52a8ba0d8ab6d5907d7942a1834cc6f7093cce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182712 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2025-04-13fold DataSeriesHelper functions into ChartTypeNoel Grandin1-1/+1
Where it better belongs, and where we can do a much better implementation. Change-Id: I00d77c28d3dc78c672e8a6756797a768a2eb0d02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184097 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-08loplugin:reftotemp in chart2Noel Grandin1-1/+1
Change-Id: I0ce3c76e873921f04897955b62cc9c4cb15a5a40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176258 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-05-07loplugin:ostr in chart2Noel Grandin1-20/+20
Change-Id: I2985b6793a776639214a25bf9732c000b9026bfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167236 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-03-27tdf#146619 Remove unused #includes from C/C++ filesRafał Dobrakowski1-1/+0
'chart2' module was cleaned. Change-Id: Ib4cdb3c8a21d0ed47f4970894d416327df5e68a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164864 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2023-10-19Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: chart2Stephan Bergmann1-1/+1
Change-Id: Ifcb57548a594cbbaf70df8d9da17cf94a96667db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158146 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-05-10tdf#155231: fix CRASH: with embedded OLE chartJulien Nabet1-2/+3
First bt: 6 0x00007f19f96b29b2 in rtl::Reference<chart::Diagram>::operator->() const (this=0x55f40881f1f0) at include/rtl/ref.hxx:216 7 0x00007f19f97b0a03 in chart::DialogModel::isCategoryDiagram() const (this=0x55f407cfffb0) at /home/julien/lo/libreoffice/chart2/source/controller/dialogs/DialogModel.cxx:656 8 0x00007f19f983ab1a in chart::DataSourceTabPage::updateControlState() (this=0x55f408bdd840) at /home/julien/lo/libreoffice/chart2/source/controller/dialogs/tp_DataSource.cxx:439 9 0x00007f19f983a954 in chart::DataSourceTabPage::SeriesSelectionChangedHdl(weld::TreeView&) (this=0x55f408bdd840) at /home/julien/lo/libreoffice/chart2/source/controller/dialogs/tp_DataSource.cxx:469 10 0x00007f19f98380e2 in chart::DataSourceTabPage::updateControlsFromDialogModel() (this=0x55f408bdd840) at /home/julien/lo/libreoffice/chart2/source/controller/dialogs/tp_DataSource.cxx:313 see full bt here: https://bugs.documentfoundation.org/attachment.cgi?id=187190 Second part bt: 6 0x00007fc66e0b29b2 in rtl::Reference<chart::Diagram>::operator->() const (this=0x7ffce5f5c9b0) at include/rtl/ref.hxx:216 7 0x00007fc66e1b00d8 in chart::DialogModel::getCategories() const (this=0x5590bff92f10) at /home/julien/lo/libreoffice/chart2/source/controller/dialogs/DialogModel.cxx:601 8 0x00007fc66e1b0474 in chart::DialogModel::getCategoriesRange() const (this=0x5590bff92f10) at /home/julien/lo/libreoffice/chart2/source/controller/dialogs/DialogModel.cxx:637 9 0x00007fc66e238141 in chart::DataSourceTabPage::updateControlsFromDialogModel() (this=0x5590c00c4030) at /home/julien/lo/libreoffice/chart2/source/controller/dialogs/tp_DataSource.cxx:316 Regression from: commit 5a4b75dcb5abc2e925870614a28e1c2876df8ed9 (patch) tree 5fe1f89c70f9c6d90d3eea8f9eb9a68e91f2dec0 parent dab0d4e1f36faace21145a51733bd3a946992624 (diff) use more concrete types in chart2, Diagram Change-Id: I4332a237248c5acacab7180733d502f049aead96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151642 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-28move get/setScheme from ThreeDHelper to DiagramNoel Grandin1-4/+4
so we can use the get/setFastPropertyValue methods Change-Id: I2b57212a1d3933cd2825e647f692e2ae3cb8b484 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149647 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-22use more concrete type in chart2Noel Grandin1-1/+1
Change-Id: I0ed45cf9acd1c9bf702bbe335f8a07b6947fb946 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149282 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-21move getLabel inside chart2::DataSeriesNoel Grandin1-1/+1
Change-Id: I38baff5980d8cae5f63ee9163d667385837d249b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149198 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-19move getDataSeries inside chart2::DiagramNoel Grandin1-1/+1
Change-Id: Ie60d288dba9c8d006de03c80d3cfc7bf8f108782 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149085 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-18move isCategory inside chart2::DiagramNoel Grandin1-1/+1
Change-Id: I568a573004c20d7bbf60a947b34a6a8223217b19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149083 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-18move getCategories/setCategories inside chart2::DiagramNoel Grandin1-2/+2
Change-Id: I7c6b4e92bb131cc3c6b5b4eedb3304128b8bd988 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149082 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-17move getChartTypeByIndex inside chart2::DiagramNoel Grandin1-1/+1
Change-Id: Idff60dbd7c1cdb8c60e7ac07ad3abe3c6b07e321 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149050 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-17move getChartTypes inside chart2::DiagramNoel Grandin1-2/+2
Change-Id: I43fd96feb1e3d34a5f3327b2e6398ca4b5e9f928 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149049 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-17use more concrete types in Diagram::moveSeriesNoel Grandin1-1/+1
Change-Id: Ic5bb7f36137afe112d1a542bd642355d996cf68c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149048 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-17move isSeriesMoveable inside chart2::DiagramNoel Grandin1-1/+1
Change-Id: I119552a4f1300eafc8b060f567777a74dc11772f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149038 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-27tdf#153859 sw: crash fix for setting chart with deleted data tableLászló Németh1-5/+12
Opening Data Ranges dialog window of a chart with deleted data table crashed Writer immediately. Follow-up to commit 5b9855acc7fa6d1e4a5f53ff0bc47e1dd4729827 "tdf#132714 sw: fix crash at table row deletion associated to a chart". Change-Id: I96e901db75d40ae234f58827a957204bca13aa92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147893 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-11-19tdf#151846 Restore XChartTypeTemplateNoel Grandin1-4/+4
Which I removed in commit 58766f997d59e4684f2887fd8cdeb12d2f8a9366. Turns out it does have some usefulness for extensions. So restore most of it. The exception is the getDataInterpreter method, for which I have added a placeholder, so that the restored class has the same vtable layout as the original. Change-Id: Ief9b48ef2c408580bc24b5a8a0e11131edb3b943 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142908 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-18Move tools/diagnose_ex.h to comphelper/diagnose_ex.hxxStephan Bergmann1-1/+1
...so that its TOOLS_WARN_EXCEPTION can be used in comphelper/source/misc/logging.cxx in a follow-up commit. (And while at it, rename from diangose_ex.h to the more appropriate diagnose_ex.hxx. The comphelper module is sufficiently low-level for this immediate use case, so use that at least for now; o3tl might be even more suitable but doesn't have a Library until now. Also, for the immediate use case it would have sufficed to only break DbgGetCaughtException, exceptionToString, TOOLS_WARN_EXCEPTION, TOOLS_WARN_EXCEPTION_IF, and TOOLS_INFO_EXCEPTION out of include/tools/diagnose_ex.h into an additional new include/comphelper/diagnose_ex.hxx, but its probably easier overall to just move the complete include file as is.) Change-Id: I9f3222d4ccf1a9ac29d7eb9ba1530d53e2affaee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138451 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-13clang-tidy modernize-pass-by-value in chart2Noel Grandin1-4/+4
Change-Id: I73ae444487571fb61a02a2c813c060d269d52a02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135723 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-01Use more appropriate index variable typesStephan Bergmann1-3/+4
Change-Id: Ic2cf5512cabcda0ad476c43bcbc544d0d6dd2685 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135231 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-25Recheck module chart2 with IWYUGabor Kelemen1-2/+0
See tdf#42949 for motivation This time using the new --noexclude switch to recheck validity of the excludelist; these were the obsolete exclusions Change-Id: Ifdf79b30ebaf198082c2194611a2ed2b664e6f1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133309 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-23Recheck module chart2 with IWYUGabor Kelemen1-4/+0
See tdf#42949 for motivation Change-Id: Id4cdca3eed8618c289f30913d506f8f2bd46f0bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133112 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-02-17loplugin:unusedfieldsNoel Grandin1-3/+1
Change-Id: I07ec409ea3663e789b6505dbfc999666525ed97f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130062 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-08use more concrete types in chart2, DataSeriesNoel Grandin1-9/+10
Change-Id: I80bc8961832a20c29b31f7618b9d2609f15ab3c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129642 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-07use more concrete types in chart2, DataSeriesNoel Grandin1-16/+11
Change-Id: If92f6ff6f90d53a9dc6211fd9f071d4d3fce2997 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129535 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-07crashtesting ooo#20372Noel Grandin1-4/+4
this reverts parts of the "use more concrete types in chart2, LabeledDataSequence" commits, since writer uses it's own implementation of the XLabeledDataSequence UNO interface Change-Id: Icc2c5e9a38f789cddd9fbca63301397ce759fbff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129587 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-04use more concrete types in chart2, LabeledDataSequenceNoel Grandin1-2/+2
Change-Id: Iecc22ad488fff7d0536ffa37f4cde7da460c2c7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129458 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-04use more concrete types in chart2, LabeledDataSequenceNoel Grandin1-4/+5
Change-Id: I88d5b7e045814cbd40750ebe927e6a76d5a463d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129456 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-04use more concrete types in chart2, DataSeriesNoel Grandin1-23/+13
Change-Id: I51a30d2a6a3c424dcdc29b6647aa2b67fa35884a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129455 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-31use more concrete types in chart2, DataSeriesNoel Grandin1-5/+8
Change-Id: Ib07ed6ec3321dc617cfec872d16683cf5de60907 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129181 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-30use more concrete types in chart2, DiagramNoel Grandin1-5/+2
Change-Id: Ieaee7c8381c19e3bfd3560d2f674bebf49afac56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129156 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-29use more concrete types in chart2, ChartTypeNoel Grandin1-8/+5
Change-Id: I78fe27e14993b7a6e5d27662282241b3007ac03e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129113 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-25use more concrete types in chart2, DiagramNoel Grandin1-7/+7
Change-Id: I40cd39d0878dc56e4e86e05149c9744cb563d745 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-25use more concrete types in chart2, ChartTypeNoel Grandin1-1/+1
Change-Id: Ife8d3f31d65e2911fa365a53f0defacde183f7b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128936 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-25use more concrete types in chart2, ChartTypeNoel Grandin1-80/+33
Change-Id: I68c04c7e3ffb21a52ad054adac7e9ed0c554e583 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128883 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-23remove css::chart::XDataInterpreterNoel Grandin1-3/+3
these are purely internal interfaces, they cannot be used from outside chart2. Change-Id: I43c6d8aa96eb94e47767a4b16b89b4889f571579 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128792 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-22remove css::chart::XChartTypeTemplateNoel Grandin1-1/+2
these are purely internal interfaces, they cannot be used from outside chart2. Change-Id: Ib89e98e8099c34a530951bd85236fced216aff18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128784 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-22use more concrete types in chart2, ChartTypeNoel Grandin1-5/+8
Change-Id: Ibd299e2e8d82169706d810af98c29d684809c320 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128741 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-21use more concrete types in chart2, BaseCoordinateSystemNoel Grandin1-5/+5
Change-Id: I25fc26c9c3eb861d72c44ac04e502b2f002ef951 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128711 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-21use more concrete types in chart2, DiagramNoel Grandin1-6/+5
Change-Id: Ib78f327c8bf1b71c3bb038c029b10e6fe54edaa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-20use more concrete types in chart2, ChartModelNoel Grandin1-3/+3
Change-Id: Ie38d941f855978b04995162040d8871a2577255c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128641 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-19use more concrete types in chart2, ChartTypeTemplateNoel Grandin1-1/+2
and return data using a little struct rather than std::pair, to make the call sites read a little better. Change-Id: Ieb6fc24e053f50823789167ed0112aa04a083725 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128613 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-01-06Add 'reference' to the iterator_traits, needed by LegacyIterator reqsMike Kaganski1-0/+2
This addressed a failure with VS2022 Version 17.1.0 Preview 2.0: C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(1152): error C2794: 'reference': is not a member of any direct or in direct base class of 'std::iterator_traits<`anonymous-namespace'::lcl_DataSeriesContainerAppend>' C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(3932): note: see reference to alias template instantiation 'std::_Iter_ref_t<`anonymous-namespace'::lcl_DataSeriesContainerAppend>' being compiled C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(3992): note: see reference to variable template 'const bool _Iterator_is_volatile<`anonymous namespace'::lcl_DataSeriesContainerAppend>' being compiled C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(4048): note: see reference to function template instantiation '_OutIt std::_Copy_unchecked<com::sun::star::uno::Reference<com::sun::star::chart2::XDataSeriesContainer>*,_OutIt>(_InIt,_InIt,_OutIt)' being compiled with [ _OutIt=`anonymous-namespace'::lcl_DataSeriesContainerAppend, _InIt=com::sun::star::uno::Reference<com::sun::star::chart2::XDataSeriesContainer> * ] C:/lo/src/core/chart2/source/controller/dialogs/DialogModel.cxx(504): note: see reference to function template instantiation '_OutIt std::copy<std::_Vector_iterator<std::_Vector_val<std::_Simple_types<_Ty>>>,`anonymous-namespace'::lcl_DataSeriesContainerAppend>(_InIt,_InIt,_OutIt)' being compiled with [ _OutIt=`anonymous-namespace'::lcl_DataSeriesContainerAppend, _Ty=com::sun::star::uno::Reference<com::sun::star::chart2::XDataSeriesContainer>, _InIt=std::_Vector_iterator<std::_Vector_val<std::_Simple_types<com::sun::star::uno::Reference<com::sun::star::chart2::XDataSeriesContainer>>>> ] C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(3932): error C2938: 'std::_Iter_ref_t' : Failed to specialize alias template C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(3932): error C2062: type 'unknown-type' unexpected C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(3992): error C3376: 'std::_Iterator_is_volatile': only static data member templates are allowed C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(4026): error C2976: 'std::_Iter_copy_cat': too few template arguments C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(3994): note: see declaration of 'std::_Iter_copy_cat' C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(1152): error C2794: 'reference': is not a member of any direct or in direct base class of 'std::iterator_traits<`anonymous-namespace'::lcl_RolesWithRangeAppend>' C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(3932): note: see reference to alias template instantiation 'std::_Iter_ref_t<`anonymous-namespace'::lcl_RolesWithRangeAppend>' being compiled C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(3992): note: see reference to variable template 'const bool _Iterator_is_volatile<`anonymous namespace'::lcl_RolesWithRangeAppend>' being compiled C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(4048): note: see reference to function template instantiation '_OutIt std::_Copy_unchecked<_InIt,_OutIt>(_InIt,_InIt,_OutIt)' being compiled with [ _OutIt=`anonymous-namespace'::lcl_RolesWithRangeAppend, _InIt=const com::sun::star::uno::Reference<com::sun::star::chart2::data::XLabeledDataSequence> * ] C:/lo/src/core/chart2/source/controller/dialogs/DialogModel.cxx(563): note: see reference to function template instantiation '_OutIt std::copy<const E*,`anonymous-namespace'::lcl_RolesWithRangeAppend>(_InIt,_InIt,_OutIt)' being compiled with [ _OutIt=`anonymous-namespace'::lcl_RolesWithRangeAppend, E=com::sun::star::uno::Reference<com::sun::star::chart2::data::XLabeledDataSequence>, _InIt=const com::sun::star::uno::Reference<com::sun::star::chart2::data::XLabeledDataSequence> * ] make[1]: *** [C:/lo/src/core/solenv/gbuild/LinkTarget.mk:332: C:/lo/src/build/workdir/CxxObject/chart2/source/controller/dialogs/DialogModel.o] Error 2 Change-Id: Ic93dc7922cd48870ef62bfd682dd5cbdc827a255 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128036 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-29Prepare for removal of non-const operator[] from Sequence in chart2Mike Kaganski1-1/+3
Change-Id: I71e0b458c4dd2a85e36a485e3efa72b1077b0e54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124346 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-14Avoid COW overhead using css::uno::SequenceMike Kaganski1-1/+1
The scenarios are: 1. Calling sequence's begin() and end() in pairs to pass to algorithms (both calls use getArray(), which does the COW checks) 2. In addition to #1, calling end() again when checking result of find algorithms, and/or begin() to calculate result's distance 3. Using non-const sequences in range-based for loops, which internally do #1 4. Assigning sequence to another sequence variable, and then modifying one of them In many cases, the sequences could be made const, or treated as const for the purposes of the algorithms (using std::as_const, std::cbegin, and std::cend). Where algorithm modifies the sequence, it was changed to only call getArray() once. For that, css::uno::toNonConstRange was introduced, which returns a struct (sublclass of std::pair) with two iterators [begin, end], that are calculated using one call to begin() and one call to getLength(). To handle #4, css::uno::Sequence::swap was introduced, that swaps the internal pointer to uno_Sequence. So when a local Sequence variable should be assigned to another variable, and the latter will be modified further, it's now possible to use swap instead, so the two sequences are kept independent. The modified places were found by temporarily removing non-const end(). Change-Id: I8fe2787f200eecb70744e8b77fbdf7a49653f628 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123542 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-05-21tdf#138556 Don’t add Open Values to stock chart types 1 and 3Aritz Erkiaga1-2/+43
A new function was defined, XdataInterpreter::getChartTypeSpecificData. Being 100% chart-type-agnostic when retrieving chart data is impossible; candlestick charts can have different numbers of sequences per series, and this information is not present in any other chart type. Change-Id: I0f54b09202c42667331b083d54d90e4ceee81083 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113075 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-22OUStringLiteral/OStringLiteral coverity PARSE_ERROR workaroundCaolán McNamara1-1/+1
do more like commit 121771e37f7e2de41cd5643475861062bf25627b Date: Mon Sep 21 09:17:54 2020 +0200 Make some OUStringLiteral vars constexpr cause coverity can live with that Change-Id: I9efd7f848289c4865997a44c6780373068422227 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103147 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2025-07-05 02:02:30 +0000