summaryrefslogtreecommitdiff
path: root/chart2/source/controller/dialogs
AgeCommit message (Collapse)AuthorFilesLines
2 daystdf#167316 tdf#167407 - VT style to chart props & char/para formatHeiko Tietze4-81/+153
Change-Id: If103cb3ba1b5d60bce08a237d39e93475a6f16d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187466 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2025-06-20uitest: test column name in Data Table dialogXisco Fauli1-9/+14
for that, use set_buildable_name Change-Id: Ic7329571385338c9eb50a9e1700da132db8a9921 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186772 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-06-17inline some constantsNoel Grandin2-4/+4
these are only used in a single place Change-Id: I9aae2331bc22e7ac842870a6b27030fc57c01b08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186591 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-06-16Adjust naming after moving SvColorDialog to vclMichael Weghorn1-1/+1
Adjust naming following Change-Id: Iebc3c1172dfd12dbbe72c3a56eeb6eb333d799c5 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Fri Jun 13 18:45:11 2025 +0200 Move SvColorDialog from svtools to vcl * Rename SvColorChooserDialog -> ColorChooserDialog, now that the class is no longer in svtools * Move ColorPickerMode from svtools namespace to vcl Change-Id: I27e84d6c6e7f7cde35dea31159b01dd1e0d312cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186482 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-06-16Move SvColorDialog from svtools to vclMichael Weghorn1-1/+1
Now after Change-Id: I3b9997b73a9a6bcce4c5b3ae3bd7d57816a4419b Author: Michael Weghorn <m.weghorn@posteo.de> Date: Fri Jun 13 18:27:09 2025 +0200 Stop using UNO abstraction for color picker , SvColorDialog no longer depends on anything above vcl, so move it there, which will help in implementing support for platform/toolkit-native alternatives for the color picker instead of using the LO-internal one. The "Sv" naming prefix will be dropped in a separate commit, to keep the diff clearer. Change-Id: Iebc3c1172dfd12dbbe72c3a56eeb6eb333d799c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186481 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-06-16Pass SvColorDialog parent in ctorMichael Weghorn1-2/+2
... instead of as a param to SvColorDialog::Execute or SvColorDialog::ExecuteAsync. Passing a dialog or widget parent in the ctor is typical for UI toolkits. While SvColorDialog currently only creates the actual color picker dialog in its Execute{,Async} methods, this will change in an upcoming commit, for which this one prepares. Change-Id: Ib1ea41cc986577a3e3f1dddfd93a04c2e69bc15f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186463 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-05-31tdf#163738 Use insert() to add multiple values in container instead of for loopStefan Dorneanu1-2/+3
Signed-off-by: Stefan Dorneanu <cdmail2012.cd@gmail.com> Change-Id: I6f34abdf199db2cfb14313a600652452ac328079 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185432 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2025-05-20chart color palette for data series: dialog tab paneMarco Cecchetti3-1/+267
Change-Id: I0877212c715d320e954fcd8089d4f984eae16ac6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184265 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185143 Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Tested-by: Jenkins
2025-04-22Revert "use more concrete UNO in chart2"Noel Grandin3-6/+8
This reverts commit 1886ecf7ee10cc51ca90fe1365e4a8ef2a1b6f27. because reportdesign will pass in a OReportDefinition* and not a SvNumberFormatsSupplierObj* Change-Id: Ic0068d18a10ce24ed74bb86cfef4cb9f34e9eeb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184437 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-04-14chart2: fold isSupported* functions into ChartTypeTomaž Vajngerl3-14/+15
This moves isSupported* function from ChartTypeHelper to ChartType where it better belongs to. We can access the concrete classes now instead of accessing through UNO si this is possible to do. Change-Id: Icc52a8ba0d8ab6d5907d7942a1834cc6f7093cce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182712 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2025-04-13use more concrete UNO in chart2Noel Grandin1-2/+3
Change-Id: I6de2e5376cf2a9054d5bb06fc04884e89babd3df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184119 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-04-13fold DataSeriesHelper functions into DataSeriesNoel Grandin1-2/+1
Where it better belongs, and where we can do a much better implementation. Change-Id: I370bd23ee0dfb1570d6376d21b8dac4c83591096 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184098 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-04-13fold DataSeriesHelper functions into ChartTypeNoel Grandin1-1/+1
Where it better belongs, and where we can do a much better implementation. Change-Id: I00d77c28d3dc78c672e8a6756797a768a2eb0d02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184097 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-04-11fold ChartModelHelper functions into ChartModelNoel Grandin4-9/+4
This moves functions from ChartModelHelper to ChartModel where it better belongs to. We can access the concrete classes now instead of accessing through UNO si this is possible to do. Change-Id: I21dce8aabe8f8a956863beef7ca5cb4ec6f3b44b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183990 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-04-04use more concrete UNO in chart2Noel Grandin3-8/+6
Change-Id: Id71c919abb85039d7fdfdb334e505f293e530255 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183706 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-31merge ExplicitValueProvider interface into ChartViewNoel Grandin2-4/+3
Change-Id: I4e5ef8c00b8e1b001d0f711c0c15814d316e2905 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183479 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-03-31simplify the DLL annotations in chart2Noel Grandin1-1/+1
now that the libraries are merged, nothing needs to be visible Change-Id: I009f062301ccec9cf9c57b3280a3cd7452adcf38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183482 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-02-20use more concrete UNO types in some local varsNoel Grandin1-1/+1
found by a clang plugin I created. Change-Id: I72ebc2b6fadb854a12d69a543facf2fd7e4f1e8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181932 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-02-07browsebox: Convert dispatch ID defines to enum classMichael Weghorn1-4/+4
Convert the `BROWSER_*` defines in include/svtools/brwbox.hxx to a new enum class BrowserDispatchId. The specific integer values that were used don't seem to have any particular meaning, so just drop them. Add default case that does nothing in BrowseBox::Dispatch to address /home/michi/development/git/libreoffice/svtools/source/brwbox/brwbox2.cxx:1779:13: error: 5 enumeration values not handled in switch: 'NONE', 'CURSORENDOFSCREEN', 'CURSORTOPOFSCREEN'... [-Werror,-Wswitch] 1779 | switch (eId) | ^~~ 1 error generated. Change-Id: Ibb023ec13ee2c10a0fc0ef7abe1371dbd856e735 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181167 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-01-03Drop unneeded forward declarations from include/Gabor Kelemen2-0/+4
test drive the new bin/find-unneeded-includes --fwdecl mode Change-Id: I507fa2b172ec9e348d1d91066ea241f02187b5ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179321 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2025-01-02Drop unneeded forward declarations from chart2 moduleGabor Kelemen11-25/+0
test drive the new bin/find-unneeded-includes --fwdecl mode Change-Id: I9fd1148e8cff3ebda4595820af5fc824f530245c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178967 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-12-07weld: Rename weld::Treeview selection signal/connectMichael Weghorn3-4/+5
Rename weld::TreeView member + methods to clarify that these are about selection changes: * m_aChangeHdl to m_aSelectionChangedHdl, * signal_changed to signal_selection_changed * connect_changed to connect_selection_changed In GtkInstanceTreeview, also rename the related methods calling signal_selection_changed accordingly for consistency. Change-Id: I299d7930484677395a0bdd0ff105df18688f2e04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178023 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-26tdf#161800 - I/O of '# of values in second plot' parameter not supportedKurt Nordback2-4/+20
Add support for input and output of 'split position' parameter (number of entries in second plot) for of-pie charts. In OOXML this uses the supported split-pos tag. For ODF I added an extension in loext namespace for this parameter. This commit also includes simple tests for the I/O functionality in OOXML and ODF. Change-Id: I00ff59db721867fa836eb99b6677350040d005dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170666 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-11-16tdf#163486: PVS: Identical branchesBogdan Buzea1-3/+1
V1037 Two or more case-branches perform the same actions. Check lines: 146, 158. This will still be the case, the code being just at the moment similar. Change-Id: Iceca3c717ccc6ee3ea865d3a469418ff6e8accd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175146 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-11-12tdf#145614 Convert #define to enum classOromidayo Owolabi1-2/+2
Converted #define to enum class Change-Id: I16195a439643bcf0111c591a829272b5bf70179d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175027 Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Jenkins
2024-11-11clang-tidy: performance-unnecessary-copy-initialization in chart2Noel Grandin2-4/+4
Change-Id: I6f84cfea6390d6a263e5e43ec5a638260c10c00d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176374 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-08loplugin:reftotemp in chart2Noel Grandin1-1/+1
Change-Id: I0ce3c76e873921f04897955b62cc9c4cb15a5a40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176258 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-07loplugin:passstuffbyref in chart2..connectivityNoel Grandin4-7/+7
Change-Id: Ic2c6606ea0ce1d5c3089bc4c1a879fed3f2c7aff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176180 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-02tdf#163486: PVS: Identical branchesBogdan Buzea1-3/+1
Change-Id: Ief90706c81423116efa2507e1e2bf2b4eee1a2fc V1037: Two or more case-branches perform the same actions. Check lines: 256, 287 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175145 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-10-18tdf#163486: PVS: Identical branchesBogdan Buzea1-3/+1
Change-Id: Ibe65f4eca6009e8be4355974cdf33b5cabbe03e5 V1037: Two or more case-branches perform the same actions. Check lines: 54, 60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175144 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-18SW: extract transform charts (using dialog code)Attila Szűcs4-173/+3
Implemented chart data extraction, and transformation added insert/delete/modify row/column, and the ability to set resize data table setcolumndesc / setrowdesc .. for 1 descriptor, or with multiple descriptor to set set 1 cell value, or set the whole table cells values. it will resize the table, but you can still use partial arrays like "data": [ [ 1,2,3,4 ], [ 2,3,4,5 ], [ 3 ], [ 4,5,6,7 ], [ 2,2,1 ], [ 5,6,7,8 ] ], that means the 3. row 2,3,4th cell will not be overwritten. for insert column, it call codes from DataBrowserModel. (used by dialog code) added tests, fixed a contentcontrol date problem 2. commit (made by Caolan) squashed into 1. commit: WIP hack this to link move stuff from chartcontroller to chartcore and adjust visibility until it links at least Change-Id: I5529f4da33f046eef7e947d755e29486fa966274 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172849 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175121 Tested-by: Jenkins
2024-08-24Resolves: tdf#162597 'ok' in chart range dialog doesn't commit datarangeCaolán McNamara1-10/+12
so nothing happens. since: commit 4965b055b5998dc345ecaeb80fc8c3874b19e2a5 CommitDate: Fri Feb 16 12:08:55 2024 +0100 Chart: Make Data Range Dialog Async async conversion missed that there is a DataSourceDialog::run override so the use of asyncRun means the body of that isn't run. To keep things simple we can add an explicit 'ok' handler and move the special dialog ok code into that instead, so all the existing asyncRun's used with this dialog run the same code originally called in the previous non-async case. Change-Id: Ibdb4b764b1a1e48c01ee1528bc260f694e840221 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172336 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-29Prevent rtl::Reference -> css::uno::Reference -> rtl::Reference implicit pathMike Kaganski1-1/+1
Replace up-casting conversion constructor with respective conversion operator, similar to existing css::uno::Reference conversion operator. Thic change will not allow code like rtl::Reference<Foo> foo; rtl::Reference<Foo> bar(foo, uno::UNO_QUERY_THROW); which was possible because compiler could use temporary css::uno::Reference. Change-Id: I54b79af3e2508b26e9cd59f2cc7e2ae92f6efbbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171166 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-29tdf#161090 - Spec how many / which values are in remainder of-Pie chartKurt Nordback2-7/+163
This commit moves bar-of-pie and pie-of-pie chart types into a separate line in the chart type selection UI from 'plain' pie chart types. This allows for separate UI controls, including a spin button added in this commit for of-pie types to specify the number of entries to be included in the composite wedge and broken out in the right-hand subchart. Per discussion in this and related bugs, this may not be the long-term best approach for specifying which entries go into the composite, and it still only allows for the last entries in the composite. But it is a step towards allowing greater control. I've also changed the default number in the composite from 3 to 2, to better match MSO. I/O of the 'number in the composite wedge' parameter is not included in this commit. Implementing that for ODF and OOXML perhaps should be a separate bug or bugs. Change-Id: If4afc1417ea94c15e86a9a4dfe967a6f8ecb7ca8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168690 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-07-21tdf#82716 Add initial implementation of the Histogram Chartvarshneydevansh2-0/+52
- Add the Histogram selection to the UI - Histogram bars showing with No Gap - Convert X and Y axis to group data into bins and frequency - Adjusted failing UI test (tdf138556) as a new chart type was added Change-Id: Id1f161adac943ead5e17c7fbb7e14c9ab7f1655e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167068 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-07-17Resolves: tdf#158753 GtkAssistant loses current page on hide+showCaolán McNamara4-31/+26
gtk_assistant_unmap ... { ... priv->current_page = NULL; ... } gtk_assistant_map { page_num = 0; ... set_current_page (assistant, page_num) ... } It doesn't automatically restore itself to the page it was on when it was hidden, so do that explicitly. Change-Id: If23b255193c4a65b286e036c8796d9d8a2ffcb5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170611 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-05-07loplugin:ostr in chart2Noel Grandin50-508/+513
Change-Id: I2985b6793a776639214a25bf9732c000b9026bfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167236 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-04-09tdf#146619 Drop unused 'using namespace' in: chart2/Gabor Kelemen4-4/+0
Change-Id: I632d0dda0e62e5b1bf0956e731ab5ed6417db1ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165688 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-02tdf#39052 - Chart: make characters formatable in editable chart textshapesBalazs Varga1-1/+1
Editable textshapes include main chart title, sub chart title, axis titles. In chart2 the chart2::XFormattedString and chart2::XFormattedString2 store the formatted characters from textshapes, so we need to set all the character properties from the EditTextObject and need to add them to to the XFormattedString array with all the related texts which are formatted individually. For formatting of the characters the .uno:FontDialog command can be used, which can be called from the chart menubar, toolbar and with right click on the text when we are in edit mode in the textshape. (Note: in the next patch the OOXML export will be fixed.) Change-Id: I5750a5fe694b384dc6b28e2ef03ac1f2b03957db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165501 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-03-27tdf#146619 Remove unused #includes from C/C++ filesRafał Dobrakowski17-23/+1
'chart2' module was cleaned. Change-Id: Ib4cdb3c8a21d0ed47f4970894d416327df5e68a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164864 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-03-21ITEM: Remove InvalidateAllItems()Armin Le Grand (allotropia)4-17/+17
I checked if this is used, but it can be replaced using Clear() -> all. This prevents that the whole array of Items in an ItemSet gets set to INVALID_POOL_ITEM. I also checked if INVALID_POOL_ITEM/IsInvalidItem is needed at all representing SfxItemState::DONTCARE but it is and still will need to be set for individual Items. At last checked if SfxItemState::UNKNOWN and ::DISABLED really need to be separate states, but indeed there are some rare cases that need that. To make things more consistent I also renamed SfxItemState::DONTCARE to SfxItemState::INVALID to better match Set/IsInvalid calls at ItemSet. The build showed a missing UT and led to a problem due to the hand-made ItemSet-like SearchAttrItemList. The state 'invalid' seems to be used as 'unused' marker. It should be changed to use SfxPoolItemHolder and not need that. For now, set by using an own loop to set to that state. Change-Id: Ifc51aad60570569a1e37d3084a5e307eed47d06c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165035 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-03-03Resolves: tdf#159879 Crash when closing "3D View" dialogCaolán McNamara1-0/+2
Change-Id: I9c116007afe9cea97b597933ad8483dce25c3707 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164295 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-02-06tdf#50934: Add a version comment, and more structure for of-pieKurt Nordback1-1/+1
Change-Id: I9d7c25e47a3f4a78360f9b2deffe8650e378866d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156305 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-02-02tdf#50934: Initial plumbing and infrastructureKurt Nordback1-0/+6
Change-Id: I355bdc8e6d67e7cdd47e4d6eccecedc4b53ac11b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155851 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-01-27Drop std::as_const from css::uno::Sequence iterationsMike Kaganski1-1/+1
Obsoleted by commit 2484de6728bd11bb7949003d112f1ece2223c7a1 (Remove non-const Sequence::begin()/end() in internal code, 2021-10-15) and commit fb3c04bd1930eedacd406874e1a285d62bbf27d9 (Drop non-const Sequence::operator[] in internal code, 2021-11-05). Change-Id: Idbafef5d34c0d4771cbbf75b9db9712e504164cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162640 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-16no need to allocate this on the heapNoel Grandin1-2/+2
Change-Id: I89d4e680e6c8aabcc543605a0e496b3086dd2d3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160838 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-14tdf#158684: CHART XY Scatter Chart: line type "stepped" ignores parametersJulien Nabet1-1/+1
Regression from 65752e649872edfd98915035b61aca510ae8f271 Date: Fri Mar 24 10:52:13 2023 +0100 jsdialog: enable and make async chart line prop dialog Change-Id: I1532c45ae72d2c45ace72bcc099fcc8baa265b99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160715 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-10-19Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: chart2Stephan Bergmann2-5/+5
Change-Id: Ifcb57548a594cbbaf70df8d9da17cf94a96667db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158146 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-09-11jsdialog: fix layout of chart type dialogSzymon Kłos1-1/+1
directly set content area container to avoid buttons on top of the dialog in lok case Change-Id: I8353102f679a8f19c3041c7b4ec0b1200ed7d515 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156254 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156813 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-09-02replace set(nullptr) with clear()Noel Grandin1-1/+1
It's a little easier to read, but mostly it makes an upcoming loplugin easier to implement Change-Id: I4ae7db8eda77795dab3255d1afd8ba4f20a8de76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156451 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2025-07-12 16:14:50 +0000