summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEric Anholt <eric@anholt.net>2011-10-21 19:08:55 -0700
committerEric Anholt <eric@anholt.net>2011-10-29 12:15:59 -0700
commitfff693828ed5398ae284fb01c129d0f8986a126e (patch)
treed7da8d8ea0971b0996e8cc0c83f473d725f1acea
parent3faf56ffbdebef04345ebb1fa8e0d50b4beeedb2 (diff)
i965: Add a note about an unsafe-looking state check.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Acked-by: Paul Berry <stereotype441@gmail.com>
-rw-r--r--src/mesa/drivers/dri/i965/brw_draw.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c
index c02b2bc7852..c3755d564a5 100644
--- a/src/mesa/drivers/dri/i965/brw_draw.c
+++ b/src/mesa/drivers/dri/i965/brw_draw.c
@@ -350,6 +350,11 @@ static bool brw_try_draw_prims( struct gl_context *ctx,
else
gen6_set_prim(brw, &prim[i]);
+ /* Note that before the loop, brw->state.dirty.brw was set to != 0, and
+ * that the state updated in the loop outside of this block is that in
+ * *_set_prim or intel_batchbuffer_flush(), which only impacts
+ * brw->state.dirty.brw.
+ */
if (brw->state.dirty.brw) {
brw_validate_state(brw);