summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRhys Perry <pendingchaos02@gmail.com>2020-03-13 16:07:26 +0000
committerMarge Bot <eric+marge@anholt.net>2021-01-07 16:34:53 +0000
commitf4eb833a12523142d908bf67e08904f4e8a866e9 (patch)
tree2d8ac62c758f3e981e6e3648cfb5395a561365b8
parent4d0b8a9d323ebc316ba3cf7fbd2c2ee08e901347 (diff)
nir/load_store_vectorize: don't ignore subgroup memory barriers
Not sure why I thought this was correct, but we should consider them for optimization purposes. Fixes: ce9205c03bd ('nir: add a load/store vectorization pass') Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4202>
-rw-r--r--src/compiler/nir/nir_opt_load_store_vectorize.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/compiler/nir/nir_opt_load_store_vectorize.c b/src/compiler/nir/nir_opt_load_store_vectorize.c
index e52006e40ef..41c968bfb25 100644
--- a/src/compiler/nir/nir_opt_load_store_vectorize.c
+++ b/src/compiler/nir/nir_opt_load_store_vectorize.c
@@ -1195,7 +1195,6 @@ handle_barrier(struct vectorize_ctx *ctx, bool *progress, nir_function_impl *imp
release = nir_intrinsic_memory_semantics(intrin) & NIR_MEMORY_RELEASE;
switch (nir_intrinsic_memory_scope(intrin)) {
case NIR_SCOPE_INVOCATION:
- case NIR_SCOPE_SUBGROUP:
/* a barier should never be required for correctness with these scopes */
modes = 0;
break;