diff options
| author | Marcin Ślusarz <marcin.slusarz@intel.com> | 2021-07-05 15:48:03 +0200 |
|---|---|---|
| committer | Marge Bot <emma+marge@anholt.net> | 2022-02-02 18:17:57 +0000 |
| commit | f12f5ae2f8d4b394e31b3b39c3385f74a4abff86 (patch) | |
| tree | 028ef05e0a7cc6c2e26ebf7d3737cf515090cf38 | |
| parent | 97da3e0814f98949f7fc78ee3bb805654787db66 (diff) | |
anv: Add support for non-zero firstTask in vkCmdDrawMeshTasksNV
Signed-off-by: Marcin Ślusarz <marcin.slusarz@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13662>
| -rw-r--r-- | src/intel/vulkan/genX_cmd_buffer.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index f5e39fced96..5b7e05ea60f 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/intel/vulkan/genX_cmd_buffer.c @@ -4857,12 +4857,15 @@ genX(CmdDrawMeshTasksNV)( if (cmd_buffer->state.conditional_render_enabled) genX(cmd_emit_conditional_render_predicate)(cmd_buffer); - /* TODO(mesh): Support non-zero firstTask. */ - assert(firstTask == 0); + /* BSpec 54016 says: "The values passed for Starting ThreadGroup ID X + * and ThreadGroup Count X shall not cause TGIDs to exceed (2^32)-1." + */ + assert((int64_t)firstTask + taskCount - 1 <= UINT32_MAX); anv_batch_emit(&cmd_buffer->batch, GENX(3DMESH_1D), m) { m.PredicateEnable = cmd_buffer->state.conditional_render_enabled; m.ThreadGroupCountX = taskCount; + m.StartingThreadGroupIDX = firstTask; } } |