summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVinson Lee <vlee@freedesktop.org>2023-06-03 16:32:44 -0700
committerVinson Lee <vlee@freedesktop.org>2023-06-03 17:42:58 -0700
commitbfb092b955516d5ff0d1cfb73de80fed30cec6c3 (patch)
treeb7208c9a6c198f1be3f1b656dde2b39a10aa16e4
parent87ac5d7d0a14be1457385ccf3e11059aedd95acb (diff)
nv50: Fix memory leak in error path
Fix defect reported by Coverity Scan. Resource leak (RESOURCE_LEAK) leaked_storage: Variable memobj going out of scope leaks the storage it points to. Fixes: a1571333804 ("nvc0/nv50: support and enable EXT_memory_object*") Signed-off-by: Vinson Lee <vlee@freedesktop.org> Reviewed-by: Karol Herbst <kherbst@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23417>
-rw-r--r--src/gallium/drivers/nouveau/nv50/nv50_resource.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gallium/drivers/nouveau/nv50/nv50_resource.c b/src/gallium/drivers/nouveau/nv50/nv50_resource.c
index 6e215be55a5..2e2961c88a8 100644
--- a/src/gallium/drivers/nouveau/nv50/nv50_resource.c
+++ b/src/gallium/drivers/nouveau/nv50/nv50_resource.c
@@ -109,7 +109,7 @@ nv50_memobj_create_from_handle(struct pipe_screen *screen,
memobj->bo = nouveau_screen_bo_from_handle(screen, handle, &memobj->stride);
if (memobj->bo == NULL) {
- FREE(memobj->bo);
+ FREE(memobj);
return NULL;
}
memobj->handle = handle;