summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKarol Herbst <kherbst@redhat.com>2023-10-24 21:28:02 +0200
committerEric Engestrom <eric@engestrom.ch>2023-10-30 15:47:32 +0000
commitbcfdd7476fad4cd0d3c7adffca7bb2646a2ae908 (patch)
tree49a044407d981736ca780206a2fa960d7ab413e4
parent336e6df3ef959fe9a968c48b56e8bda7e96573c2 (diff)
rusticl/device: restrict param_max_size further
It's kinda pointless to have it too big, it also causes weird shaders to be generated and causes stack overflows in `nir_opt_gcm`. Nothing needs big values here anyway. Cc: mesa-stable Signed-off-by: Karol Herbst <kherbst@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25837> (cherry picked from commit 694001eef70e220c709523cd71aad4b7b7c6c8db)
-rw-r--r--.pick_status.json2
-rw-r--r--src/gallium/frontends/rusticl/core/device.rs2
2 files changed, 2 insertions, 2 deletions
diff --git a/.pick_status.json b/.pick_status.json
index 39c4d0675f8..28636b62eab 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -754,7 +754,7 @@
"description": "rusticl/device: restrict param_max_size further",
"nominated": true,
"nomination_type": 0,
- "resolution": 0,
+ "resolution": 1,
"main_sha": null,
"because_sha": null,
"notes": null
diff --git a/src/gallium/frontends/rusticl/core/device.rs b/src/gallium/frontends/rusticl/core/device.rs
index 8058f5cbb79..0a5e07ffb5a 100644
--- a/src/gallium/frontends/rusticl/core/device.rs
+++ b/src/gallium/frontends/rusticl/core/device.rs
@@ -856,7 +856,7 @@ impl Device {
pub fn param_max_size(&self) -> usize {
min(
self.shader_param(pipe_shader_cap::PIPE_SHADER_CAP_MAX_CONST_BUFFER0_SIZE) as u32,
- 32 * 1024,
+ 4 * 1024,
) as usize
}