summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPavel Ondračka <pavel.ondracka@gmail.com>2022-02-07 16:49:38 +0100
committerDylan Baker <dylan.c.baker@intel.com>2022-02-24 14:56:50 -0800
commitb8e9c345d063c8283be9cb2e625f09e7de7ce47b (patch)
treee6961a464f48bacd19c3e5d540b61f0be6b98455
parent3b1563dcfb4d2123338fc46a4c2bc1310395baee (diff)
r300: fix transformation of abs modifiers with negate
It is being overwritten by the memset. Just set the only remaining member RelAddr explicitly. Signed-off-by: Pavel Ondračka <pavel.ondracka@gmail.com> Reviewed-by: Filip Gawin <filip.gawin@zoho.com> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14915> (cherry picked from commit 1f5330de3a6c54faf7a0ed7485c72a2ce40ac744)
-rw-r--r--.pick_status.json2
-rw-r--r--src/gallium/drivers/r300/compiler/r3xx_vertprog.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/.pick_status.json b/.pick_status.json
index f3cebbaf028..d1817a7e0d5 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -292,7 +292,7 @@
"description": "r300: fix transformation of abs modifiers with negate",
"nominated": true,
"nomination_type": 0,
- "resolution": 0,
+ "resolution": 1,
"main_sha": null,
"because_sha": null
},
diff --git a/src/gallium/drivers/r300/compiler/r3xx_vertprog.c b/src/gallium/drivers/r300/compiler/r3xx_vertprog.c
index de0d98240f3..ea84ad17ece 100644
--- a/src/gallium/drivers/r300/compiler/r3xx_vertprog.c
+++ b/src/gallium/drivers/r300/compiler/r3xx_vertprog.c
@@ -688,10 +688,10 @@ static int transform_nonnative_modifiers(
new_inst->U.I.SrcReg[1] = inst->U.I.SrcReg[i];
new_inst->U.I.SrcReg[1].Negate ^= RC_MASK_XYZW;
- memset(&inst->U.I.SrcReg[i], 0, sizeof(inst->U.I.SrcReg[i]));
inst->U.I.SrcReg[i].File = RC_FILE_TEMPORARY;
inst->U.I.SrcReg[i].Index = temp;
inst->U.I.SrcReg[i].Swizzle = RC_SWIZZLE_XYZW;
+ inst->U.I.SrcReg[i].RelAddr = 0;
}
}
return 1;