summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKeith Whitwell <keithw@vmware.com>2009-11-06 08:28:17 +0000
committerKeith Whitwell <keithw@vmware.com>2009-11-06 08:28:17 +0000
commitb8e63e92102b6ca0b5ce06685590232a3a47d1ea (patch)
tree4944790c20ee3f5050c288777edcdf066bcf7c67
parentb9bb41321a9add139cd1dbddcf48e6c81c9d019d (diff)
i965g: point_rast_rule comment no longer applies
Not sure exactly what state we want here now, will need to experiment.
-rw-r--r--src/gallium/drivers/i965/brw_sf_state.c30
1 files changed, 4 insertions, 26 deletions
diff --git a/src/gallium/drivers/i965/brw_sf_state.c b/src/gallium/drivers/i965/brw_sf_state.c
index 955478e6240..25dc2b52e07 100644
--- a/src/gallium/drivers/i965/brw_sf_state.c
+++ b/src/gallium/drivers/i965/brw_sf_state.c
@@ -221,32 +221,10 @@ sf_unit_create_from_key(struct brw_context *brw,
/* XXX: gl_rasterization_rules? something else?
*/
- if (0) {
- /* Rendering to an OpenGL window */
- sf.sf6.point_rast_rule = BRW_RASTRULE_UPPER_RIGHT;
- }
- else {
- /* If rendering to an FBO, the pixel coordinate system is
- * inverted with respect to the normal OpenGL coordinate
- * system, so BRW_RASTRULE_LOWER_RIGHT is correct.
- * But this value is listed as "Reserved, but not seen as useful"
- * in Intel documentation (page 212, "Point Rasterization Rule",
- * section 7.4 "SF Pipeline State Summary", of document
- * "IntelĀ® 965 Express Chipset Family and IntelĀ® G35 Express
- * Chipset Graphics Controller Programmer's Reference Manual,
- * Volume 2: 3D/Media", Revision 1.0b as of January 2008,
- * available at
- * http://intellinuxgraphics.org/documentation.html
- * at the time of this writing).
- *
- * It does work on at least some devices, if not all;
- * if devices that don't support it can be identified,
- * the likely failure case is that points are rasterized
- * incorrectly, which is no worse than occurs without
- * the value, so we're using it here.
- */
- sf.sf6.point_rast_rule = BRW_RASTRULE_LOWER_RIGHT;
- }
+ sf.sf6.point_rast_rule = BRW_RASTRULE_UPPER_RIGHT;
+ sf.sf6.point_rast_rule = BRW_RASTRULE_LOWER_RIGHT;
+ sf.sf6.point_rast_rule = 1;
+
/* XXX clamp max depends on AA vs. non-AA */
/* _NEW_POINT */