summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDave Airlie <airlied@redhat.com>2022-02-21 09:35:00 +1000
committerEric Engestrom <eric@engestrom.ch>2022-02-23 17:55:57 +0000
commitb07f30270c2241bb3250dc19f9fadefea2fb24f5 (patch)
treea3942fefda139dd3f0c45a3bfc730b198e5fa134
parentb75deed85a7c05ffa5637568428d91da5aafeabc (diff)
crocus: fix leak on gen4/5 stencil fallback blit path.
Noticed by Ilia. Fixes: f3630548f1da ("crocus: initial gallium driver for Intel gfx 4-7") Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15100> (cherry picked from commit 0f989a840efda4aedee2dbf009c400c428be01d7)
-rw-r--r--.pick_status.json2
-rw-r--r--src/gallium/drivers/crocus/crocus_blit.c1
2 files changed, 2 insertions, 1 deletions
diff --git a/.pick_status.json b/.pick_status.json
index 8dfde437e45..428461c3777 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -1093,7 +1093,7 @@
"description": "crocus: fix leak on gen4/5 stencil fallback blit path.",
"nominated": true,
"nomination_type": 1,
- "resolution": 0,
+ "resolution": 1,
"main_sha": null,
"because_sha": "f3630548f1da904ec6c63b43ece7e68afdb8867e"
},
diff --git a/src/gallium/drivers/crocus/crocus_blit.c b/src/gallium/drivers/crocus/crocus_blit.c
index 7620efc932b..67c10e7c00e 100644
--- a/src/gallium/drivers/crocus/crocus_blit.c
+++ b/src/gallium/drivers/crocus/crocus_blit.c
@@ -433,6 +433,7 @@ crocus_blit(struct pipe_context *ctx, const struct pipe_blit_info *info)
info->src.level,
&info->src.box, NULL);
+ pipe_surface_release(ctx, &dst_view);
}
return;
}