diff options
| author | Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> | 2020-02-03 14:28:18 -0500 |
|---|---|---|
| committer | Tomeu Vizoso <tomeu.vizoso@collabora.com> | 2020-02-04 08:24:18 +0100 |
| commit | 8ec4028d4057da19708b4f4bce88ee16f96f322a (patch) | |
| tree | 41778f6e1252ec3f89d47c4606f80209bc2b0ff3 | |
| parent | c32bd325e7688c781b7e5de58a2d0534c82f00a0 (diff) | |
panfrost: Avoid overlapping copy
CID 1457486: Memory - corruptions (OVERLAPPING_COPY)
Assigning "(*attr).extra_flags = (*attr).size = 0U" to "(*attr).stride",
which have overlapping memory +locations.
Coverity.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3684>
| -rw-r--r-- | src/panfrost/encoder/pan_attributes.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/panfrost/encoder/pan_attributes.c b/src/panfrost/encoder/pan_attributes.c index d15ed9c1ea1..d4c8ab6e8ad 100644 --- a/src/panfrost/encoder/pan_attributes.c +++ b/src/panfrost/encoder/pan_attributes.c @@ -202,7 +202,9 @@ panfrost_instance_id( union mali_attr *attr) { attr->elements = MALI_ATTR_INSTANCEID; - attr->stride = attr->extra_flags = attr->size = 0; + attr->stride = 0; + attr->extra_flags = 0; + attr->size = 0; /* POT records have just a shift directly with an off-by-one for * unclear reasons. NPOT records have a magic divisor smushed into the |