summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCharmaine Lee <charmainel@vmware.com>2016-07-11 17:11:41 -0700
committerBrian Paul <brianp@vmware.com>2016-07-15 14:24:34 -0600
commit6b7923ee46eca7b98a36992f77fea362b469a1d9 (patch)
treef51815db8f8c574b270a292d76b28ddef9869642
parent4f633d110ac552f7658199dacf80df15d6690c24 (diff)
svga: avoid ubinding render targets that have already been unbound
Fixed the remaining redundant SetRenderTargets command emission. Tested with lightsMark2008, Heaven, mtt piglit, glretrace, conform. Reviewed-by: Brian Paul <brianp@vmware.com>
-rw-r--r--src/gallium/drivers/svga/svga_state_framebuffer.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/src/gallium/drivers/svga/svga_state_framebuffer.c b/src/gallium/drivers/svga/svga_state_framebuffer.c
index 54f75a2f834..b1362a98168 100644
--- a/src/gallium/drivers/svga/svga_state_framebuffer.c
+++ b/src/gallium/drivers/svga/svga_state_framebuffer.c
@@ -168,6 +168,7 @@ emit_fb_vgpu10(struct svga_context *svga)
struct pipe_framebuffer_state *curr = &svga->curr.framebuffer;
struct pipe_framebuffer_state *hw = &svga->state.hw_clear.framebuffer;
const unsigned num_color = MAX2(curr->nr_cbufs, hw->nr_cbufs);
+ int last_rtv = -1;
unsigned i;
enum pipe_error ret = PIPE_OK;
@@ -187,6 +188,7 @@ emit_fb_vgpu10(struct svga_context *svga)
}
assert(svga_surface(rtv[i])->view_id != SVGA3D_INVALID_ID);
+ last_rtv = i;
}
else {
rtv[i] = NULL;
@@ -213,7 +215,10 @@ emit_fb_vgpu10(struct svga_context *svga)
if (ret != PIPE_OK)
return ret;
- svga->state.hw_draw.num_rendertargets = num_color;
+ /* number of render targets sent to the device, not including trailing
+ * unbound render targets.
+ */
+ svga->state.hw_draw.num_rendertargets = last_rtv + 1;
svga->state.hw_draw.dsv = dsv;
memcpy(svga->state.hw_draw.rtv, rtv, num_color * sizeof(rtv[0]));