summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorErik Faye-Lund <erik.faye-lund@collabora.com>2021-04-22 13:46:41 +0200
committerMarge Bot <eric+marge@anholt.net>2021-05-05 09:37:18 +0000
commit2736370294427d87933ce7ae293e0465fbab77e2 (patch)
tree88516bcd2c271ed4b165a6e4cccef7dbcee18f89
parent5a1675a03030c68f2f4b27f1a687b56762e4190a (diff)
docs: do not generate redirects on error
The build-finished event is also triggered when there's an error. I somehow got the second argument wrong, and ended up ignoring the case. This can lead to new exceptions being thrown due to missing files, that ends up hiding the real problem. Fixes: 64a4ba9e1ce ("docs: add an extension to generate redirects") Reviewed-by: Eric Engestrom <eric@engestrom.ch> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10407>
-rw-r--r--docs/_exts/redirects.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/docs/_exts/redirects.py b/docs/_exts/redirects.py
index 90d69efee5f..1adf3cdb8ab 100644
--- a/docs/_exts/redirects.py
+++ b/docs/_exts/redirects.py
@@ -6,8 +6,8 @@ def create_redirect(dst):
tpl = '<html><head><meta http-equiv="refresh" content="0; url={0}"><script>window.location.replace("{0}")</script></head></html>'
return tpl.format(dst)
-def create_redirects(app, docname):
- if not app.builder.name == 'html':
+def create_redirects(app, exception):
+ if exception is not None or not app.builder.name == 'html':
return
for src, dst in app.config.html_redirects:
path = os.path.join(app.outdir, '{0}.html'.format(src))