summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Schürmann <daniel@schuermann.dev>2021-10-04 11:03:14 +0100
committerMarge Bot <emma+marge@anholt.net>2021-12-31 14:52:14 +0000
commit11712729eb837f093816028b5ec9802a03f6f6ed (patch)
tree966576d96fc63710c10d5db30b3660b6cdd7b856
parent1502c22e2c32d6a87dd17bdc76af68b8470cb6ea (diff)
aco/optimizer: keep instr_mod_labels after applying extract
This allows to use clamp on SDWA and VOP3 opsel instructions. Totals from 32 (0.02% of 134572) affected shaders: (GFX10.3) SpillVGPRs: 1783 -> 1780 (-0.17%); split: -0.50%, +0.34% CodeSize: 881480 -> 881496 (+0.00%); split: -0.15%, +0.15% Instrs: 154400 -> 154388 (-0.01%); split: -0.13%, +0.12% Latency: 5021791 -> 5033485 (+0.23%); split: -0.67%, +0.90% InvThroughput: 2486454 -> 2492312 (+0.24%); split: -0.67%, +0.91% VClause: 4763 -> 4755 (-0.17%); split: -0.52%, +0.36% Copies: 42866 -> 42965 (+0.23%); split: -0.25%, +0.48% Branches: 5640 -> 5639 (-0.02%) Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13576>
-rw-r--r--src/amd/compiler/aco_optimizer.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/amd/compiler/aco_optimizer.cpp b/src/amd/compiler/aco_optimizer.cpp
index faa82fdf9e9..1e314ed9550 100644
--- a/src/amd/compiler/aco_optimizer.cpp
+++ b/src/amd/compiler/aco_optimizer.cpp
@@ -1030,9 +1030,9 @@ apply_extract(opt_ctx& ctx, aco_ptr<Instruction>& instr, unsigned idx, ssa_info&
instr->vop3().opsel |= 1 << idx;
}
- /* label_vopc seems to be the only one worth keeping at the moment */
+ /* output modifier and label_vopc seem to be the only one worth keeping at the moment */
for (Definition& def : instr->definitions)
- ctx.info[def.tempId()].label &= label_vopc;
+ ctx.info[def.tempId()].label &= (label_vopc | instr_mod_labels);
}
void