Age | Commit message (Collapse) | Author | Files | Lines |
|
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/712>
|
|
This seems to have gotten past the AMD binary driver due to it
implicitly converting the result back to a half float which isn't
actually allowed without GL_ARB_shading_language_420pack.
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/712>
|
|
It didn't work at all. There were lots of bugs, nonsense, and duplication,
and the texture completeness test was failing.
This is much simpler.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/713>
|
|
When tests whose names were too long were renamed, they were only
changed in the build, and not in the runner which was still looking for
the old names.
Fixes: 3a1dfe70fa35 ("tests: Rename tests with overly-long names")
Signed-off-by: Daniel Stone <daniels@collabora.com>
Reported-by: Michel Dänzer <daenzer@redhat.com>
Reviewed-by: Michel Dänzer <mdaenzer@redhat.com>
Tested-by: Michel Dänzer <mdaenzer@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/714>
|
|
Under CMake, we end up with a limit of 250 characters for the path name.
CMake was generating names like:
C:/Users/Administrator/runner/builds/daniels/piglit/target_api/gl/tests/spec/arb_framebuffer_object/CMakeFiles/same-attachment-glFramebufferRenderbuffer-GL_DEPTH_STENCIL_ATTACHMENT.dir/./same-attachment-glFramebufferRenderbuffer-GL_DEPTH_STENCIL_ATTACHMENT.c.obj
Rename the three most egregiously long test names to work around this.
Signed-off-by: Daniel Stone <daniels@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/710>
|
|
This is feature is not part of EXT_texture_env_combine, but it was added
by basically every extension that came after. All of the
ATI_texture_env_combine3 test cases in this test try to use this
feature, and they all fail with:
Problem in combine(): bad alphaOperand2
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/706>
|
|
GL_ARB_shading_language_420pack
GL_ARB_shading_language_420pack is requred for implicit conversions
of return value.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/707>
|
|
test
This worked on the AMD closed driver but its not actually allowed by
the spec.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/707>
|
|
Needed a vertex passthrough shader. Add a clear so that we know
we are not just testing the previous shader_runner result.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/707>
|
|
Without this fix, glGetIntegerv can report INT_MAX, which won't return
an error because it's not more than UINT32_MAX, so it will start a dispatch
of (INT_MAX+1)^3, which is long enough to be treated as a hang.
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/695>
|
|
this avoids wsi deadlocks
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/705>
|
|
v2: Support 1/2/4/8/16 samples (Mike)
Signed-off-by: Pavel Asyutchenko <sventeam@yandex.ru>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/611>
|
|
lima driver exposes GL_ARB_blend_func_extended, but it has no
GL_EXT_gpu_shader4 support. The only way to use it in GL
is by using GLES2 shaders.
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/688>
|
|
All tests pass on the AMD closed driver, except the
GL_ARB_gpu_shader_int64 test as the driver doesn't support that
extension and skips the test.
Acked-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/698>
|
|
Fix defects reported by Coverity Scan.
Uninitialized scalar variable (UNINIT)
uninit_use: Using uninitialized value use_gl_sample_position.
uninit_use: Using uninitialized value use_interpolate_at_sample
Fixes: 5e9ede3e8 ("add GL_ARB_sample_locations")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/667>
|
|
Fix defect reported by Coverity Scan.
Uninitialized pointer read (UNINIT)
uninit_use_in_call: Using uninitialized value ctx when calling glXDestroyContext.
Fixes: 4991384f1 ("glx: add test for GLX_ARB_create_context_no_error")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/692>
|
|
There's nothing timing-related or window-system related here, so run
it concurrent. Dodges an unrelated softpipe flake where the setup of
the frontbuffer rendering to the window (since this test also fails to
set PIGLIT_VISUAL_DOUBLE) produced an error from X11, and that results
in piglit atexit handlers firing ending with a segfault in X11 during
teardown.
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/651>
|
|
This tests whether the loop will unroll if one component of vec4 is
used as a loop counter. Similar code can be produced by running C&C3
Tiberium Wars under nine with non-integer hardware and than going
through ttn.
Signed-off-by: Pavel Ondračka <pavel.ondracka@gmail.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/673>
|
|
This is based on the existing vs-loop-complex-unroll-with-else-break
test, however this one can't be unrolled and demonstrates an issue
with copy propagation in r300 compiler.
More details in: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6467
Signed-off-by: Pavel Ondračka <pavel.ondracka@gmail.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/694>
|
|
Fix defect reported by Coverity Scan.
Use after free (USE_AFTER_FREE)
pass_freed_arg: Passing freed pointer got_pixels as an argument to *piglit_dispatch_glTextureImage2DEXT.
Fixes: 1429c2c69 ("ext_direct_state_access: add tests for glTexture*EXT functions")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/691>
|
|
Seriously.
The Linux OpenGL ABI has always required at least OpenGL 1.2. The
Windows OpenGL ABI has always required at least OpenGL 1.1. I don't
know what the Mac OS X ABI requires, but every supported device has
had 1.1 at least as far back as 10.5.8. SGI O2 and Octane support at
least OpenGL 1.1. I don't think piglit needs to fail gracefully on
systems from before 1996.
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/686>
|
|
piglit_require_GLSL() only checks that shader objects and the shading
language exist. It does *NOT* check that any particular shader stage
exists. It is perfectly valid to have an OpenGL 1.5 implementation that
has only vertex shaders or only fragment shaders.
piglit_require_GLSL_version(110) and piglit_require_GLSL_version(120)
have the same failings as piglit_require_GLSL() and more. GLSL 1.10 is
the minimum GLSL version that actually exists, so anything that has GLSL
has version 1.10. GLSL 1.20 can be exposed by any implementation, so
checking that version doesn't guarantee anything either. GLSL 1.30
implicitly requires OpenGL 3.0, so that is a strong check.
All of the non-shader drivers in Mesa advertise shader objects and GLSL
1.20 and NEITHER vertex nor fragment stages. This fixes these tests to
just skip on those drivers.
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/686>
|
|
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/686>
|
|
Remove check for:
1. GLSL version checks that are redundant with GL version checks (e.g.,
checking for GLSL 1.30 when the test already required OpenGL 3.0).
2. GL version checks that are redundant with the requirements section.
3. One call to piglit_require_GLSL() when no GLSL related API calls are
made.
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/686>
|
|
Neither GL_EXT_packed_depth_stencil nor GL_ARB_depth_buffer_float
implies that the implementation can create depth textures. This affects
the R200 driver in Mesa, for example.
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/686>
|
|
Here we make sure gl_FragColor.x is always given a value. Otherwise
the if (b) check, the coord uniform etc can all be optimised away
because gl_FragColor.x can simply always be set to 1.0 as anything
else is undefined.
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/690>
|
|
sqrt() on Mali4x0 PP is too imprecise, so with 3 passes
accumulated error is enough for the test to fail.
Since we don't really care how to transform the data,
replace sqrt() with multiplication.
Acked-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/689>
|
|
Fix defect reported by Coverity Scan.
Logically dead code (DEADCODE)
dead_error_condition: The condition enable_dither & visualize & (num_samples = 0) cannot be true.
Fixes: 8ea4dcbd2 ("tests: Added tests for nv_alpha_to_coverage_dither_control")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/684>
|
|
Fix defect reported by Coverity Scan.
Uninitialized scalar field (UNINIT_CTOR)
uninit_member: Non-static class member mType is not initialized in
this constructor nor in any functions that it calls.
Fixes: 1d0af5e7c ("llvmpipe: Add tests designed to exercise llvmpipe linear rasterizer.")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/681>
|
|
The counter exposed by this ARB_shader_clock is "monotonically
incrementing [...] within a single shader invocation" so we
can't compare the value from one dispatch with one from a later
dispatch.
Reviewed-by: Nicolai Hähnle <nicolai.haehnle@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/685>
|
|
Switch to one-based indices for primitive and index and use the table
from https://www.khronos.org/opengl/wiki/Primitive to compute the
correct index.
This fixes the test for radeonsi, llvmpipe and zink (and probably
other drivers but I can't test them).
Acked-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/680>
|
|
ux has type unsigned.
Fix defect reported by Coverity Scan.
Unsigned compared against 0 (NO_EFFECT)
unsigned_compare: This less-than-zero comparison of an unsigned value is never true. ux < 0U.
Fixes: 728dde0e0 ("shader_runner: add xfb testing support")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/682>
|
|
Fix defects reported by Coverity Scan.
Resource leak (RESOURCE_LEAK)
leaked_storage: Variable attachments going out of scope leaks the storage it points to.
Fixes: deec4392c ("ext_direct_state_access: add test for Framebuffer functions")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/679>
|
|
GL_MAX_TEXTURE_BUFFER_SIZE_ARB + 1 won't necessarly fit in an int32_t so use
a int64_t in the computation.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/675>
|
|
Fix defects reported by Coverity Scan.
Resource leak (RESOURCE_LEAK)
leaked_storage: Variable dst_data going out of scope leaks the storage it points to.
leaked_storage: Variable src_data going out of scope leaks the storage it points to.
leaked_storage: Variable exp_data going out of scope leaks the storage it points to.
Fixes: c02fca9f8 ("Ported logicop test from Glean to Piglit.")
Fixes: c773ae680 ("test/logicop: expand tests to also cover MSAA render target")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/666>
|
|
Fixes https://gitlab.freedesktop.org/mesa/piglit/-/issues/69
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/678>
|
|
prop_count is of type uint32_t.
Fix defect reported by Coverity Scan.
Unsigned compared against 0 (NO_EFFECT)
unsigned_compare: This less-than-zero comparison of an unsigned value is never true. prop_count < 0U.
Fixes: a0722042b ("ext_external_objects: Selecting a queue that supports graphics")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/663>
|
|
Waffle 1.6.0 was released over 2 years ago. Even Debian stable has
version 1.6.3.
As result remove all the ifdef version checks.
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Corentin Noël <corentin.noel@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/592>
|
|
It is an EGL surfaceless platform, so might as well guard it properly.
Otherwise we would end building it on Windows where (barring ANGLE) it
is not a thing.
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Corentin Noël <corentin.noel@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/592>
|
|
Vestigial reference which accidentally got in.
Fixes: https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/529
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/672>
|
|
Fix defect reported by Coverity Scan.
Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking attachments suggests that it may
be null, but it has already been dereferenced on all paths leading
to the check.
Fixes: 8713fbda2 ("ext_external_objects: Vulkan framework additions")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/660>
|
|
They are already defined somewhere else in this case.
Signed-off-by: Corentin Noël <corentin.noel@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/626>
|
|
Fix defect reported by Coverity Scan.
Resource leak (RESOURCE_LEAK)
leaked_storage: Variable texel_fetch_macro going out of scope leaks the storage it points to.
Fixes: 8e842367d ("ext_framebuffer_multisample_blit_scaled: Rewrite the fragment shader")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/657>
|
|
See https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10765
v2: Fix out-of-source builds. Remove unused variable. Define NOGDI to
avoid Polygon symbol clash. Fix build when Git is not found.
-- Jose Fonseca <jfonseca@vmware.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/529>
|
|
Fix defect reported by Coverity Scan.
Resource leak (RESOURCE_LEAK)
leaked_storage: Variable offset_coords going out of scope leaks the storage it points to.
Fixes: 95241b0c6 ("textureGather: make sure to test out min/max offsets")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/655>
|
|
Noticed in updated deqp-runner which reports Missing instead of just
Fail (seems reasonable for a missing binary).
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/650>
|
|
"'GL_PROGRAM_INPUT(vs,fs) active resources' expected 2 but got 6" is
not very useful without also seeing the list of resources you got.
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/661>
|
|
From the ARB_shader_objects spec:
The error INVALID_VALUE is generated by any command that takes one or
more handles as input, and one or more of these handles are not an
object handle generated by OpenGL.
However, Mesa's implementation of glDeleteObjectARB does not emit that
error at the time of writing.
Let's add a test to make sure we don't regress this in the future.
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/656>
|
|
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/658>
|
|
Fix defect reported by Coverity Scan.
Resource leak (RESOURCE_LEAK)
leaked_storage: Variable name going out of scope leaks the storage it points to.
Fixes: 98f9fb5f8 ("texture integer getTexImage clamping: Remove GLenum string literals.")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/646>
|