diff options
| author | Andres Gomez <agomez@igalia.com> | 2021-02-01 17:32:26 +0200 |
|---|---|---|
| committer | Marge Bot <eric+marge@anholt.net> | 2021-02-10 10:42:47 +0000 |
| commit | 5fc7342477df36ecc27bf4bffea26d3ada83e3ce (patch) | |
| tree | 37a5d49aa035de024a905230c8b161120e38ddb3 /framework | |
| parent | 3b1e87da57e377d0731d7ce5a3acffb10983b9bd (diff) | |
framework/replay: do not raise in compare if no images were dumped
Previously we were trusting that the backends will always return a
failure in case replaying a trace was not succesfull.
Now, we manage also this scenario without exceptions because
eglretrace won't fail if the parameters passed are malformed and we
really want to deal with it gracefully in any case.
Signed-off-by: Andres Gomez <agomez@igalia.com>
Reviewed-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
Acked-by: Martin Peres <martin.peres@mupuf.org>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/466>
Diffstat (limited to 'framework')
| -rw-r--r-- | framework/replay/compare_replay.py | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/framework/replay/compare_replay.py b/framework/replay/compare_replay.py index cd4156d8c..c67c76340 100644 --- a/framework/replay/compare_replay.py +++ b/framework/replay/compare_replay.py @@ -72,9 +72,10 @@ def _replay(trace_path, results_path): file_name = path.basename(trace_path) files = glob(path.join(results_path, file_name + '-*' + '.png')) if not files: - raise exceptions.PiglitFatalError( - 'No dumped files found ' - 'in the results path "{}".'.format(results_path)) + print('[check_image] No dumped files found ' + 'in the results path "{}". ' + 'See above logs for more information.'.format(results_path)) + return None, None image_file = files[0] return hexdigest_from_image(image_file), image_file |