diff options
| author | Emma Anholt <emma@anholt.net> | 2023-01-25 09:37:21 -0800 |
|---|---|---|
| committer | Marge Bot <emma+marge@anholt.net> | 2023-02-01 19:53:02 +0000 |
| commit | 025e04cfcbd14d095eed57c546500012940173f5 (patch) | |
| tree | dad24518790ed3088289f403443342efab207ffa | |
| parent | 1a55fb4c34489a2a0de89846b2ee93c7a76d8c91 (diff) | |
shader_runner: Improve link_error output.
If you're expecting link to fail but it succeeds, that's suitable for
stderr. But if link is supposed to fail and it in fact does fail,
that's the right thing! Don't whine to stderr about it!
Acked-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/762>
| -rw-r--r-- | tests/shaders/shader_runner.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index b8191231e..b353bebdc 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_runner.c @@ -5415,10 +5415,10 @@ piglit_display(void) } else if (parse_str(line, "link error", &rest)) { link_error_expected = true; if (link_ok) { - printf("shader link error expected, but it was successful!\n"); + fprintf(stderr, "shader link error expected, but it was successful!\n"); piglit_report_result(PIGLIT_FAIL); } else { - fprintf(stderr, "Failed to link:\n%s\n", prog_err_info); + printf("Failed to link (as expected):\n%s\n", prog_err_info); } } else if (parse_str(line, "link success", &rest)) { result = program_must_be_in_use(); |