summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-01-06radeonsi: disable SDMA on gfx8 to fix corruption on RX 580Marek Olšák1-0/+5
Closes: #1399 Closes: #1889 Cc: 19.2 19.3 <mesa-stable@lists.freedesktop.org> Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Reviewed-By: Timur Kristóf <timur.kristof@gmail.com>
2020-01-06radeonsi: move SI and CIK+ SDMA code into 1 common function for cleanupsMarek Olšák12-190/+104
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Reviewed-By: Timur Kristóf <timur.kristof@gmail.com>
2020-01-06radeonsi: rename dma_cs -> sdma_csMarek Olšák10-46/+46
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Reviewed-By: Timur Kristóf <timur.kristof@gmail.com>
2020-01-06radeonsi: add AMD_DEBUG=nodmacopyimage for debuggingMarek Olšák3-1/+4
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Reviewed-By: Timur Kristóf <timur.kristof@gmail.com>
2020-01-06radeonsi: add AMD_DEBUG=nodmaclear for debuggingMarek Olšák3-1/+4
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Reviewed-By: Timur Kristóf <timur.kristof@gmail.com>
2020-01-06radeonsi: remove broken and unused SI SDMA image copy codeMarek Olšák1-181/+2
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Reviewed-By: Timur Kristóf <timur.kristof@gmail.com>
2020-01-06radeonsi: rename SDMA debug flagsMarek Olšák4-9/+9
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Reviewed-By: Timur Kristóf <timur.kristof@gmail.com>
2020-01-06gitlab-ci: Switch LAVA jobs to use shared dEQP runnerTomeu Vizoso17-292/+206
Take one step towards sharing code between the LAVA and non-LAVA jobs, with the goals of reducing maintenance burden and use of computational resources. The env var DEQP_NO_SAVE_RESULTS allows us to skip the procesing of the XML result files, which can take a long time and is not useful in the LAVA case as we are not uploading artifacts anywhere at the moment. Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Reviewed-by: Eric Anholt <eric@anholt.net>
2020-01-06gitlab-ci: Update kernel for LAVA to 5.5-rc1 plus fixesTomeu Vizoso2-2/+2
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Reviewed-by: Eric Anholt <eric@anholt.net>
2020-01-06panfrost: Handle PIPE_FORMAT_R10G10B10A2_USCALEDAlyssa Rosenzweig1-0/+2
Same format code as UINT... might be different in how it's fed into a shader but we'll deal with that when we get there. Fixes dEQP-GLES3.functional.vertex_arrays.single_attribute.output_types.usigned_int2_10_10_10.components4_vec2_quads1 Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
2020-01-06panfrost: Report MSAA 4x supported for dEQPAlyssa Rosenzweig1-1/+10
Fixes dEQP-GLES3.functional.state_query.integers.max_samples_getinteger64 We'll have to actually implement multisampling next, but hey. Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
2020-01-06panfrost: Cleanup tiling selection logicAlyssa Rosenzweig1-13/+14
Make it a lot more obvious what we're doing and fix more than a few corner cases in the process. Fixes dEQP-GLES3.functional.buffer.map.write.render_as_index_array.pixel*, and likely others. Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
2020-01-06panfrost: Implement sRGB blend shadersAlyssa Rosenzweig2-8/+16
We use the lowering in nir_format_convert. There are native ops for this so this is far from optimal and not remotely efficient but as with most blend shader things right now, it's hard enough to get it working, so let's focus on that for now. We'll make it fast later (once we have GLES3 stable, we can start optimizing these things). Fixes dEQP-GLES3.functional.fragment_ops.blend.fbo_srgb.* Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
2020-01-06panfrost: Support rendering to non-zero Z/S layersAlyssa Rosenzweig1-5/+5
Fixes abort in STK's shadow implementation. Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
2020-01-06panfrost: Texture from Z32F_S8 as R32FAlyssa Rosenzweig1-0/+4
Z32F_S8 becomes Z32F in texturing, which in turn just becomes R32F. Fixes dEQP-GLES3.functional.texture.format.sized.*.depth32f_stencil8* Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
2020-01-06iris/query: Implement PIPE_QUERY_GPU_FINISHEDDanylo Piliaiev1-0/+17
Implementation is similar to radeonsi in 5f1cef76 Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
2020-01-06st/mesa: use uint-samplers for sampling stencil buffersErik Faye-Lund1-4/+6
Otherwise, we end up mismatching the sampler types when rendering. Signed-off-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com>
2020-01-06ac/surface: use uint16_t for mipmap level pitchesSamuel Pitoiset1-1/+1
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com>
2020-01-05etnaviv: fix incorrectly failing vertex size assertJonathan Marek1-1/+1
Changes the assert to match the comment above. This assert was failing in some cases while running darkplaces. Signed-off-by: Jonathan Marek <jonathan@marek.ca> Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
2020-01-05lima: fix PP stream terminator sizeVasily Khoruzhick1-1/+3
PP stream terminator size seems to be 4 words, it worked with full PP stream because we align stream beginning to 32 bytes and BO is initialized with zeroes. But with partial PP stream it sometimes break if for new PP stream we reuse BO that has non-zero value at this place. Reviewed-by: Qiang Yu <yuq825@gmail.com> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
2020-01-05lima: don't reload and redraw tiles that were not updatedVasily Khoruzhick3-7/+67
We don't need to reload and redraw some tiles if framebuffer was not cleared and scissor test was enabled for some of draws. This simple optimization fixes cursor lag in X11 Reviewed-by: Qiang Yu <yuq825@gmail.com> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
2020-01-05lima: postpone PP stream generationVasily Khoruzhick1-11/+17
This commit postpones PP stream generation till job is submitted. Doing that this late allows us to skip reloading and redrawing tiles that were not updated. Reviewed-by: Qiang Yu <yuq825@gmail.com> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
2020-01-05lima/parser: Fix VS cmd stream parserAndreas Baierl1-2/+2
prefetch is int, not bool. Reviewed-by: Qiang Yu <yuq825@gmail.com> Signed-off-by: Andreas Baierl <ichgeh@imkreisrum.de>
2020-01-05lima/parser: Fix rsw parserAndreas Baierl1-2/+0
Drop assert as it is not necessary and used wrong anyway. Reviewed-by: Qiang Yu <yuq825@gmail.com> Signed-off-by: Andreas Baierl <ichgeh@imkreisrum.de>
2020-01-04anv: Only enable EWA LOD algorithm when doing anisotropic filtering.Kenneth Graunke1-1/+2
Updated documentation renames "Anisotropic Algorithm" to "LOD Algorithm" and adds a note for Gen9+ saying "The EWA Algorithm should only be enabled for Anisotropic Filtering modes." and indicating that the extra accuracy shouldn't be necessary for other modes, and comes at a cost. Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
2020-01-04iris: Allow HiZ for copy_region sourcesKenneth Graunke3-5/+18
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
2020-01-04i965: Allow HiZ for glCopyImageSubData sourcesJason Ekstrand1-0/+9
v2 (Ken): Handle platforms without sampler support for HiZ Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> [v2 changes]
2020-01-04anv: Allow HiZ in TRANSFER_SRC_OPTIMAL on Gen8-9Jason Ekstrand2-11/+18
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
2020-01-04intel/blorp: Use the source format when using blorp_copy with HiZJason Ekstrand1-1/+9
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
2020-01-04i965/blorp: Don't resolve HiZ unless we're reinterpretingJason Ekstrand1-1/+1
This eliminates 50% of pixels (2M) rendered for a blit in GS:GO. This accounts for 3% of pixels rendered in the game. Total GPU clocks for the first 900 frames of CSGO improves by 1%. Tested-by: Mark Janes <mark.a.janes@intel.com> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
2020-01-04blorp: Allow reading with HiZJason Ekstrand2-2/+12
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
2020-01-04blorp: Stop whacking Z24 depth to BGRA8Jason Ekstrand1-11/+0
The shader code required to do this is int(sat(x) * UINT24_MAX) which isn't really worth all the effort to avoid. Doing the format conversion, on the other hand, prevents us from sampling with HiZ which is something that we very much want on gen8-9 where we can. Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
2020-01-04etnaviv: move descriptor based texture structsChristian Gmeiner2-40/+31
This moves the descriptor based texture structs and their helpers into the only user. Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Jonathan Marek <jonathan@marek.ca>
2020-01-04etnaviv: move state based texture structsChristian Gmeiner2-49/+42
This moves the state based texture structs and their helpers into the only user. Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Jonathan Marek <jonathan@marek.ca>
2020-01-04panfrost: Fix Android buildRoman Stratiienko1-0/+1
Include missing `encoder/pan_props.c` into the build. Signed-off-by: Roman Stratiienko <roman.stratiienko@globallogic.com> Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
2020-01-04mesa/st: glsl_to_nir: don't lower atomics to SSBOs if driver supports HW atomicsGert Wollny1-2/+3
At least on r600 HW atomic operations are way less expensive than SSBO atomic operations. v2: use st->has_hw_atomics (Erik Anholt) v3: remove second invocation of atomic to ssbo lowering (Erik Anholt) Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Eric Anholt <eric@anholt.net> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3286> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3286>
2020-01-04r600: Delete vertex buffer only if there is actually a shader stateGert Wollny1-1/+2
Fixes: gl-2.0-vertexattribpointer Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Konstantin Kharlamov <hi-angel@yandex.ru> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3286>
2020-01-04r600: Make SID and unsigned valueGert Wollny1-1/+1
The value is never negative, and makeing it unsigned fixes some warnings Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Konstantin Kharlamov <hi-angel@yandex.ru> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3286>
2020-01-04r600: Fix maximum line widthGert Wollny1-4/+1
There are only 13 bits available to store the line width, hence it can't be larger than 8191 v2: Add Fixes tag v3: - Unify value since for all r600 archs (Konstantin Kharlamov) - Correct the value the line width value is emitted as a 12.4 fixed point value of 1/2 line width on r600-r700 and as 8 * line width on Evergreen and newer. Fixes: 06bfb2d28f7adca7edc6be9c210a7a3583023652 r600: fork and import gallium/radeon Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Konstantin Kharlamov <hi-angel@yandex.ru> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3286>
2020-01-04r600/sb: Correct SB disassambler for better debuggingGert Wollny2-1/+8
Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Konstantin Kharlamov <hi-angel@yandex.ru> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3286>
2020-01-04r600: Make it possible to include r600_asm.h in a C++ fileGert Wollny1-0/+9
Signed-off-by: Gert Wollny <gw.fossdev@gmail.com> Reviewed-by: Konstantin Kharlamov <hi-angel@yandex.ru> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3286>
2020-01-04r600: Add functions to dump the shader infoGert Wollny4-0/+211
This will be helpful to compare TGSI and NIR code path, Signed-off-by: Gert Wollny <gw.fossdev@gmail.com> Reviewed-by: Konstantin Kharlamov <hi-angel@yandex.ru> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3286>
2020-01-04gallium: tgsi_from_mesa - handle VARYING_SLOT_FACEGert Wollny1-0/+4
Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Eric Anholt <eric@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3286>
2020-01-04nir: make nir_get_texture_size/lod available outside nir_lower_texGert Wollny3-110/+117
This functions can be useful in other places. Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Eric Anholt <eric@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3286>
2020-01-04gallium/tgsi_from_mesa: Add 'extern "C"' to be able to include from C++Gert Wollny1-0/+9
The r600/nir backend is in C++ and needs to include this file. Signed-off-by: Gert Wollny <gw.fossdev@gmail.com> Reviewed-by: Eric Anholt <eric@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3286>
2020-01-04spirv: Fix glsl type assert in spir2nir.Bas Nieuwenhuizen1-0/+4
Fixes: 624789e3708 "compiler/glsl: handle case where we have multiple users for types" Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
2020-01-04etnaviv: use a better name for FE_VERTEX_STREAM_UNK14680Christian Gmeiner2-2/+2
Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
2020-01-04radv: Only use the gfx mipmap level offset/pitch for linear textures.Bas Nieuwenhuizen1-2/+6
The tiled-case is non-sensical for non-base mips, but Vulkan requires that this function handles it but at the same time does not require returning anything useful. So we can basically return anything. Correct tiled pitch and offset are still required for our own WSI and in the future getting the layouts of images with DRM format modifiers. Both don't have to deal with images with more than 1 level though. Fixes: 824bd0830e8 "radv: return the correct pitch for linear mipmaps on GFX10" Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2301 Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2304 Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com>
2020-01-04Revert "amd/common: Always initialize gfx9 mipmap offset/pitch."Bas Nieuwenhuizen2-5/+7
This reverts commit 973181c06cca3fe232c3a435abde31f2fc1b81ef. Requested by Marek. Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com>
2020-01-03iris: Delete remnants of the unimplemented ASTC 5x5 workaroundKenneth Graunke4-38/+10
I copy and pasted some of the boilerplate but never the implementation. For now, ASTC 5x5 is disabled and faked via uncompressed RGBA; let's delete these remnants until such a time when we implement it properly. Reviewed-by: Tapani Pälli <tapani.palli@intel.com>