summaryrefslogtreecommitdiff
path: root/.gitlab-ci
AgeCommit message (Collapse)AuthorFilesLines
2020-10-20llvmpipe: enable CL imagesKarol Herbst1-11/+13
Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7069>
2020-10-20softpipe: Switch to using NIR as the shader format from mesa/st.Eric Anholt1-0/+1
This causes our TGSI to use far more temps, since NTT is currently not releasing temps from registers. On the other hand, this interpreter is already spectacularly slow, and if we wanted to go fast we should probably write a scalar NIR intrepeter. For now, using NTT means that we test that codepath in preparation for switching TGSI-consuming HW drivers over, so that we can eventually garbage collect st_glsl_to_tgsi. As this is a major restructuring, there are some impacts on piglit: - Several tests start assert failing about 64-bit NIR registers for temp arrays not getting split to vec2s: - fs-frexp-dvec4-variable-index.shader_test - arb_gpu_shader_fp64/uniform_buffers/{vs,fs,gs}-array-copy.shader_test - arb_gpu_shader_int64/execution/indirect-array-two-accesses.shader_test - dEQP-GLES31.functional.primitive_bounding_box.wide_points.global_state.vertex_geometry_fragment.fbo_bbox_larger starts crashing depending on various bits of state (previous tests run before it, presence of valgrind, presence of glib's memcheck). Doesn't seem really NTT-specific, added to flakes list with other GS flakes. - Almost 200 fp64/int64-related tests start passing, mostly around i/o loayout. shader-db: total instructions in shared programs: 3492656 -> 3081674 (-11.77%) total loops in shared programs: 1418 -> 1387 (-2.19%) total temps in shared programs: 340041 -> 615527 (81.02%) total const in shared programs: 3158970 -> 1528630 (-51.61%) total imm in shared programs: 117586 -> 101349 (-13.81%) Total CPU time (seconds): 430.36 -> 900.94 (109.35%) FPS results: glmark2 texture +7.32484% +/- 3.76528% (n=10) glmark2 desktop:effect=shadow +20% +/- 0% (n=10) glmark2 shadow +6.49351% +/- 3.65335% (n=7) glmark2 conditionals +18.75% +/- 2.74658% (n=9) Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3395>
2020-10-20ci: Enable NIR_VALIDATE everywhere.Eric Anholt2-8/+20
I wasted a bunch of time today tracking down a spurious test results change due to a driver invoking UB by running tests where NIR validation had failed (instruction reading from components beyond vector size). If we need to shrink our coverage to get runtimes down, it will still be better to be catching validation errors in CI. To keep the test jobs runtime under 10 minutes, I've split a530's gles2 to two different jobs. Acked-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7203>
2020-10-15ci: Unskip fragment_ops tests on BifrostTomeu Vizoso2-1178/+0
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7165>
2020-10-15glsl: more accurately handle swizzle in 64bit varying split with no left valueMike Blumenkrantz1-19/+7
as implied in the surrounding code, left_components can be 0 here, in which case creating a left swizzle is unnecessary (and triggers an assert) this moves a failing assert farther down the stack to a more useful location when trying to pack e.g., struct[3] { dvec3; float; } ref spec@arb_gpu_shader_fp64@execution@inout@vs-out-fs-in-s1-s2@3-dvec2-float Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7134>
2020-10-14ci/android: Switch to using the Android NDK.Eric Anholt3-0/+131
To support Android drivers, we're going to want to be tracking that Mesa's build succeeds on a real android toolchain. This still uses the android stubs since these libs aren't in the NDK. Note that I had to drop the Intel and AMD drivers currently: we don't have LLVM cross-compiled for Android in this container, and I'm honestly hoping ACO saves us from that. Intel has dependencies on libexpat, which AOSP really doesn't want to bring in, and it looks to me like those dependencies could be optional. Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6700>
2020-10-11nir: Allow more deref modes in phisJason Ekstrand1-4/+3
In particular, OpenCL needs to allow shader_temp and function_temp through because they're 100% real pointers. Fixes piglit CL calls.cl Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7092>
2020-10-10ci: piglit: conditionally build OpenCL testsChristian Gmeiner2-2/+6
For baremetal piglit this is not yet needed. Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Eric Anholt <eric@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7075>
2020-10-10CI: build our own spirv toolsDave Airlie4-297/+158
This causes a lot of hiccups on the CL tests, but I've got most of them fixed in another MR in pieces. This should at least give a much more realistic baseline. v2: use script in both places Reviewed-by: Michel Dänzer <mdaenzer@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7073>
2020-10-10ci: fix deqp clone + fetchDave Airlie1-2/+0
This was taking > 10 minutes and I got bored, don't do a depth 1 fetch in the first place just to do a proper fetch later. Acked-by: Eric Anholt <eric@anholt.net> Acked-by: Daniel Stone <daniels@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7073>
2020-10-08ci/softpipe: Add another flaky GS test to the skips list.Eric Anholt1-0/+1
We've seen the new GS flake once or twice a week for a long time. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7070>
2020-10-08nir/opt_deref: Fix the vector bitcast optimizationJason Ekstrand1-4/+3
It assumes the parent is a vector or scalar so we need to fail if it isn't. Fixes: 9190f82d573c "nir/opt_deref: Add an optimization for bitcasts" Reviewed-by: Karol Herbst <kherbst@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7064>
2020-10-08ci: Disable pm_runtime and max clocks in LAVA jobsTomeu Vizoso1-0/+6
To get more consistent performance and results, use the performance devfreq governor and disable PM runtime. Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7011>
2020-10-08ci: Test Panfrost on Khadas VIM3 boardsTomeu Vizoso3-0/+2688
For testing Panfrost on Bifrost GPUs, add a job for dEQP GLES2 testing. Right now almost all tests are skipped, but as we make progress and things show stable, we'll be running more and more tests. Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7011>
2020-10-08ci: Update kernel for LAVATomeu Vizoso3-3/+7
Update to v5.9-rc5-based drm-misc-for-next, so we can run jobs on machines with Bifrost GPUs. Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7011>
2020-10-08ci: enable piglit testing of clover/llvmpipe.Dave Airlie6-1/+518
This adds support for building clover/llvmpipe and running the piglit CL tests on it. It uses the gl testing container, and add builds the libclc spirv libraries as part of that which requires the llvm spirv translator in the build container. It also builds the llvm spirv translator as part of the build root and creates a mesa build that builds clover for testing against it. It uses llvm 10 as the baseline. This drops bswap as it has an oob memory access with llvmpipe which cause flaky test results. phatk also seems flaky Reviewed-by: Michel Dänzer <mdaenzer@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6901>
2020-10-07CI: Don't run pixmark-piano twice on radeonsiDaniel Stone1-4/+0
For some reason, the radeonsi Tracie definition had the piano traces listed twice. Noted by @airlied Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7052>
2020-10-08ci: move to using clang 10 for meson + cloverDave Airlie5-7/+12
Reviewed-by: Michel Dänzer <mdaenzer@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7017>
2020-10-07panfrost: Rework fixed-function blendingBoris Brezillon1-4/+4
The fixed-function blend logic uses the following equation: A + B x C. A, B and C are configurable and can be complemented with negation (for A and B) or inversion (for C) modifiers. Let's rework the blending code to take that into account. Note that we need to update the checksum of a few traces because the equations we use have changed, leading to small deviations on the final images. Indeed, there are several valid options for a given GL blend equation, but the operand selection probably has an impact on the rounding, leading to those mismatch. Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6980>
2020-10-06util: implement F16C using inline assembly on x86_64Marek Olšák1-3/+2
F16C: https://en.wikipedia.org/wiki/F16C This also happens to fix bptc-float-modes on llvmpipe. Reviewed-by: Matt Turner <mattst88@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6987>
2020-10-06CI: Re-enable Panfrost T7xx CIDaniel Stone1-2/+2
Lab maintenance is done now. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7032>
2020-10-06CI: Disable Panfrost T7xx CIDaniel Stone1-2/+2
The lab is having some more maintenance work this morning to continue expanding capacity and improving resilience. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7023>
2020-10-02ci/bare-metal: Move the "POWER_GOOD not seen in time" check to the right time.Eric Anholt1-5/+5
The poweron failure happens before we get to the bootloader ("load_archive: loading locale_en.bin") not after we're trying to boot the kernel and we're waiting for the deqp run to complete. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6970>
2020-10-01Revert F16C series (MR 6774)Matt Turner1-2/+3
This reverts commit 4fb2eddfdf9adafde2e6f94de23202ee44123d59. This reverts commit 7a1deb16f8af4e0ae4ed64511cbfcc606087f0ee. This reverts commit 2b6a17234376817e75d1f81edf5bd1b28eefb374. This reverts commit 5af81393e419eaf086e4de2a1d149af78cd1f54d. This reverts commit 87900afe5bbe90c5f3ad0921b28ae1c889029ada. A couple of problems were discovered after this series was merged that cause breakage in different configurations: (1) It seems that using -mf16c also enables AVX, leading to SIGILL on platforms that do not support AVX. (2) Since clang only warns about unknown flags, and as I understand it Meson's handling in cc.has_argument() is broken, the F16C code is wrongly enabled when clang is used, even for example on ARM, leading to a compilation error. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3583 Reviewed-by: Eric Anholt <eric@anholt.net> Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6969>
2020-09-30util: implement f16c - fast half<->float conversionsMarek Olšák1-3/+2
This also happens to fix bptc-float-modes on llvmpipe. Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6774>
2020-09-29gallivm: fix pow(0, y) to be 0Dave Airlie2-20/+3
The log2(0) was producing bad results. Fixes: piglit pow tests on llvmpipe. Reviewed-by: Roland Scheidegger <sroland@vmware.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6907>
2020-09-29ci: Enable remaining (non-rotate) mustpass CTS testsRob Clark2-0/+0
The gles3 and gles31 multisample and 565-no-depth-no-stencil caselists are also mustpass. And they don't add a significant number of extra test cases. The remaining mustpass caselists all involve rotation, which is not currently supported in the surfaceless deqp build. Signed-off-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6553>
2020-09-29ci: cherry-pick deqp fix for config choosingRob Clark1-0/+5
Signed-off-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6553>
2020-09-29ci/deqp-runner: Allow overriding width/height/configRob Clark2-5/+14
This will allow adding multi-sample caselists, and jobs with larger surface size. Signed-off-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6553>
2020-09-29turnip: initial implementation of VK_KHR_push_descriptorJonathan Marek1-0/+3
Add missing descriptor sets code for push descriptors, and a simple initial implementation to enable the extension and pass dEQP tests. Signed-off-by: Jonathan Marek <jonathan@marek.ca> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6755>
2020-09-29panfrost: Add support for rbg16 formatsBoris Brezillon1-21/+0
Fixes: 171e94fe629 ("mesa/st: enable EXT_color_buffer_half_float when formats supported") Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6887>
2020-09-29CI: Re-enable Panfrost T7xxDaniel Stone1-2/+2
Lab maintenance is complete. Signed-off-by: Daniel Stone <daniels@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6910>
2020-09-29CI: Temporarily disable Panfrost T7xxDaniel Stone1-2/+2
Due to more work in the on-site lab, we need to take the T7xx machines out of the rotation for a couple of hours. Signed-off-by: Daniel Stone <daniels@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6896>
2020-09-28nir/lower_clip: Add i/o semantics for load/store intrinsics.Eric Anholt1-5/+4
ir3 looks at the .location on its inputs for handling non-VARYING_SLOT_POS, but our uninitialized semantics matched that and threw a compiler assertion failure. Fixes: 502abfce7f5d ("nir: save IO semantics in lowered IO intrinsics") Reviewed-by: Connor Abbott <cwabbott0@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6716>
2020-09-28ci/freedreno: Add trace tests for glxgears, 0 A.D., and xonotic.Eric Anholt1-6/+22
glxgears is now trimmed to not be tons of frames, and we've picked up a couple more traces in the public repo. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6716>
2020-09-28ci/freedreno: Sort the traces in the .yml of expectationsEric Anholt1-90/+90
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6716>
2020-09-28ci: add dEQP-VK.info.device_extensions to the list of skipped testsSamuel Pitoiset1-0/+3
It regularly fails when a new KHR extension is implemented. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6843>
2020-09-24ci: adjust RadeonSI rulesSamuel Pitoiset1-1/+5
src/amd/vulkan is specific to RADV and shouldn't trigger RadeonSI CI. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Michel Dänzer <mdaenzer@redhat.com> Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6839>
2020-09-22ci: Use ignore_scheduled_pipelines anchor in .radeonsi-rulesMichel Dänzer1-0/+1
Without this, scheduled pipelines erroneously tried to create jobs using this template, which can't work, because their dependency jobs don't exist in scheduled pipelines. Unfortunately, this resulted in scheduled pipelines not running silently, without any direct feedback about what's wrong (see https://gitlab.com/gitlab-org/gitlab/-/issues/25490). Fixes: 6c8b921572a5 "ci: Build kernels and rootfs for x86 devices" Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6802>
2020-09-16nir,radeonsi: move ffma fusing to late optimizations for better codegenMarek Olšák2-21/+16
The freedreno trace changes were suggested by Rob Clark. ALU performance is higher, because ffma is used more often, but so is register usage, because trinary opcodes (such as ffma) usually need at least 3 live registers. 54793 shaders in 33659 tests Totals: SGPRS: 2639746 -> 2642938 (0.12 %) VGPRS: 1534120 -> 1536392 (0.15 %) Spilled SGPRs: 3541 -> 3618 (2.17 %) Spilled VGPRs: 33 -> 44 (33.33 %) Scratch size: 292 -> 312 (6.85 %) dwords per thread Code Size: 55639836 -> 55620116 (-0.04 %) bytes Max Waves: 964785 -> 963977 (-0.08 %) Totals from affected shaders: SGPRS: 1105800 -> 1108992 (0.29 %) VGPRS: 635292 -> 637564 (0.36 %) Spilled SGPRs: 3193 -> 3270 (2.41 %) Spilled VGPRs: 33 -> 44 (33.33 %) Scratch size: 36 -> 56 (55.56 %) dwords per thread Code Size: 31568708 -> 31548988 (-0.06 %) bytes Max Waves: 319991 -> 319183 (-0.25 %) Reviewed-by: Connor Abbott <cwabbott0@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6596>
2020-09-10nir/algebraic: add late optimizations that optimize out mediump conversions (v3)Marek Olšák1-1/+1
v2: move *2*mp patterns to the end of late_optimizations v3: remove ftrunc from the optimizations to fix: dEQP-GLES3.functional.shaders.builtin_functions.common.modf.vec2_lowp_vertex Reviewed-by: Rob Clark <robdclark@chromium.org> (v1) Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6283>
2020-09-10ci: do not build libdrm for vc4, reedreno and etnavivChristian Gmeiner1-1/+1
They are using a in source tree version of the needed libdrm functionality or are shipping all needed headers in the source tree. Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Eric Anholt <eric@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6672>
2020-09-10freedreno: Don't bypass fd_draw_vbo() in clear fallbackRob Clark1-11/+0
Otherwise we bypass all the resource-usage tacking. Signed-off-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6649>
2020-09-10gallivm: disable brilinear for lod bias and explicit lod.Dave Airlie2-48/+2
This allows GL 4.5 CTS to pass in full with no flags, other than that I'm not sure if it's a good or bad idea. Reviewed-by: Roland Scheidegger <sroland@vmware.com> Cc: mesa-stable@lists.freedesktop.org Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6638>
2020-09-09freedreno: Add another new sysmem flake.Eric Anholt1-0/+1
This one blocked a marge merge a few minutes ago. Fixes: b4317fccdd7f ("ci/bare-metal: Update the kernel to msm-next-pgtables") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6670>
2020-09-09ci/bare-metal: Allow wget of the kernel/dtb for kernel development.Eric Anholt2-4/+45
It's useful for kernel dev to be able throw all of our testing infrastructure at a risky kernel change, but it's expensive (time and bandwidth) to roll new containers every time your rev your kernel. Make it so you can just point the env vars to your personal build you've uploaded. Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com> Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6592>
2020-09-09ci/bare-metal: Update the kernel to msm-next-pgtablesEric Anholt3-2/+14
I'd like to see this new non-UAPI feature bake in CI. More importantly, it may prevent some classes of flakes on cheza by isolating the processes on the GPU so that a fault in one doesn't stomp over memory in another. I've also pulled in a fix that etnaviv needed for their upcoming CI. We add a few more kernel options while uprevving: - More interconnect drivers for getting good GPU perf - PRNG so that we don't get late-in-boot complaints about randomness. - db820c's power domains and ethernet so hopefully we can switch to this upstream kernel This seems to slightly change the flakes happening in bypass mode, so add them to the list. Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com> Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6592>
2020-09-08gitlab-ci: Enable unit test reports for lava traces jobsAlexandros Frantzis1-0/+11
Download from minio the JUnit XML file that tracie produces and inform gitlab about it, so that the pipeline page can present more detailed information about tracie test results. Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com> Reviewed-by: Eric Anholt <eric@anholt.net> Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6598>
2020-09-08tracie: Produce JUnit XML resultsAlexandros Frantzis2-5/+81
Write tracie results to the 'results/junit.xml' file using the JUnit XML format. Among other uses, this file can be picked up by gitlab to display more useful information to the user. Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com> Reviewed-by: Eric Anholt <eric@anholt.net> Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6598>
2020-09-08tracie: Make tests independent of environmentAlexandros Frantzis2-2/+5
Provide some sensible values for required environment variables to allow tests to run properly in any environment. Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com> Reviewed-by: Eric Anholt <eric@anholt.net> Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6598>