summaryrefslogtreecommitdiff
path: root/src/gallium/winsys/drm/vmware
diff options
context:
space:
mode:
authorCaio Oliveira <caio.oliveira@intel.com>2024-05-31 13:34:57 -0700
committerCaio Oliveira <caio.oliveira@intel.com>2024-06-21 17:37:46 -0700
commita0877c132c3ff955717ae7f5fcaca34ca6deba54 (patch)
tree6ed5daf3c0cf92913d86acbf7a693a79900ce682 /src/gallium/winsys/drm/vmware
parent0d1813837bab65805f15172f9e6036c01b96cfab (diff)
glsl: Fix warning related to tg4_offsets in release modeHEADmain
Compiler can't know that array_size() of the offsets parameter in textureGatherOffsets is (at most) 4, so use a MIN2() to make the limit visible. Just adding an assert() gets ignored in Release builds. This fixes the following warning in Release compilation: ``` ../src/compiler/glsl/glsl_to_nir.cpp: In member function ‘virtual void {anonymous}::nir_visitor::visit(ir_texture*)’: ../src/compiler/glsl/glsl_to_nir.cpp:2453:41: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=] 2453 | instr->tg4_offsets[i][j] = val; | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~ In file included from ../src/compiler/glsl/glsl_to_nir.h:31, from ../src/compiler/glsl/glsl_to_nir.cpp:29: ../src/compiler/nir/nir.h:2470:11: note: at offset 8 into destination object ‘nir_tex_instr::tg4_offsets’ of size 8 2470 | int8_t tg4_offsets[4][2]; | ^~~~~~~~~~~ ../src/compiler/glsl/glsl_to_nir.cpp:2453:41: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=] 2453 | instr->tg4_offsets[i][j] = val; | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~ ../src/compiler/nir/nir.h:2470:11: note: at offset 9 into destination object ‘nir_tex_instr::tg4_offsets’ of size 8 2470 | int8_t tg4_offsets[4][2]; | ^~~~~~~~~~~ ``` This is from: `gcc (GCC) 14.1.1 20240522 (Red Hat 14.1.1-4)`. Reviewed-by: Jordan Justen <jordan.l.justen@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29508>
Diffstat (limited to 'src/gallium/winsys/drm/vmware')
0 files changed, 0 insertions, 0 deletions