diff options
author | Lucas Fryzek <lfryzek@igalia.com> | 2023-07-07 15:15:20 -0400 |
---|---|---|
committer | Marge Bot <emma+marge@anholt.net> | 2023-07-11 15:52:08 +0000 |
commit | 6b2fa965c6cb062d7a30ed056bf905fc6fd7cc72 (patch) | |
tree | 3ed61e034d2ba3b3184893dbd2fe5e4e43b1db40 /src/gallium/auxiliary/util/u_screen.c | |
parent | 99e58460efb975f7acf91cf32b044bc55a77b936 (diff) |
gallium: Remove `PIPE_CAP_RGB_OVERRIDE_DST_ALPHA_BLEND`
Since the mesa state tracker can promote RGB texture formats
to RGBA texture formats (among other formats) without exposing
any of that information to a driver, it is more desirable to
have the behaviour of `PIPE_CAP_RGB_OVERRIDE_DST_ALPHA_BLEND`
be the default. This avoids rendering bugs where an application
sets `DST_ALPHA` blending on a format where there is no alpha
channel, that has been promoted to a format that actually has an
alpha channel. The driver can instead rely on the common code
in the state tracker to convert the blending parameter to one
that reflects the limitations of the application requested format,
as long as `PIPE_CAP_INDEP_BLEND_FUNC` is supported.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24044>
Diffstat (limited to 'src/gallium/auxiliary/util/u_screen.c')
-rw-r--r-- | src/gallium/auxiliary/util/u_screen.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/gallium/auxiliary/util/u_screen.c b/src/gallium/auxiliary/util/u_screen.c index 40218d26205..f7005cbcf2a 100644 --- a/src/gallium/auxiliary/util/u_screen.c +++ b/src/gallium/auxiliary/util/u_screen.c @@ -100,7 +100,6 @@ u_pipe_screen_get_param_defaults(struct pipe_screen *pscreen, case PIPE_CAP_FRAGMENT_COLOR_CLAMPED: case PIPE_CAP_SEAMLESS_CUBE_MAP: case PIPE_CAP_SEAMLESS_CUBE_MAP_PER_TEXTURE: - case PIPE_CAP_RGB_OVERRIDE_DST_ALPHA_BLEND: return 0; case PIPE_CAP_SUPPORTED_PRIM_MODES_WITH_RESTART: |