summaryrefslogtreecommitdiff
path: root/src/amd/vulkan/radv_sqtt.c
diff options
context:
space:
mode:
authorSamuel Pitoiset <samuel.pitoiset@gmail.com>2023-02-09 15:16:47 +0100
committerMarge Bot <emma+marge@anholt.net>2023-02-17 11:36:06 +0000
commit663877e8943d074e6ac520a8312f221e6a45e629 (patch)
tree2b48688b8cacbb579962494a397a22eca800e132 /src/amd/vulkan/radv_sqtt.c
parentc426e5677f36c3b0b8e8ea199ed4f2c7fad06d47 (diff)
Revert "radv: acquire pstate on-demand when capturing with RGP"
This change is wrong for two reasons: - it hangs most of the time maybe, because changing PSTATE when the application is running is broken somehow - it increases the time between triggering and generating the capture considerably, because there is a delay for changing PSTATE This restores previous logic where PSTATE is set to profile_peak at logical device creation. Though, it also re-introduces an issue with multiple logical devices (kernel returns -EBUSY) but this will be fixed in the next commit. This fixes GPU hangs when trying to record RGP captures on my NAVI21. Note that profile_peak is only required for some RDNA2 chips (including VanGogh). Cc: mesa-stable This reverts commit 923a864d94517462698c529bdc0e5c056d37b4e1. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21222>
Diffstat (limited to 'src/amd/vulkan/radv_sqtt.c')
-rw-r--r--src/amd/vulkan/radv_sqtt.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/amd/vulkan/radv_sqtt.c b/src/amd/vulkan/radv_sqtt.c
index 28298981701..270af5be507 100644
--- a/src/amd/vulkan/radv_sqtt.c
+++ b/src/amd/vulkan/radv_sqtt.c
@@ -526,6 +526,9 @@ radv_thread_trace_init(struct radv_device *device)
if (!radv_thread_trace_init_bo(device))
return false;
+ if (!radv_device_acquire_performance_counters(device))
+ return false;
+
list_inithead(&thread_trace_data->rgp_pso_correlation.record);
simple_mtx_init(&thread_trace_data->rgp_pso_correlation.lock, mtx_plain);