diff options
| author | Emil Velikov <emil.velikov@collabora.com> | 2018-12-17 16:25:40 +0000 |
|---|---|---|
| committer | Emil Velikov <emil.l.velikov@gmail.com> | 2019-01-11 16:43:31 +0000 |
| commit | 6d3811d82b92609e2c3a449a6815e2563b3fa96b (patch) | |
| tree | dfd7a18f2a65c1975caa645cf876a8e3d67c5bc2 /bin | |
| parent | 6486d1c1a387655e92425168e63a6b282d086a20 (diff) | |
bin/get-pick-list.sh: warn when commit lists invalid sha
We had cases where people would list old/invalid sha in the commit.
Add a trivial checker to catch those and throw a warning.
CC: Juan A. Suarez <jasuarez@igalia.com>
CC: Dylan Baker <dylan@pnwbakers.com>
CC: mesa-stable@lists.freedesktop.org
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Andres Gomez <agomez@igalia.com>
(cherry picked from commit e0dbfc995370756355f28ac31495eab96a410384)
Diffstat (limited to 'bin')
| -rwxr-xr-x | bin/get-pick-list.sh | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/bin/get-pick-list.sh b/bin/get-pick-list.sh index 08a783f35a8..79b7a295ea6 100755 --- a/bin/get-pick-list.sh +++ b/bin/get-pick-list.sh @@ -38,6 +38,17 @@ is_sha_nomination() if test $fixes_count -eq 0; then return 1 fi + + # Throw a warning for each invalid sha + while test $fixes_count -gt 0; do + # Treat only the current line + id=`echo "$fixes" | tail -n $fixes_count | head -n 1 | cut -d : -f 2` + fixes_count=$(($fixes_count-1)) + if ! git show $id &>/dev/null; then + echo WARNING: Commit $1 lists invalid sha $id + fi + done + return 0 } |