summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJason Ekstrand <jason@jlekstrand.net>2021-11-09 20:17:42 -0600
committerMarge Bot <emma+marge@anholt.net>2021-12-18 01:46:19 +0000
commitd49d092259829ad9e33d0d9fc8eef9759d9fe56e (patch)
tree4971d77d418ea524f3158d4f40735357df0eaee6
parente6f0def97df3f83823bd1300e334ce48b23be005 (diff)
Revert "intel/fs: Do cmod prop again after scheduling"
This reverts commit ba2fa1ceaf4ccb905e1d841b45f88505449db44e. Doing optimizations after scheduling but before RA means doing them in the middle of the scheduling loop which introduces additional dependencies between one scheduling iteration and the next. That won't work if we want to make the scheduling modes independent, at least not unless we have some way of fully cloning the IR. Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13734>
-rw-r--r--src/intel/compiler/brw_fs.cpp17
1 files changed, 0 insertions, 17 deletions
diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp
index 03733ce719c..e31e94c9ff2 100644
--- a/src/intel/compiler/brw_fs.cpp
+++ b/src/intel/compiler/brw_fs.cpp
@@ -8677,23 +8677,6 @@ fs_visitor::allocate_registers(bool allow_spilling)
break;
}
- /* Scheduling may create additional opportunities for CMOD propagation,
- * so let's do it again. If CMOD propagation made any progress,
- * eliminate dead code one more time.
- */
- bool progress = false;
- const int iteration = 99;
- int pass_num = 0;
-
- if (OPT(opt_cmod_propagation)) {
- /* dead_code_eliminate "undoes" the fixing done by
- * fixup_3src_null_dest, so we have to do it again if
- * dead_code_eliminiate makes any progress.
- */
- if (OPT(dead_code_eliminate))
- fixup_3src_null_dest();
- }
-
bool can_spill = allow_spilling &&
(i == ARRAY_SIZE(pre_modes) - 1);