diff options
| author | Samuel Iglesias Gonsalvez <siglesias@igalia.com> | 2015-02-24 19:02:57 +0100 |
|---|---|---|
| committer | Eduardo Lima Mitev <elima@igalia.com> | 2015-03-13 16:40:20 +0100 |
| commit | b43bbfa90ace596c8b2e0b3954a5f69924726c59 (patch) | |
| tree | c5b7010c5c9265a22183fbd90df673a90f96b82a | |
| parent | cf6f33ee68ca56df1650762634fa9c038359c3ec (diff) | |
glsl: optimize (0 cmp x + y) into (-x cmp y).
The optimization done by commit 34ec1a24d did not take it into account.
Fixes:
dEQP-GLES3.functional.shaders.random.all_features.fragment.20
Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
Cc: "10.4 10.5" <mesa-stable@lists.freedesktop.org>
| -rw-r--r-- | src/glsl/opt_algebraic.cpp | 15 |
1 files changed, 12 insertions, 3 deletions
diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp index c6040bff825..69c03ea8be7 100644 --- a/src/glsl/opt_algebraic.cpp +++ b/src/glsl/opt_algebraic.cpp @@ -626,9 +626,18 @@ ir_algebraic_visitor::handle_expression(ir_expression *ir) if (!is_vec_zero(zero)) continue; - return new(mem_ctx) ir_expression(ir->operation, - add->operands[0], - neg(add->operands[1])); + /* Depending of the zero position we want to optimize + * (0 cmp x+y) into (-x cmp y) or (x+y cmp 0) into (x cmp -y) + */ + if (add_pos == 1) { + return new(mem_ctx) ir_expression(ir->operation, + neg(add->operands[0]), + add->operands[1]); + } else { + return new(mem_ctx) ir_expression(ir->operation, + add->operands[0], + neg(add->operands[1])); + } } break; |