diff options
author | Jason Ekstrand <jason@jlekstrand.net> | 2020-08-06 16:22:15 -0500 |
---|---|---|
committer | Marge Bot <eric+marge@anholt.net> | 2020-11-25 05:37:10 +0000 |
commit | 303378e1dd4119e04e0f6cb623766115a00c2eea (patch) | |
tree | dec959d6e8ddf817ce23f365fd1abf469f11ffd7 | |
parent | cb261b03e5af7862f1321c778e3ad54b640226bc (diff) |
intel/rt: Add lowering for combined intersection/any-hit shaders
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7356>
-rw-r--r-- | src/intel/Makefile.sources | 1 | ||||
-rw-r--r-- | src/intel/compiler/brw_nir_lower_intersection_shader.c | 260 | ||||
-rw-r--r-- | src/intel/compiler/brw_nir_lower_shader_calls.c | 3 | ||||
-rw-r--r-- | src/intel/compiler/brw_nir_rt.c | 3 | ||||
-rw-r--r-- | src/intel/compiler/brw_nir_rt.h | 3 | ||||
-rw-r--r-- | src/intel/compiler/meson.build | 1 |
6 files changed, 270 insertions, 1 deletions
diff --git a/src/intel/Makefile.sources b/src/intel/Makefile.sources index 33dd2bd1817..537f9391f66 100644 --- a/src/intel/Makefile.sources +++ b/src/intel/Makefile.sources @@ -93,6 +93,7 @@ COMPILER_FILES = \ compiler/brw_nir_lower_conversions.c \ compiler/brw_nir_lower_cs_intrinsics.c \ compiler/brw_nir_lower_image_load_store.c \ + compiler/brw_nir_lower_intersection_shader.c \ compiler/brw_nir_lower_mem_access_bit_sizes.c \ compiler/brw_nir_lower_rt_intrinsics.c \ compiler/brw_nir_lower_scoped_barriers.c \ diff --git a/src/intel/compiler/brw_nir_lower_intersection_shader.c b/src/intel/compiler/brw_nir_lower_intersection_shader.c new file mode 100644 index 00000000000..01b90683d67 --- /dev/null +++ b/src/intel/compiler/brw_nir_lower_intersection_shader.c @@ -0,0 +1,260 @@ +/* + * Copyright (c) 2020 Intel Corporation + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the "Software"), + * to deal in the Software without restriction, including without limitation + * the rights to use, copy, modify, merge, publish, distribute, sublicense, + * and/or sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice (including the next + * paragraph) shall be included in all copies or substantial portions of the + * Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + */ + +#include "brw_nir_rt.h" +#include "brw_nir_rt_builder.h" + +static nir_function_impl * +lower_any_hit_for_intersection(nir_shader *any_hit) +{ + nir_function_impl *impl = nir_shader_get_entrypoint(any_hit); + + /* Any-hit shaders need three parameters */ + assert(impl->function->num_params == 0); + nir_parameter params[] = { + { + /* A pointer to a boolean value for whether or not the hit was + * accepted. + */ + .num_components = 1, + .bit_size = 32, + }, + { + /* The hit T value */ + .num_components = 1, + .bit_size = 32, + }, + { + /* The hit kind */ + .num_components = 1, + .bit_size = 32, + }, + }; + impl->function->num_params = ARRAY_SIZE(params); + impl->function->params = + ralloc_array(any_hit, nir_parameter, ARRAY_SIZE(params)); + memcpy(impl->function->params, params, sizeof(params)); + + nir_builder build; + nir_builder_init(&build, impl); + nir_builder *b = &build; + + b->cursor = nir_before_cf_list(&impl->body); + + nir_ssa_def *commit_ptr = nir_load_param(b, 0); + nir_ssa_def *hit_t = nir_load_param(b, 1); + nir_ssa_def *hit_kind = nir_load_param(b, 2); + + nir_deref_instr *commit = + nir_build_deref_cast(b, commit_ptr, nir_var_function_temp, + glsl_bool_type(), 0); + + nir_foreach_block_safe(block, impl) { + nir_foreach_instr_safe(instr, block) { + switch (instr->type) { + case nir_instr_type_intrinsic: { + nir_intrinsic_instr *intrin = nir_instr_as_intrinsic(instr); + switch (intrin->intrinsic) { + case nir_intrinsic_ignore_ray_intersection: + b->cursor = nir_instr_remove(&intrin->instr); + /* We put the newly emitted code inside a dummy if because it's + * going to contain a jump instruction and we don't want to + * deal with that mess here. It'll get dealt with by our + * control-flow optimization passes. + */ + nir_store_deref(b, commit, nir_imm_false(b), 0x1); + nir_push_if(b, nir_imm_true(b)); + nir_jump(b, nir_jump_halt); + nir_pop_if(b, NULL); + break; + + case nir_intrinsic_terminate_ray: + /* The "normal" handling of terminateRay works fine in + * intersection shaders. + */ + break; + + case nir_intrinsic_load_ray_t_max: + nir_ssa_def_rewrite_uses(&intrin->dest.ssa, + nir_src_for_ssa(hit_t)); + nir_instr_remove(&intrin->instr); + break; + + case nir_intrinsic_load_ray_hit_kind: + nir_ssa_def_rewrite_uses(&intrin->dest.ssa, + nir_src_for_ssa(hit_kind)); + nir_instr_remove(&intrin->instr); + break; + + default: + break; + } + break; + } + + default: + break; + } + } + } + + nir_validate_shader(any_hit, "after initial any-hit lowering"); + + nir_lower_returns_impl(impl); + + nir_validate_shader(any_hit, "after lowering returns"); + + return impl; +} + +void +brw_nir_lower_intersection_shader(nir_shader *intersection, + const nir_shader *any_hit, + const struct gen_device_info *devinfo) +{ + void *dead_ctx = ralloc_context(intersection); + + nir_function_impl *any_hit_impl = NULL; + struct hash_table *any_hit_var_remap = NULL; + if (any_hit) { + nir_shader *any_hit_tmp = nir_shader_clone(dead_ctx, any_hit); + NIR_PASS_V(any_hit_tmp, nir_opt_dce); + any_hit_impl = lower_any_hit_for_intersection(any_hit_tmp); + any_hit_var_remap = _mesa_pointer_hash_table_create(dead_ctx); + } + + nir_function_impl *impl = nir_shader_get_entrypoint(intersection); + + nir_builder build; + nir_builder_init(&build, impl); + nir_builder *b = &build; + + b->cursor = nir_before_cf_list(&impl->body); + + nir_ssa_def *t_addr = brw_nir_rt_mem_hit_addr(b, false); + nir_variable *commit = + nir_local_variable_create(impl, glsl_bool_type(), "ray_commit"); + nir_store_var(b, commit, nir_imm_false(b), 0x1); + + assert(impl->end_block->predecessors->entries == 1); + set_foreach(impl->end_block->predecessors, block_entry) { + struct nir_block *block = (void *)block_entry->key; + b->cursor = nir_after_block_before_jump(block); + nir_push_if(b, nir_load_var(b, commit)); + { + /* Set the "valid" bit in mem_hit */ + nir_ssa_def *ray_addr = brw_nir_rt_mem_hit_addr(b, false); + nir_ssa_def *flags_dw_addr = nir_iadd_imm(b, ray_addr, 12); + nir_store_global(b, flags_dw_addr, 4, + nir_ior(b, nir_load_global(b, flags_dw_addr, 4, 1, 32), + nir_imm_int(b, 1 << 16)), 0x1 /* write_mask */); + + nir_intrinsic_instr *accept = + nir_intrinsic_instr_create(b->shader, + nir_intrinsic_accept_ray_intersection); + nir_builder_instr_insert(b, &accept->instr); + } + nir_push_else(b, NULL); + { + nir_intrinsic_instr *ignore = + nir_intrinsic_instr_create(b->shader, + nir_intrinsic_ignore_ray_intersection); + nir_builder_instr_insert(b, &ignore->instr); + } + nir_pop_if(b, NULL); + break; + } + + nir_foreach_block_safe(block, impl) { + nir_foreach_instr_safe(instr, block) { + switch (instr->type) { + case nir_instr_type_intrinsic: { + nir_intrinsic_instr *intrin = nir_instr_as_intrinsic(instr); + switch (intrin->intrinsic) { + case nir_intrinsic_report_ray_intersection: { + b->cursor = nir_instr_remove(&intrin->instr); + nir_ssa_def *hit_t = nir_ssa_for_src(b, intrin->src[0], 1); + nir_ssa_def *hit_kind = nir_ssa_for_src(b, intrin->src[1], 1); + nir_ssa_def *min_t = nir_load_ray_t_min(b); + nir_ssa_def *max_t = nir_load_global(b, t_addr, 4, 1, 32); + + /* bool commit_tmp = false; */ + nir_variable *commit_tmp = + nir_local_variable_create(impl, glsl_bool_type(), + "commit_tmp"); + nir_store_var(b, commit_tmp, nir_imm_false(b), 0x1); + + nir_push_if(b, nir_iand(b, nir_fge(b, hit_t, min_t), + nir_fge(b, max_t, hit_t))); + { + /* Any-hit defaults to commit */ + nir_store_var(b, commit_tmp, nir_imm_true(b), 0x1); + + if (any_hit_impl != NULL) { + nir_push_if(b, nir_inot(b, nir_load_leaf_opaque_intel(b))); + { + nir_ssa_def *params[] = { + &nir_build_deref_var(b, commit_tmp)->dest.ssa, + hit_t, + hit_kind, + }; + nir_inline_function_impl(b, any_hit_impl, params, + any_hit_var_remap); + } + nir_pop_if(b, NULL); + } + + nir_push_if(b, nir_load_var(b, commit_tmp)); + { + nir_store_var(b, commit, nir_imm_true(b), 0x1); + nir_store_global(b, t_addr, 4, + nir_vec2(b, hit_t, hit_kind), + 0x3); + } + nir_pop_if(b, NULL); + } + nir_pop_if(b, NULL); + + nir_ssa_def *accepted = nir_load_var(b, commit_tmp); + nir_ssa_def_rewrite_uses(&intrin->dest.ssa, + nir_src_for_ssa(accepted)); + break; + } + + default: + break; + } + break; + } + + default: + break; + } + } + } + + /* We did some inlining; have to re-index SSA defs */ + nir_index_ssa_defs(impl); + + ralloc_free(dead_ctx); +} diff --git a/src/intel/compiler/brw_nir_lower_shader_calls.c b/src/intel/compiler/brw_nir_lower_shader_calls.c index 8bf5029c47e..885ac5b4680 100644 --- a/src/intel/compiler/brw_nir_lower_shader_calls.c +++ b/src/intel/compiler/brw_nir_lower_shader_calls.c @@ -84,7 +84,8 @@ brw_nir_lower_shader_returns(nir_shader *shader) break; case MESA_SHADER_INTERSECTION: - unreachable("TODO"); + /* This will be handled by brw_nir_lower_intersection_shader */ + break; default: unreachable("Invalid callable shader stage"); diff --git a/src/intel/compiler/brw_nir_rt.c b/src/intel/compiler/brw_nir_rt.c index 0467edab27a..ca0c43ebf6d 100644 --- a/src/intel/compiler/brw_nir_rt.c +++ b/src/intel/compiler/brw_nir_rt.c @@ -363,5 +363,8 @@ brw_nir_lower_combined_intersection_any_hit(nir_shader *intersection, assert(intersection->info.stage == MESA_SHADER_INTERSECTION); assert(any_hit == NULL || any_hit->info.stage == MESA_SHADER_ANY_HIT); NIR_PASS_V(intersection, brw_nir_lower_shader_returns); + NIR_PASS_V(intersection, brw_nir_lower_intersection_shader, + any_hit, devinfo); + NIR_PASS_V(intersection, lower_ray_walk_intrinsics, devinfo); lower_rt_io_and_scratch(intersection); } diff --git a/src/intel/compiler/brw_nir_rt.h b/src/intel/compiler/brw_nir_rt.h index c391301ddb5..a16f6be47fa 100644 --- a/src/intel/compiler/brw_nir_rt.h +++ b/src/intel/compiler/brw_nir_rt.h @@ -59,6 +59,9 @@ bool brw_nir_lower_shader_calls(nir_shader *shader, void brw_nir_lower_rt_intrinsics(nir_shader *shader, const struct gen_device_info *devinfo); +void brw_nir_lower_intersection_shader(nir_shader *intersection, + const nir_shader *any_hit, + const struct gen_device_info *devinfo); nir_shader * brw_nir_create_trivial_return_shader(const struct brw_compiler *compiler, diff --git a/src/intel/compiler/meson.build b/src/intel/compiler/meson.build index be38e3c0914..240f12753ac 100644 --- a/src/intel/compiler/meson.build +++ b/src/intel/compiler/meson.build @@ -84,6 +84,7 @@ libintel_compiler_files = files( 'brw_nir_lower_cs_intrinsics.c', 'brw_nir_lower_alpha_to_coverage.c', 'brw_nir_lower_image_load_store.c', + 'brw_nir_lower_intersection_shader.c', 'brw_nir_lower_mem_access_bit_sizes.c', 'brw_nir_lower_rt_intrinsics.c', 'brw_nir_lower_scoped_barriers.c', |