summaryrefslogtreecommitdiff
path: root/sd/source/ui/tools/SdGlobalResourceContainer.cxx
AgeCommit message (Collapse)AuthorFilesLines
2024-04-28Drop CacheConfiguration in favor of officecfgGabor Kelemen1-4/+0
Also the key path was wrong in SlsCacheConfiguration.cxx: MultiPaneGUI/SlideSorter/PreviewCache but in Impress.xcs we have MultiPaneGUI/SlideSorterBar/PreviewCache hierarchy so this may actually now start to work :) Change-Id: I4b552be713e6e157edb45692ba78101429aa1c85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166755 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2023-02-18osl::Mutex->std::mutex in SdGlobalResourceContainerNoel Grandin1-5/+6
Change-Id: I521ec7397e9ac54547bc82be6579cbb4fb4fc5a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147266 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-16rtl::Static->thread-safe staticNoel Grandin1-3/+6
Change-Id: I0f39dea1392eb2ba11881615aedbe386870282ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125324 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-26tdf#42949 Fix IWYU warnings in sd/source/ui/[p-t]*/*cxxGabor Kelemen1-1/+0
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Idc9ca0ec1d888d3625f24b8dea4421408d2e7e7d Reviewed-on: https://gerrit.libreoffice.org/78047 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-19loplugin:sequentialassign in sdNoel Grandin1-4/+2
Change-Id: I7d592b8929ca46c64a622551b039af0d6a7911db Reviewed-on: https://gerrit.libreoffice.org/70716 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-07tdf#42949 Fix IWYU warnings in include/vcl/[v-x]*Gabor Kelemen1-0/+1
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I98f49765c6b74808dcbd692e0f375dd2848fcfd4 Reviewed-on: https://gerrit.libreoffice.org/65614 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-10-30tdf#42949 Fix IWYU warnings in sd/source/ui/inc/{framework,tools,view}/*Gabor Kelemen1-0/+1
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Also a typo fix :) Change-Id: I7c96e8459f6fb75b07f6447715e8165800ecba53 Reviewed-on: https://gerrit.libreoffice.org/62259 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-06use more uniqueptr in SdGlobalResourceContainerNoel Grandin1-23/+12
Change-Id: I2cfd478032066c7e4cd930d098a086711b99934f Reviewed-on: https://gerrit.libreoffice.org/61431 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11Revert "clang bugprone-unused-return-value"Noel Grandin1-1/+4
comment from sberg: aren't these changes broken in general, when the called function may throw an exception before it takes ownership of the passed-in pointer? So revert, except for (a) PlainTextFilterDetect::detect, which was definitely a leak (b) SwCursor::FindAll, where unique_ptr was being unnecessarily used This reverts commit 7764ae70b04058a64a3999529e98d1115ba59d1c. Change-Id: I555e651b44e245b031729013d2ce88d26e8a357e Reviewed-on: https://gerrit.libreoffice.org/60301 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-08clang bugprone-unused-return-valueNoel Grandin1-4/+1
most of these changes just make the change of ownership when using std::unique_ptr clearer, but there is one definite leak fix in PlainTextFilterDetect::detect Change-Id: I8282a68007222a4fee84004f394bde0cca8569e9 Reviewed-on: https://gerrit.libreoffice.org/60159 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-30Add missing sal/log.hxx headersGabor Kelemen1-0/+1
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories scripting, sd, sdext Change-Id: I47889cd889cf1d68353184229bfd4712f1528fbf Reviewed-on: https://gerrit.libreoffice.org/58220 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-22C++17 deprecated std::shared_ptr::unique()Michael Stahl1-2/+2
Most of these calls are in assertions, and the ones that aren't should be guarded by SolarMutex, so the thread safety concerns that caused unique() to be deprecated don't look relevant, so use use_count(), which oddly enough isn't deprecated. Change-Id: Ia166615af6c3ce85145c391752669c7461bd35fb Reviewed-on: https://gerrit.libreoffice.org/48222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-10-23loplugin:includeform: sdStephan Bergmann1-2/+2
Change-Id: I4b75316c8644a591e6d1cfab4945ef123f945b53
2017-08-29sd: delete the global CacheConfiguration timer on shutdownMichael Stahl1-0/+4
Crashes in SchedulerMutex::acquire if destroyed from __run_exit_handlers Change-Id: Ie8bbb399183d118d92c94a40f55cc9c650baf742 Reviewed-on: https://gerrit.libreoffice.org/41629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock1-0/+1
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-02-21loplugin:subtlezeroinit: sdStephan Bergmann1-1/+1
Change-Id: I2cfa2507235d51c5518123a290abfa6a4f945872
2017-01-13tdf#105188 sd: fix shutdown crash after accessing master pagesMichael Stahl1-13/+28
The problem here is that the destructor of SdModule does a lot of things, including destroying an SdXImpressDocument that is referenced from some SdGlobalResourceContainer. This calls SD_MOD() to get the SdModule to get some resource, but at that point SfxApplication::GetModule() returns null, because the sequence was changed from first deleting the SfxModules, then clearing the pointer in ~SfxModule to null, to unique_ptr::reset(), which, at least in libstdc++, is implemented via std::swap, so it clears the pointer before deleting the SfxModule. It appears rather brittle to rely on such a subtle detail, so refactor things so that SdGlobalResourceContainer is no longer owned by SdModule but has its own pet XTerminationListener, which means it will be destroyed earlier, while the SdModule is still fully alive. (regression from f7b1cd66167050afecf487e3d89ea12de74200b5) Change-Id: I7f03f3adf431be8728ef3d65a078b536cb96f959
2016-12-15teach sallogareas plugin to catch inconsistenciesNoel Grandin1-3/+3
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a Reviewed-on: https://gerrit.libreoffice.org/32004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-06-12convert more DBG_ASSERT(false to SAL_WARNNoel Grandin1-3/+3
Change-Id: Ie52f28f28c67a91c4d3d4517d5c6a466890c7a55 Reviewed-on: https://gerrit.libreoffice.org/26195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-12clang-tidy performance-unnecessary-value-param in sdNoel Grandin1-1/+1
Change-Id: Id55410931305a9695a001977a5227b430a984e99
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann1-4/+4
Change-Id: If1b80da64ba575f07b31dce9bc0e34b7eb9f11a4
2015-09-23boost::shared_ptr->std::shared_ptrCaolán McNamara1-2/+2
Change-Id: I2c6ac98f0984534894759cfbf4449eb554801cf8 Reviewed-on: https://gerrit.libreoffice.org/18678 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-17revert for mac and win unit case crashes after boost->stdCaolán McNamara1-2/+2
Change-Id: I82c7084f203a834c2d42f9527705288e6036019b
2015-09-17boost->stdCaolán McNamara1-2/+2
Change-Id: I1e6a7fd66f90e6acd803c6cd464f1d73252f7bcb
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin1-3/+3
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-03-13tdf#43157: Fix format string violations in OSL_TRACE etc.Stephan Bergmann1-1/+2
...in preparation of enabling the __attribute__((format(...))) in sal_detail_logFormat (include/sal/detail/log.h) Change-Id: I8a859199fa11ca0f9f4f4b4b23a8ebddec955a86
2014-10-01sd: std::auto_ptr -> std::unique_ptrStephan Bergmann1-4/+4
ToolBarManager::Implementation::Update in sd/source/ui/view/ToolBarManager.cxx is dubious. It takes its parameter by value (so in UnlockUpdate() the passed-in mpSynchronousLayouterLock is reset upon passing it in), but the comment that it "is [...] released at its end" together with the redundant pLocalLayouterLock.reset() at the end of Update() make it look as though the intention was to pass by reference. However, resetting mpSynchronousLayouterLock even in the case where pass-by-ref would fail to reset it is apparently important, as otherwise e.g. JunitTest_svx_unoapi would run into the OSL_ASSERT(mpSynchronousLayouterLock.get()==NULL) in LockUpdate() with a call stack of ... -> Update -> SetValid -> UpdateLockImplementation -> LockUpdate. Change-Id: I7d2717d5e1f8aa69c79a626c100d7fefb0cfb120
2014-06-25remove whitespacesMarkus Mohrhard1-23/+0
Change-Id: I9daea42a433b5032931a722878874917cf37f4d1
2012-06-21re-base on ALv2 code.Michael Meeks1-23/+14
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2011-11-27remove include of pch header from sdNorbert Thiebaud1-2/+0
2010-10-13Add vim/emacs modelines to all source filesSebastian Spaeth1-0/+3
Fixes #fdo30794 Based on bin/add-modelines script (originally posted in mail 1286706307.1871.1399280959@webmail.messagingengine.com) Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2010-10-05remove include guards using fixguard.pyPetr Mladek1-0/+0
2010-06-14cws impress190: rebase m82Christian Lippka1-25/+0
2010-05-05#i89450# removed unused codeChristian Lippka1-25/+0
2010-02-12changefileheader2: #i109125#: change source file copyright notice from Sun ↵Jens-Heiner Rechtien1-4/+1
Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision)
2008-04-10INTEGRATION: CWS changefileheader (1.6.234); FILE MERGEDRüdiger Timm1-23/+18
2008/03/31 13:59:05 rt 1.6.234.1: #i87441# Change license header to LPGL v3.
2008-04-03INTEGRATION: CWS presenterview (1.6.22); FILE MERGEDKurt Zenker1-2/+41
2008/01/23 10:53:10 af 1.6.22.1: #i18486# Added support UNO object resources.
2007-04-03INTEGRATION: CWS components1 (1.4.52); FILE MERGEDRüdiger Timm1-4/+9
2006/09/25 17:34:49 af 1.4.52.2: RESYNC: (1.4-1.5); FILE MERGED 2006/08/22 12:34:28 af 1.4.52.1: #i68075# Extended the releasing of shared resources that are not unique.
2006-09-16INTEGRATION: CWS pchfix02 (1.4.104); FILE MERGEDOliver Bolte1-2/+5
2006/09/01 17:37:27 kaib 1.4.104.1: #i68856# Added header markers and pch files
2006-04-26INTEGRATION: CWS taskpane (1.3.116); FILE MERGEDKurt Zenker1-2/+41
2006/02/17 13:41:46 af 1.3.116.1: #i61359# Added shared_ptr resources.
2005-09-09INTEGRATION: CWS ooo19126 (1.2.394); FILE MERGEDRüdiger Timm1-47/+21
2005/09/05 13:25:06 rt 1.2.394.1: #i54170# Change license header: remove SISSL
2004-08-04INTEGRATION: CWS impress18ea (1.1.2); FILE ADDEDRüdiger Timm1-0/+188
2004/07/29 08:07:42 af 1.1.2.3: #i31401# Added missing header file. 2004/07/28 17:07:35 af 1.1.2.2: #i31401# Reversed order of resource destruction to avoid dependency problems. 2004/07/28 15:22:39 af 1.1.2.1: #i31401# Initial revision.
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-21 18:52:06 +0000