summaryrefslogtreecommitdiff
path: root/sd/qa/unit/data
AgeCommit message (Collapse)AuthorFilesLines
2025-09-01Related: tdf#111927 - PPTX: fix placeholder title text becomes smallBalazs Varga1-0/+0
after clicking in&out Follow-up after a7a02a742237d739e7b6b25fcfb9dbe2d4675c28 Wrong styles were applied to the different Outline (1, 2, ...) levels during ooxml import. Should also the Title, Subtitle, Outliner placeholders properties saved in LstStyles as OOXML standard requires. Even if we have no LstStyles in the xml, still need to apply the char/para properties to the placeholder styles. Change-Id: I5086f706fd8dc2704a439a2e410d74db2656d09b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190360 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga@collabora.com>
2025-08-29sd: add documents for visually testing text fitting / scalingTomaž Vajngerl4-0/+0
Made this when changing the text scaling algorithm to have a reference if we are regressing or progressing compared to MSO. These documents are useful when further changing the text scaling algorithm. Note that the rendering was not perfectly matching MSO, but it was a progress. Making the algorithm be perfectly inline with the MSO rendering is not a simple task. Change-Id: I59a17d197724fd84603d8f2928c2a26ee2069a68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190328 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2025-08-19tdf#164622: introduce UseTrailingEmptyLinesInLayout compat optionMike Kaganski3-0/+0
In PowerPoint, autoshrink text size is calculated the same way as in Impress, ignoring the empty lines block in the end. But when the text is positioned, these lines are taken into account, which may change position of texts aligned to bottom. Since this method of positioning text may change text placement very seriously, it can't be used unconditionally, and requires a compat flag, which is introduced here, only enabled for PPTX import, and in ODP documents having the option explicitly set. It is not used for other MS Office document types. I saw that Excel behaves similarly to PowerPoint, so maybe it makes sense to enable it for XLSX, too; on the other hand, MS Word works differently. Also I couldn't prepare a test document in binary PPT to test hehavior. The decisions about these file types should go in separate changes. Change-Id: Ie37f1d2b3393f9c52be89586c73df70b108190a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189935 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-08-13tdf#163239 - OOXML sd: fix customized placeholder text in master slide to beBalazs Varga1-0/+0
shown as the "prompt" text in the final slides What should works - New sd specific uno api shape property: CustomPromptText - With this property, the corresponding master slide SdrObj's and their final slide SdrObj's placeholder text can be set. - If we have CustomPromptText value it will be used for the PresetObj and will be created (CreatePresObj) with those texts as a default prompt text. If we do not have the usual default ones will be used. - OOXML import and export (partly since we have many other problems around export) are works - Enable to OOXML import of com.sun.star.presentation.SubtitleShape (partly, since in the core we handle them as Text objects) to handle them a bit better. OOXML export is still not good for different reasons: see tdf#112557 - Unit tests for custom "prompt" text TODO - odf import/export - we cannot set in runtime new custom placeholder texts, so the new placeholders/presobj will be created with the usual default texts. Change-Id: Ic2b06a10f7a19f0cfdb2b705645b08a24b3e433b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189185 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga@collabora.com>
2025-08-11tdf#166647 avoid duplicating slideshow user paintRegina Henschel1-0/+0
When a user enables 'mouse as pen' before starting the slideshow, then his paintings are saved as persistent shapes when he exits slideshow. These shapes were then converted back to paintings when the user starts the slideshow again, so that they are visible againg. But these old paintings were treated as new paintings when the user exits slideshow and were then saved again as shape to the page although the page contains these shapes already. Thus with every new start and exit of the slideshow the shapes were duplicated. Because the duplicates are at exactly the same place as the originals, you do not notice it immediately. But you can see the duplicates in the Navigator and notice it in the file size. The fix introduces a flag that is set at the paintings from the existing shapes when the slideshow is started. This flag is then used to skip those paintings from converting to shapes when slideshow is finished. Change-Id: I93324d157b1b802d7b8e24858034d2fdc5d71b45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188364 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@collabora.com>
2025-06-27tdf#167214: sd_font_embedding: Add testXisco Fauli1-0/+0
Change-Id: I9f164b0f309821479f8381d2f62ac4578e34a867 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187070 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-06-04sd: PPTX embedded fonts - skip common fontsTomaž Vajngerl1-0/+0
Skip embedding common fonts that are considered to be always available or are substituted for a metric compatible fonts in a LO or MSO. Change-Id: Ic970e25e464517fa44f446492c1fdfce29379c77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185761 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 21a5a743f3663392798c16943a40c431af4f2dd1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186166 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-05-24tdf#149207 fix image not getting a unique nameTomaž Vajngerl4-0/+0
Using "background" as the name, CheckNamedItem doesn't correctly determine that another XFillBitmapItem exists with an same "background" name already, which is then a problem when exporting the document and from all "background" images only one will be exported. regression from commit ec7ba61a6164c805f5a71b077715b7e1521a2d62 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed Apr 17 15:19:25 2019 +0200 simplify SfxPoolItemArray_Impl (tdf#81765 related) I am not sure why the above commit caused this problem. Right now, the reason CheckNamedItem doesn't work is because with other subsequent changes to the pool infrastructure, the new PoolItem is already in the surrogates/NameOrIndex array and so it finds itself when scanning the array. But back then, the new PoolItem should not have been inserted yet. Any way, fix it by making CheckNamedItem exclude itself when scanning the surrogates data. Added a test for uniqueness of names. Change-Id: I3c04065a4875a21649ad8141243cc39a8d1a5b3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185719 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-05-20PPTX: add "glue points" to all remaining shapesXisco Fauli7-0/+116
Similar to commit e6b974fd699dcef28a7c26a96c74f3b9a8df9cab Author: Tibor Nagy <tibor.nagy.extern@allotropia.de> Date: Mon Apr 22 16:09:04 2024 +0200 tdf#157216 PPTX: add "glue points" to flowchart shapes Generated running oox/source/drawingml/customshapes/generate.sh Change-Id: I27d6b5b72590d24e35367c0290a1e79cc4aca5d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185574 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-05-08sd: Test OOXML embedded fonts - import, export and round-tripTomaž Vajngerl1-0/+0
Import and round-trip tests don't run when libeot is not available. Export test doesn't depend on libeot, so it can run. Change-Id: I71d290b3f93a0ccdb9f8a5bdb9c933464c7059ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184974 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-04-10tdf#154858 - FILEOPEN PPTX: fix Radial gradient in shape imported asBalazs Varga1-0/+0
a Linear gradient XML_circle gradients should be always imported as GradientStyle_RADIAL. Regression from: 898e4ae1364e76af8be22183ac64d73b6a6d8d90 Change-Id: I8166a2afd3dadce61c742eeb0a55a0c8a8b9ada6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183836 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2025-04-01tdf#165995 pptx export: table cell margins weren't exportedJustin Luth1-0/+0
Although some left/right margins have been exported since 5.0 commit 636c5a63d67b52b0d2f9f21a863c45eca6ac9ff7 Author: yogesh.bharate001 on Thu Mar 26 10:48:15 2015 +0530 tdf#90223:PPTX table cell left and right margin is not exported. zero left/right margins weren't exported, and nothing was done for top/bottom border padding from table cells. (That's a bit weird, because I am using Yogesh's unit test to test for a round-tripped zero bottom border. It was the only existing unit test with non-default border spacing.) [The default (if not specified during import) L/R margins are 0.25cm (so definitely a zero margin needs to be exported and not ignored), and the import default for T/B margins is 0.127cm. However, none of that is documented of course.] make CppunitTest_sd_export_tests-ooxml1 \ CPPUNIT_TEST_NAME=testCellLeftAndRightMargin Change-Id: I12a8a785ddb784cacd4abf10e8e19df7cd50ec64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183564 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2025-03-20tdf#165670 PPTX export: fix glue points export regressionTibor Nagy1-0/+0
In some cases, we exported non-integer values for the glue points, and their positions were also incorrect. this regression is caused by commit Id4a127e7ef462611bf63da791717f8260ec51be0 (tdf165262 PPTX export: fix shape export regression). Change-Id: I978fa180ef181391651abad5c2b748e0b606b320 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183165 Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de> Tested-by: Jenkins
2025-03-12tdf#165636 - FILESAVE PPTX: fix extra table border lines shownBalazs Varga1-0/+0
Export correctly the transparency value of table borders. Change-Id: I22ee5e29d1846295645ce5934149cf864a178bb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182741 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2025-03-07tdf#165341 - FILEOPEN PPTX: fix paragraph alignment for text wrapped shapesBalazs Varga1-0/+0
In case of word wrapped text objects no need to set TextHorizontalAdjust based on text alignment. regression from: 1d9ce0a67a71e51569cd33c26270eeece587a354 (tdf#162571 - sd: Text box expands or shrinks on left or right or) Change-Id: I9455e30a58cc3853bc2a1c2030ab7cc62314106c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182616 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2025-03-07tdf#165321 - sd ooxml import fix missing shapes or shapes with nearBalazs Varga2-2/+2
zero height Use the calculated shapes size (before we calculate the shape size with NbcAdjustTextFrameWidthAndHeight if the autoTextGrowHeight is true) instead of the shape size directly from the xml, which need to be transformed in some cases. Regression from commit: ebf13e890766f4cadbba81444784cfe3c8e1bbc3 (tdf#156857: sd ooxml import: fix shape size if spAutofit is set) Change-Id: Icddaf22d10a89b172a3f1ca3e55150162e51a877 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182581 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2025-02-25tdf#164640: improve unittestXisco Fauli1-0/+0
* Test more levels * Can be reproduced with a blank document After commit 3aa4d993063a3f871f8f509ba81274a356d0dda0 Author: Xisco Fauli <xiscofauli@libreoffice.org> Date: Tue Feb 25 13:49:12 2025 +0100 tdf#164640: sd_import_tests2: Add unittest Change-Id: I4135a757bc85fb8a3233f613263ea6b71f41efa5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182187 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2025-02-25tdf#164640: sd_import_tests2: Add unittestXisco Fauli1-0/+0
Change-Id: Ibbfbd91ccf9eb9d27fcf80bf90cc9127a4db9813 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182166 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-02-24tdf165262 PPTX export: fix shape export regressionTibor Nagy1-0/+0
When exporting a shape from PPT to PPTX, the preset shape export is sometimes incorrect. In such cases, we export the shapes as custom shapes. The export of glue points is also important, so it has been added to the fix. this regression is caused by commit I378ffffc2ba09fcffcaa4e5dcf74bfd19e9f704d (tdf#149126 fix export of PPTX preset shapes). Change-Id: Id4a127e7ef462611bf63da791717f8260ec51be0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182068 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2025-02-23tdf#164936 oox: modify getColor method to include alphaMohit Marathe1-0/+0
Change-Id: I141be9568b54334a17f5f781f1612423bec19999 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181861 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
2025-02-18tdf#165261 - PPTX import: fix text in shape is left-alignedBalazs Varga5-6/+6
instead of being centered regression from: 1d9ce0a67a71e51569cd33c26270eeece587a354 (tdf#162571 - sd: Text box expands or shrinks on left or right or...) Change-Id: Ieed39426dc5aec7a34d15bbb0a4faaeba04ba50f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181822 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2025-02-09tdf#164775 PPTX export: fix connector shape regressionTibor Nagy1-0/+0
A connector shape can be connected to a shape, if the end of connector shape is released inside the target shape, it will automatically attach to the best possible connection point. It takes into account the shape type, geometric properties, and user-defined glue points. In this case, if we export the ODP file to PPTX, we need to use the GetConnectorRule() method to get the correct connection index(idx). this regression is caused by commit 4d153517183193f468dee9148c94fe9d874bacb3 (tdf#149697 PPTX export: fix changing place of connection points). Change-Id: I8eda059e72f595edc62fd5bc7f3e6466988af5bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181226 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2025-02-04sd: pptx export every layout usedJaume Pujantell1-0/+0
Regression from commit 9205b4eb09dcb4c91539e092db521154fc4e9523. On conversion from odp or ppt to pptx, some slide layouts were not saved if their masters were seen as equivalent. When reducing duplicated masters, only the layouts used in the Impress masters were saved for each duplicated masters. But when converting from other formats that handle masters/layouts differently it's necessary to search for all used layouts in each Impress slide that uses each duplicated master. Change-Id: Ie27852e7c0ff0b160a4e2415669f5e615c46e2f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181030 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181070 Tested-by: Jenkins Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>
2025-01-21sd: de-duplicate masters on save to pptx follow-upJaume Pujantell1-0/+0
After commit 2d9c808d1952c18daa007b41e70fc7e63f6c5712 "sd: de-duplicate slide masters on save to pptx", there was some loss of data on save since when saving only the layouts for de-duplicated masters, not enough of the shape tree was being saved. Ideally we may want a clever algorithm that best separates the shape tree between master and layout, but just saving all the shape tree on the layout files when de-duplicating masters also works. Change-Id: I8b932708ef9212a4d5034713066299065083da8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179861 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 3c8c537b3cfc4cf812e8728f6e6e46c0596ba7f6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180546 Tested-by: Jenkins Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>
2025-01-20tdf#164622 - SVG: fix broken cropped svg files at metafile exportBalazs Varga1-0/+0
For creating metafile, there mask polygon from MaskPrimitive2D needs to be closed. Otherwise later during the metafile export the we will skipp the rendering of the last points of the polylines. SVG clipping paths: "A clipping path is a set of closed vector path that may consist of an arbitrary number of straight and curved segments." Change-Id: I21487a81b904ec7ec5c6bd2a89b7539aeb86d606 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180278 Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
2025-01-06tdf#163852 ooxml: fix import of cropped vector graphic objectsBalazs Varga1-0/+0
We need to store the vector graphic objects size, so later we can calculate with that for the cropping. follow-up commit of: 1db193c6c744289139b1df2af0b8defcf974b238 (tdf#126084 import svg image from ooxml document that use svgBlip elem) Change-Id: Iffa98cc6a03063544bdf2b8ec3012415868e7c65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179626 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-12-19tdf#155211 - Change line style from solid to dashedAndreas Heinisch1-0/+4
Change line style from solid to dashed during GDI meta file import, if there exist dashed line properties. Change-Id: Ia5b88bd8513929969aed67b17494541da83b29d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178708 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2024-12-18tdf#135320 sd fix soft edges are not shown on text framesBalazs Varga2-0/+0
Allow soft edge and glow effect on text frames objects. Change-Id: If08da1cfeae515aa50ded5689b7fe3a963a98cd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178656 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-12-13tdf#150789 - FILEOPEN PPTX: fix text in SmartArt vertically offBalazs Varga1-0/+0
Calculate correctly the textbox area of upArrowCallout and downArrowCallout shapes in group shapes. In grouped list text area does not cover the whole shape but just a part of it at the top. In case of upArrowCallout and downArrowCallout the arrow size of the shape is not included in the textbox area of the full shape. Change-Id: If732305747c20da55bbd2896522c0b9c05cc4b4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178343 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
2024-12-09tdf#158512: PPTX import: reset useBgFill flag when it is unusedVasily Melenchuk1-0/+0
Even if current fill is not "use background" we should reset useBgFill explicitly, since this value could be set from master slide and was nested in current shape. It is somewhat confusing to have fillStyle as none and using slide background at the same time. So better to clean it explicitly. Change-Id: I0d817dc295785be7a6cb8f884d5023d316cd2ebf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165994 Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-12-05tdf#160487 - PPTX export: fix "Fit height to text"Balazs Varga1-0/+0
attribute of drawing objects (placeholders) Export spAutoFit attribute correctly to ooxml. Change-Id: I57e5b21bd6c407bdb5d1b36b3c3674249fbd2f59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177798 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-11-30tdf#163483: implement export of Math formula's fallback image to PPTXMike Kaganski1-0/+41
This was left as a TODO in commit cb890ae43bacd2be24bc74fad2e2e5cce8910995 (oox: export Math objects to PPTX files, 2016-01-15). Now after commit 7cfff4751befd678b3db4b6f16b020d38f4e9c32 (Related: tdf#129061 Avoid formula import and use fallback for now, 2024-09-11), that relied on the fallback being present, our exported documents lost the formulas completely on load. So the fallback export became a necessity. Change-Id: I52d4ef0400ce72ee10fda10a1131b4ba29ea56be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177564 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-10-16tdf#162571 - sd: Text box expands or shrinks on left or right orBalazs Varga4-6/+6
both sides, depending on the text alignment. Set the text anchor position based on the first paragraph alignment. WIP: testing... Change-Id: Ie1588c3eab5dd24eddb20baf342aca57c0dd39fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174885 Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-09-13Resolves: tdf#162455 svg->curve causes text in objects to disappearCaolán McNamara1-0/+2115
Rather than assuming there is a uniform unchanging MapMode scaling, follow the same pattern as SVGWriter and map positions/sizes back relative to the original MapMode. Examples of #i119125#, tdf#162455 and tdf#160625 work Change-Id: I8229cebee6173fa4905828afb3b973c80ede3315 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173126 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-09-12tdf#149865: reduce size of sample fileXisco Fauli1-0/+0
Change-Id: Ic0751f22f3158536dc5753db2ea9f133692e0d7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173213 Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-09-11Related: tdf#129061 Avoid formula import and use fallback for nowMike Kaganski2-0/+70
Until we support the correct inline formulas, their import fails badly in Impress, because we completely lose them in boxes with other content, and even where they are the sole content, they stretch to the size of the box incorrectly. Commit 4038d6c393c3cf6330671124ba69cdba98b24960 (tdf#117658 PPTX import: fix duplicated math object handling, 2019-11-13) opted to enable the Choice variant from the AlternateContent representing formula boxes. This change switches to Fallback graphic, losing the option to edit standalone imported formulas, but instead, allowing to see the formulas as they were created in PowerPoint. Unit test in sd/qa/unit/export-tests-ooxml2.cxx, created in commit 331a0a347e2ed238ff41c8cd7815b946cc95ac0f (starmath: fix OOXML export of non-BMP Unicode, 2016-01-21) was changed, because it depended on importing the formula from PPTX, which is disabled here. Since it was fixing the export part, the FODP source seems to be a reasonable replacement. Change-Id: Ibd0e2bcd68296020c3bc057cb6a563918926cf2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173163 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-09-11tdf#149865 - FILEOPEN PPTX: fix table lacks borderBalazs Varga1-0/+0
Fix wrong border line styles if we have merged cells. Change-Id: I238aa08c65b9aefd7b77b0f4ae3c3df979a7171d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173109 Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
2024-09-04tdf#143603: disable undo in DrawDocShell::ImportFromMike Kaganski1-0/+15
Change-Id: I6fbc317d9f72f1bec70ff97e915487ac2b5a2f53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172872 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-09-03Related: tdf#161826 - Add uniform Glow effect for texts in shapesBalazs Varga1-0/+0
Using text-properties for the glow-text attributes in odf import/export instead of graphic-properties. Change-Id: I94f5a76f33a03891fa0bfed988e7e3cd0e842cc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172741 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-08-29tdf#161826 - Add uniform Glow effect for texts in shapesBalazs Varga2-0/+0
- Add new text Glow effect properties for shapes - Using TextGlowPrimitive for rendering uniform text glow in shapes - Add/allow new UI Glow Effect for texts in shapes on sidebar (Only for Impress/Draw and Calc) - Import/Export ooxml files with Glow effect on texts in shapes (Only PPTX/XLSX) - Import/Export odf files with Glow effect on texts in shapes - Add unit test for glow text attributes in ODF - Add uni tests for OOXML import/export Note: Also this patch effects on tdf#144061 - Effects: Allow GLOW to apply to Text (as we have for shapes) Change-Id: I16586c01654f197f532129e4e06aa2ef9f214395 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172216 Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2024-08-21tdf#162283 PPT export: fix regression...Tibor Nagy1-0/+0
...was made by: Iefb9d97e0eb10a04c39b515b11e549aeb7be8f25 This regression occurred because there is a feature in MSO that allows the shape of a placeholder to be changed. In this case, the placeholder is converted into a custom shape after the import and saving custom shape from .pptx to .ppt didn't work. Change-Id: I85305b65742da8b4966d4956b9141c59b4563973 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172091 Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de> Tested-by: Jenkins
2024-08-12tdf#156857: sd ooxml import: fix shape size if spAutofit is setBalazs Varga1-2/+2
and the size of the shape from ooxml file is different then the inew calculated by TextAutoGrowHeight. Furthermore, no need to check and resize the shape size during the spell checking. Change-Id: Iffd15e02579942d4f5f20db73f2194f8298c0838 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171621 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-08-02tdf#162259: correctly handle font width on WindowsMike Kaganski1-0/+15
Unlike other platforms, on Windows, the font width is not relative to font height, but to average width of font's glyphs. This is mentioned in LogicalFontInstance::GetScale. 1. In VclProcessor2D::RenderTextSimpleOrDecoratedPortionPrimitive2D, when calculating the correction for width / height (introduced in commit cc3663bbaed4f65d64154e5f9abb51a5f622f710, 2024-04-20), the already applied X scale is now calculated using unscaled font's width. 2. Commit 8557ea84c9336ba8061246f1f46ddb6e02f413a1 (Exclude getHScale from DirectWrite font rendering, 2024-04-08) was effectively reverted, because I was wrong assuming that the code there was unnecessary. 3. Commit 2092df2a9044f1c2ae4379f48a3201e5867575a8 (tdf#161154: pass "scaling is done externally" information down the stack, 2024-05-18) was also reverted. Change-Id: I8cff39b67a6efd380f7807f5655f401bdb62cc3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171382 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-07-16package: add additional consistency checks for local file headerMichael Stahl2-0/+0
Check it contains same as central directory header, also check data descriptor if available. Also check there are no gaps or overlaps. This causes 3 fuzzer generated test documents to fail to load; adapt tests. Change-Id: If5813652f3bd03e90fdf95eb97e1e1523455b2b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170571 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-07-05Add escape direction support for glue points in the preset shapesTibor Nagy2-0/+2
Change-Id: I6727def5dd42ecd5dae3ddd27d2af733b5883e09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170006 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2024-07-01tdf#157172 tdf#157460 PPTX import: fix connectors adjustment valuesTibor Nagy1-0/+0
Change-Id: Ie95ccd5bcd4d5c3f9c45c7dcc4f88acc0c9438aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169830 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2024-06-29tdf#157216 PPTX: add "glue points" to flowchart shapesTibor Nagy1-0/+0
Change-Id: I1595c3ddcca08e4e95da608edbe18edc57b41362 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166457 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2024-06-22tdf#157529 PPTX import: fix transparency valueTibor Nagy1-0/+0
if the paragraph, which uses transformation (Arch, Circle, etc.), contains multiple texts and the first text is only a space character, then we use the transparency value of the following text. Change-Id: Ia87242e34b495802cbecf5dc0dd13d490312f435 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169351 Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de> Tested-by: Jenkins
2024-06-19tdf#160490 PPTX import: fix automatically resized placeholder heightTibor Nagy2-1/+1
See also commit Ia7f94d7452d1a1c3f004aebd73b6ed5cbfd9b43b "tdf#157285 PPTX import: fix placeholder height". Change-Id: I6203af3fe86a60e29121685ffeb435f4ff25368a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169206 Tested-by: Jenkins Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
2024-06-17pptx: Don't export notes author/date when in privacy modeSamuel Mehrbrodt1-0/+0
Change-Id: Ia2f20b05b043d45df090f2843a4d365c692770fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168813 Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Tested-by: Jenkins