summaryrefslogtreecommitdiff
path: root/sd/inc
AgeCommit message (Collapse)AuthorFilesLines
5 daysloplugin:constantparamNoel Grandin1-5/+1
Change-Id: Ifd973d558a73954d4b240b4d740739aa0a0a077e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187044 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
5 daysremove some dead codeNoel Grandin1-20/+8
from commit 0d8f5429a0f4b1e9818c6d04502e08dbfeec3eba Author: Mohamed Ali <mohmedali1462005@gmail.com> Date: Tue Feb 25 03:13:44 2025 +0200 tdf#45617 Make master slide copyable Change-Id: I166a4db94db5ccf940220d61bc0174e9ad41bd7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187043 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
5 daysFix error LNK2005 in MSVC after recent sd changesMike Kaganski1-1/+6
Seen as: isvl.lib(svllo.dll) : error LNK2005: "public: virtual class com::sun::star::uno::Any __cdecl cppu::WeakImplHelper<>::queryInterface(class com::sun::star::uno::Type const &)" (?queryInterface@?$WeakImplHelper@$$V@cppu@@UEAA?AVAny@uno@star@sun@com@@AEBVType@4567@@Z) already defined in Configuration.o isvl.lib(svllo.dll) : error LNK2005: "public: virtual void __cdecl cppu::WeakImplHelper<>::acquire(void)" (?acquire@?$WeakImplHelper@$$V@cppu@@UEAAXXZ) already defined in Configuration.o isvl.lib(svllo.dll) : error LNK2005: "public: virtual void __cdecl cppu::WeakImplHelper<>::release(void)" (?release@?$WeakImplHelper@$$V@cppu@@UEAAXXZ) already defined in Configuration.o isvl.lib(svllo.dll) : error LNK2005: "public: virtual class com::sun::star::uno::Sequence<class com::sun::star::uno::Type> __cdecl cppu::WeakImplHelper<>::getTypes(void)" (?getTypes@?$WeakImplHelper@$$V@cppu@@UEAA?AV?$Sequence@VType@uno@star@sun@com@@@uno@star@sun@com@@XZ) already defined in Configuration.o C:\lo\build\instdir\program\sdlo.dll : fatal error LNK1169: one or more multiply defined symbols found Change-Id: I3d52651f37952cb5f7c68959e8b300c235a8bac5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187052 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
5 daysloplugin:unusedmethodsNoel Grandin1-5/+0
Change-Id: I82b8f96b69055233e4e7ae29a33e5bdd9a4e2d65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187041 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
5 days[API CHANGE] remove css::drawing::framework::XResourceIdNoel Grandin1-47/+109
internal to sd, no need for it to use UNO Change-Id: I9cbf069e9697d70f8d54da48cc265dcee8965d71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186893 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
6 daysmark some classes finalNoel Grandin1-1/+1
Change-Id: I49da10f361a2479388ea8feec17e078662d2f744 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186972 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
6 daysuse more concrete UNO in sdNoel Grandin2-1/+520
Change-Id: Icc8740b6cf370c53df76ebbdf753782d84856e56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186971 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
6 daysinline USE_OPTIMISATIONS in ResourceIdNoel Grandin1-8/+0
it has been true for very very long, so just make it the default Change-Id: I249d22d5cf42fce812241cba086dc6ce536a6bbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186946 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
7 days[API CHANGE] remove css::drawing::framework::XViewNoel Grandin1-1/+0
internal to sd, no need for it to use UNO Change-Id: I17db2d5185051e551565361d29b9f890eb8d77a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186886 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
8 days[API CHANGE] remove css::drawing::ResourceIdNoel Grandin2-1/+203
internal to sd, no need for it to use UNO Change-Id: If3400472c136e315d1a8070faf67db2dc9e173e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186584 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
9 days[API CHANGE] remove drawing::framework::XConfiguration*Noel Grandin1-1/+0
these are internal to sd and do not need to be exposed as API Change-Id: Ifeebd510a56ecd82b7c86d4b5365dd2fb7d3e734 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186784 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
12 daysloplugin:unusedmethodsNoel Grandin2-9/+0
Change-Id: I245db9dcee5e4193cbc4b811c8e7d6145ea46415 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186671 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
13 days[API CHANGE] remove css::drawing::framework::XConfigurationControllerNoel Grandin2-2/+0
this is internal to sd, no need to use UNO here Change-Id: I7b1a68a45dc9e1a812e3f3724c08989021df29f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186648 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
13 days[API CHANGE] remove sd::drawing::framework::XControllerManagerNoel Grandin1-1/+0
this is internal to sd, no need to use UNO here Change-Id: I7987fd8ac86348451f9df2a14b3c6fed431ad1d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186647 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-06-16Drop SlideRender serviceNoel Grandin1-19/+9
since the console code is now inside sd/, we dont need this anymore. Change-Id: Ic663c148a641297b1e935aa7f5e245643ebc1157 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186569 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-06-16no need for PresenterPreviewCache to be an UNO service anymoreNoel Grandin1-0/+89
now that the slide console is not a separate component anymore. Change-Id: I21641e4157b8af4d44be91b15bc0b5740311472c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-06-15no need for SlideRenderer to be an UNO service anymoreNoel Grandin1-0/+87
now that the slide console is not a separate component anymore. Change-Id: I85b219b43752596a67633f8a793d139b739316e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-06-10sd: pass SdDrawDocument by refXisco Fauli1-4/+4
Change-Id: I8dc1f134b7b4aff462405d20899746c5b914fd50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186319 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-05-30SdUndoAction: pass SdDrawDocument by refXisco Fauli2-3/+3
Change-Id: I0f15f2e93e701f23dd588a891e3d40cc0854ce78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186041 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-05-27FuPoor: pass SdDrawDocument by refXisco Fauli1-4/+4
Change-Id: I75701740a24ad64f7a491937991eacf0c733d37e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185906 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2025-05-24tdf#149207 fix image not getting a unique nameTomaž Vajngerl1-1/+1
Using "background" as the name, CheckNamedItem doesn't correctly determine that another XFillBitmapItem exists with an same "background" name already, which is then a problem when exporting the document and from all "background" images only one will be exported. regression from commit ec7ba61a6164c805f5a71b077715b7e1521a2d62 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed Apr 17 15:19:25 2019 +0200 simplify SfxPoolItemArray_Impl (tdf#81765 related) I am not sure why the above commit caused this problem. Right now, the reason CheckNamedItem doesn't work is because with other subsequent changes to the pool infrastructure, the new PoolItem is already in the surrogates/NameOrIndex array and so it finds itself when scanning the array. But back then, the new PoolItem should not have been inserted yet. Any way, fix it by making CheckNamedItem exclude itself when scanning the surrogates data. Added a test for uniqueness of names. Change-Id: I3c04065a4875a21649ad8141243cc39a8d1a5b3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185719 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2025-05-20loplugin:finalclassesNoel Grandin1-2/+2
Change-Id: I56ba3f1d6a3bf90f1b3923ef54745a1582d6c85e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185541 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-05-19ImportPPT: pass SdDrawDocument by refXisco Fauli1-1/+1
Change-Id: Ie8cc94a924758e00f8b6c6103091f8f3636fb81a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185354 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-05-14sd: pass ViewShell by refXisco Fauli1-1/+1
Change-Id: Idbc66dedfb64c28bc699b54f9c433cfa535598ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185309 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2025-05-12New Clang 21 trunk -Werror,-Wunnecessary-virtual-specifierStephan Bergmann1-1/+1
...warning about non-overriding virtual dtors in final classes. Every single one of these might or might not be suspicious (e.g., in some cases it might be better to have a virtual dtor in a derived-from class). Also, for some of the virtual dtors, making them non-virtual then caused > error: unnecessary user-declared destructor [loplugin:unnecessaryoverride] so those were removed completely. Change-Id: If0ee71645a347d6096b65988c56f627c42fe54b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185223 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2025-05-08Remove obsolete fw declarations from sd/Gabor Kelemen3-8/+0
found with bin/find-unneeded-includes --fwdecl Change-Id: Icca48a80a17fad6765d0e871ec2a6f12e0317d60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183901 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2025-04-30const things up, elide a copyCaolán McNamara1-1/+1
Change-Id: I8b81c69c4a01ff3a2dd9a58628e203f187ed5e0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184843 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2025-04-30sd: use slide(SdPage/Part) selection for current view onlyPranam Lashkari1-1/+2
problem: in LOK when multipe users select the different slides some operations may fail i.e: - user A and B opens the document, - User B selects slide 4 - User A selects slide 1 (without this patch SdPage will only concider slide 1 selected) - Then user B tries to drag and drop slide 4 above the slide 1 - now core will think slide 1 is selected and need to put it above slide 1 that means nothing happens Change-Id: Ia9ebe531ddb1c21ffaa1435d9cc777750b4ca24c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184629 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> (cherry picked from commit aee332547295c78b3bcda38b67ba3f1ec2b0fc06) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184842 Tested-by: Jenkins
2025-04-30oox: embed used fonts only and font scripts for PPTX exportTomaž Vajngerl1-1/+15
Support properties "EmbedOnlyUsedFonts", "EmbedLatinScriptFonts", "EmbedAsianScriptFonts", "EmbedComplexScriptFonts" when exporting embedded fonts. This brings it to the same functionality as other embedded font exports. Change-Id: I9e463c0fbc8a41b165b30fa11222648e930dbca3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184348 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2025-04-30sd: move ModelTraverser to own file so it can be reusedTomaž Vajngerl1-0/+53
Change-Id: I8d487fd009ca3fa5fb9de8aabe65fd3e5e21b41d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184692 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2025-04-28tdf#45617 Make master slide copyableMohamed Ali1-20/+68
Added a new boolean option `bMergeMasterPagesOnly` to `InsertBookmarkOptions` to allow operations that only merge master pages. Updated various functions across the codebase to accommodate this new option, including `ForPaste`, `ForFileInsert`, `ForDragDrop`, and others Modified the `DocumentPageCounts` structure to include a count of new master pages Adjusted the logic in `insertAllPages`, `PasteBookmarkAsPage`, `ResolvePageLinks`, and `ImportDocumentPages` to utilize the new option for conditional merging behavior Updated UI components to pass the new parameter where necessary Enhances the naming logic for duplicate master slides, using a numeric prefix pattern (e.g., "1_MasterName") instead of simply appending underscores. Add unit tests for copying and pasting master pages Change-Id: If4167e846e5a747e1e1b194e3ced065a39f34ede Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182206 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2025-04-17Ignore pastes that don't originate from a Slide SorterCaolán McNamara1-0/+2
so we only do the creation of new pages when pasting entire slides, and do the usual paste otherwise. if this doesn't work out then an alternative idea is to extend TransferableObjectDescriptor with some additional information. Change-Id: I3630ff46c118350e8988e0c8cbd03b83a5a4e1ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184279 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit f57727e8ea65edbc8e6c25730f2b6574d4fa9b6e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184314 Tested-by: Jenkins
2025-04-15loplugin:unusedmethodsNoel Grandin1-16/+0
Change-Id: I1b2dce9aa52e8af57b15c2bc14c0df67bef185af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184190 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-04-09uno: introduced command to copy slidesPranam Lashkari1-0/+2
problem: in online though kit process it was difficult to trigger the slidesorter clipboard to copy slides. Difficulty was caused by slidesorter using its own viewshell to copy and online triggering copy command on drawviewshell. It's more convenient to use a different command rather than jumping between viewshells in this case Change-Id: I347ad0044efa64a3e5dcd26aeb16fe5b8103bb12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183924 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2025-03-31loplugin:constparam in variousNoel Grandin1-1/+1
Change-Id: I874a95777aed3471675bf03acfcf05ecfcb4f830 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183531 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-27tdf#45617 Refactor the member function SdDrawDocument::InsertBookmarkAsPageMohamed Ali1-51/+433
Break down the monolithic InsertBookmarkAsPage function into smaller, more specialized methods with clearer responsibilities: - Extract separate methods for inserting all/selected pages - Create specialized variants for different insertion scenarios (paste, file insert, drag-drop, page links, internal document operations, document import) - Introduce parameter structures to better organize function arguments - Add dedicated methods for style transfer and master page management - Improve code organization with clearer function boundaries - Enhance maintainability through smaller, focused functions Change-Id: If2b8bda0c2e88f25478d534af3f8fa0394017dbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179832 Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Jenkins
2025-03-06Revert "tdf#165504 restore SdrPage::GetLayoutName virtual"Xisco Fauli1-1/+1
This reverts commit 5137fcc47f8e40dcba991db1f57dc1b395bbf970. The commit I bisected in https://bugs.documentfoundation.org/show_bug.cgi?id=165504#c3 was actually the same as tdf#164463 which got fixed in 960db01dbfe2f916b91782da03532fae1f836445 "Resolves: tdf#164463 we need to pass a copy of the LayoutName" So this revert is not necessary. I'm really sorry for all the inconveniences caused. Change-Id: Ice96b06220decf8078658b61ca721638cc8d2254 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182578 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-03-06use more concrete UNO classes in sdNoel Grandin1-0/+161
Change-Id: I8727b67fbafa2a7baf89589ee2c85ce4637659ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182584 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-05tdf#165504 restore SdrPage::GetLayoutName virtualCaolán McNamara1-1/+1
revert commit 235c230cd348600ce7385cc580c45a7be3572704 CommitDate: Tue Oct 22 09:17:02 2024 +0200 We don't need a virtual here and commit 960db01dbfe2f916b91782da03532fae1f836445 CommitDate: Sat Dec 28 22:13:40 2024 +0100 Resolves: tdf#164463 we need to pass a copy of the LayoutName Change-Id: Iecc486eca72e4d752527e77a9817dc4bed663cc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182445 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2025-02-27sd presenter a11y: No longer read a11y names from configMichael Weghorn1-0/+4
Instead of reading strings for the a11y names to use for the Impress Presenter Console objects, use the usual approach for translatable strings. This is simpler and I see no reason to have those accessible names configurable. Maybe the previous approach was somehow related to the fact that Presenter Console used to be an extension before commit ea91c7d90d74e1ca039ba669b5d3e14fa359c0fa Author: Stephan Bergmann <sbergman@redhat.com> Date: Wed Nov 21 17:19:28 2012 +0100 Turn presenter screen from bundled extension to plain code Change-Id: I55b5e525913f429ec60a1c21b7bf162870d79af9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182325 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-02-27sd presenter: Drop always false paramsMichael Weghorn1-11/+1
All callers of PresenterHelper::createWindow pass false for both, the `bEnableChildTransparentMode` and the `bEnableParentClip` params. Drop them altogether, which allows to simplify PresenterHelper::createWindow a bit. Change-Id: Id4dc1ddb81833cdd303ec8314a80eeeee1cd89ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182300 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-02-27sd presenter: Drop always false bCreateSystemChildWindow paramMichael Weghorn1-5/+0
PresenterHelper::createWindow always gets called with a `bCreateSystemChildWindow` param of false. Drop the param altogether. Change-Id: Ia82dfa6d4826bf2cbe85a164c7645d3e9a7d1fc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182299 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-02-27sd presenter: Don't allow creating PresenterHelper objsMichael Weghorn1-11/+1
By now, the class is only useful for the static helper methods it provides. The last use of an actual PresenterHelper object was dropped in Change-Id: I7b85ae4f720474faf72d2721545158726b1d745d Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Feb 27 11:04:45 2025 +0100 sd presenter: Drop PresenterPaneBorderPainter::Renderer::mxPresenterHelper Make that clear by marking the default ctor as deleted and dropping what has become irrelevant. Change-Id: I411b02b94c8f81bc8cfb19e248e861adfe1a670e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182298 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-02-27sd presenter: Drop unused PresenterHelper::createCanvasMichael Weghorn1-18/+0
Change-Id: Ia3231f30ff7ee0223d596d1b15936b5ddd792a47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182290 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-02-27sd presenter: Make PresenterHelper::getWindowExtentsRelative staticMichael Weghorn1-1/+1
Now that PresenterHelper no longer needs to implement the XPresenterHelper interface dropped in commit a80dec4e7bfb64d5331fe59d0feaeede636376f4 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Feb 26 17:17:42 2025 +0100 [API CHANGE] Drop css::drawing::XPresenterHelper , make sd::presenter::PresenterHelper::getWindowExtentsRelative static. Drop rtl::Reference<PresenterHelper> class members in other classes that are now no more needed as they were only used to call the now static method. Change-Id: Ic095cfa900db7211bc3b7e286702807afeba1c20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182289 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2025-02-27sd presenter: Make PresenterHelper::toTop staticMichael Weghorn1-2/+2
Now that PresenterHelper no longer needs to implement the XPresenterHelper interface dropped in commit a80dec4e7bfb64d5331fe59d0feaeede636376f4 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Feb 26 17:17:42 2025 +0100 [API CHANGE] Drop css::drawing::XPresenterHelper , make sd::presenter::PresenterHelper::captureMouse and sd::presenter::PresenterHelper::releaseMouse static. This also makes PresenterScrollBar::mxPresenterHelper unnecessary, so drop it. Change-Id: Id45500f07fd5388abdcc0fc51623287cfc247f51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182288 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-02-27sd presenter: Make PresenterHelper::loadBitmap staticMichael Weghorn1-1/+1
Now that PresenterHelper no longer needs to implement the XPresenterHelper interface dropped in commit a80dec4e7bfb64d5331fe59d0feaeede636376f4 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Feb 26 17:17:42 2025 +0100 [API CHANGE] Drop css::drawing::XPresenterHelper , make PresenterHelper::loadBitmap static. Change-Id: I7741b966e09850412f60d2a3f44d36b401553729 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182287 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-02-27sd presenter: Align param names in doc with actual onesMichael Weghorn1-11/+11
This was forgotten when the doc was taken over from the XPresenterHelper IDL file in commit a80dec4e7bfb64d5331fe59d0feaeede636376f4 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Feb 26 17:17:42 2025 +0100 [API CHANGE] Drop css::drawing::XPresenterHelper Change-Id: I79d9ff754f175d768b53bfc3a64d77d2cae88faf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182280 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-02-27sd presenter: Use u16_string_view, OUString instead of char const*Michael Weghorn1-2/+2
This also prepares for an upcoming commit to make PresenterHelper::loadBitmap static, at which point switching the method param to std::u16string_view would be mandated by a clang-plugin. Change-Id: I6def3aceb1966c5d0d24db5112d64f6e662d55bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182279 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-02-27sd presenter: Make PresenterHelper::createSharedCanvas staticMichael Weghorn1-1/+1
Now that PresenterHelper no longer needs to implement the XPresenterHelper interface dropped in commit a80dec4e7bfb64d5331fe59d0feaeede636376f4 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Feb 26 17:17:42 2025 +0100 [API CHANGE] Drop css::drawing::XPresenterHelper , make PresenterHelper::createSharedCanvas static. This also makes PresenterButton::mxPresenterHelper unnecessary, so drop it and the ctor param only needed create it. Change-Id: I4af6e537d140a330fc6ffca518ed2809b935dafe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182278 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>