summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2021-04-30tdf#137945: sc: Add UItestXisco Fauli2-0/+38
Change-Id: I6fa935d0c77556113ae087a67c2932ddcee12a1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114871 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114935 Tested-by: Jenkins
2021-04-29tdf#137945: Revert "use more FastParser in ScXMLContentValidationContext"Xisco Fauli3-28/+103
This reverts commit ae854970bf9c734df132797c0f23a7829efd167c. This is only reverted in libreoffice-7-0 branch. See https://bugs.documentfoundation.org/show_bug.cgi?id=137945#c2 Besides, this commit partially reverts d32289d715f7182b9e82a4d3fde9cfcf87517da3 < loplugin:unusedmethods > and be9f45ad69a510185971957e7643fd64b873e98d < loplugin:unusedenumconstants > since some methods and enumerations are needed after reverting the commit Change-Id: Ia71257a37d384e7eb6ba904a6a13f8ae5603a79b Change-Id: I04c74ceb6e38c54ea41464b8337016bb5f81d90d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114882 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-09tdf#141547: maQueryItems can be 0Mike Kaganski3-13/+7
E.g., fillQueryParam (sc/source/ui/unoobj/datauno.cxx) may clear it and leave empty if relevant input item is empty. Note how commit e4b924df8f9ad02c66549751cb8e123e420e8508 had changed the same checks in ScQueryEntry::IsQueryBy[Non]Empty. Change-Id: I552462c72e69ddce43711bcff645dc6c7b133db7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113783 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit a0d2fb3217094aa7158310f0bcf16093bcc4984f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113757 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 7ba4eeb2e9b8153eb17779c93492ab80a5cd4644) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113767
2021-04-06tdf#139786 partial revert tdf#106181 XLSX export: output form controlsJustin Luth1-2/+2
Not every export is going to be to OOXML format, so don't just set ooxmlexport to true and remove the "if" clause (especially when leaving the comment that this is for DOCX only). This is a partial revert to 7.1 (and backported to 6.4.5) commit 577dd32b1c4eb0a4cff574fbabca987cb52b831b. Change-Id: If7ea32a236715ec779cac302773c4c9da19865a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113399 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit a3c5c0f7ce73001adab7475fde1f8ffec4eef48b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113484 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 4d63b046679539c1e0f5a6f44e87c9420d679f5b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113638
2021-04-06ofz: Segv on unknown addressCaolán McNamara1-1/+8
Change-Id: I6c69375a89781fc0b87230203335c861efb562f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113482 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-10fix ScFlatBoolSegmentsImpl delayed setup with threads (tdf#140754)Luboš Luňák3-0/+46
Change-Id: I258263f6a15e7098a2292ba7f3336fcaaf5224ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112184 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 2fb274950e5207ca55f4f52325fb522bd44024e1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112212 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112250
2021-03-09tdf#140833 show ScHeaderControl help tip after double click time has expiredCaolán McNamara2-11/+39
so under gtk the popover isn't active when the double click is processed by gtk because under load on wayland the double click is getting handled by something else and getting sent to the the window underneath our window Change-Id: Ie3afcf45c69b7b947b1aeb787478f947deca9307 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112136 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-03-08tdf#140700 nullptr dereferenceMike Kaganski1-1/+1
Change-Id: I6a2ffddfd67784ddc2194dafba7d3eaeb6e4e12e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110854 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 20305894243e24eb383ab9feefebf4a0e9f2644f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112084 Tested-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-11tdf#140006 don't limit dropdown width to 300pixelsCaolán McNamara1-4/+3
let it use the full width of the cell. Keep that 300 pixel limit if we are expanding the widget width beyond its size request. Change-Id: Ifeaa9ee60e0d5649de71c960ae83270fb1afb2e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110683 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-02-04tdf#140014 calc crash on COUNTIFNoel Grandin1-0/+2
regression from jumbo-sheets work Change-Id: I207cf3cc4c6d295688936ea3b672b32f9c09d89a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110349 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit c4540f86925609a54d473051ceb8dcf46d0e22aa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110358
2021-02-03tdf#120348: Avoid data loss when copying chart with error in formulasOuyang Leyan1-1/+1
During a chart copy in Calc, when skipping cells with ERR:502 in values, the rest of the column was skipped as well, including valid values. Change-Id: I2578dfdefe9d006de572f8faa3a8cc32e9f55010 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109025 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 318d384c596c1593667d6c936f55bf6ebd0c5db6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110355 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-25Related tdf#139782 sc: Make sure column exists before accessing itMichael Weghorn1-2/+2
While the first fix (Change-Id I12a780bf52024cef31188651813d3a93cc2b5ddd, "tdf#139782 sc: Don't try to access unallocated column") makes opening the simplified bugdoc I had attached to tdf#139782 work, the original document I was given (which I can't share as is, but from which the simplified bugdoc was created) had more formulas and managed to hit another similar issue related to the fact that columns are now dynamically allocated, and crashed trying to access one that wasn't yet allocated. Fix this place as well by making sure the column exists. Backtrace: "#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50\n" "#1 0x00007ffff7aa7537 in __GI_abort () at abort.c:79\n" "#2 0x00007ffff794beb1 in std::__throw_bad_exception() () at /lib/x86_64-linux-gnu/libstdc++.so.6\n" "#3 0x00007fffa0b161dc in std::__debug::vector<std::unique_ptr<ScColumn, o3tl::default_delete<ScColumn> >, std::allocator<std::unique_ptr<ScColumn, o3tl::default_delete<ScColumn> > > >::operator[](unsigned long) (this=0x555558827250, __n=84) at /usr/include/c++/10/debug/vector:427\n" "#4 0x00007fffa0c23935 in ScColContainer::operator[](unsigned long) (this=0x555558827250, nIndex=84) at .../libreoffice/sc/inc/colcontainer.hxx:44\n" "#5 0x00007fffa0c76275 in ScQueryCellIterator::InitPos() (this=0x7fffffff8040) at .../libreoffice/sc/source/core/data/dociter.cxx:1082\n" "#6 0x00007fffa0c76c28 in ScQueryCellIterator::GetFirst() (this=0x7fffffff8040) at .../libreoffice/sc/source/core/data/dociter.cxx:1233\n" "#7 0x00007fffa0c76fb6 in ScQueryCellIterator::FindEqualOrSortedLastInRange(short&, int&) (this=0x7fffffff8040, nFoundCol=@0x7fffffff7f58: 1024, nFoundRow=@0x7fffffff7fb0: 1048576) at .../libreoffice/sc/source/core/data/dociter.cxx:1304\n" "#8 0x00007fffa11b1529 in ScInterpreter::ScMatch() (this=0x5555619f7fd0) at .../libreoffice/sc/source/core/tool/interpr1.cxx:5050\n" "#9 0x00007fffa121f653 in ScInterpreter::Interpret() (this=0x5555619f7fd0) at .../libreoffice/sc/source/core/tool/interpr4.cxx:4247\n" "#10 0x00007fffa0f03bf5 in ScFormulaCell::InterpretTail(ScInterpreterContext&, ScFormulaCell::ScInterpretTailParameter) (this=0x55555e793030, rContext=..., eTailParam=ScFormulaCell::SCITP_NORMAL) at .../libreoffice/sc/source/core/data/formulacell.cxx:1952\n" "#11 0x00007fffa0f028b2 in ScFormulaCell::Interpret(int, int) (this=0x55555e793030, nStartOffset=-1, nEndOffset=-1) at .../libreoffice/sc/source/core/data/formulacell.cxx:1644\n" "#12 0x00007fffa0be0274 in ScFormulaCell::MaybeInterpret() (this=0x55555e793030) at .../libreoffice/sc/inc/formulacell.hxx:445\n" "#13 0x00007fffa0f07b34 in ScFormulaCell::GetErrCode() (this=0x55555e793030) at .../libreoffice/sc/source/core/data/formulacell.cxx:2974\n" "#14 0x00007fffa10bac28 in ScCellFormat::GetString(ScRefCellValue const&, unsigned int, rtl::OUString&, Color const**, SvNumberFormatter&, ScDocument const&, bool, bool, bool) (rCell=..., nFormat=0, rString=\"\", ppColor=0x7fffffff87e8, rFormatter=..., rDoc=..., bNullVals=true, bFormula=false, bUseStarFormat=false) at .../libreoffice/sc/source/core/tool/cellform.cxx:77\n" "#15 0x00007fffa0bcb8f8 in ScColumn::UpdateScriptType(sc::CellTextAttr&, int, mdds::detail::mtv::iterator_base<mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>::iterator_trait, mdds::detail::mtv::private_data_forward_update<mdds::detail::mtv::iterator_value_node<unsigned long, mdds::mtv::base_element_block> > >&) (this=0x55555e793330, rAttr=..., nRow=1, itr=...) at .../libreoffice/sc/source/core/data/column3.cxx:794\n" "#16 0x00007fffa0b9e315 in ScColumn::GetRangeScriptType(mdds::detail::mtv::iterator_base<mdds::multi_type_vector<mdds::mtv::custom_block_func1<mdds::mtv::default_element_block<51, sc::CellTextAttr> >, mdds::detail::mtv::event_func>::iterator_trait, mdds::detail::mtv::private_data_forward_update<mdds::detail::mtv::iterator_value_node<unsigned long, mdds::mtv::base_element_block> > >&, int, int, mdds::detail::mtv::iterator_base<mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>::iterator_trait, mdds::detail::mtv::private_data_forward_update<mdds::detail::mtv::iterator_value_node<unsigned long, mdds::mtv::base_element_block> > > const&) (this=0x55555e793330, itPos=..., nRow1=1, nRow2=1, itrCells_=...) at .../libreoffice/sc/source/core/data/column2.cxx:2089\n" "#17 0x00007fffa0b27563 in (anonymous namespace)::FindEditCellsHandler::operator()(size_t, ScFormulaCell const*) (this=0x7fffffff9180, nRow=1, p=0x55555e793030) at .../libreoffice/sc/source/core/data/column.cxx:3091\n" "#18 0x00007fffa0b31267 in sc::CheckElem<mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell>, mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>, (anonymous namespace)::FindEditCellsHandler>(mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent> const&, mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>::const_iterator const&, size_t, size_t, (anonymous namespace)::FindEditCellsHandler&) (rStore=..., it=..., nOffset=0, nDataSize=999, rFuncElem=...) at .../libreoffice/sc/inc/mtvfunctions.hxx:149\n" "#19 0x00007fffa0b2eb58 in sc::FindElement2<mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell>, (anonymous namespace)::FindEditCellsHandler, (anonymous namespace)::FindEditCellsHandler>(mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent> const&, mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>::size_type, mdds::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreEvent>::size_type, (anonymous namespace)::FindEditCellsHandler&, (anonymous namespace)::FindEditCellsHandler&) (rStore=..., nStart=0, nEnd=1048575, rFuncElem=..., rFuncElse=...) at .../libreoffice/sc/inc/mtvfunctions.hxx:496\n" "#20 0x00007fffa0b2b487 in sc::FindFormulaEditText<(anonymous namespace)::FindEditCellsHandler>(sc::CellStoreType const&, SCROW, SCROW, (anonymous namespace)::FindEditCellsHandler&) (rStore=..., nRow1=0, nRow2=1048575, rFunc=...) at .../libreoffice/sc/inc/mtvcellfunc.hxx:141\n" "#21 0x00007fffa0b293e3 in ScColumn::HasEditCells(int, int, int&) (this=0x55555e793330, nStartRow=0, nEndRow=1048575, rFirst=@0x7fffffff92ec: 0) at .../libreoffice/sc/source/core/data/column.cxx:3434\n" "#22 0x00007fffa0b981b1 in ScColumn::GetOptimalHeight(sc::RowHeightContext&, int, int, unsigned short, int) (this=0x55555e793330, rCxt=..., nStartRow=0, nEndRow=1048575, nMinHeight=0, nMinStart=0) at .../libreoffice/sc/source/core/data/column2.cxx:863\n" "#23 0x00007fffa0fcaf7d in (anonymous namespace)::GetOptimalHeightsInColumn(sc::RowHeightContext&, ScColContainer&, SCROW, SCROW, ScProgress*, sal_uLong) (rCxt=..., rCol=..., nStartRow=0, nEndRow=1048575, pProgress=0x7fffffff9740, nProgressStart=406268) at .../libreoffice/sc/source/core/data/table1.cxx:93\n" "#24 0x00007fffa0fccdae in ScTable::SetOptimalHeight(sc::RowHeightContext&, int, int, ScProgress*, unsigned long) (this=0x55555a39e890, rCxt=..., nStartRow=0, nEndRow=1048575, pOuterProgress=0x7fffffff9740, nProgressStart=406268) at .../libreoffice/sc/source/core/data/table1.cxx:470\n" "#25 0x00007fffa0c7ced6 in ScDocRowHeightUpdater::update() (this=0x7fffffff9910) at .../libreoffice/sc/source/core/data/dociter.cxx:2732\n" "#26 0x00007fffa15aae65 in ScXMLImport::endDocument() (this=0x555558902ec0) at .../libreoffice/sc/source/filter/xml/xmlimprt.cxx:1443\n" "#27 0x00007fff99f9e04b in sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) (this=0x555559b8e0f0, rStructSource=...) at .../libreoffice/sax/source/fastparser/fastparser.cxx:911\n" "#28 0x00007fff99fa2318 in sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource const&) (this=0x55555a718940, aInputSource=...) at .../libreoffice/sax/source/fastparser/fastparser.cxx:1482\n" "#29 0x00007fffecc8fa95 in SvXMLImport::parseStream(com::sun::star::xml::sax::InputSource const&) (this=0x555558902ec0, aInputSource=...) at .../libreoffice/xmloff/source/core/xmlimp.cxx:504\n" "#30 0x00007fffa15e0863 in ScXMLImportWrapper::ImportFromComponent(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, com::sun::star::uno::Reference<com::sun::star::frame::XModel> const&, com::sun::star::xml::sax::InputSource&, rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, bool) (this=0x7fffffffa2b0, xContext=uno::Reference to (cppu::(anonymous namespace)::ComponentContext *) 0x55555591a590, xModel=uno::Reference to (ScModelObj *) 0x55555a39fe50, aParserInput=..., sComponentName=\"com.sun.star.comp.Calc.XMLOasisContentImporter\", sDocName=\"content.xml\", aArgs=uno::Sequence of length 4 = {...}, bMustBeSuccessfull=true) at .../libreoffice/sc/source/filter/xml/xmlwrap.cxx:182\n" "#31 0x00007fffa15e3c0b in ScXMLImportWrapper::Import(ImportFlags, ErrCode&) (this=0x7fffffffa2b0, nMode=ImportFlags::All, rError=...) at .../libreoffice/sc/source/filter/xml/xmlwrap.cxx:510\n" "#32 0x00007fffa182aa1c in ScDocShell::LoadXML(SfxMedium*, com::sun::star::uno::Reference<com::sun::star::embed::XStorage> const&) (this=0x55555a783820, pLoadMedium=0x55555aa07260, xStor=empty uno::Reference) at .../libreoffice/sc/source/ui/docshell/docsh.cxx:482\n" "#33 0x00007fffa182b423 in ScDocShell::Load(SfxMedium&) (this=0x55555a783820, rMedium=...) at .../libreoffice/sc/source/ui/docshell/docsh.cxx:629\n" "#34 0x00007ffff5182831 in SfxObjectShell::LoadOwnFormat(SfxMedium&) (this=0x55555a783820, rMedium=...) at .../libreoffice/sfx2/source/doc/objstor.cxx:3128\n" "#35 0x00007ffff5174ee3 in SfxObjectShell::DoLoad(SfxMedium*) (this=0x55555a783820, pMed=0x55555aa07260) at .../libreoffice/sfx2/source/doc/objstor.cxx:677\n" "#36 0x00007ffff51c5544 in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x55555a39fdc0, seqArguments=uno::Sequence of length 16 = {...}) at .../libreoffice/sfx2/source/doc/sfxbasemodel.cxx:1883\n" "#37 0x00007ffff52f307f in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) (this=0x5555587e4650, rArgs=uno::Sequence of length 13 = {...}, _rTargetFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x5555569f3330) at .../libreoffice/sfx2/source/view/frmload.cxx:681\n" "#38 0x00007ffff5fd8854 in framework::LoadEnv::impl_loadContent() (this=0x555557039788) at .../libreoffice/framework/source/loadenv/loadenv.cxx:1163\n" "#39 0x00007ffff5fd45c7 in framework::LoadEnv::start() (this=0x555557039788) at .../libreoffice/framework/source/loadenv/loadenv.cxx:394\n" [..] Change-Id: I2d61e4a29543b1d331ae63d7ec023e88395e0b68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109705 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit fc3b904b671a71266db2e8b30cbeeef4f7981753) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109788 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-23tdf#139782 sc: Don't try to access unallocated columnMichael Weghorn1-0/+4
This fixes a regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic. Change-Id: I12a780bf52024cef31188651813d3a93cc2b5ddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109704 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 3032cf9df042f50511a15c6a627c50f708a34238) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109787 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-19Resolves: tdf#138972 dnd is moving instead of copying the dataCaolán McNamara1-4/+4
Change-Id: Icb2a3882704bf38c14b7a46154d51c3171268ca6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109220 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 1095b7bdf1bb33b3dc0fb5ae73342ae6ca0396fc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109522 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-15tdf#136155 let the other elements in the dialog determine the final widthCaolán McNamara1-0/+3
Change-Id: Ib47db4f47a331b1f3754ca4974a9f3e5b14efc95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109278 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-12-20Resolves: tdf#138710 Do not push an out-of-bounds bound to boundariesEike Rathke1-1/+2
... if a virtual non-existent row is being shifted in for MAXROWCOUNT (MAXROW+1), so sc/source/core/tool/sharedformula.cxx SharedFormulaUtil::splitFormulaCellGroups() is not triggered to split a group there, which would throw an exception. Instead of returning false ... CellStoreType::position_type aPos = rCells.position(nRow); if (aPos.first == rCells.end()) return false; However, avoiding the cause is the solution. Change-Id: I8f9adcb62bb78bc98092677b5d4fdc7fc3baf150 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107979 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 121d4f610a2b4caa871aa0132eccbd4e12d13b3f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107913 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-17tdf#138822: really undo when clicking Cancel in managing Named RangesJulien Nabet1-0/+1
Change-Id: Ib4d15e7e5287221ea51eb3e20dd1811c97999306 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107635 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 1790ed500f3033581ee4a3ef43428d7fda4692cc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107807
2020-12-14tdf#138851: Named range manager always display "Document (Global)" at launchingJulien Nabet1-7/+8
In Init() method, call SelectionChanged() at the end so we're sure everything is up-to-date. Change-Id: I1bd8c44e172cd9f739650a6f76478214c0a31ac0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107628 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-01Resolves: tdf#138549 use GetSpecialTextBoxShadow to identify ScPostItCaolán McNamara1-11/+0
instead of a 'special' name which causes undo-related causes side effects Change-Id: Id36b0b5360ddde3469721a7c837fe3942af08209 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106925 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-28tdf#138466 Crash when creating different scenariosNoel Grandin1-2/+3
apparently this is a regression from commit 4176beb7ef831152ce92ac3fa31314438635ec2c Author: Noel Grandin <noelgrandin@gmail.com> Date: Sat Sep 12 18:21:44 2020 +0200 tdf#133327 fix calc loading background color with many cols but I have no idea how or why, so just fix the crash. Change-Id: Ia2f056fc53527338c431d3b34bb64e6eedc8e955 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106799 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 52aebe6986bcec07071adb3f94d6c09fea147044) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106748 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-25crashtesting: make tdf129410-1.ods not crash on loadCaolán McNamara1-1/+2
Give its multiple anonymous ChartListeners unique names Maybe ScMyOLEFixer::FixupOLEs should instead skip calling CreateChartListener if getPropertyValue(sPersistName) >>= sName succeeded but has an empty sName result. Change-Id: I0741694ee692aaa22e0441a5e09748eb67e8dbf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106066 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106363 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-11-23tdf#138428 don't record SetName("ScPostIt") in undoCaolán McNamara1-0/+8
Change-Id: Iae87db47907078282e48035ad7892dbf52942e53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106432 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-19remove translatable string added in 6d9cc23aXisco Fauli1-5/+0
Change-Id: I55c10f1ab3c0f5b471b8033607681d8dbd4af735 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106158 Reviewed-by: Kevin Suo <suokunlong@126.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2020-11-19Resolves: tdf#114956 skip broadcast optimization for ScPostItsCaolán McNamara1-0/+3
so we can resize the ScPostIt as was the case before commit f06b48a5dddab20fd1bbf9b5f3e8543593f5e590 Date: Fri Aug 4 18:56:43 2017 +0200 editviewoverlay: Allow EditView to run in Overlay Change-Id: Idd92716a9b38058f6f275769d4f2523eddac500c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106005 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-11-18tdf#128135 update Pivot Table Layout to fit minimum heightandreas kainz1-27/+17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102319 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com> (cherry picked from commit d435997f446941adaa76fe4b253946cd08861ffd) Change-Id: I450625ccac06aec54371ede6bf9b50a221e1ba8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104936 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit bdc19e66f2bc1455b0cf3aff5f520e94365aba73) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106002 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-10tdf#134161: sc_anchor: Add unittestXisco Fauli2-0/+16
Change-Id: Iff58a85b9080ebe9c0d088237acb3af7018d3f04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105380 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 7ccbeade150f450568f44ad6283d4a4dc3b379bf) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105532
2020-11-10Revert "tdf#132137 Rename Default Style in Calc."Xisco Fauli26-53/+41
This reverts commit 4111ed76906bf6be05b704bf52fa91353dfef183. the document would also hang if define STR_STYLENAME_STANDARD NC_("STR_STYLENAME_STANDARD", "Default"); is replaced by define STR_STYLENAME_STANDARD NC_("STR_STYLENAME_STANDARD", "DefaultTest"); meaning somewhere in the code 'Default' is harcoded as git grep "\"Default\"" sc/source/ shows Reverting for now so we can backport it to libreoffice-7-0 while a better solution is provided for tdf#132137 Some other problems of the reverted commit are mentioned in comment 4 and comment 5 of tdf#134161 I'm adding a unittest in another commit so this one can be easily reverted in the future Change-Id: Ifabc133b8f72547fb506da0925df97f1b006291c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105390 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-04Resolves: tdf#137215 restore original modality before dialog loop endsCaolán McNamara2-0/+10
Change-Id: I83467e28534b781c51b8d75a023e41f3c6a03903 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105214 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-11-03Resolves: tdf#135108 Allow link updates if loaded document so far had noneEike Rathke3-1/+16
It is the current user who'll add external references, not the creator of the loaded document. Change-Id: I59a6d0b8600a9b299aa54a1efeedfccc16ad69d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105152 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 14f9dac4fbaeb0e13ad4875f77960c4019d8f229) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105055 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-11-01tdf#137897 scRetypePassInputDlg: re-allow password removalJustin Luth1-1/+1
This weld-conversion logic error caused a LO 6.1 regression in commit 0e4f93e88bfae3489d2de84fc2febed100880628. - m_pPasswordGrid->Disable(); + m_xPasswordGrid->set_sensitive(false); //disable == false - m_pBtnOk->Enable(); + m_xBtnOk->set_sensitive(false); //enable == true The result is that attempting to remove the password did not enable the OK button, so it was impossible. Change-Id: I4067b2ec6b89e86b21968d33c8850cca6d067e71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105049 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-29Resolves: tdf#137617 Use document address convention to create namesEike Rathke1-1/+2
... from selection. Change-Id: I0b170f36cfdb592e7cebae0246fba12c0180e2c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104854 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104867
2020-10-29avoid warning on set_active(0) on empty GtkComboBoxCaolán McNamara1-3/+6
i.e. gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL Change-Id: I48e7d015ec02ece407c732afebebb43c9c6fed48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104843 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-29tdf#137726 hide pivot table dlg so its not a candidate as error dlg parentCaolán McNamara1-0/+6
because this pivot table dialog is going to disappear on response and the error dialog is not run in its own event loop but instead async so will end up as a parent of a dialog that doesn't exist Change-Id: I78302428a246612e3107d2907ffffb97a2d25ea2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104841 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-27tdf#127680 change even/odd dialog orderSrijan Bhatia1-2/+2
Change-Id: I6dea25b3d212072df9a6638dc774f35e203e1f80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98602 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104878
2020-10-27tdf#127680 Add the option to print even or odd values from a particular rangeSrijan Bhatia1-18/+40
Added a box besides the pages option that lets the user choose between left and right pages/left pages/right pages. Change-Id: Iee0386f4f3cfd2dac3fcf898a3fefb5434cb27a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96612 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104877 Reviewed-by: Sophie Gautier <sophi@libreoffice.org>
2020-10-20tdf#137594 prevent converting unallocated columns.Mark Hung1-1/+2
Check col against GetAllocatedColumnsCount() instead of MaxCol(). This prevents allocating a new column just for converting an empty cell. Change-Id: I5c8dcfffc2661ab9c4fd9c2c53ed389e57351517 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit aa99b57cdc8cb3763aa935ed84e7d80c4e56a172) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104503 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-15Resolves: tdf#137248 Fix wrong condition breaking non-group interpretEike Rathke1-4/+4
Regression from commit 4f36f2ccab6286ec09480caea602c0fa19195736 CommitDate: Thu Sep 10 11:15:47 2020 +0200 detect if a cell still needs interpreting after Interpret() The bool return from ScFormulaCell::Interpret() does not indicate if it was succesful but whether a group interpret was done. As both calls here happen in a non-group context bailing out on that if false (no group interpret) is wrong. Instead, ask the cell if it still needs to be interpreted after having been interpreted. Change-Id: I40eeeef65e1da3d729cb3fef550620b1ea0a5741 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104261 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 59f86333f3fce091177d1cfb9363aa81686aa497) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104289 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-04tdf#134351: do not apply autofilter if all entries are selectedXisco Fauli2-7/+40
Change-Id: I33cdfe07cc53b579bbe16486f302daf7bd3da841 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103352 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103388 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-09-30tdf#137091: sc_subsequent_filters_test: Add unittestXisco Fauli2-0/+26
Change-Id: I435ffbdd82b5a40e56dd5f6ef55c032802184767 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103604 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 7672ac2e8764d9e4fcb5a896ef6210077907dcd0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103657
2020-09-30Resolves: tdf#137091 Use CharClass matching the formula languageEike Rathke2-24/+68
This is a combination of 3 commits. Resolves: tdf#137091 Use CharClass matching the formula language ... not the current locale. Specifically important for uppercase/lowercase conversions that may yield different results for example in Turkish i with/without dot. I2aa57cdcf530d7a0697c4ffbd5dccb86bb526d8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103588 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 3c6177be2705303044e3de262689d593f3d0f282) Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Current sytem locale's CharClass for user defined names, tdf#137091 follow-up I5f025a12ca183acb3f80d2a7527677aceb9ffbd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103593 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit d41c45a522c5e973d7043d36bc6c82e77735ab9b) Determine CharClass difference once, tdf#137091 follow-up As a side note: Clang plugin simplifybool for !(rLT1.getLanguage() == "en" && rLT2.getLanguage() == "en") told "error: logical negation of logical op containing negation, can be simplified" which is nonsense (the message stayed the same while the checks evolved). It actually complained about !(a==b && c==d) to be rewritten as (a!=b || c!=d) whether that makes sense or not.. it may save one boolean operation, yes, but.. Ib478d46d7ff926c1c9f65fec059c7a3f31fa7ce3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103601 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 1acf517906b7cdc4931dd26319d467dff53ae7d2) Conflicts: sc/source/core/tool/compiler.cxx Change-Id: I2aa57cdcf530d7a0697c4ffbd5dccb86bb526d8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103598 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-28Resolves: tdf#67007 display sheet-local range name in Name Box for selectionEike Rathke1-0/+14
Change-Id: Ia9980b13ed5c93cc72231ead532e3916e6234f56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103509 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit d3a8fdf3cad0e71ff5e13bb229fed6e52206c6b9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103430 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-28Resolves: tdf#133812 Add the 'Result' style again used by the Subtotal toolEike Rathke2-1/+9
Necessary to also adapt the test case that checks for a defined number of styles. Regression from commit 7b0aed617f1e57335837cf56ef2d222a96f8270d CommitDate: Wed Sep 28 11:42:56 2016 +0000 Remove old cell styles from calc and commit 06f319937187f76ee402d53b3baa78c391c2af19 CommitDate: Sun Oct 2 13:51:26 2016 +0000 tdf#90937 Add a set of cell styles to calc Change-Id: I3e47d8e24d375a64d9056e7a85197b89173c8e41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103520 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 930d82550863430c9bef96ac307c3ff2cfefe4d8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103432 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-21tdf#136620 tdf#136708 filter,oox,sw: fix export of 2 different wrapsMichael Stahl1-0/+2
This reverts commit 2cb90a5c87fe46737c8d840967d8836284f92ffd. Revert the change to EscherPropertyContainer, which was completely bogus, based on pre-existing bogus code in VMLExport::Commit(). The problem is that ESCHER_Wrap values are for wrapping text *inside* a text box, which is "mso-wrap-style" in VML, whereas VML's w10:wrap element defines how text wraps *around* a shape, doesn't exist as an ESCHER property and is specific to Word formats. Instead, export the w10:wrap element in VMLExport::EndShape(). This has 2 callers, WriteActiveXControl() and writeVMLDrawing(). Furthermore the value "none" wasn't written for WrapTextMode_THROUGH, which caused the wrap element to be omitted in that case. Change-Id: Id4a01fcb2ea73fa9bef4ee8769b5e0680e059f15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103009 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit fdc8590032b292dcb8152b328401e591fea642a4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103090 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-16detect if a cell still needs interpreting after Interpret()Luboš Luňák1-2/+26
https://bugs.documentfoundation.org/attachment.cgi?id=51878 after hard-recalc asserts because of not having cell dependencies non-dirty for threaded calculation. This is because Interpret() actually sometimes returns without computing a value for the cell, e.g. when it backs out because of a need to do iteration. This is handled when Interpret() is called from InterpretTail(), but ScDependantsCalculator does not handle this and considers all cells interpreted, unless it detected a problem. We've already fixed a number of such bugs, and given that there are still problematic corner cases after all this time, add code simply detecting this generic problem and avoiding threading in that case, with a SAL_WARN. This does not fix the problem itself, but at least now it's handled. Change-Id: I2f454b577f6516d2ce008005dbfbeb554e18d811 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102156 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 4f36f2ccab6286ec09480caea602c0fa19195736) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102308 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-16tdf#135799: properly load arrays in user-defined types from imageMike Kaganski3-1/+62
This requires to reset Fixed flag temporarily, as in SbiParser::DefType for non-image case. And save the dimensions of the arrays in the custom types correctly: the dimensions are numbered from 1, not from 0. The existing unit test (that happened to not test anything actually) was fixed. Change-Id: I48c6b6d5d735d9972a2c0dd40345d5db75f87f39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100877 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102748
2020-09-15tdf#135181 Calc print preview zoom slider print preview not transparent (gen)Noel Grandin1-2/+4
Change-Id: I7244f429194145df99a4b52fce144c6ec45f3b61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102168 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 00cffc20e40b2412c7e9867eed24c9834504e24f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102646 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-14tdf#133327 fix calc loading background color with many colsNoel Grandin1-3/+2
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa tdf#50916 Makes numbers of columns dynamic. Change-Id: Ic9e1b31d74b11367a5ad1a82480ffe9467c37ad8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102535 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 4176beb7ef831152ce92ac3fa31314438635ec2c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102634 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-12Resolves: tdf#107459 MATCH() in descending sorted array find last equal valueEike Rathke1-1/+1
... not reverse the first equal value. This only affected the array/matrix argument case, not cell references. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102493 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 6f80e2d37ce11e3ea728b7ce5987f912fdfa60b3) Conflicts: sc/source/core/tool/interpr1.cxx Change-Id: I0ff574a5132b6ee93789ac32f6c5de02465263f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102428 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-09Check range before accessing Calc sort userlistThorsten Behrens2-4/+4
Conflicts: sc/source/filter/excel/excrecds.cxx Change-Id: Ib5078dc4ce3f85be9b42320b60ef6fc40b684cb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102140 Tested-by: Jenkins Tested-by: Serge Krot <Serge.Krot@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102253 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-09-09tdf#108673 XLSX: Don't export invalid sheet references in cell validationSerge Krot5-3/+63
Change-Id: Id9d88f5e34f3017516f693505df4c3ce82b1890f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98479 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit a3b4831208da615789bd1e2d5660dd130807f504) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102127 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 13:40:40 +0000