summaryrefslogtreecommitdiff
path: root/sc
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2020-10-27 15:59:56 +0000
committerXisco Fauli <xiscofauli@libreoffice.org>2020-10-29 11:52:48 +0100
commitb7eef4e6242d8ef803d1789cf1c44e2f8bc9ceee (patch)
treecb4e044636d7f9885540b44a4dcb9bb03e09f781 /sc
parent1bf0997d459909d0d72b168b342939237ed92a99 (diff)
tdf#137726 hide pivot table dlg so its not a candidate as error dlg parent
because this pivot table dialog is going to disappear on response and the error dialog is not run in its own event loop but instead async so will end up as a parent of a dialog that doesn't exist Change-Id: I78302428a246612e3107d2907ffffb97a2d25ea2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104841 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Diffstat (limited to 'sc')
-rw-r--r--sc/source/ui/dbgui/PivotLayoutDialog.cxx6
1 files changed, 6 insertions, 0 deletions
diff --git a/sc/source/ui/dbgui/PivotLayoutDialog.cxx b/sc/source/ui/dbgui/PivotLayoutDialog.cxx
index 294771e955be..788e81574810 100644
--- a/sc/source/ui/dbgui/PivotLayoutDialog.cxx
+++ b/sc/source/ui/dbgui/PivotLayoutDialog.cxx
@@ -628,6 +628,12 @@ void ScPivotLayoutDialog::Close()
IMPL_LINK_NOARG( ScPivotLayoutDialog, OKClicked, weld::Button&, void )
{
+ /* tdf#137726 hide so its not a candidate to be parent of any error
+ messages that may appear because this dialog is going to disappear on
+ response(RET_OK) and the error dialog is not run in its own event loop
+ but instead async */
+ m_xDialog->hide();
+
ApplyChanges();
m_xDialog->response(RET_OK);
}