summaryrefslogtreecommitdiff
path: root/connectivity/source
AgeCommit message (Collapse)AuthorFilesLines
42 hoursFix logic of fb_shutdown checkJulien Nabet3-2/+13
From https://www.firebirdsql.org/file/documentation/release_notes/html/en/2_5/rnfb25-apiods-api.html " Return Values A return value of zero means shutdown was successful A non-zero value means some errors occurred during the shutdown. Details will be written to firebird.log. " Change-Id: I1139e1abdd1f07f0fad23f24a177aa5439546b19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184939 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
13 daysThese bogus -Wdangling-reference still hit with current GCC 16 trunkStephan Bergmann1-2/+2
Change-Id: I228e0b148d77b973afb4e35b8976438ba5a95967 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184517 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2025-04-13Remove obsolete fw declarations from connectivity/Gabor Kelemen24-60/+0
found with bin/find-unneeded-includes --fwdecl Change-Id: I0da5d8732b883f862688371bfb175a0aef950691 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183880 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2025-03-28fix CppunitTest_dbaccess_SingleSelectQueryComposer_test deadlock (2)Noel Grandin1-0/+8
similar to commit c02c75ba1e748ee72f299464fc6cf34f9ddc9298 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Mar 27 14:28:02 2025 +0200 fix CppunitTest_dbaccess_SingleSelectQueryComposer_test deadlock deadlocking threads are in privateSnippetExecutor in connectivity::hsqldb::ODriverDelegator::shutdownConnection in connectivity::hsqldb::ODriverDelegator::disposing in privateSnippetExecutor in dbaccess::OConnection::disposing in dbaccess::OSharedConnection::close in SingleSelectQueryComposerTest::tearDown and Thread 42 (Thread 0x7f7d6e672700 (LWP 3544697) "DocumentEventNo"): in comphelper::SolarMutex::acquire in dbaccess::ModelMethodGuard::ModelMethodGuard in dbaccess::DocumentGuard::DocumentGuard in dbaccess::ODatabaseDocument::getCurrentController in non-virtual thunk to dbaccess::ODatabaseDocument::getCurrentController in tdoc_ucp::OfficeDocumentsManager::isWithoutOrInTopLevelFrame in tdoc_ucp::OfficeDocumentsManager::isOfficeDocument in tdoc_ucp::OfficeDocumentsManager::documentEventOccured in dbaccess::DocumentEventNotifier_Impl::impl_notifyEvent_nothrow in dbaccess::DocumentEventNotifier_Impl::processEvent in comphelper::AsyncEventNotifierBase::execute() in comphelper::AsyncEventNotifierAutoJoin::run() in threadFunc(void*) (param=0x36a7450) Change-Id: Ifb8e37a05ce62ca37132e8391980de821bb97ee8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183428 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-28tdf#165928: MySQL/MariaDB direct connection: VARCHAR can be > 255 charactersJulien Nabet1-1/+9
Change-Id: If3d5163416508d0f9e26978e2d853542f7a01961 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183400 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2025-03-25tdf#165839 Changes the transaction isolation leveljucasaca1-1/+1
Changes the transaction isolation level to allow modification of the same table by multiple simultaneous connections Change-Id: I5db7e55ffbe75e21c5eba56e168deb8e478eb282 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183180 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-03-12use more concrete UNO in connectivityNoel Grandin16-256/+245
Change-Id: I3842706a0b28c3bf78c8f359ca2d2226ed5f1b07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182769 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-07trim excessive leading whitespace in connectivityNoel Grandin162-10227/+10227
Change-Id: I5629ca3ac7503c1cab848f65fcd25d15a1e3dcaa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182580 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Lionel Mamane <lionel@mamane.lu>
2025-03-05improve type-safety in FirebirdDriverNoel Grandin2-3/+5
Change-Id: I110d7d2c10d5855b6486d84763b7e963de1617f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182532 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-05improve type-safety in ado::ODriverNoel Grandin2-4/+7
Change-Id: Ic93722a2e4b8348011316c2ee1ecd3addf6fdd2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182534 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-03-05remove unused typedefNoel Grandin1-2/+0
Change-Id: I6954a70e9ca3498ef38164a7415e19ac3ade524a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182533 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-05improve type safety in OEvoabDriverNoel Grandin2-4/+6
Change-Id: I9b65bdf5ffb4ffd52f2ec8f87eb999c767569948 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182478 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-05improve type safety in file::OFileDriverNoel Grandin6-8/+11
Change-Id: I2150fbd2c23b6bde08443f2eb6eabdcb269376fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182477 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-04improve type safety in mysqlc::MysqlCDriverNoel Grandin2-5/+3
Change-Id: I3050e0e3b649a0e093750d9e51019d5e0b2cc730 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182476 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-03-04improve type safety in mysqlc::OConnectionNoel Grandin3-10/+12
Change-Id: Id41f78a67c9634ddfcfd0435357bb9a754a150f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182475 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-04improve type safety in mysqlc::OPreparedResultSetNoel Grandin2-4/+4
Change-Id: If0a427ff5c02ed15f62608603e641a8f6dbe5755 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182474 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-03-04improve type safety in mysqlc::OResultSetNoel Grandin2-3/+4
Change-Id: I44e7aafd7b9e7d426d511aab72ccd5f818305133 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182466 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-04ODatabaseMetaDataResultSet::m_aStatement is unusedNoel Grandin2-3/+1
Change-Id: If8ce23440a5046c8d6b16558ac7ecd885afc0305 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182465 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-03-04improve type safety in hsqldb::ODriverDelegatorNoel Grandin2-30/+34
we can use type-safe WeakReference wrappers classes. Also use a custom struct instead of std::pair<std::pair< Change-Id: Idc984e316dd063a3656688872bf7b40ca8733b0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182460 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-04more type-safety in odbc::ODBCDriverNoel Grandin2-3/+7
Change-Id: I5db758cd282299ccd15872195a292224827d0c97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182468 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-03-04ado::ODatabaseMetaDataResultSet::m_aStatement is unusedNoel Grandin2-3/+2
Change-Id: I5185f4ddeaa041013af43006c927aa2709fb2ac4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182467 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-04improve type safety in mysql::ODriverDelegatorNoel Grandin2-25/+26
we can use type-safe WeakReference wrappers classes. Also use a custom struct instead of std::pair<std::pair< Change-Id: I0debaf3b0a77e92545c39aa755ca2477cc1e8c26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182459 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-04m_aStatement in ODatabaseMetaDataResultSet is unusedNoel Grandin2-2/+0
Change-Id: If7cc484a3160dbb1422547d0c88cbf81f4b5aeb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182461 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-03-03expand the ObjectType typedefNoel Grandin75-174/+184
in preparation for making some of the code more typesafe Change-Id: I7c8a4b30cd1144feaaa2e31fce67cd6545065a38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182425 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2025-02-27Revert "tdf#159588: Query-GUI: LOWER isnt supported in Query-GUI if ...Julien Nabet1-4/+17
This causes regression, see tdf#165458 This reverts commit 9530664d07f400f4d8dcbe54d0e82d69168844de. Change-Id: Ic2be6ea3a41e1a22c9443a2fe8a0cae188bc6eb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182314 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2025-02-25use more concrete UNO types in some local varsNoel Grandin13-32/+18
found by a little plugin I created. Change-Id: If89a8fa349bb823c4e8dfa5cd9732950149d06cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182162 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2025-01-29tdf#130672: handle Rule::factor explicitlyMike Kaganski1-1/+22
When representing a signed number, the rule may consist of two subnodes: a punctuation bearing "+" or "-", and then the following digits (see 'factor:' in connectivity/source/parse/sqlbison.y). After punctuation was added to the string buffer, the following number is passed to parseLeaf, where it checks if the buffer is not empty, and then adds a space between the preceding sign and the digits. This change handles the 'factor' rule explicitly. Change-Id: I0c929418ad88c5bf653a4e820f45b7d627b07da7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180917 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2025-01-19tdf#158337 Use C++20 std::erase instead of std::remove followed by erasebruh1-2/+1
Change-Id: Ic6781ae74c2945608c35b92ad8ba92e789582973 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180421 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-07Simplify getTypes implementationsMike Kaganski3-15/+6
Change-Id: Ia0f7e8497f628b17a108a4dd8ffebc60745b7d6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178054 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-07Simplify OPreparedStatementMike Kaganski2-41/+6
Change-Id: I1c36ec85d1acafc5c6ef33ea250ac6027d604da7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178053 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-12-07Use std::initializer_list, C-style array instead of more expensive SequenceMike Kaganski1-3/+3
Change-Id: Ibb268268926cc91f595f19026f6cee4b5a74a8bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178038 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-07Drop support for Windows versions prior to Windows 10Mike Kaganski6-15/+15
Now when version 25.8 is in development, and the drop of legacy Windows versions was announced in release notes. Change-Id: Iefda63a29cafe40aec78d149067bdd7a3f20cffb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178025 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-30cid#1607542 COPY_INSTEAD_OF_MOVECaolán McNamara1-2/+2
and cid#1606986 COPY_INSTEAD_OF_MOVE cid#1557969 COPY_INSTEAD_OF_MOVE cid#1557837 COPY_INSTEAD_OF_MOVE cid#1557772 COPY_INSTEAD_OF_MOVE cid#1557735 COPY_INSTEAD_OF_MOVE cid#1557672 COPY_INSTEAD_OF_MOVE cid#1557664 COPY_INSTEAD_OF_MOVE cid#1557650 COPY_INSTEAD_OF_MOVE cid#1557642 COPY_INSTEAD_OF_MOVE cid#1557639 COPY_INSTEAD_OF_MOVE cid#1557628 COPY_INSTEAD_OF_MOVE cid#1557623 COPY_INSTEAD_OF_MOVE cid#1557581 COPY_INSTEAD_OF_MOVE cid#1557489 COPY_INSTEAD_OF_MOVE cid#1557473 COPY_INSTEAD_OF_MOVE cid#1557317 COPY_INSTEAD_OF_MOVE cid#1557261 COPY_INSTEAD_OF_MOVE cid#1557146 COPY_INSTEAD_OF_MOVE cid#1557135 COPY_INSTEAD_OF_MOVE cid#1557134 COPY_INSTEAD_OF_MOVE cid#1557079 COPY_INSTEAD_OF_MOVE cid#1557063 COPY_INSTEAD_OF_MOVE cid#1557052 COPY_INSTEAD_OF_MOVE cid#1556982 COPY_INSTEAD_OF_MOVE cid#1556977 COPY_INSTEAD_OF_MOVE cid#1556950 COPY_INSTEAD_OF_MOVE cid#1556943 COPY_INSTEAD_OF_MOVE cid#1556804 COPY_INSTEAD_OF_MOVE cid#1556736 COPY_INSTEAD_OF_MOVE cid#1556658 COPY_INSTEAD_OF_MOVE cid#1556621 COPY_INSTEAD_OF_MOVE cid#1556590 COPY_INSTEAD_OF_MOVE cid#1556579 COPY_INSTEAD_OF_MOVE cid#1556534 COPY_INSTEAD_OF_MOVE cid#1556524 COPY_INSTEAD_OF_MOVE cid#1556478 COPY_INSTEAD_OF_MOVE cid#1556467 COPY_INSTEAD_OF_MOVE cid#1556422 COPY_INSTEAD_OF_MOVE cid#1556314 COPY_INSTEAD_OF_MOVE cid#1556309 COPY_INSTEAD_OF_MOVE cid#1556258 COPY_INSTEAD_OF_MOVE cid#1556143 COPY_INSTEAD_OF_MOVE cid#1556119 COPY_INSTEAD_OF_MOVE cid#1556101 COPY_INSTEAD_OF_MOVE cid#1556097 COPY_INSTEAD_OF_MOVE cid#1556039 COPY_INSTEAD_OF_MOVE cid#1555966 COPY_INSTEAD_OF_MOVE cid#1555948 COPY_INSTEAD_OF_MOVE cid#1555915 COPY_INSTEAD_OF_MOVE cid#1555836 COPY_INSTEAD_OF_MOVE cid#1555748 COPY_INSTEAD_OF_MOVE cid#1555644 COPY_INSTEAD_OF_MOVE cid#1555582 COPY_INSTEAD_OF_MOVE cid#1555478 COPY_INSTEAD_OF_MOVE cid#1555475 COPY_INSTEAD_OF_MOVE cid#1555409 COPY_INSTEAD_OF_MOVE cid#1555372 COPY_INSTEAD_OF_MOVE cid#1555334 COPY_INSTEAD_OF_MOVE cid#1555330 COPY_INSTEAD_OF_MOVE cid#1555310 COPY_INSTEAD_OF_MOVE cid#1555257 COPY_INSTEAD_OF_MOVE cid#1555247 COPY_INSTEAD_OF_MOVE cid#1555147 COPY_INSTEAD_OF_MOVE cid#1555120 COPY_INSTEAD_OF_MOVE cid#1555059 COPY_INSTEAD_OF_MOVE cid#1555016 COPY_INSTEAD_OF_MOVE cid#1554880 COPY_INSTEAD_OF_MOVE cid#1554824 COPY_INSTEAD_OF_MOVE cid#1554808 COPY_INSTEAD_OF_MOVE cid#1546189 COPY_INSTEAD_OF_MOVE Change-Id: I2d2f33c603f1596228c9ecb169472ba6751e7826 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177593 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-29tdf#158237 connectivity: use c++20 contains() instead of find() and end()Bogdan Buzea1-1/+1
Change-Id: I2e047407e771b75323898ecf096721b8f3600ead Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176799 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-11-20tdf#163486: PVS: Identical branchesBogdan Buzea1-8/+4
Change-Id: Ibd3f95a7af4df51aee5fd1974914aa808dded229 V1037: Two or more case-branches perform the same actions. Check lines: 666, 688. Similar cases are grouped closer. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175051 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-11-16Related tdf#105112: FB fix request for getFunctionsJulien Nabet1-3/+3
add missing spaces + quote before and after function name searched Change-Id: I3b0bd3ca780c4de9d04fda7d2c80c29e60ddd1ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176669 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-15Related tdf#105112: use XDatabaseMetadata3 in Firebird + implement getFunctionsJulien Nabet2-2/+219
Firebird query for getFunctions comes from Jaybird (Firebird JDBC client). Change-Id: I427cc1a103ed6fe2b1ad3554bb7c3e2f7a903d87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176273 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-11clang-tidy: performance-unnecessary-copy-initialization in connectivityNoel Grandin4-5/+5
Change-Id: Ibb485324c71b78ff569cb15b6cf6f7f3889e1dc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176376 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-10tdf#163486: PVS: The variable was asign the same value.Bogdan Buzea1-1/+0
V1048 The 'bNumeric' variable was assigned the same value. See line 205 and 232. Change-Id: If047644a491c8c52933e9bc25d8d85dcbd3565c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175154 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-11-10com::sun::star -> cssMike Kaganski2-106/+106
Change-Id: I890ec73e30d3cc6b210903ecee29431f3cb5f635 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175979 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-08loplugin:reftotemp in codemaker..connectivityNoel Grandin6-9/+9
Change-Id: I9da2976410f7c4da8ab0d85150fc87f2b3df9e0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176275 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-08no need to take a copy of the getProcessComponentContext return valueNoel Grandin1-1/+1
we can just take a "const &". (found by running clang-tidy with the performance-unnecessary-copy-initialization warning) Change-Id: I20fd208c65303da78170b1ac06c638fdf3aa094b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176267 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-08Avoid checking exact interface type of Any valueMike Kaganski1-3/+1
Change-Id: Ic883c3a9fd8eb87469aec6b6570a39aadf575c3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176184 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-08Simplify a bitMike Kaganski4-13/+13
Change-Id: I618b0f8bcb2e8032ee12367c73e1136685f66b3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176183 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-07use more concrete UNO type in connectivity::adoNoel Grandin3-11/+6
Change-Id: I4a23e8847496166f1f9668830b97c71a248dd143 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176206 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-07use more concrete UNO type in connectivity::adoNoel Grandin3-8/+8
Change-Id: Ia9bc0e4aade832373def4460e44750be4415967d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176205 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-07loplugin:passstuffbyref in chart2..connectivityNoel Grandin5-8/+8
Change-Id: Ic2c6606ea0ce1d5c3089bc4c1a879fed3f2c7aff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176180 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-06tdf#163486: PVS: Identical branchesBogdan Buzea1-5/+2
Change-Id: Iad298c2819b0fa1fd4d98a64f19008a7ef8d39be V1037: Two or more case-branches perform the same actions. Check lines: 353, 362 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175050 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-11-06loplugin:staticconstexpr (macOS)Stephan Bergmann1-1/+1
Change-Id: I294b9476413a0d7b12daef9f26881241afcbde29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176051 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-11-04new loplugin:staticconstexprNoel Grandin1-1/+1
Change-Id: Ida1996dfffa106bf95fd064e8191b8033b4002f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>