diff options
| author | Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com> | 2011-01-31 14:02:07 +0200 |
|---|---|---|
| committer | Alan Coopersmith <alan.coopersmith@oracle.com> | 2011-02-09 22:19:52 -0800 |
| commit | c37e278993b9e5b3d7025ef4c434373a011996ec (patch) | |
| tree | 8f04f798997069276cde85e8391f9d9f714639c7 | |
| parent | 50f4107811249806718a100f9d34f996c58e5e25 (diff) | |
xcms/LRGB: don't double-free property_return
property_return was free'd before and in the case the conditional is true,
the call to XcmsGetProperty failed which means that property_return wasn't
set so there is no need to free it again.
Double free of pointer "property_return" in call to "free"
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Erkki Seppälä <erkki.seppala@vincit.fi>
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
| -rw-r--r-- | src/xcms/LRGB.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/xcms/LRGB.c b/src/xcms/LRGB.c index 750c4924..2dca82ee 100644 --- a/src/xcms/LRGB.c +++ b/src/xcms/LRGB.c @@ -573,7 +573,6 @@ LINEAR_RGB_InitSCCData( if (CorrectAtom == None || !_XcmsGetProperty (dpy, RootWindow(dpy, screenNumber), CorrectAtom, &format_return, &nitems, &nbytes_return, &property_return)) { - Xfree ((char *)property_return); goto FreeSCCData; } |