Xrm.c: ReadInFile: refactor fstat error handling

We can simplify the fstat failure case now that the GetFileSize macro
has been expanded inline.

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Julien Cristau <jcristau@debian.org>

1 files changed, 4 insertions, 9 deletions

diff --git a/src/Xrm.c b/src/Xrm.c
index 4892b64b..c466cae7 100644
--- a/src/Xrm.c
+++ b/src/Xrm.c
@@ -1596,18 +1596,13 @@ ReadInFile(_Xconst char *filename)
      */
     {
 	struct stat status_buffer;
-	if ( (fstat(fd, &status_buffer)) == -1 )
-	    size = -1;
-	else
+	if ( (fstat(fd, &status_buffer)) == -1 ) {
+	    close (fd);
+	    return (char *)NULL;
+	} else
 	    size = status_buffer.st_size;
     }
 
-    /* There might have been a problem trying to stat a file */
-    if (size == -1) {
-	close (fd);
-	return (char *)NULL;
-    }
-
     if (!(filebuf = Xmalloc(size + 1))) { /* leave room for '\0' */
 	close(fd);
 	return (char *)NULL;