diff options
author | Lucas Fryzek <lfryzek@igalia.com> | 2023-07-07 15:15:20 -0400 |
---|---|---|
committer | Marge Bot <emma+marge@anholt.net> | 2023-07-11 15:52:08 +0000 |
commit | 6b2fa965c6cb062d7a30ed056bf905fc6fd7cc72 (patch) | |
tree | 3ed61e034d2ba3b3184893dbd2fe5e4e43b1db40 /src/mesa/state_tracker/st_context.h | |
parent | 99e58460efb975f7acf91cf32b044bc55a77b936 (diff) |
gallium: Remove `PIPE_CAP_RGB_OVERRIDE_DST_ALPHA_BLEND`
Since the mesa state tracker can promote RGB texture formats
to RGBA texture formats (among other formats) without exposing
any of that information to a driver, it is more desirable to
have the behaviour of `PIPE_CAP_RGB_OVERRIDE_DST_ALPHA_BLEND`
be the default. This avoids rendering bugs where an application
sets `DST_ALPHA` blending on a format where there is no alpha
channel, that has been promoted to a format that actually has an
alpha channel. The driver can instead rely on the common code
in the state tracker to convert the blending parameter to one
that reflects the limitations of the application requested format,
as long as `PIPE_CAP_INDEP_BLEND_FUNC` is supported.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24044>
Diffstat (limited to 'src/mesa/state_tracker/st_context.h')
-rw-r--r-- | src/mesa/state_tracker/st_context.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/mesa/state_tracker/st_context.h b/src/mesa/state_tracker/st_context.h index bc63dfb1487..d38ff6741ea 100644 --- a/src/mesa/state_tracker/st_context.h +++ b/src/mesa/state_tracker/st_context.h @@ -167,7 +167,6 @@ struct st_context bool has_pipeline_stat; bool has_indep_blend_enable; bool has_indep_blend_func; - bool needs_rgb_dst_alpha_override; bool can_dither; bool can_bind_const_buffer_as_vertex; bool lower_flatshade; |