summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2015-01-27 10:22:30 +0000
committerCaolán McNamara <caolanm@redhat.com>2015-01-27 10:46:58 +0000
commit81b5d8427e29849915d544e5c17c3ea3c3e26043 (patch)
tree6230f7cc64168e64b36749737c458a10e5404b5d
parent199cec3af070a59fd8e4bc550e9819e3949c2d08 (diff)
Resolves: tdf#88819 printing with ps hangs
regression from commit bbf3aa7f92c194c9cc4546c95706e6b28e0c070c Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Nov 14 11:06:44 2014 +0000 coverity#705989 silence Insecure temporary file and coverity#705983 Insecure temporary file Change-Id: If580196322e68098adc38a9fdb775827843a9c30
-rw-r--r--extensions/source/scanner/sane.cxx2
-rw-r--r--vcl/generic/print/glyphset.cxx2
2 files changed, 2 insertions, 2 deletions
diff --git a/extensions/source/scanner/sane.cxx b/extensions/source/scanner/sane.cxx
index d1f27ff9b8c6..1d42f039bf0e 100644
--- a/extensions/source/scanner/sane.cxx
+++ b/extensions/source/scanner/sane.cxx
@@ -699,7 +699,7 @@ bool Sane::Start( BitmapTransporter& rBitmap )
}
utl::TempFile aFrame;
aFrame.EnableKillingFile();
- FILE* pFrame = fopen(OUStringToOString(aFrame.GetFileName(), osl_getThreadTextEncoding()).getStr(), "wb");
+ FILE* pFrame = fopen(OUStringToOString(aFrame.GetFileName(), osl_getThreadTextEncoding()).getStr(), "w+b");
if( ! pFrame )
{
bSuccess = false;
diff --git a/vcl/generic/print/glyphset.cxx b/vcl/generic/print/glyphset.cxx
index b3314ab5e4ab..3ac8d8dd28e9 100644
--- a/vcl/generic/print/glyphset.cxx
+++ b/vcl/generic/print/glyphset.cxx
@@ -744,7 +744,7 @@ GlyphSet::PSUploadFont (osl::File& rOutFile, PrinterGfx &rGfx, bool bAllowType42
utl::TempFile aTmpFile;
aTmpFile.EnableKillingFile();
- FILE* pTmpFile = fopen(OUStringToOString(aTmpFile.GetFileName(), osl_getThreadTextEncoding()).getStr(), "wb");
+ FILE* pTmpFile = fopen(OUStringToOString(aTmpFile.GetFileName(), osl_getThreadTextEncoding()).getStr(), "w+b");
if (pTmpFile == NULL)
return false;