From 81b5d8427e29849915d544e5c17c3ea3c3e26043 Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Tue, 27 Jan 2015 10:22:30 +0000 Subject: Resolves: tdf#88819 printing with ps hangs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit regression from commit bbf3aa7f92c194c9cc4546c95706e6b28e0c070c Author: Caolán McNamara Date: Fri Nov 14 11:06:44 2014 +0000 coverity#705989 silence Insecure temporary file and coverity#705983 Insecure temporary file Change-Id: If580196322e68098adc38a9fdb775827843a9c30 --- extensions/source/scanner/sane.cxx | 2 +- vcl/generic/print/glyphset.cxx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/extensions/source/scanner/sane.cxx b/extensions/source/scanner/sane.cxx index d1f27ff9b8c6..1d42f039bf0e 100644 --- a/extensions/source/scanner/sane.cxx +++ b/extensions/source/scanner/sane.cxx @@ -699,7 +699,7 @@ bool Sane::Start( BitmapTransporter& rBitmap ) } utl::TempFile aFrame; aFrame.EnableKillingFile(); - FILE* pFrame = fopen(OUStringToOString(aFrame.GetFileName(), osl_getThreadTextEncoding()).getStr(), "wb"); + FILE* pFrame = fopen(OUStringToOString(aFrame.GetFileName(), osl_getThreadTextEncoding()).getStr(), "w+b"); if( ! pFrame ) { bSuccess = false; diff --git a/vcl/generic/print/glyphset.cxx b/vcl/generic/print/glyphset.cxx index b3314ab5e4ab..3ac8d8dd28e9 100644 --- a/vcl/generic/print/glyphset.cxx +++ b/vcl/generic/print/glyphset.cxx @@ -744,7 +744,7 @@ GlyphSet::PSUploadFont (osl::File& rOutFile, PrinterGfx &rGfx, bool bAllowType42 utl::TempFile aTmpFile; aTmpFile.EnableKillingFile(); - FILE* pTmpFile = fopen(OUStringToOString(aTmpFile.GetFileName(), osl_getThreadTextEncoding()).getStr(), "wb"); + FILE* pTmpFile = fopen(OUStringToOString(aTmpFile.GetFileName(), osl_getThreadTextEncoding()).getStr(), "w+b"); if (pTmpFile == NULL) return false; -- cgit v1.2.3